From: Geliang Tang <tanggeliang@kylinos.cn>

Since create_netns() is updated in "bpf-next add netns helpers" series,
some mptcp bpf patches need to be updated.

This series epends on "bpf-next add netns helpers" series.

Based-on: <cover.1715821541.git.tanggeliang@kylinos.cn>

v3:
 - add based-on tag.

v2:
 - drop patch 1. Now netns is deleted first before adding it in
"selftests/bpf: Export create_netns helper", no need to use SIGINT
to delete it anymore.

Geliang Tang (2):
  Squash to "selftests/bpf: Add mptcp subflow subtest"
  Squash to "selftests/bpf: Add bpf scheduler test"

 tools/testing/selftests/bpf/prog_tests/mptcp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.43.0

Hi Matt,

On Thu, 2024-05-16 at 16:38 +0800, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> Since create_netns() is updated in "bpf-next add netns helpers"
> series,
> some mptcp bpf patches need to be updated.
> 
> This series epends on "bpf-next add netns helpers" series.

The series "bpf-next: add netns helpers" has not been accepted yet,
and I guess it will take a long time. I suggest to send v3 of
"selftests/bpf: new MPTCP subflow subtest" to bpf-next first. Don't
wait for the series "bpf-next: add netns helpers" anymore.

I changed this series "fixes for create_netns" from "Awaiting Upstream"
to "Changes Requested" on patchwork.

Thanks,
-Geliang

> 
> Based-on: <cover.1715821541.git.tanggeliang@kylinos.cn>
> 
> v3:
>  - add based-on tag.
> 
> v2:
>  - drop patch 1. Now netns is deleted first before adding it in
> "selftests/bpf: Export create_netns helper", no need to use SIGINT
> to delete it anymore.
> 
> Geliang Tang (2):
>   Squash to "selftests/bpf: Add mptcp subflow subtest"
>   Squash to "selftests/bpf: Add bpf scheduler test"
> 
>  tools/testing/selftests/bpf/prog_tests/mptcp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Hi Geliang,

On 30/05/2024 08:53, Geliang Tang wrote:
> Hi Matt,
> 
> On Thu, 2024-05-16 at 16:38 +0800, Geliang Tang wrote:
>> From: Geliang Tang <tanggeliang@kylinos.cn>
>>
>> Since create_netns() is updated in "bpf-next add netns helpers"
>> series,
>> some mptcp bpf patches need to be updated.
>>
>> This series epends on "bpf-next add netns helpers" series.
> 
> The series "bpf-next: add netns helpers" has not been accepted yet,
> and I guess it will take a long time.

Thank you for the update!

> I suggest to send v3 of
> "selftests/bpf: new MPTCP subflow subtest" to bpf-next first. Don't
> wait for the series "bpf-next: add netns helpers" anymore.

This 'new MPTCP subflow subtest' series is not urgent, nor blocking
anything: I'm sure it is fine to wait. We have ~6 weeks before the
future v6.10 release. Do you think the "add netns helpers" will not be
accepted before?

> I changed this series "fixes for create_netns" from "Awaiting Upstream"
> to "Changes Requested" on patchwork.

Thanks!

Cheers,
Matt

> 
> Thanks,
> -Geliang
> 
>>
>> Based-on: <cover.1715821541.git.tanggeliang@kylinos.cn>
>>
>> v3:
>>  - add based-on tag.
>>
>> v2:
>>  - drop patch 1. Now netns is deleted first before adding it in
>> "selftests/bpf: Export create_netns helper", no need to use SIGINT
>> to delete it anymore.
>>
>> Geliang Tang (2):
>>   Squash to "selftests/bpf: Add mptcp subflow subtest"
>>   Squash to "selftests/bpf: Add bpf scheduler test"
>>
>>  tools/testing/selftests/bpf/prog_tests/mptcp.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
> 

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Unstable: 1 failed test(s): selftest_simult_flows 🔴
- KVM Validation: debug: Unstable: 1 failed test(s): packetdrill_sockopts 🔴
- KVM Validation: btf (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/9109397952

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/448ec9f2f3c9
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=853620


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)