convert helpers for win and space

[PATCH mptcp-next 0/2] convert helpers for win and space

Posted by Geliang Tang 8 months, 1 week ago

From: Geliang Tang <tanggeliang@kylinos.cn>

Paired with mptcp_win_from_space(), added an mptcp_space_from_win() helper,
use them in mptcp_rcv_space_adjust() and mptcp_set_rcvlowat().

Geliang Tang (2):
  mptcp: use mptcp_win_from_space helper
  mptcp: add mptcp_space_from_win helper

 net/mptcp/protocol.c | 4 ++--
 net/mptcp/protocol.h | 5 +++++
 net/mptcp/sockopt.c  | 2 +-
 3 files changed, 8 insertions(+), 3 deletions(-)

-- 
2.43.0

Re: [PATCH mptcp-next 0/2] convert helpers for win and space

Posted by Matthieu Baerts 8 months ago

Hi Geliang, Mat,

On 11/05/2024 10:37, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> Paired with mptcp_win_from_space(), added an mptcp_space_from_win() helper,
> use them in mptcp_rcv_space_adjust() and mptcp_set_rcvlowat().
Thank you for the patches and the reviews!

Now in our tree (feat. for net-next):

New patches for t/upstream:
- 1b4da355e261: mptcp: use mptcp_win_from_space helper
- 9562c14a05f0: mptcp: add mptcp_space_from_win helper
- Results: c30047008247..767563eb7a1b (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/85fd224def76881f192ebfbd8c066f59984eb7d4/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Re: [PATCH mptcp-next 0/2] convert helpers for win and space

Posted by Mat Martineau 8 months, 1 week ago

On Sat, 11 May 2024, Geliang Tang wrote:

> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> Paired with mptcp_win_from_space(), added an mptcp_space_from_win() helper,
> use them in mptcp_rcv_space_adjust() and mptcp_set_rcvlowat().
>
> Geliang Tang (2):
>  mptcp: use mptcp_win_from_space helper
>  mptcp: add mptcp_space_from_win helper
>
> net/mptcp/protocol.c | 4 ++--
> net/mptcp/protocol.h | 5 +++++
> net/mptcp/sockopt.c  | 2 +-
> 3 files changed, 8 insertions(+), 3 deletions(-)
>

Series LGTM, thanks Geliang!


Reviewed-by: Mat Martineau <martineau@kernel.org>

Re: [PATCH mptcp-next 0/2] convert helpers for win and space

Posted by MPTCP CI 8 months, 1 week ago

Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/9042513520

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/de6a800ee3b6
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=852503


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)