[PATCH mptcp-next v2 00/16] register default scheduler

Geliang Tang posted 16 patches 1 year, 5 months ago
Failed in applying to current master (apply log)
include/net/mptcp.h                           |  7 +-
net/mptcp/bpf.c                               |  1 +
net/mptcp/protocol.c                          | 33 ++++---
net/mptcp/protocol.h                          | 13 ++-
net/mptcp/sched.c                             | 92 ++++++++++---------
tools/testing/selftests/bpf/bpf_tcp_helpers.h |  9 +-
.../selftests/bpf/progs/mptcp_bpf_bkup.c      | 10 +-
.../selftests/bpf/progs/mptcp_bpf_first.c     | 10 +-
.../selftests/bpf/progs/mptcp_bpf_rr.c        | 10 +-
9 files changed, 116 insertions(+), 69 deletions(-)
[PATCH mptcp-next v2 00/16] register default scheduler
Posted by Geliang Tang 1 year, 5 months ago
v2:
- split "mptcp: add mptcp_sched_data argument" into 5 squash-to patches.
- split "mptcp: register default scheduler" into 3 patches.
- depends on "refactor push pending" v7

Register the burst scheduler as the default one.

Geliang Tang (16):
  Squash to "mptcp: add struct mptcp_sched_ops"
  Squash to "mptcp: add get_subflow wrappers" II
  Squash to "mptcp: simplify push_pending"
  Squash to "mptcp: multi subflows push_pending"
  Squash to "mptcp: simplify subflow_push_pending"
  Squash to "mptcp: multi subflows subflow_push_pending"
  Squash to "mptcp: multi subflows retrans support"
  mptcp: use snd_burst of data instead of msk
  mptcp: define default scheduler
  mptcp: register default scheduler
  mptcp: add mptcp_sched_data_set_contexts helper
  Squash to "bpf: Add bpf_mptcp_sched_ops"
  Squash to "bpf: Add bpf_mptcp_sched_kfunc_set"
  Squash to "selftests/bpf: Add bpf_first scheduler"
  Squash to "selftests/bpf: Add bpf_bkup scheduler"
  Squash to "selftests/bpf: Add bpf_rr scheduler"

 include/net/mptcp.h                           |  7 +-
 net/mptcp/bpf.c                               |  1 +
 net/mptcp/protocol.c                          | 33 ++++---
 net/mptcp/protocol.h                          | 13 ++-
 net/mptcp/sched.c                             | 92 ++++++++++---------
 tools/testing/selftests/bpf/bpf_tcp_helpers.h |  9 +-
 .../selftests/bpf/progs/mptcp_bpf_bkup.c      | 10 +-
 .../selftests/bpf/progs/mptcp_bpf_first.c     | 10 +-
 .../selftests/bpf/progs/mptcp_bpf_rr.c        | 10 +-
 9 files changed, 116 insertions(+), 69 deletions(-)

-- 
2.35.3
Re: [PATCH mptcp-next v2 00/16] register default scheduler
Posted by Mat Martineau 1 year, 5 months ago
On Wed, 12 Oct 2022, Geliang Tang wrote:

> v2:
> - split "mptcp: add mptcp_sched_data argument" into 5 squash-to patches.
> - split "mptcp: register default scheduler" into 3 patches.
> - depends on "refactor push pending" v7
>

Thanks for rebasing this Geliang.

In the review for the "refactor push pending" series, I proposed that the 
series focus on the single-subflow refactoring for now. Does it make sense 
to rearrange these two patch series in to four different series like this:

1. refactor push pending (single subflow)
2. register default scheduler (single subflow)
3. Add multi-subflow scheduling
4. Update BPF scheduler for multi-subflow

I'm trying to think of a way to focus on *one patch set at a time* so we 
can make progress more easily. The large patch sets with lots of squash-to 
patches are getting hard to keep track of.

Thanks,

Mat

> Register the burst scheduler as the default one.
>
> Geliang Tang (16):
>  Squash to "mptcp: add struct mptcp_sched_ops"
>  Squash to "mptcp: add get_subflow wrappers" II
>  Squash to "mptcp: simplify push_pending"
>  Squash to "mptcp: multi subflows push_pending"
>  Squash to "mptcp: simplify subflow_push_pending"
>  Squash to "mptcp: multi subflows subflow_push_pending"
>  Squash to "mptcp: multi subflows retrans support"
>  mptcp: use snd_burst of data instead of msk
>  mptcp: define default scheduler
>  mptcp: register default scheduler
>  mptcp: add mptcp_sched_data_set_contexts helper
>  Squash to "bpf: Add bpf_mptcp_sched_ops"
>  Squash to "bpf: Add bpf_mptcp_sched_kfunc_set"
>  Squash to "selftests/bpf: Add bpf_first scheduler"
>  Squash to "selftests/bpf: Add bpf_bkup scheduler"
>  Squash to "selftests/bpf: Add bpf_rr scheduler"
>
> include/net/mptcp.h                           |  7 +-
> net/mptcp/bpf.c                               |  1 +
> net/mptcp/protocol.c                          | 33 ++++---
> net/mptcp/protocol.h                          | 13 ++-
> net/mptcp/sched.c                             | 92 ++++++++++---------
> tools/testing/selftests/bpf/bpf_tcp_helpers.h |  9 +-
> .../selftests/bpf/progs/mptcp_bpf_bkup.c      | 10 +-
> .../selftests/bpf/progs/mptcp_bpf_first.c     | 10 +-
> .../selftests/bpf/progs/mptcp_bpf_rr.c        | 10 +-
> 9 files changed, 116 insertions(+), 69 deletions(-)
>
> -- 
> 2.35.3
>
>
>

--
Mat Martineau
Intel