On Tue, 22 Mar 2022, Geliang Tang wrote:
> v4:
> - set msk->sched to &mptcp_sched_default when the sched argument is NULL
> in mptcp_init_sched().
>
> Depends on the bpf patches queued in the patchwork:
> - add skc_to_mptcp_sock, v10
> - check more values from mptcp_sock, v2
Hi Geliang -
I sent a message earlier today about rebasing the above series, can you
rebase this one too? It doesn't apply easily on the current export branch
or export/20220303T054913, with the above prerequisites.
I'll still post a few comments just based on the email version of the
patches.
- Mat
>
> v3:
> - add mptcp_release_sched helper in patch 4.
> - rename mptcp_set_sched to mptcp_init_sched in patch 4.
> - add mptcp_sched_first_release in patch 7.
> - do some cleanups.
>
> v2:
> - split into more small patches.
> - change all parameters of mptcp_sched_ops from sk to msk:
> void (*init)(struct mptcp_sock *msk);
> void (*release)(struct mptcp_sock *msk);
> struct sock * (*get_subflow)(struct mptcp_sock *msk);
> - add tests in bpf_tcp_ca.c, instead of adding a new one.
>
> v1:
>
> Addressed to the commends in the RFC version:
> https://patchwork.kernel.org/project/mptcp/cover/cover.1631011068.git.geliangtang@xiaomi.com/
>
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/75
>
> Geliang Tang (8):
> mptcp: add struct mptcp_sched_ops
> mptcp: register default scheduler
> mptcp: add a new sysctl scheduler
> mptcp: add sched in mptcp_sock
> mptcp: add mptcp_get_subflow wrapper
> mptcp: add bpf_mptcp_sched_ops
> selftests: bpf: add bpf_first scheduler
> selftests: bpf: add bpf_first test
>
> Documentation/networking/mptcp-sysctl.rst | 8 ++
> include/net/mptcp.h | 13 +++
> kernel/bpf/bpf_struct_ops_types.h | 4 +
> net/mptcp/Makefile | 2 +-
> net/mptcp/bpf.c | 102 ++++++++++++++++++
> net/mptcp/ctrl.c | 14 +++
> net/mptcp/protocol.c | 13 ++-
> net/mptcp/protocol.h | 11 ++
> net/mptcp/sched.c | 94 ++++++++++++++++
> tools/testing/selftests/bpf/bpf_tcp_helpers.h | 12 +++
> .../selftests/bpf/prog_tests/bpf_tcp_ca.c | 42 +++++++-
> tools/testing/selftests/bpf/progs/bpf_first.c | 30 ++++++
> 12 files changed, 336 insertions(+), 9 deletions(-)
> create mode 100644 net/mptcp/sched.c
> create mode 100644 tools/testing/selftests/bpf/progs/bpf_first.c
>
> --
> 2.34.1
>
>
>
--
Mat Martineau
Intel