From nobody Thu Mar 28 14:36:28 2024 Delivered-To: wpasupplicant.patchew@gmail.com Received: by 2002:a02:b119:0:0:0:0:0 with SMTP id r25csp345273jah; Thu, 13 Jan 2022 07:09:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJzIlOcu3cdJN2FlUCGw5WXqzttH0LGadlJAaknnmuNiQ1pc0+xNUeKtVIVORqfVuf21r+5n X-Received: by 2002:a05:620a:430b:: with SMTP id u11mr3366331qko.70.1642086553502; Thu, 13 Jan 2022 07:09:13 -0800 (PST) Return-Path: Received: from ewr.edge.kernel.org (ewr.edge.kernel.org. [147.75.197.195]) by mx.google.com with ESMTPS id a19si1133362qkk.643.2022.01.13.07.09.13 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jan 2022 07:09:13 -0800 (PST) Received-SPF: pass (google.com: domain of mptcp+bounces-3118-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 147.75.197.195 as permitted sender) client-ip=147.75.197.195; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=mimecast20200619 header.b=jTWYekv1; arc=fail (body hash mismatch); spf=pass (google.com: domain of mptcp+bounces-3118-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 147.75.197.195 as permitted sender) smtp.mailfrom="mptcp+bounces-3118-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ewr.edge.kernel.org (Postfix) with ESMTPS id 36FDA1C0A95 for ; Thu, 13 Jan 2022 15:09:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A19312C9C; Thu, 13 Jan 2022 15:09:11 +0000 (UTC) X-Original-To: mptcp@lists.linux.dev Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 768842C80 for ; Thu, 13 Jan 2022 15:09:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1642086548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XiPWLyd9C5Mjmx/EW6saxdJD0TuzZGSidMlTf6dOTzU=; b=jTWYekv1/htCUmQmu1zH+Zg3G47ugZ2z85UYQf7a9wFIJ0gBwD3zmz2tx1PbRlsusr88IP EgdAp4dIEooQc0M8mfL9yH2EKLAz5zpeVmD+VhpZmu7PlDkV60k4z50ZvmfNGzDzJXwec1 yHQ1ROskmyYrTqs64aKRdcRBMZ64jxs= Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2111.outbound.protection.outlook.com [104.47.18.111]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-4-nYbKPoTINeitPmtfxh7E_w-1; Thu, 13 Jan 2022 16:09:07 +0100 X-MC-Unique: nYbKPoTINeitPmtfxh7E_w-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S/XqbUKQAyJDjMY4UYH6qwjwV6zEkpppkaIqf/FmvIp9o2i1ibeDQjc8iygkopbXAhvkGk744bbNca9z2j2HTnMN/7KD5a0ssZfujOTB6Dw0PWBPK7tQIGgbMO7nmSBVh3UMnUHxmADQhKj1sYHHgbUQxDeLnFmvwXCwnMaqb8yND/9MlZXjhgRdmQL1Wny/p6Ttx/ndpHXA9gJ5x6NY8FzpgqJwxg3CUqzrK4e9URUtLB2s9Yi2q3ic0AvO1qvhnDnEwMtNqEoyRKOC5BdGObW5XpI2ITZRhHQfvCc+hhoFMAQTnFv4HlB95ZJyy9phqZVjSTkKMj7/+otDF87hBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y30rYRfSYA0Mz4jB05oS+6zXyA71XDWlHxXN2UR3Gog=; b=UXmjleGavqSET9u7i6hms23hHOaqn0HP5qAgiKDlVQpm3AaL8XmJIVkC77sf4TTRHRXWwNJLqVUHKZphLqbPcVvjuji31ADA68R/39TscGzWuT3FeK2PsFEec7mJ+T9MtYs8DMusTHWYibrfuTlQK8qF7v0vXXhClbWO1WFBVC2+rKVUkVaZkPjHWSLTkdgUzszr9zhmzbRCpNg1a4vvFcg7CwUDBV6quXJ5pYmEYBol96aFMsH5sJYovy8Qmc+zmGUx3888+zdTxw/t8RhXk8fwSTsPiu50+enojiTzFnVkm8nDD/lUPmH2/7WuW9qjQvrVVP4ctTy3BS5KTwxSBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from HE1PR0402MB3497.eurprd04.prod.outlook.com (2603:10a6:7:83::14) by HE1PR0401MB2489.eurprd04.prod.outlook.com (2603:10a6:3:86::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.9; Thu, 13 Jan 2022 15:09:05 +0000 Received: from HE1PR0402MB3497.eurprd04.prod.outlook.com ([fe80::b5bf:e1b5:42fd:4dba]) by HE1PR0402MB3497.eurprd04.prod.outlook.com ([fe80::b5bf:e1b5:42fd:4dba%5]) with mapi id 15.20.4867.011; Thu, 13 Jan 2022 15:09:05 +0000 From: Geliang Tang To: mptcp@lists.linux.dev CC: Geliang Tang Subject: [PATCH mptcp-next v2 1/3] mptcp: allow to use port and non-signal in set_flags Date: Thu, 13 Jan 2022 23:08:31 +0800 Message-ID: <288383507f5fb793dde04ec834bd92e25898f8c5.1642085750.git.geliang.tang@suse.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HK2PR02CA0136.apcprd02.prod.outlook.com (2603:1096:202:16::20) To HE1PR0402MB3497.eurprd04.prod.outlook.com (2603:10a6:7:83::14) Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 31be467d-244d-4cb9-3b05-08d9d6a6a407 X-MS-TrafficTypeDiagnostic: HE1PR0401MB2489:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BooeuPwklzlOCglnDpTMLfU05hIfuEldwQul7oyZKGIkhi5w2/eKV/aVrVfsZlitHpmrVHgKNSYKon6ZgHERM5OFf7je2Fu5BKE6HU3sHJz2YJyfIVLB/LqXtcEZwmo8HqLuYjTYb7yFeW3Wbg85lgmfbMPi9bNlVAdUy9E0i8sETtBzZ10OFhRf3rZURkBfgM3uZAPDDCk1O7qFY12Dk9ZZbBwo68N7LthpI4jS+vxlDqEDiBtflvao0RkipSSm3MefIwOfNZT1Tsq1YU8Wi3XOHbvDxFb9QrXJ0QDPikWySj7cgMObcc/PuiURwGjzPVxU7Aps2+UPeqFfpWNNjJ93eQl0mIviFNEt2qX4QiGJcT8flLri4ZjqvQV7Wr0NFu+qM8I3+Ynyj5irTwCGo8vUKukWNJgGYKcQestT0EGMNCdoB0RjB8ip/LZW+9spRNlCVkm0UnsBkEa/rub36fjIH/VvCpSe0nU57YDFqO2mITdcU0gaHautsBv+d1SgY2tsZ2f5shtPwWF9+z53cweGPe4lHysIo0naVzmaL1hIfZbIv/COnxmeOcjMgDhsd3kq/OhEk1U4J0h/CCznPxndkkWdLh1Rv8MsvueNEaDCmZ9GE9+j31FC/x1DUm6MknL5SuxsRF97zyhpEm7E/w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR0402MB3497.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6506007)(8936002)(2906002)(6666004)(2616005)(86362001)(44832011)(186003)(4326008)(36756003)(66946007)(316002)(83380400001)(6916009)(66556008)(508600001)(5660300002)(8676002)(107886003)(6512007)(38100700002)(66476007)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uKs7yBdZSN1302ZthqowXw6seGQDo/VAplYisn5E3Au1x4okn/rotsCsKy6R?= =?us-ascii?Q?BYknQPG794sZMIwoRA1Qjg+hiPVyKSbfRHoAotzIGr2TvbdVHHxEzlmO65jl?= =?us-ascii?Q?/+nRoZ2vF3BOirPZt5GXvu+8JToxKzjvvntYve/FUc2bshYar1mMDCs+D6hJ?= =?us-ascii?Q?1mNgbynowS6385Ab9XT9yDeN9XnCx6ItWvQCQnfeAwpPHod1zGnBihjD7tn6?= =?us-ascii?Q?ZnDdeSF+Niz2RHVgksRRHbmvMRdVu1zu1Dgkug7M0ThoQIyBOVmGrWYtxRyw?= =?us-ascii?Q?FMWY6NMti2YAxRiCtb4vsoU8GGWODRpGCibKzUl/artik5AKjRmvXcuyS1nt?= =?us-ascii?Q?IMZQDHD/b8/5fMHSaPgfLPylH/OSRe59BOBhNNX1iQ7aJ/hqDHRN2cCAJaIr?= =?us-ascii?Q?GhCdQxEJE4CKyxncSxVQfIiieHwYxssxx0q4TmgQsVtpiYVLBvZPGtEpmb5W?= =?us-ascii?Q?sn2B5SWhcLzr8WL2JaDzc76Qp7axdsSSw7yjFcvr/9MnN6NshbC9F2F1IPpO?= =?us-ascii?Q?ZJyxv6ghmaNuINbFtpnMCfyMYDyIpCflgrwsuNso8zW/vo5XiuGmRsy2VPTS?= =?us-ascii?Q?W8RZ63FLG336UjdIBxlTQCpYR0mmHvr1Ng3mwKexS+7iMayuEWVlPBbhQN70?= =?us-ascii?Q?J4AZEwduKU7b7G1E9V3bS7ipsWO1ibGELEBhXwPWnK8Oh/6cB5rZXuF6E37a?= =?us-ascii?Q?/0Qu5xAD+uWIcPNjIY4H696/TM5e7jlZj4cSpnKvNBwy7XuFmfAbo86hqkNs?= =?us-ascii?Q?AGW2NIWVleB1xymKR7dsR6xxudyjQh7wbtqfszD7MyHKdp2FbjaC0MNnrub7?= =?us-ascii?Q?sQsAFDqOcGqmrorN5AFBYnXIJE6sMdsEooBCdBLjczLBiQ7CHlYVcfBL1gQK?= =?us-ascii?Q?XS9jMxF3ckeiUYg1H05Lll6NJ5TxTJwDKGq04rVksaugTG4Kfu5OhDGSD5E8?= =?us-ascii?Q?XNUbtF0htU1m7qj3EL4qauA1QNlVUeuRiVUleySs4MoWlNCi5NN1fI7y5+Vg?= =?us-ascii?Q?2DGwwqQIJs+/7yE1OhDGF9kKUz4HVq01m2Xnqd1Fc/fEJ0OpX3Ue2zQaqhmA?= =?us-ascii?Q?oQvqQTur96OxSVvHl6+tR7Gy13Hl0QJ+U3vPS2bAUK4/YQcnoeZZVrrzvJWk?= =?us-ascii?Q?yKLcwiHzUsi84bK94aBmV2o8b/8rvIeEv/kBNsXSY43Chnd0RndKtkcL0RtI?= =?us-ascii?Q?w4IjEUXg4VMN5XmQ332JIinGTB3oy4lq+A21Uo6Ls4lK/eFcAH1vOf9592w/?= =?us-ascii?Q?H0TyoEdQLVwLzwiAulzuXfGqdSpPUO8RTqBMO73PJdVj0d6mNCIVzJmSRPMZ?= =?us-ascii?Q?CLzQDv4eOui/NbxW43zbuSDnpQoz47/9GGDys/3jZkVs/lDceNjk8KFpL/0z?= =?us-ascii?Q?hFkLXUOzPvsqudD7tGyHAp/CCfjgjldWXO3MuO7MwlDbjbo4Vth/w2slpfxZ?= =?us-ascii?Q?yVSFetDXeG4w5tFpehwNPFjf/FRf/xlXFMWujxW5r7L0zcBwEVanb1UDJ0NI?= =?us-ascii?Q?E8p5+OtLTiX16PlWaW4zkETcSwIHIlu8D5SOyoJbBmnKsRXdhWjqS//QHTGP?= =?us-ascii?Q?voCcozSvT9Mx4Cuoj3/WICM8R7keMyKT7ClLHww0/8VQqg3rFlSe5MC/DSeD?= =?us-ascii?Q?dHIKjLAZlzNSqDB6LUDjFPaDwzc+POy5LelKfFHxaMRURI0FF/DFwYIVF7jF?= =?us-ascii?Q?u/RGlMlpNi1uVrSG+zshd4qZo3g=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31be467d-244d-4cb9-3b05-08d9d6a6a407 X-MS-Exchange-CrossTenant-AuthSource: HE1PR0402MB3497.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2022 15:09:05.6050 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: S+R9n539lWY1QxtcJ8LDtAxVGHQChS804N7qV0sCm+UwDDGz514sxebMmzOfhZEAX15hmC6eGxlLvKDAbH+ozA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2489 Content-Type: text/plain; charset="utf-8" It's illegal to use both port and non-signal flags for adding address. But it's legal to use both of them for setting flags, which always uses non-signal flags, backup or fullmesh. This patch moves this non-signal flag with port check from mptcp_pm_parse_addr() to mptcp_nl_cmd_add_addr(). Do the check only when adding addresses, not setting flags or deleting addresses. Signed-off-by: Geliang Tang --- net/mptcp/pm_netlink.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c index 8c5a4be21e3d..d28e9f5d2780 100644 --- a/net/mptcp/pm_netlink.c +++ b/net/mptcp/pm_netlink.c @@ -1162,14 +1162,8 @@ static int mptcp_pm_parse_addr(struct nlattr *attr, = struct genl_info *info, if (tb[MPTCP_PM_ADDR_ATTR_FLAGS]) entry->flags =3D nla_get_u32(tb[MPTCP_PM_ADDR_ATTR_FLAGS]); =20 - if (tb[MPTCP_PM_ADDR_ATTR_PORT]) { - if (!(entry->flags & MPTCP_PM_ADDR_FLAG_SIGNAL)) { - NL_SET_ERR_MSG_ATTR(info->extack, attr, - "flags must have signal when using port"); - return -EINVAL; - } + if (tb[MPTCP_PM_ADDR_ATTR_PORT]) entry->addr.port =3D htons(nla_get_u16(tb[MPTCP_PM_ADDR_ATTR_PORT])); - } =20 return 0; } @@ -1216,6 +1210,11 @@ static int mptcp_nl_cmd_add_addr(struct sk_buff *skb= , struct genl_info *info) if (ret < 0) return ret; =20 + if (addr.addr.port && !(addr.flags & MPTCP_PM_ADDR_FLAG_SIGNAL)) { + GENL_SET_ERR_MSG(info, "flags must have signal when using port"); + return -EINVAL; + } + entry =3D kmalloc(sizeof(*entry), GFP_KERNEL); if (!entry) { GENL_SET_ERR_MSG(info, "can't allocate addr"); --=20 2.31.1 From nobody Thu Mar 28 14:36:28 2024 Delivered-To: wpasupplicant.patchew@gmail.com Received: by 2002:a02:b119:0:0:0:0:0 with SMTP id r25csp345345jah; Thu, 13 Jan 2022 07:09:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJy3KuGRy49QA8+SVFwnzsj+1UIj9He+COuh1hONCWbx72LJRb2HprO33FxntWeZBwGc+rHO X-Received: by 2002:a05:6214:e6d:: with SMTP id jz13mr4340852qvb.27.1642086558187; Thu, 13 Jan 2022 07:09:18 -0800 (PST) Return-Path: Received: from ewr.edge.kernel.org (ewr.edge.kernel.org. [147.75.197.195]) by mx.google.com with ESMTPS id ge6si1345489qvb.206.2022.01.13.07.09.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jan 2022 07:09:18 -0800 (PST) Received-SPF: pass (google.com: domain of mptcp+bounces-3119-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 147.75.197.195 as permitted sender) client-ip=147.75.197.195; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=mimecast20200619 header.b=WCfdGZxM; arc=fail (body hash mismatch); spf=pass (google.com: domain of mptcp+bounces-3119-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 147.75.197.195 as permitted sender) smtp.mailfrom="mptcp+bounces-3119-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ewr.edge.kernel.org (Postfix) with ESMTPS id C188D1C0BCE for ; Thu, 13 Jan 2022 15:09:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8261F2C9C; Thu, 13 Jan 2022 15:09:16 +0000 (UTC) X-Original-To: mptcp@lists.linux.dev Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 521FC2C80 for ; Thu, 13 Jan 2022 15:09:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1642086553; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Edt1p9KSDoya75M6IGXtjEKGXl8SOfJIAkR/V+wo6XU=; b=WCfdGZxMZYp8HwrMbRzY381VUd9tMWjTPKfoC3dc8aRFuJikJ8v0K2p0X2uKOS0Pp/Tl28 4ZmuzR3SvXVgVZ2yc4qGC9SeKQ9f5+/AwfhnZ35TfMd8AOQb2syTjMVFgh3gRVzIklOjGM O53xTS1Fi9kM3MbLdfqJCK3NKxdpajQ= Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2108.outbound.protection.outlook.com [104.47.18.108]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-41-iSxxtJMqNz-zMY8R8p8NBw-1; Thu, 13 Jan 2022 16:09:12 +0100 X-MC-Unique: iSxxtJMqNz-zMY8R8p8NBw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kw58pDeD5Hzoom4a8C8rWiv/+29Z2itxbn64V57oUP71xtruDuMzj2Z2D6F1Df6xpvZ5Y4ImSwgYifwkNAhvC5F56jPuKpzGfU6FqJenRtzgWqBBj27FXykdIflC+oIjCKuiOAjbjvf5xC2PphcSAFDDH5ZBH/ispGvu+pTSOfGqxQKJDJIbuRcJsgBy/0qmmsfmeBZNEdIM7xkvjriJb8brKIByKuNidAvyUoVpsgdnr5OoabvICzT9YlQza0aRRbQZ2Uh0mYXYQ80DY8zNerbNXT7Y+tiGic3Jv6cpYQAOgdw51jamZtkfFAA90670WPVLqmQNMgY8UbGNqgnvWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w2ju45BwrOeaW84wTo2BgVqr4hubXPkYYwiKW/v1dwo=; b=Gl2F50OjJ0YbkrM1kmVFyqXxfxuTyf8PQXQNzwZVAElWnSoBChQonOoY9g3fml01PE/h2illW2P2TWHpLnXD8RCllG8oXnlGslpTSRz4XktBhXWLJAPG8mW0rKRpMe5kkywtdp1rbDJ0XBUdBcgo+RbQI05wpOBfc4PDsuhgTz5cr2sEwzVAGV1wiAxEzINsnmnwukEkzVFxgJVRn50xloSTrTQlLavu1n87+CIiKB/IBUH2o11ouX3qGYD9LOxwdAOOjOtRmST2pfF7Mc7b/KnIjzGCjrvyXGJhwk3DIKPz+zBPJzzsCUXul4+Q+mGXbmXS26DlRXYSq5VIWda65Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from HE1PR0402MB3497.eurprd04.prod.outlook.com (2603:10a6:7:83::14) by HE1PR0401MB2489.eurprd04.prod.outlook.com (2603:10a6:3:86::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.9; Thu, 13 Jan 2022 15:09:12 +0000 Received: from HE1PR0402MB3497.eurprd04.prod.outlook.com ([fe80::b5bf:e1b5:42fd:4dba]) by HE1PR0402MB3497.eurprd04.prod.outlook.com ([fe80::b5bf:e1b5:42fd:4dba%5]) with mapi id 15.20.4867.011; Thu, 13 Jan 2022 15:09:12 +0000 From: Geliang Tang To: mptcp@lists.linux.dev CC: Geliang Tang Subject: [PATCH mptcp-next v2 2/3] selftests: mptcp: add the port argument for set_flags Date: Thu, 13 Jan 2022 23:08:32 +0800 Message-ID: <3a30b5a11c8a7a5b510d99ba65e473344d61ffd2.1642085750.git.geliang.tang@suse.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HK2PR02CA0127.apcprd02.prod.outlook.com (2603:1096:202:16::11) To HE1PR0402MB3497.eurprd04.prod.outlook.com (2603:10a6:7:83::14) Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6eec366c-707b-47a6-d228-08d9d6a6a7df X-MS-TrafficTypeDiagnostic: HE1PR0401MB2489:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1850; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P0lhNMDTRe7+B01HNY8KLNrx1RE+9RJ2hKdIndLWRou4CFVJ7paL6ev+xB/rlPDXHidfG07IXfp5oUaDPHE1J53CazA3Zxxur1VeR6cpHloAAFPoPLtZK4L8DpsxV9lfvoIc9j387QVY7xsSu/rOl3SEotoZO7uAAPSxkNhGTznll88D/cLpJ2FMQRSy5M4iYthem+K7mGLyi+Tg3ylQfVZAJRA9usMEhRmEzzyqsLjNl/KDJ7p+x/q5C49YXl1Etsm2U25fbq9fGmVZwNIzYt6I19kXLqNWPCHvcwXyFftFsoMIDtYS20NuBkLgSZBwnyGNHuvJE6T5h1QrwfdBYQ66DuHfSlJx9TuswUrhI3wjwT8HGR4WveSJ0ZaZkPjz+TAA/zfAZkLCiGVHOs5sfrLjt1sV/N8KY2VAm8vvseKXWn/W35EM0vuVU9QAwdKrDG9OSCyRzB/aYhz20WVTrbdZhjeOwMujT9ocYCufRp7rLONUnG1ufclCkbQJazcrHRzuhaZrjs4JX+2k19skxThwoVOM6FIsHN8HE2issbLG7XvLOgRys9yky+8zdby19KDE9BEGFotE9RyvM8e/4rhc0pfBCuXZutERXY1/PWU2HIklF4DVY9Xnkxwhi6YpmXKAEXKXF7kUUDVBijMu2Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR0402MB3497.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6506007)(8936002)(2906002)(6666004)(2616005)(86362001)(44832011)(186003)(4326008)(36756003)(66946007)(316002)(83380400001)(6916009)(66556008)(508600001)(5660300002)(8676002)(107886003)(6512007)(38100700002)(66476007)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IyDNeNuXNrnZkuWVzQE0CBQwJ0v3ZbPiqI+8A8/YFIjksQZRCwOEip/YUaBK?= =?us-ascii?Q?GFeTlltb97i/9530TsFbnkNm3hPpBeC4RWgqt5GhMi4vvWb8WSGCfOrSCQf9?= =?us-ascii?Q?b/hyFj1m0tw8E/6fmckPwjcgi012Exn0CZrWk8zYKh/P/JoK4s7GvmC4M9Us?= =?us-ascii?Q?oVPeRXfElZCJbqoM6kLxYje4P73e8MDQWDMk8eGajxBMO441S754ELWURuwI?= =?us-ascii?Q?d1VNJahgHpQLV2haSyqtrDRquuYjwsqqSl///JlTc3Zp08i08BY+VBDG5pdM?= =?us-ascii?Q?UYeyDVaLkf9JatDN0os2W4BoOHJXQkTys70shbjF+U+lY8lQdolxIFgOidfy?= =?us-ascii?Q?spaKuT9KMvhJrEuATs5OJHhwOa8faf35KLt7dPrc4jfEujyQg7mqTCL5TaEb?= =?us-ascii?Q?oFi+r5e6LtJX8a5PLsciTSCPDtOX9jlGmPdzMUB9jHdkg8sx7SHbyjeD054e?= =?us-ascii?Q?7YU0Cx60rNCgQKSjANcjSejg/0Hgw/EFBUtnHOn6j9vTjzSiDARbBfe3FC0U?= =?us-ascii?Q?jG0B/kmyXpafsuOf2jpUp99vDmbNxW14lx9QPJkNHM/KGSqvExDA1Id5EBm6?= =?us-ascii?Q?QqBfJHkS8J4l3bb+4O/Qpxq6AZ9wUlItyq55iefTNenOMA5AyP2bca815YU2?= =?us-ascii?Q?S7+B0xsL8yNzCBBx60ZcCuI/IZ7llvhWIV5/qgUP0n95j2xcXWDDIId3Lqef?= =?us-ascii?Q?HiyChq6RO50gAs7a3nLjRrJO6xE1ZKHce/kbdKB2RxcHPAOhT0zEr+oIzydw?= =?us-ascii?Q?IONaM3VbpjLB8sGNBW49BxLnJ9XSZM5u2bXJkVh3H2v0jeLMBuHshSuQaQCA?= =?us-ascii?Q?TdYdZKLcZiKWIbWagOYp15HhpthAboqQgoLt187L7YzYFzpl8FijS+f6d7jK?= =?us-ascii?Q?aUbu/JuAQ1GjnvxTc+H/g9KOeGJR+dr7OW1HE6p7HR26AjKzXtCESI3CI93A?= =?us-ascii?Q?wnM9vpnrFdbSlbB9sz9yR4w6iNozZsFoWotrv8rIoN6vTY9ooRcq+A/oC+Fn?= =?us-ascii?Q?4YkXE735ftByR85iOTQAasJ5sFOYrsVRkWKhoJ9txM1rpOVaxdoM9ezjfvom?= =?us-ascii?Q?Lw5ohqWP8ec8BvzJqJv6B/l0FTo6krVPtIhqjqjlFU9b/RWerFBgmdQ7Hwq5?= =?us-ascii?Q?B7tFfVQALykN3JErCKLUZ3p7PPrlqaz3FLe6qoy72K7gEBVaza5rfiYTNhUA?= =?us-ascii?Q?H32V4YTMb3E6hYD7kfCGPctv4xuUGp3a8QJFw1DAI+JW2Qv2eyrdrhyHUmX3?= =?us-ascii?Q?4ZfsCswwRzYBQqn2YX+N4xOgDf80nOxbvLhCqwwGnlPqXYBbKzvyell/x1vx?= =?us-ascii?Q?9GnhCaq1+VcUBHguV6d6FcWGR9TWAmEWY4vVo0dZjdqi7Hk5Jlu11iSuy01n?= =?us-ascii?Q?PZSuEwoiA8EeU7PXHg9q428fUhhAetslYDuJxgfyAnSVMiznTxbKbiq0kH0q?= =?us-ascii?Q?DgtyA/AJewHkutBMv9SBl+V3AIB4N23BO2KXMXEcGXElSuJpmp0noGUC8JCM?= =?us-ascii?Q?eOCSNVMA/lpF0e9PDTS531kcfNO5hPbTJIMSvWc9TSG1Z0W3kG4rpU7TwSWE?= =?us-ascii?Q?w03bSQT9UNpvPcbmbPijLBAmAy2nGDPo/mHAmt7MVnUlvWywS+grNdBiy2zF?= =?us-ascii?Q?lit79Xf7aXyaiTcJmSrgXwbMD1+53r+FXAQVwJCrt9zwXm90Hk/B1WNmbQrf?= =?us-ascii?Q?2GkvaS8bvYJo130lowWWBM2051I=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6eec366c-707b-47a6-d228-08d9d6a6a7df X-MS-Exchange-CrossTenant-AuthSource: HE1PR0402MB3497.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2022 15:09:12.0108 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TpOrgaPb5dmmaKLpdP8K34mkD62pHlWNBJhFvykAtGD8JtSuGDIkVEzjWzkRWxo4DuQbFFnmQgBBWPsS1teFZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2489 Content-Type: text/plain; charset="utf-8" This patch added the port argument for setting the address flags in pm_nl_ctl. Usage: pm_nl_ctl set 10.0.2.1 flags backup port 10100 Signed-off-by: Geliang Tang --- tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/mptcp/pm_nl_ctl.c b/tools/testing/= selftests/net/mptcp/pm_nl_ctl.c index 9b6db9d77223..3c449158d821 100644 --- a/tools/testing/selftests/net/mptcp/pm_nl_ctl.c +++ b/tools/testing/selftests/net/mptcp/pm_nl_ctl.c @@ -28,7 +28,7 @@ static void syntax(char *argv[]) fprintf(stderr, "\tadd [flags signal|subflow|backup|fullmesh] [id ] [= dev ] \n"); fprintf(stderr, "\tdel []\n"); fprintf(stderr, "\tget \n"); - fprintf(stderr, "\tset [flags backup|nobackup|fullmesh|nofullmesh]\n= "); + fprintf(stderr, "\tset [flags backup|nobackup|fullmesh|nofullmesh] [= port ]\n"); fprintf(stderr, "\tflush\n"); fprintf(stderr, "\tdump\n"); fprintf(stderr, "\tlimits [ ]\n"); @@ -722,6 +722,18 @@ int set_flags(int fd, int pm_family, int argc, char *a= rgv[]) rta->rta_len =3D RTA_LENGTH(4); memcpy(RTA_DATA(rta), &flags, 4); off +=3D NLMSG_ALIGN(rta->rta_len); + } else if (!strcmp(argv[arg], "port")) { + u_int16_t port; + + if (++arg >=3D argc) + error(1, 0, " missing port value"); + + port =3D atoi(argv[arg]); + rta =3D (void *)(data + off); + rta->rta_type =3D MPTCP_PM_ADDR_ATTR_PORT; + rta->rta_len =3D RTA_LENGTH(2); + memcpy(RTA_DATA(rta), &port, 2); + off +=3D NLMSG_ALIGN(rta->rta_len); } else { error(1, 0, "unknown keyword %s", argv[arg]); } --=20 2.31.1 From nobody Thu Mar 28 14:36:28 2024 Delivered-To: wpasupplicant.patchew@gmail.com Received: by 2002:a02:b119:0:0:0:0:0 with SMTP id r25csp345491jah; Thu, 13 Jan 2022 07:09:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJw/hsbwD3o5c79c79bnqnmXfXcKuucyqqHL/xzn5zgZjsQ/cxklJbgLiv6Qm0y3S41AvD0M X-Received: by 2002:a05:6214:5092:: with SMTP id kk18mr4152891qvb.43.1642086566274; Thu, 13 Jan 2022 07:09:26 -0800 (PST) Return-Path: Received: from ewr.edge.kernel.org (ewr.edge.kernel.org. [147.75.197.195]) by mx.google.com with ESMTPS id k13si1512631qko.422.2022.01.13.07.09.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jan 2022 07:09:26 -0800 (PST) Received-SPF: pass (google.com: domain of mptcp+bounces-3120-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 147.75.197.195 as permitted sender) client-ip=147.75.197.195; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=mimecast20200619 header.b=e5+hSdkn; arc=fail (body hash mismatch); spf=pass (google.com: domain of mptcp+bounces-3120-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 147.75.197.195 as permitted sender) smtp.mailfrom="mptcp+bounces-3120-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ewr.edge.kernel.org (Postfix) with ESMTPS id E353F1C0B8E for ; Thu, 13 Jan 2022 15:09:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A9E242C9C; Thu, 13 Jan 2022 15:09:24 +0000 (UTC) X-Original-To: mptcp@lists.linux.dev Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AAD82C80 for ; Thu, 13 Jan 2022 15:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1642086561; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lHGgMQ9SPUrupz+obZGy1NDzEASvprhL7FIQCHrS/yk=; b=e5+hSdknK0jss+YupyBczCX8+NqOzZQ7M2RCLA0C3Y8ipcaCbM33fPWL7iD/Cnta69NYAk gwCrNGtnKSeejilvIb7Z4FmLDkshFa0GcUtfLwACEPUxeFMLQihm8g8tVUobReHRa5BzN8 qZN8YgXylz1c2+oDJsivEIKtk4bPRCc= Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2109.outbound.protection.outlook.com [104.47.18.109]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-2-yxXbGt7ROs2S3XEiuQzB-A-1; Thu, 13 Jan 2022 16:09:20 +0100 X-MC-Unique: yxXbGt7ROs2S3XEiuQzB-A-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QWmIZ35X7U3eApGb6r+htUk7oM7KsZafJtbYFCyqf+EPe8PCe/hXQBrPDJmKTrurWIJWEpsNuE8K/P274lo9IJLbB2oTBsw+sm2gsOKtWg0f4C+UY0s4xw/czenK7Llg2JV2IDMcSNKRQw+vVtIfFhRGwtrPc9nMH5hqQf74GbNoYHwhe6o6m3dvdUCmk1I+Vf+VL8clqa21ZWrtFQQiA8nvQw+loXYkfaLk5EvC4kiETD3B5y1xh0E67tY6wS1zTfnat6EsWHBzz2NrsSyskGbOjkD5+0/Gpw8pSya4umM+GKuspj5rId8lW8rTiAfIfCNIfqq5BgS4Rjcn+HBqsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1FwwkOeZ4nXyhXMsfEN9LqLysOafh5F9iSxz7KyT/Ls=; b=IlOCDvbp5rLxSHNVqEJa6qcLtVnUTRXXT38DmoMW12NuLrwKkSW7zYNVXIPNt8IOokFDiXT+hNIB5lc/x7D8vvk7p+hIUpasE3g6eOzguahbngXzDhzXOJoTGQfLlJHgnD2kp/kJ1PLcQRnywJt/GWOVARh3WhNVospGAwKa51K9SwspRE0RKddiDLehk5Dsy8vRiEQnGOofoH0QJkfEz+DLkhyabBXInSeIKmBzz5xmn020jcr4W6ahrHIGUjeUHP3LWP10NxJcufurLW1MSUl70uYoMRxc4cy6l38EJahKeKOP4eWFOPvUrm1Rsk1iySUVPRGEaol9ZTZ/hRBr5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from HE1PR0402MB3497.eurprd04.prod.outlook.com (2603:10a6:7:83::14) by HE1PR0401MB2489.eurprd04.prod.outlook.com (2603:10a6:3:86::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.9; Thu, 13 Jan 2022 15:09:20 +0000 Received: from HE1PR0402MB3497.eurprd04.prod.outlook.com ([fe80::b5bf:e1b5:42fd:4dba]) by HE1PR0402MB3497.eurprd04.prod.outlook.com ([fe80::b5bf:e1b5:42fd:4dba%5]) with mapi id 15.20.4867.011; Thu, 13 Jan 2022 15:09:20 +0000 From: Geliang Tang To: mptcp@lists.linux.dev CC: Geliang Tang Subject: [PATCH mptcp-next v2 3/3] selftests: mptcp: add backup with port testcase Date: Thu, 13 Jan 2022 23:08:33 +0800 Message-ID: <7472cf13c155c5d37e6faba42d00dfa8ea4fe08b.1642085750.git.geliang.tang@suse.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HK2PR02CA0130.apcprd02.prod.outlook.com (2603:1096:202:16::14) To HE1PR0402MB3497.eurprd04.prod.outlook.com (2603:10a6:7:83::14) Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c450dd5a-4588-48df-e61b-08d9d6a6ac7b X-MS-TrafficTypeDiagnostic: HE1PR0401MB2489:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mmv1p7mWs4nOtGSEk0+XJADp9B42BOokgwphje2AQdWfzRASX++krUqKXGQWBQCocqPtSD+hIHjes8X2bFKSFnorbfsuDCO1Lo+BYoS5g6E4Zvv0m81gxZYeSKPwIHeDXwphnyuxBYoQfv08j1XmiR7qf1jN7JK7U7ZRxqwFSTDTJxDEs4DTDcaX0yEd9TEKk21m0CPvxPbw5xneNVpf1/VA/BbMHsQ44DwfxxUJzcHwh/5rO7bF+fZwxLCzjTpT6eGqNK0ZToaQkvameR2pRttEE+XDSGZcu6Yg9y9SJXtlqaL7UEpjTpVsCX15cOr3FKHlmc6jfpZxE7wWZRP1swN9R73GF85t78rlwESlCVQmP8ReIS5wO6mDo/jK5k4FNrAuuCW3eF2kfqJ6s/LsMrasvkFQ9gaiO/gxBpQr62T8MsG63N0rSCl/2p8yXmZW8MovRfn/pFqvHsR/YfhPDFT+40gpZeZxlgEcJ6WpPdXrxAUnZfXiGYQI+DHp1xEKXdtY3emiE8NUOIKoJZZIUrO4HEWrHE24L9xp7ab7MVuhoNXhVevjOXYk897osn+2ar/fL1qT43xwfkv62sF7l9z7F0h7F041xysnym+GzvXMqGYUpFMxKoXvHNy57vFWQPU+iaFq5MmNzvf85uRbxQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR0402MB3497.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6506007)(8936002)(2906002)(6666004)(2616005)(86362001)(44832011)(186003)(4326008)(36756003)(66946007)(316002)(83380400001)(6916009)(66556008)(508600001)(5660300002)(8676002)(107886003)(6512007)(38100700002)(66476007)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xwgCyMIqOPnD2/r+oFXrwRBgD7CC0PjcejcfCGcXprfb8/KpIp+dTGiBKIma?= =?us-ascii?Q?bMGVVyOO7+wnL2bJBebmGbkXtT0Uo1DcN9mHMWSWp91j2IyuRS9Bmzz72ygg?= =?us-ascii?Q?Jd0cRQGd4WcrjcE/AvH5i4H8Vv24ngl/E8UI0OWxhjF9DeRdKvmWtdVM1Eyj?= =?us-ascii?Q?xUraliacH3isM6pdnG06YsVGKHnSZRcAFst9KU0VJ8nfsgktt5eoV4Us4mpY?= =?us-ascii?Q?/UcQ3QWIdqz+v5xMYI92sfFlCQnhJIESf2jQkEpPdyJW/JNuH8j/98hyTM0L?= =?us-ascii?Q?kEQ9Zbrp29VPZUUjpiwUF0UO8XXTdLY81oPnPxLSizkzElqmTuw1kQCMQC5j?= =?us-ascii?Q?LduW8lwrOZGEa+o0xwQ8I/Vu/GHqfEBYanSDn0KRjk6bl0D7CLKa8Cv3vAr0?= =?us-ascii?Q?fJsbIwPIsTVHkpkO2KOAD9F9Xq+CQ3WSozG+ba4Rukf6tm8jj+s499QAMy4E?= =?us-ascii?Q?Al3EoDwiNCPm9fS9GTDUcfj2G82aZdQT0aU1e1CyY9JZiMqODuzvhKNhbpcE?= =?us-ascii?Q?rL/1WTm0nRzHncr/Qb3HzfaclgOMv8YABAuutslbpAMot7R2kYyDzUC8ivak?= =?us-ascii?Q?vUYXYTJ8S4tYQyjQeQDterZUbd4sJaAwRCA89d6X6N6E3oD9fNfzpCyrQ19g?= =?us-ascii?Q?qbOTwhDqSMoUGTEWnJIWLIV+QIoF4eFbYfu/UyzHWis16S2fmnK3JyAqknjV?= =?us-ascii?Q?+h7k3NLmWEmMKxWC+rV9seRrKjZg9ZUXiKESwVfmnJZSclWYXk5ZFm9FI6Fz?= =?us-ascii?Q?s6zqGv8gOCN4dlrT15PQF6hYQSGcVbpoOq4LQ4hUuEnCzKq8s20kMoqXLhhN?= =?us-ascii?Q?451Pc63dhehqs/3ViAZ8/WmGvfAZKNgNVClamu8N4yrJkJ2JaNCGm/8NIPWF?= =?us-ascii?Q?gZ/6+PBs1xk2APS2Wafd9Wc/ltHf3HGy5dhJpbIS4+uyUAJngjF8XE3EkUlA?= =?us-ascii?Q?IAdc+h/FQyxlfCJp27e5zH6D6GVVKpAkHPg5Ogd9tE/A46/LR8txEpfZZ3KD?= =?us-ascii?Q?3MhBWpZLeaGyA3957Dw58BoVAi7oTn2ZpMckSMrWwglwWjiAJ2DL0zFvG4ff?= =?us-ascii?Q?b2xUlzdk32JocQQq360bNzzT4oH1pm8trCySx9wKOHBK/GDtCXCq2ZNAfIqx?= =?us-ascii?Q?cNxsxA7UaSftHSposUYLHI6b+Y8BCLdacpR1e+h6DVBnemIPlMdYBk9mn60F?= =?us-ascii?Q?dCUtmoosBUlWFgESU6TiARFGvBaSeG3VHnccOByqgCdoxBzPgntElQwLv3X4?= =?us-ascii?Q?EceO6JVs3xUfEFcuQy4lhQZpw/QKZkvX17nTIuGrBHTimzDyy6tizY8t3eNN?= =?us-ascii?Q?5POYzl8lc/xZHG4T0t0qQZnKFOVKc9qbXwOKc97SlbuGtCYqC3+8XpL3z5+T?= =?us-ascii?Q?wtDu78q3gK+FnUF1U+mBYx0Ut/O/i4p2OLx/Rs2BxQ3LaVaXZvKNzGG0JBQ4?= =?us-ascii?Q?u9ux7BqGxFauqpFX1pIaavdG7vBKUZ+gvCN/QH4DdSwKQL5VTlqN3MbiJwa8?= =?us-ascii?Q?RXmvVERaPWWwJ6m9hQPyvVPC2ZghoW5s4/rVTKxr2qUqxf7RPPEjy2uQgViz?= =?us-ascii?Q?RhIUAZN4cbxOKT89wTBRU77HIhEp8geYut8Bhi4HWNvzKIlKcIKo/keG/F0d?= =?us-ascii?Q?FZbY6qykc1fQgZtuKK+AJntbAg3edatm2v17pFQ7W3oGWDX0giTtKsbc1xf2?= =?us-ascii?Q?nIZQFGRm6rcsbTYgMPbl97IzD4M=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c450dd5a-4588-48df-e61b-08d9d6a6ac7b X-MS-Exchange-CrossTenant-AuthSource: HE1PR0402MB3497.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2022 15:09:19.9633 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kArdaiRe/sber12tGPPOdMbneSIPCi1VMNab+WnJh0quQHOjJs7LP4PiMFcygu6jCEwC+zAnTanKbNDzFd9e6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2489 Content-Type: text/plain; charset="utf-8" This patch added the backup testcase using an address with a port number. The original backup tests only work for the output of 'pm_nl_ctl dump' without the port number. It chooses the last item in the dump to parse the address in it, and in this case, the address is showed at the end of the item. But it dosen't work for the dump with the port number, in this case, the port number is showed at the end of the item, not the address. This patch implemented a more flexible approach to get the address and the port number from the dump to fit for the port number case. Signed-off-by: Geliang Tang --- .../testing/selftests/net/mptcp/mptcp_join.sh | 46 +++++++++++++++++-- 1 file changed, 41 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testin= g/selftests/net/mptcp/mptcp_join.sh index 25725be98342..39dffde68ae2 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh @@ -239,6 +239,16 @@ is_v6() [ -z "${1##*:*}" ] } =20 +is_addr() +{ + [ -z "${1##*[.:]*}" ] +} + +is_number() +{ + [[ $1 =3D=3D ?(-)+([0-9]) ]] +} + # $1: ns, $2: port wait_local_port_listen() { @@ -464,11 +474,27 @@ do_transfer() if [ ! -z $sflags ]; then sleep 1 for netns in "$ns1" "$ns2"; do - dump=3D(`ip netns exec $netns ./pm_nl_ctl dump`) - if [ ${#dump[@]} -gt 0 ]; then - addr=3D${dump[${#dump[@]} - 1]} - ip netns exec $netns ./pm_nl_ctl set $addr flags $sflags - fi + ip netns exec $netns ./pm_nl_ctl dump | while read line; do + local arr=3D($line) + local addr + local port=3D0 + local _port=3D"" + + for i in ${arr[@]}; do + if is_addr $i; then + addr=3D$i + fi + if is_number $i; then + if [ $i -gt 10000 ]; then + port=3D$i + fi + fi + done + if [ $port -gt 0 ]; then + _port=3D"port $port" + fi + ip netns exec $netns ./pm_nl_ctl set $addr flags $sflags $_port + done done fi =20 @@ -1651,6 +1677,16 @@ backup_tests() chk_add_nr 1 1 chk_prio_nr 1 0 chk_rm_nr 0 0 + + # single address with port, backup + reset + ip netns exec $ns1 ./pm_nl_ctl limits 0 1 + ip netns exec $ns1 ./pm_nl_ctl add 10.0.2.1 flags signal port 10100 + ip netns exec $ns2 ./pm_nl_ctl limits 1 1 + run_tests $ns1 $ns2 10.0.1.1 0 0 0 slow backup + chk_join_nr "single address with port, backup" 1 1 1 + chk_add_nr 1 1 + chk_prio_nr 1 0 } =20 add_addr_ports_tests() --=20 2.31.1