[PATCH net-next 0/4] net: remove sk skb caches

Paolo Abeni posted 4 patches 4 weeks, 1 day ago
Failed in applying to current master (apply log)
Documentation/networking/ip-sysctl.rst |   8 --
include/net/sock.h                     |  19 ----
include/net/tcp.h                      |   4 +-
net/ipv4/af_inet.c                     |   4 -
net/ipv4/sysctl_net_ipv4.c             |  12 ---
net/ipv4/tcp.c                         |  38 ++-----
net/ipv4/tcp_ipv4.c                    |   6 --
net/ipv6/tcp_ipv6.c                    |   6 --
net/mptcp/protocol.c                   | 137 ++++++++++++++-----------
9 files changed, 85 insertions(+), 149 deletions(-)

[PATCH net-next 0/4] net: remove sk skb caches

Posted by Paolo Abeni 4 weeks, 1 day ago
Eric noted we would be better off reverting the sk
skb caches.

MPTCP relies on such a feature, so we need a
little refactor of the MPTCP tx path before the mentioned
revert.

The first patch exposes additional TCP helpers. The 2nd patch
changes the MPTCP code to do locally the whole skb allocation
and updating, so it does not rely anymore on core TCP helpers
for that nor the sk skb cache.

As a side effect, we can make the tcp_build_frag helper static.

Finally, we can pull Eric's revert.

RFC -> v1:
 - drop driver specific patch - no more needed after helper rename
 - rename skb_entail -> tcp_skb_entail (Eric)
 - preserve the tcp_build_frag helpwe, just make it static (Eric)

---
Note:

that this series touches some LoC also modifed by this -net patch:

https://patchwork.kernel.org/project/netdevbpf/patch/706c577fde04fbb8285c8fc078a2c6d0a4bf9564.1632309038.git.pabeni@redhat.com/

so the whole series is based on top of the above and will apply
with no conflict after such patch will land into net-next

Eric Dumazet (1):
  tcp: remove sk_{tr}x_skb_cache

Paolo Abeni (3):
  tcp: expose the tcp_mark_push() and tcp_skb_entail() helpers
  mptcp: stop relying on tcp_tx_skb_cache
  tcp: make tcp_build_frag() static

 Documentation/networking/ip-sysctl.rst |   8 --
 include/net/sock.h                     |  19 ----
 include/net/tcp.h                      |   4 +-
 net/ipv4/af_inet.c                     |   4 -
 net/ipv4/sysctl_net_ipv4.c             |  12 ---
 net/ipv4/tcp.c                         |  38 ++-----
 net/ipv4/tcp_ipv4.c                    |   6 --
 net/ipv6/tcp_ipv6.c                    |   6 --
 net/mptcp/protocol.c                   | 137 ++++++++++++++-----------
 9 files changed, 85 insertions(+), 149 deletions(-)

-- 
2.26.3


Re: [PATCH net-next 0/4] net: remove sk skb caches

Posted by patchwork-bot+netdevbpf@kernel.org 4 weeks, 1 day ago
Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Wed, 22 Sep 2021 19:26:39 +0200 you wrote:
> Eric noted we would be better off reverting the sk
> skb caches.
> 
> MPTCP relies on such a feature, so we need a
> little refactor of the MPTCP tx path before the mentioned
> revert.
> 
> [...]

Here is the summary with links:
  - [net-next,1/4] tcp: expose the tcp_mark_push() and tcp_skb_entail() helpers
    https://git.kernel.org/netdev/net-next/c/04d8825c30b7
  - [net-next,2/4] mptcp: stop relying on tcp_tx_skb_cache
    https://git.kernel.org/netdev/net-next/c/f70cad1085d1
  - [net-next,3/4] tcp: make tcp_build_frag() static
    https://git.kernel.org/netdev/net-next/c/ff6fb083a07f
  - [net-next,4/4] tcp: remove sk_{tr}x_skb_cache
    https://git.kernel.org/netdev/net-next/c/d8b81175e412

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html