From nobody Mon Feb 9 03:51:21 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E19FA10975 for ; Mon, 10 Jul 2023 12:55:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688993725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jmXeZSV87nwifsUiMNUyO3NvNPSNqQAzW63NHEbdwhg=; b=IJ+LDwBF4cDeJxD9GDHrv0kaM+sQ/psj1blv17XefqSkbxPelwFchCx9U4PWmZfzyrxzET t0M8qWi2iqxUsDAsbWViap7dPiHHAeEdt3iDNdtZGKgHv3do3dCC6XqHpik1CXtBZCkRyL SrrBF/C0ExTZaUxR5SESIJf82/3hvtk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-659--dgvT5SVNa-0_wXCWzHQfQ-1; Mon, 10 Jul 2023 08:55:24 -0400 X-MC-Unique: -dgvT5SVNa-0_wXCWzHQfQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3C3C386F122 for ; Mon, 10 Jul 2023 12:55:24 +0000 (UTC) Received: from gerbillo.redhat.com (unknown [10.45.225.74]) by smtp.corp.redhat.com (Postfix) with ESMTP id A6883C09A09 for ; Mon, 10 Jul 2023 12:55:23 +0000 (UTC) From: Paolo Abeni To: mptcp@lists.linux.dev Subject: [PATCH mptcp-next 02/14] mptcp: avoid unneeded mptcp_token_destroy() calls Date: Mon, 10 Jul 2023 14:54:57 +0200 Message-ID: <7a250eadfc33ac621c10f330b825754838afe7b5.1688993569.git.pabeni@redhat.com> In-Reply-To: References: Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8"; x-default="true" The mptcp protocol currently clears the msk token both at connect() and listen() time. That was necessary before the mptcp protocol gained a full disconnect implmenetation, but after commit b29fcfb54cd7 ("mptcp: full disconnect implementation") such calls are no more necessary and a bit confusing. Just drop them. Signed-off-by: Paolo Abeni --- net/mptcp/protocol.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index 8b5c78f582f7..17174bdae1ca 100644 --- a/net/mptcp/protocol.c +++ b/net/mptcp/protocol.c @@ -3634,7 +3634,6 @@ static int mptcp_connect(struct sock *sk, struct sock= addr *uaddr, int addr_len) if (IS_ERR(ssock)) return PTR_ERR(ssock); =20 - mptcp_token_destroy(msk); inet_sk_state_store(sk, TCP_SYN_SENT); subflow =3D mptcp_subflow_ctx(ssock->sk); #ifdef CONFIG_TCP_MD5SIG @@ -3753,7 +3752,6 @@ static int mptcp_listen(struct socket *sock, int back= log) goto unlock; } =20 - mptcp_token_destroy(msk); inet_sk_state_store(sk, TCP_LISTEN); sock_set_flag(sk, SOCK_RCU_FREE); =20 --=20 2.41.0