From nobody Tue Feb 10 03:04:34 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0986DDDA for ; Sun, 25 Feb 2024 13:04:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708866254; cv=none; b=J1PiAiLbVgHzKsueUPzrvCGVPi/fbEM9k2W/aSoB3v2oreMZkuIO10AgdAxeZ5P24fN9W1wI5OCraKP8I/C+yrueZQ3mQXtoddS4Ue/Kf9jXaSoevYKZDnaqy3pr0Kgoz6xQuUuW6dawlHMSyrmzOxRTOxxaMNXVtJf0AM0XuWY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708866254; c=relaxed/simple; bh=AsYKZHM4Vkh2vInRTD66a/lR6QtG8JnarTaSy0Wg31I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=X3vk8Z9Om4/fHH8UlJ93FVZ1MHu7KD27jal8XwryXYdDNI03BfrNuuFfTknfsh5EGm5eJOaEysrrtfT6vXdE+cm1pCbLXPHr98pd/kN0S45ucAHU7lpXNN4KAVH1Z3lh7wcWM99inMTZlEUiqpROepYssRDYxrX43zWUUa2/GLw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=npoxUe0w; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="npoxUe0w" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B68A6C43390; Sun, 25 Feb 2024 13:04:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708866254; bh=AsYKZHM4Vkh2vInRTD66a/lR6QtG8JnarTaSy0Wg31I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=npoxUe0wysWjfIFaWXXq4MGgUeb6df7uH+XvV50xnHpl/6al1oLyT/1t+hQcb2ODa HMN5I4GG80YX2/3sSQtaEMenbVnR8K2Mtgk8hDqXXOJy3B0ShW/gS8NRjWw8WXQgqs PQZv1UwNlVn4uU/HorAaBEw/RQ9giYGhftyk5SThdeZ2R4npuzdp1sO8k5AV39PwUY P3fqdksQailIW5pRITmpWMQ8s7GAHS+U2Zn0TpkZdj2Xv/xuuRysS65yICZcoJBky0 AKOjHq2BRH0hg+ZEKaW4WWCAR9kUuDcG5OZInCkCwNCc+8kbWT3QmflgCKr7nUqi8f KWJ4+IJ4tpFfQ== From: Geliang Tang To: mptcp@lists.linux.dev Cc: Geliang Tang Subject: [PATCH mptcp-next v3 03/13] selftests: mptcp: connect: fix misaligned OK/FAIL Date: Sun, 25 Feb 2024 21:03:51 +0800 Message-Id: <57d3e04f51798ad454f1f028cd9a59a5066f0a96.1708866087.git.tanggeliang@kylinos.cn> X-Mailer: git-send-email 2.40.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Geliang Tang The first [ OK ] and [FAIL] in the output of mptcp_connect.sh misalign with the others: New MPTCP socket can be blocked via sysctl [ OK ] INFO: validating network environment with pings INFO: Using loss of 0.85% delay 16 ms reorder 95% 70% with delay 4ms on ns1 MPTCP -> ns1 (10.0.1.1:10000 ) MPTCP (duration 184ms) [ OK ] ns1 MPTCP -> ns1 (10.0.1.1:10001 ) TCP (duration 50ms) [ OK ] ns1 TCP -> ns1 (10.0.1.1:10002 ) MPTCP (duration 55ms) [ OK ] This patch fixes them. Signed-off-by: Geliang Tang --- tools/testing/selftests/net/mptcp/mptcp_connect.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.sh b/tools/tes= ting/selftests/net/mptcp/mptcp_connect.sh index ab3bb3b17522..72be905bab1f 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_connect.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_connect.sh @@ -254,7 +254,7 @@ check_mptcp_disabled() =20 # net.mptcp.enabled should be enabled by default if [ "$(ip netns exec ${disabled_ns} sysctl net.mptcp.enabled | awk '{ pr= int $3 }')" -ne 1 ]; then - echo -e "net.mptcp.enabled sysctl is not 1 by default\t\t[FAIL]" + echo -e "net.mptcp.enabled sysctl is not 1 by default\t\t\t [FAIL]" mptcp_lib_result_fail "net.mptcp.enabled sysctl is not 1 by default" ret=3D1 return 1 @@ -267,13 +267,13 @@ check_mptcp_disabled() mptcp_lib_ns_exit "${disabled_ns}" =20 if [ ${err} -eq 0 ]; then - echo -e "New MPTCP socket cannot be blocked via sysctl\t\t[FAIL]" + echo -e "New MPTCP socket cannot be blocked via sysctl\t\t\t [FAIL]" mptcp_lib_result_fail "New MPTCP socket cannot be blocked via sysctl" ret=3D1 return 1 fi =20 - echo -e "New MPTCP socket can be blocked via sysctl\t\t[ OK ]" + echo -e "New MPTCP socket can be blocked via sysctl\t\t\t [ OK ]" mptcp_lib_result_pass "New MPTCP socket can be blocked via sysctl" return 0 } --=20 2.40.1