From nobody Wed Sep 17 18:33:49 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5427B311C1F for ; Fri, 12 Sep 2025 14:20:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757686844; cv=none; b=amILT50Sk4iA8494fciXPoRAUOb4SXFQSih7Vc4VWvMJOrYmRdtSzCvQdJjl0SyNC6/hvUKw45AFZRMgGfBMYPUgPOYsotbB/jeIE4w9Iz5muS2YOUglDvL1nlRENFEgHoG3YhtaXshBKZJvDhKBGSpB50ldF4oCqebGfxPBe8g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757686844; c=relaxed/simple; bh=sORVrbDby4l0RUPAX/NUWB18tAUnW3wZ8qQ9VUOecmM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VLhIyj7MsDYofzSquCz43Z20mD0/zbCSlWjq2+2VIFWH9MXcaW+JtOd8j8NRnmcw84y0uSGpdIzNQXt/Rq/5YP5Fzomg8Gf/ldg9siNpyF7sDh2VDpcps4E+zTyPdcXZWy3VIVG9fAwrHRefC7FZzA0oF4v176qHt7YdejfTcmc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=POywXzML; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="POywXzML" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB2A4C4CEF4; Fri, 12 Sep 2025 14:20:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757686843; bh=sORVrbDby4l0RUPAX/NUWB18tAUnW3wZ8qQ9VUOecmM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=POywXzMLqotBxUPu7U44LJqw/kh/AjMqfygs4cnn5qAoU+00nB17u6EsHIHUi3RZc 2kY4GsaWhg0AKVgKjhWanukNbbNPtgandR1Z2g6DksT7kiBTBsCMshKNAsH8RjXi1q 4HVsX/8M1mmOKf3jKuksz2Nd42336MZ7r6k3FDCdlEtzZcyi5ZnUnqKclMrlqvFENR hXUzXQ/Tgx30WoqAaV+cZGlInEljO6PTxH1f/wwGA8qA2/pzO4BYfKrMuPo+mxLsWG uj+hHqUBcPEmJ60YA/iaF1GbS9wEjMJZLanJwvQjCmrPapv2zKw0f3KBnC0AQcGfEU fcwfvo1VsLZQg== From: Geliang Tang To: mptcp@lists.linux.dev Cc: Geliang Tang Subject: [PATCH mptcp-next v4 1/9] selftests: mptcp: sockopt: replace /dev/urandom with getrandom Date: Fri, 12 Sep 2025 22:19:48 +0800 Message-ID: <48a919e434afba6997539465dd512cc30bea2f23.1757686538.git.tanggeliang@kylinos.cn> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Geliang Tang Replace /dev/urandom with getrandom() for initializing the RNG. This simplifies the code and avoids potential failures from opening device files while maintaining cryptographic quality randomness. These codes are from mptcp_inq.c. Signed-off-by: Geliang Tang --- .../selftests/net/mptcp/mptcp_sockopt.c | 20 +++++++------------ 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_sockopt.c b/tools/test= ing/selftests/net/mptcp/mptcp_sockopt.c index 286164f7246e..32a78663d45d 100644 --- a/tools/testing/selftests/net/mptcp/mptcp_sockopt.c +++ b/tools/testing/selftests/net/mptcp/mptcp_sockopt.c @@ -20,6 +20,7 @@ #include #include #include +#include =20 #include #include @@ -820,21 +821,14 @@ static int rcheck(int wstatus, const char *what) =20 static void init_rng(void) { - int fd =3D open("/dev/urandom", O_RDONLY); + unsigned int foo; =20 - if (fd >=3D 0) { - unsigned int foo; - ssize_t ret; - - /* can't fail */ - ret =3D read(fd, &foo, sizeof(foo)); - assert(ret =3D=3D sizeof(foo)); - - close(fd); - srand(foo); - } else { - srand(time(NULL)); + if (getrandom(&foo, sizeof(foo), 0) =3D=3D -1) { + perror("getrandom"); + exit(1); } + + srand(foo); } =20 int main(int argc, char *argv[]) --=20 2.48.1