From nobody Fri Mar 29 12:08:31 2024 Delivered-To: wpasupplicant.patchew@gmail.com Received: by 2002:a05:6638:27c:0:0:0:0 with SMTP id x28csp7059388jaq; Tue, 12 Oct 2021 08:39:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzRiDg9fDkc0YjznqTGeRsC0933djGDlKRvLJ15+EncwYM/q36cUB8W7NxYI+5f0bxWRERU X-Received: by 2002:a9f:2371:: with SMTP id 104mr22389687uae.80.1634053191263; Tue, 12 Oct 2021 08:39:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634053191; cv=none; d=google.com; s=arc-20160816; b=w/XP5LKgLkJwmU/kkdWwYnhn0ZyN19lPx9zZhv2HYBUqaUBntMX/E6ieLrTpaJ4A/v 3KSaI3AOg2E55pt7Kj4b46vCxXebT9NYtQjhQPfUkxaCDSm9FMdahLVqwNM/n1AN4MrJ OxAQ3iIBvvJ+zktdTc4C+qlI/+iSq4PGmm4jE7THgxMVLxmIloR364qJgtIqytjaufo+ jbjpSEux5m4FK53fnbpbAbPc8wohaReg0liHz/iUDFyP+zpzl6OvRww1b6DMBQtMpPpA u5yj7lLVvy7UXsB7JY1w5+eHpS4QG6zTY5FnjHQl+W8Woo3YVhT3T/HWe5wMhs2x7MED I0cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=DADMSDrfSTUjb5Z+Gu5DHjCPzPYN94C6qVp0VW+b7Jg=; b=QtOoiAD0p5nS+0eeCu5glfoT8+Tgt48htIqJwyEPhOQN5u/OKY+6BC5RJb2uqa8ZPq xYgtpo9ffUGUDp250OZMKEA7lO2ckEAyZuhcAw2U6kDAb1tcFZm/aNmrHzvMfMSx3G5/ FTM4HTt7pLY9Cyxc98gbngkoUiuN/Z8B4rqV0iUgPL7BJKEoUx5g7WOwW7HtNrJw6WCe 8rvqiN3ZnSNIJY64FFs9lfzkmX9CXGni0Sz6XufUFv/emHFQTuseknIzmieruaV5hPPz Mu1alfXw/OxfTdtsTCWDj8zZsRmdZ/yK27FQXb+vxU16yWFUsH77G8jqQKX+KRjLmKCY XDzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ASdyunB6; spf=pass (google.com: domain of mptcp+bounces-2144-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 147.75.69.165 as permitted sender) smtp.mailfrom="mptcp+bounces-2144-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sjc.edge.kernel.org (sjc.edge.kernel.org. [147.75.69.165]) by mx.google.com with ESMTPS id w5si2513688uap.79.2021.10.12.08.39.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Oct 2021 08:39:51 -0700 (PDT) Received-SPF: pass (google.com: domain of mptcp+bounces-2144-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 147.75.69.165 as permitted sender) client-ip=147.75.69.165; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ASdyunB6; spf=pass (google.com: domain of mptcp+bounces-2144-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 147.75.69.165 as permitted sender) smtp.mailfrom="mptcp+bounces-2144-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sjc.edge.kernel.org (Postfix) with ESMTPS id 324133E0171 for ; Tue, 12 Oct 2021 15:39:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 111292C81; Tue, 12 Oct 2021 15:39:48 +0000 (UTC) X-Original-To: mptcp@lists.linux.dev Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AFCE2C80 for ; Tue, 12 Oct 2021 15:39:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634053185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=DADMSDrfSTUjb5Z+Gu5DHjCPzPYN94C6qVp0VW+b7Jg=; b=ASdyunB65kMyxYMf7DQw+NGTfeWUNzG/ddZUE551tE5TDqu34VtyjANn1cJJ51R6kTHA9B 3tQFApzlCM1/gISu6iU/eO0ascIs8rXQVb18qof1UcA8aFpOJacoJoC91eCuCYr2F5FAyu F4l6c6FcJ9QAQGjYcbefK+CYabDszCI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-254-yzbCXH5OPAOTgADtH4A3Lg-1; Tue, 12 Oct 2021 11:39:41 -0400 X-MC-Unique: yzbCXH5OPAOTgADtH4A3Lg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CFB1C801AE3; Tue, 12 Oct 2021 15:39:40 +0000 (UTC) Received: from gerbillo.redhat.com (unknown [10.39.194.242]) by smtp.corp.redhat.com (Postfix) with ESMTP id 98D0060C82; Tue, 12 Oct 2021 15:39:39 +0000 (UTC) From: Paolo Abeni To: netdev@vger.kernel.org Cc: Stephen Hemminger , David Ahern , mptcp@lists.linux.dev Subject: [PATCH iproute2-next] mptcp: cleanup include section. Date: Tue, 12 Oct 2021 17:39:05 +0200 Message-Id: <30bdb5729425940823e87450c29bfdcff918d62e.1634053020.git.pabeni@redhat.com> Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Content-Type: text/plain; charset="utf-8" From: Stephen Hemminger David reported ipmptcp breaks hard the build when updating the relevant kernel headers. We should be more careful in the header section, explicitly including all the required dependencies respecting the usual order between systems and local headers. Stephen Hemminger Signed-off-by: Paolo Abeni --- Notes: - sorry for the long turn-around time - all English errors added by me - I [mis]understood Stephen's patch was the preferred one, and I took the liberty to send the patch on his behalf. Please educate me if I somewhat screwed-up this badly --- ip/ipmptcp.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/ip/ipmptcp.c b/ip/ipmptcp.c index fd042da8..0f5b6e2d 100644 --- a/ip/ipmptcp.c +++ b/ip/ipmptcp.c @@ -1,17 +1,23 @@ // SPDX-License-Identifier: GPL-2.0 =20 +#include +#include +#include #include +#include #include -#include -#include =20 #include +#include +#include #include =20 #include "utils.h" #include "ip_common.h" -#include "libgenl.h" #include "json_print.h" +#include "libgenl.h" +#include "libnetlink.h" +#include "ll_map.h" =20 static void usage(void) { --=20 2.26.3