From nobody Mon Feb 9 21:01:07 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA60EB64A for ; Sun, 3 Mar 2024 11:53:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709466784; cv=none; b=BQ09SGJzpou2GgrsZKpcBGjcpus7sWUPi+aiDP4uBjSu+PlHAi4MIsQjvO+IjboLhLJQDMoUElfqiX8Yktaybk3BVPT0Hu0+cP2qeWy8IvaxA+iQAx4xmfk6E7RvZejVZ/iErkKgpS1+WFH+kOGq5G33mzWtflzgeKBgPSadkJ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709466784; c=relaxed/simple; bh=XJp4qlrsqFDyMqcpdQ+3RWmW8qOVLq8HkeyE6x+SDoQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=RK2rzS4P9zzg3lZnmjnon0A0iYLrdSuYy5pyf9W83VrjLyVyV+5k5FejiophfmL8PZt9DeDFhAS9XexNARrwXbW8+/sgL7L8S5wX6yRzboMDUvtECRf0Mm2THuosF/oox9+5ASejNDaTEXElCNQ+8TTbSrHaI7qO94cuUGuiow4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=td9jPWxB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="td9jPWxB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00353C433C7; Sun, 3 Mar 2024 11:53:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709466784; bh=XJp4qlrsqFDyMqcpdQ+3RWmW8qOVLq8HkeyE6x+SDoQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=td9jPWxBoOcHSz5zccxgskyJ9vzOiE+owSQtgCRp8QajDqXScAEwUEBxJVyHzFlBb Lt03z53Zz28CS1Kkz5hL4JUd+zvt2OHk0wn6nC16e0CVJGJfo9A1lMe2oqAPF1344X nF1Wj8JlA+OhLhwMlJoTfw1PTlCk6Pj+5YusZVTGZm4bZD7VXhrXRr/N8bm3U0fgl4 F3fQa6fm7oiRKKvdaUVNZoR3mTez/AWykkRijygS99PCWpMZr9J1N6MJ4yMV1dTeUd jqw0M2npvPG55wbys71vuzkAnVYOS/BUy0D9lZS+67lR7JCZYmyBjS1OzejGiQ8+jr PGlFLD9h8Uxtw== From: Geliang Tang To: mptcp@lists.linux.dev Cc: Geliang Tang Subject: [PATCH mptcp-next v11 1/8] selftests: mptcp: print all error messages to stdout Date: Sun, 3 Mar 2024 19:52:50 +0800 Message-Id: <25b38a5fd6e6f5d485a65ab3c1269b9ed8a0ac8b.1709466624.git.tanggeliang@kylinos.cn> X-Mailer: git-send-email 2.40.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Geliang Tang Some error messages are dropped while the others are printed to 'stdout'. As part of the unification, this patch drop "1>&2" to let all errors messages are printed to 'stdout'. Signed-off-by: Geliang Tang --- tools/testing/selftests/net/mptcp/mptcp_connect.sh | 10 +++++----- tools/testing/selftests/net/mptcp/mptcp_sockopt.sh | 9 +++++---- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.sh b/tools/tes= ting/selftests/net/mptcp/mptcp_connect.sh index 0ca2960c9099..679e366c8f6b 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_connect.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_connect.sh @@ -294,7 +294,7 @@ do_ping() ip netns exec ${connector_ns} ping ${ping_args} $connect_addr >/dev/null = || rc=3D1 =20 if [ $rc -ne 0 ] ; then - echo "$listener_ns -> $connect_addr connectivity [ FAIL ]" 1>&2 + echo "$listener_ns -> $connect_addr connectivity [ FAIL ]" ret=3D1 =20 return 1 @@ -470,13 +470,13 @@ do_transfer() =20 if [ ${stat_synrx_now_l} -lt ${expect_synrx} ]; then printf "[ FAIL ] lower MPC SYN rx (%d) than expected (%d)\n" \ - "${stat_synrx_now_l}" "${expect_synrx}" 1>&2 + "${stat_synrx_now_l}" "${expect_synrx}" retc=3D1 fi if [ ${stat_ackrx_now_l} -lt ${expect_ackrx} ] && [ ${stat_ooo_now} -eq 0= ]; then if [ ${stat_ooo_now} -eq 0 ]; then printf "[ FAIL ] lower MPC ACK rx (%d) than expected (%d)\n" \ - "${stat_ackrx_now_l}" "${expect_ackrx}" 1>&2 + "${stat_ackrx_now_l}" "${expect_ackrx}" rets=3D1 else printf "[ Note ] fallback due to TCP OoO" @@ -721,7 +721,7 @@ EOF ip -net "$listener_ns" route del local $local_addr/0 dev lo table 100 =20 if [ $lret -ne 0 ]; then - echo "FAIL: $msg, mptcp connection error" 1>&2 + echo "FAIL: $msg, mptcp connection error" ret=3D$lret return 1 fi @@ -810,7 +810,7 @@ log_if_error() local msg=3D"$1" =20 if [ ${ret} -ne 0 ]; then - echo "FAIL: ${msg}" 1>&2 + echo "FAIL: ${msg}" =20 final_ret=3D${ret} ret=3D0 diff --git a/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh b/tools/tes= ting/selftests/net/mptcp/mptcp_sockopt.sh index 6ed4aa32222f..bf22174c022c 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh @@ -103,7 +103,8 @@ check_mark() local v for v in $values; do if [ $v -ne 0 ]; then - echo "FAIL: got $tables $values in ns $ns , not 0 - not all expected pa= ckets marked" 1>&2 + echo "FAIL: got $tables $values in ns $ns," \ + "not 0 - not all expected packets marked" ret=3D1 return 1 fi @@ -221,7 +222,7 @@ do_mptcp_sockopt_tests() lret=3D$? =20 if [ $lret -ne 0 ]; then - echo "FAIL: SOL_MPTCP getsockopt" 1>&2 + echo "FAIL: SOL_MPTCP getsockopt" mptcp_lib_result_fail "sockopt v4" ret=3D$lret return @@ -232,7 +233,7 @@ do_mptcp_sockopt_tests() lret=3D$? =20 if [ $lret -ne 0 ]; then - echo "FAIL: SOL_MPTCP getsockopt (ipv6)" 1>&2 + echo "FAIL: SOL_MPTCP getsockopt (ipv6)" mptcp_lib_result_fail "sockopt v6" ret=3D$lret return @@ -263,7 +264,7 @@ do_tcpinq_test() local lret=3D$? if [ $lret -ne 0 ];then ret=3D$lret - echo "FAIL: mptcp_inq $*" 1>&2 + echo "FAIL: mptcp_inq $*" mptcp_lib_result_fail "TCP_INQ: $*" return $lret fi --=20 2.40.1