From nobody Thu May 7 08:39:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC61D313E03; Fri, 1 May 2026 19:36:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777664174; cv=none; b=klET86R8Q+LAO90DMUrRiFOz/nSYic3ZMaHJTxSIDBzHzZBfWz2k1ADDtRAzzWDzpvvTWdV+n1uUkxkbds7YbC5qoOa4rE8vxQ/lMMWEtehmIpd0OKLToyiaGNSUaqnpHKo/V5FscElDnOnuLxCb6cpcCWN/OAHebSfbUSXyVt8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777664174; c=relaxed/simple; bh=CQeKDnYHzNPI+8C7OhbDrXambHWvhF+m7w0D0trjZl8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=POoGR9kSGunNxnCji8GhJ0W/5QzqB6fa69xDsvwSNCcm8Hl5Mj5CSf6JZFcBgPD43khQhCn3XvfFs0UHbr6VOOWqLaXIQpIs3BYcT4z3okalC5CqRlPdT7U6JqnshjeHN3rJLJxzuALVlcnLWLpQyhfvOeaayTaskhG+xqMHRAU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=T1gCfSix; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T1gCfSix" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3EE2C2BCC4; Fri, 1 May 2026 19:36:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777664174; bh=CQeKDnYHzNPI+8C7OhbDrXambHWvhF+m7w0D0trjZl8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=T1gCfSixFK2RXXrkTgYrFx3MZRiOvOxB6efXmuIgUZsD4CffpIRD2ag2U/oXa2qDT tPuxGAXsZ1HqT6s+S/TWMEyUx5wnC1QNh8VdHLsvDQFElg8pbY8nTRCrUpafkKhIWu OO6E8GuhWel8Zj825eDmsBxNrVrlGadH6kBSNvAT2FCMp1W2ind1zO1g0CJa9+UkiY Z+GDAgNM3g8TN7pTM/lLM9QuUKI6Kb4Y2jR3mSEIEWTDJdQQzXAHGzSgIKL+xSDgWP MMEMSunTscSFNJ5TeJ4nNKuP3vsVlqw62i78tNTaG+BNqKJtoD13oILuhbkMOaVACw ao57+EtVktbkA== From: "Matthieu Baerts (NGI0)" Date: Fri, 01 May 2026 21:35:34 +0200 Subject: [PATCH net 1/4] mptcp: use MPJoinSynAckHMacFailure for SynAck HMAC failure Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260501-net-mptcp-misc-fixes-7-1-rc3-v1-1-b70118df778e@kernel.org> References: <20260501-net-mptcp-misc-fixes-7-1-rc3-v1-0-b70118df778e@kernel.org> In-Reply-To: <20260501-net-mptcp-misc-fixes-7-1-rc3-v1-0-b70118df778e@kernel.org> To: Mat Martineau , Geliang Tang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Florian Westphal , Gang Yan , Dmytro Shytyi Cc: netdev@vger.kernel.org, mptcp@lists.linux.dev, linux-kernel@vger.kernel.org, "Matthieu Baerts (NGI0)" , Shardul Bankar , stable@vger.kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1540; i=matttbe@kernel.org; h=from:subject:message-id; bh=S3NhcQVoid/E4etRupkhrJemAOUzbf6PWUYaWnK4HP8=; b=owGbwMvMwCVWo/Th0Gd3rumMp9WSGDK/Mixtu3j06MkokcuC66z3+eqJHNZpNW280/ZjwqWqi us+Lc9Wd5SyMIhxMciKKbJIt0Xmz3xexVvi5WcBM4eVCWQIAxenAEwkKJuR4bBbdeb7H73bysLV o/kOTW9Lb+z7vPbeRrFfTF3ODDN5MhgZnlz6uCUrvVzn1ooDaVlZ2y9MmXH/HsursvPpq79whVf m8AEA X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 From: Shardul Bankar In subflow_finish_connect(), HMAC validation of the server's HMAC in SYN/ACK + MP_JOIN increments MPTCP_MIB_JOINACKMAC ("HMAC was wrong on ACK + MP_JOIN") on failure. The function processes the SYN/ACK, not the ACK; the matching MPTCP_MIB_JOINSYNACKMAC counter ("HMAC was wrong on SYN/ACK + MP_JOIN") exists but is not incremented anywhere in the tree. The mirror site on the server, subflow_syn_recv_sock(), already uses JOINACKMAC correctly for ACK HMAC failure. Use JOINSYNACKMAC at the SYN/ACK validation site so each counter reflects the packet whose HMAC actually failed. Suggested-by: Matthieu Baerts (NGI0) Fixes: fc518953bc9c ("mptcp: add and use MIB counter infrastructure") Cc: stable@vger.kernel.org Signed-off-by: Shardul Bankar Reviewed-by: Matthieu Baerts (NGI0) Signed-off-by: Matthieu Baerts (NGI0) --- net/mptcp/subflow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c index e2cb9d23e4a0..bda6862264ca 100644 --- a/net/mptcp/subflow.c +++ b/net/mptcp/subflow.c @@ -581,7 +581,7 @@ static void subflow_finish_connect(struct sock *sk, con= st struct sk_buff *skb) subflow->backup); =20 if (!subflow_thmac_valid(subflow)) { - MPTCP_INC_STATS(sock_net(sk), MPTCP_MIB_JOINACKMAC); + MPTCP_INC_STATS(sock_net(sk), MPTCP_MIB_JOINSYNACKMAC); subflow->reset_reason =3D MPTCP_RST_EMPTCP; goto do_reset; } --=20 2.53.0 From nobody Thu May 7 08:39:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BBAD421A0C; Fri, 1 May 2026 19:36:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777664177; cv=none; b=hifro4sUK/m+ZyYVwhAMXjLYhsu6Jq9xmT4KjPBbYmX6617KSBn9sy/nakTQbSKc/QHkbE1TYsvFwkOfUFW8pkqbH9PKAopxvh+cIhv5jvrGT+pWVOxf811tFotXepvs3Mc30gC0LqJulY2MGLD2UiC1YhC/1h8rjtJe3s9Gykc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777664177; c=relaxed/simple; bh=iN/5ZWsd+G/llWYnMKfz9xNhUpeX3w53Wzqf1rHwPRg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DSqOxBt00+T4jYfYTYFtorRkVV4NbaT3lzChYHB+pvR13o6ouDI+etWKs7NJwT+t/kZZTfjPuzRm/YeHIdgdPvKruG6oN7ETqrb6y0YwbwCVpm3fGszmEfCorD2AP53j2u3s7d3fhK41UQAPaRQgCcNy6z6xrUVikPsk3lee080= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TDcA172B; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TDcA172B" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94083C2BCB4; Fri, 1 May 2026 19:36:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777664177; bh=iN/5ZWsd+G/llWYnMKfz9xNhUpeX3w53Wzqf1rHwPRg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=TDcA172B/JYXX9geY4/si/gC22N/nD5h8VNU+kxctS/fprkwk86GTivr2sTGzbyLJ kyNtotaBJYeUzHN/+M1/QpdOWTrD4Egro56fL8dOPcjnLgei2DSVTiKILpy0uSOj3s ND788sqtal+f2BpEKDJnZvLS9ZpOeMq12pfn7cSJgOrTowQfX+RBujdxnytBOiiZJx tJbDU+ACW99tL3AoviBc//7ujVyeGdRBPREn6pws6mpEoHRmxK3OeSyNMrslaTyGMW 2AKD523ErLprSR70HzlFDZX+TnEGr/cENcgyrJ9PqRoKEB63yZziHuMxf9XZM37+vM 48LuCyiPnB+QQ== From: "Matthieu Baerts (NGI0)" Date: Fri, 01 May 2026 21:35:35 +0200 Subject: [PATCH net 2/4] mptcp: use MPTCP_RST_EMPTCP for ACK HMAC validation failure Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260501-net-mptcp-misc-fixes-7-1-rc3-v1-2-b70118df778e@kernel.org> References: <20260501-net-mptcp-misc-fixes-7-1-rc3-v1-0-b70118df778e@kernel.org> In-Reply-To: <20260501-net-mptcp-misc-fixes-7-1-rc3-v1-0-b70118df778e@kernel.org> To: Mat Martineau , Geliang Tang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Florian Westphal , Gang Yan , Dmytro Shytyi Cc: netdev@vger.kernel.org, mptcp@lists.linux.dev, linux-kernel@vger.kernel.org, "Matthieu Baerts (NGI0)" , Shardul Bankar , stable@vger.kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1477; i=matttbe@kernel.org; h=from:subject:message-id; bh=DOYuhrAzltfrRlUqWb1toh/VN3K8I0dgYPEc5n8ev4w=; b=owGbwMvMwCVWo/Th0Gd3rumMp9WSGDK/Mixz27Ri64T6hMVeVxc84KhdoxR7sDNXNfpHrDQf+ 5SFF7W3d5SyMIhxMciKKbJIt0Xmz3xexVvi5WcBM4eVCWQIAxenAEyE35Lhn6YpU2Qrr9mO2oyl 4aL5py45xb99yha+/My7lVpl1vsbMxj+R37a4BGxrbJJ7GLVo9tejsIPuDZW2Uzc1FIuFSpz+xs vEwA= X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 From: Shardul Bankar When HMAC validation fails on a received ACK + MP_JOIN in subflow_syn_recv_sock(), the subflow is reset with reason MPTCP_RST_EPROHIBIT ("Administratively prohibited"). This is incorrect: HMAC validation failure is an MPTCP protocol-level error, not an administrative policy denial. The mirror site on the client, in subflow_finish_connect(), already uses MPTCP_RST_EMPTCP ("MPTCP-specific error") for the same kind of HMAC failure on the SYN/ACK + MP_JOIN. Use the same reason on the server side for symmetry and accuracy. Suggested-by: Matthieu Baerts (NGI0) Fixes: 443041deb5ef ("mptcp: fix NULL pointer in can_accept_new_subflow") Cc: stable@vger.kernel.org Signed-off-by: Shardul Bankar Reviewed-by: Matthieu Baerts (NGI0) Signed-off-by: Matthieu Baerts (NGI0) --- net/mptcp/subflow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c index bda6862264ca..d562e149606f 100644 --- a/net/mptcp/subflow.c +++ b/net/mptcp/subflow.c @@ -908,7 +908,7 @@ static struct sock *subflow_syn_recv_sock(const struct = sock *sk, =20 if (!subflow_hmac_valid(subflow_req, &mp_opt)) { SUBFLOW_REQ_INC_STATS(req, MPTCP_MIB_JOINACKMAC); - subflow_add_reset_reason(skb, MPTCP_RST_EPROHIBIT); + subflow_add_reset_reason(skb, MPTCP_RST_EMPTCP); goto dispose_child; } =20 --=20 2.53.0 From nobody Thu May 7 08:39:06 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1867D421880; Fri, 1 May 2026 19:36:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777664182; cv=none; b=qDxP0oELemJjJDXd8Vqhrfvifmr8UrteqVaDK8OdcMRt6T+LyAiHbogVprQQo5HC1aZdK9+4JsYIXO/hCZsgtL9M0340OvGQtZUBX4ZoALfSK7DdqB4gylsGuqLpcTLVKC+ld1f3W+0ha4Kt7s8l/EwXehHDLzyCprxF5yNn+Vw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777664182; c=relaxed/simple; bh=J14bqfzXZnJ30yanrpgQn9EjiynBYIkjHQW/i5d0tPA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TgjJP+8Vg1aOM36TjpgsozrSTEuTVxicudxpE5q16X8Vqsb8YrzDeHx4Lee2QFqoTwQR5RJRch7IiK0WSDLIecFqhqtKnYmVititCqQBbFoQlujNrVUDFWqUuXLEgvYDGZE++TnxrJ2ouTLmlw/4YMPekM8IT4oCSJsPQaDqeio= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dE1a4szM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dE1a4szM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63FA5C2BCB8; Fri, 1 May 2026 19:36:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777664179; bh=J14bqfzXZnJ30yanrpgQn9EjiynBYIkjHQW/i5d0tPA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=dE1a4szMWiB4vyzz5c6e/y9Z8Rfgp7wxrTFIo4oXplFCZcvRfb+vIFHJpUzw0nViK +cttGJ18gcvdw9RlFjJG4iiaRfggi7pgLhjhuze+jj4gZ9rm09wCZHUxhqFnWNbMvv 6EJSHgeJbS+ferzsIPmkLIegBhofoZpVH1vP24smAdFe0V0bvNC8gU51x9ly5FlcST ZWUU+5d8arD79tLsObg+pPtE/MsxV78Cw28fWRio3HOLxApUOGWt1DQEr4fGGRcXkJ vGLIwPv7kgBXvkJk7bNBw5rpg67DD+mZuKYOxOMlZ8zhdEG5lM5CCfIGvxmeI8CJHG pw4oMSq8Ka/UQ== From: "Matthieu Baerts (NGI0)" Date: Fri, 01 May 2026 21:35:36 +0200 Subject: [PATCH net 3/4] mptcp: fix rx timestamp corruption on fastopen Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260501-net-mptcp-misc-fixes-7-1-rc3-v1-3-b70118df778e@kernel.org> References: <20260501-net-mptcp-misc-fixes-7-1-rc3-v1-0-b70118df778e@kernel.org> In-Reply-To: <20260501-net-mptcp-misc-fixes-7-1-rc3-v1-0-b70118df778e@kernel.org> To: Mat Martineau , Geliang Tang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Florian Westphal , Gang Yan , Dmytro Shytyi Cc: netdev@vger.kernel.org, mptcp@lists.linux.dev, linux-kernel@vger.kernel.org, "Matthieu Baerts (NGI0)" , stable@vger.kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1531; i=matttbe@kernel.org; h=from:subject:message-id; bh=9g8A5/blgrEWNDE8rhju+qeYNCLjAPhIOXOJ2cnbGk0=; b=owGbwMvMwCVWo/Th0Gd3rumMp9WSGDK/MiyPNnuTeezv432vKgLcxUodSoW+rjRWlL4za3mH9 ctgjdrwjlIWBjEuBlkxRRbptsj8mc+reEu8/Cxg5rAygQxh4OIUgIko2DP8s+d3Y3/EtDJgo8sz Y5vz4dmeb59OC5Tk6W1embzc7qvsCYb/cWsbjJW83U7ECkhY/Nbtf8N65KyB8MeTNqoZvcJrn1U xAgA= X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 From: Paolo Abeni The skb cb offset containing the timestamp presence flag is cleared before loading such information. Cache such value before MPTCP CB initialization. Fixes: 36b122baf6a8 ("mptcp: add subflow_v(4,6)_send_synack()") Cc: stable@vger.kernel.org Signed-off-by: Paolo Abeni Reviewed-by: Matthieu Baerts (NGI0) Signed-off-by: Matthieu Baerts (NGI0) --- net/mptcp/fastopen.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/mptcp/fastopen.c b/net/mptcp/fastopen.c index 82ec15bcfd7f..082c46c0f50e 100644 --- a/net/mptcp/fastopen.c +++ b/net/mptcp/fastopen.c @@ -12,6 +12,7 @@ void mptcp_fastopen_subflow_synack_set_params(struct mptc= p_subflow_context *subf struct sock *sk, *ssk; struct sk_buff *skb; struct tcp_sock *tp; + bool has_rxtstamp; =20 /* on early fallback the subflow context is deleted by * subflow_syn_recv_sock() @@ -40,12 +41,13 @@ void mptcp_fastopen_subflow_synack_set_params(struct mp= tcp_subflow_context *subf */ tp->copied_seq +=3D skb->len; subflow->ssn_offset +=3D skb->len; + has_rxtstamp =3D TCP_SKB_CB(skb)->has_rxtstamp; =20 /* Only the sequence delta is relevant */ MPTCP_SKB_CB(skb)->map_seq =3D -skb->len; MPTCP_SKB_CB(skb)->end_seq =3D 0; MPTCP_SKB_CB(skb)->offset =3D 0; - MPTCP_SKB_CB(skb)->has_rxtstamp =3D TCP_SKB_CB(skb)->has_rxtstamp; + MPTCP_SKB_CB(skb)->has_rxtstamp =3D has_rxtstamp; MPTCP_SKB_CB(skb)->cant_coalesce =3D 1; =20 mptcp_data_lock(sk); --=20 2.53.0 From nobody Thu May 7 08:39:06 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 726F24219EB; Fri, 1 May 2026 19:36:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777664182; cv=none; b=ovII98ODTMG8sdX+367YzuCrWx8St1EFOBONLnFqHEkxr2VUK3tdltcKRKPFn1hWX08LswLihVfMor/8vf6eej4AzFuNSseHrU1SosMyA+P7uvcaGMn7YTPo/h2pDAqZmw4OvK2FOo8vo+8D6rAhnLwEcPy+/FauUYiWi6SFvJE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777664182; c=relaxed/simple; bh=YH7r1TqDwBvSYseUZJ6Hz6O11d1VtypwRVryXcDfqxA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JPvptolaVCZHmSYqXXkrSvrnRykBgTnkuF42ICQh1iyDDQx8ktI6axkE089Y4fFXcdskmWU+aAdShUAYKjG9k5hOb6eI8gIeYkViIKukhLIvcWOjrLXMT7G2ew+KVo2LdWFCTWBXEu6piP8MchjyEcllf6TBmwSwoPF6Oal56Wc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BvGlhk2A; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BvGlhk2A" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10BA7C2BCC6; Fri, 1 May 2026 19:36:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777664182; bh=YH7r1TqDwBvSYseUZJ6Hz6O11d1VtypwRVryXcDfqxA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=BvGlhk2A7v1NrdA/ly4N2ArUC26zOsrnF9oD8LZv7QIG85CQjFKPbJfbgJAtTdctG wkL1E2q5zvmmvCGzoh9OOuK1+zcTIylDkVQCXLLvMdbNURtpfI4xsPSc0NesAcD/n4 J1bgV9HFHVauSGIv6YzURK1/Mo1PvJE1UqKMw/rEMxpT6aBezVa2bF9/hw7Dkwfwke PvbKnxUCsI5nRkFUOphwKeg4SVsnCvuSmgLSB4QoGQ35Z7aqUWqqG34OcHDoT2CnVR 6XGxj//6LbiUMj036RRxpYcLuoX9JEWXMqQQgFcxwYBMuQS/T4D1ADYZG3FMxVqaM4 LY0auJIwhBZQQ== From: "Matthieu Baerts (NGI0)" Date: Fri, 01 May 2026 21:35:37 +0200 Subject: [PATCH net 4/4] mptcp: sockopt: increase seq in mptcp_setsockopt_all_sf Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260501-net-mptcp-misc-fixes-7-1-rc3-v1-4-b70118df778e@kernel.org> References: <20260501-net-mptcp-misc-fixes-7-1-rc3-v1-0-b70118df778e@kernel.org> In-Reply-To: <20260501-net-mptcp-misc-fixes-7-1-rc3-v1-0-b70118df778e@kernel.org> To: Mat Martineau , Geliang Tang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Florian Westphal , Gang Yan , Dmytro Shytyi Cc: netdev@vger.kernel.org, mptcp@lists.linux.dev, linux-kernel@vger.kernel.org, "Matthieu Baerts (NGI0)" , stable@vger.kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=982; i=matttbe@kernel.org; h=from:subject:message-id; bh=YH7r1TqDwBvSYseUZJ6Hz6O11d1VtypwRVryXcDfqxA=; b=owGbwMvMwCVWo/Th0Gd3rumMp9WSGDK/Mqw47dMt4V6VUuPmEBG+ZdencNcmabattx98Xqnqc Lz59tvFHaUsDGJcDLJiiizSbZH5M59X8ZZ4+VnAzGFlAhnCwMUpABNRV2X4n/uFMd34zorfzUe0 +E98q+JQ0BB/LPxe+hP35e3m6ayCRxj+l6ROs/myLsgoL+3qzi0VFnwiC1fr1f9bs2xm3dO+V/H 9vAA= X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 mptcp_setsockopt_all_sf() was missing a call to sockopt_seq_inc(). This is required not to cause missing synchronization for newer subflows created later on. This helper is called each time a socket option is set on subflows, and future ones will need to inherit this option after their creation. Fixes: 51c5fd09e1b4 ("mptcp: add TCP_MAXSEG sockopt support") Cc: stable@vger.kernel.org Suggested-by: Paolo Abeni Reviewed-by: Mat Martineau Signed-off-by: Matthieu Baerts (NGI0) --- net/mptcp/sockopt.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/mptcp/sockopt.c b/net/mptcp/sockopt.c index 0efe40be2fde..1cf608e7357b 100644 --- a/net/mptcp/sockopt.c +++ b/net/mptcp/sockopt.c @@ -812,6 +812,10 @@ static int mptcp_setsockopt_all_sf(struct mptcp_sock *= msk, int level, if (ret) break; } + + if (!ret) + sockopt_seq_inc(msk); + return ret; } =20 --=20 2.53.0