From nobody Tue Feb 10 13:17:54 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FB90371046; Tue, 27 Jan 2026 19:27:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769542071; cv=none; b=ZzxF5vfUpvu4isy4V9+5mzqigu+aDhg8ykJEIR6WtYPCf99mmIWvc0mwiCTbV6sXwlN1+V92tlMmBOGesTtOyYAYRkEMynbVnJt8+vOr81sWsbRu9hSzTW71O8G40GKJP6780U9iW8spMozg46ZHRmimDQMKGQO4hot59YM+bgs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769542071; c=relaxed/simple; bh=ytjJ25Q1jmwXE29IQbjqiVL3coToMRadyXhmXWtjND8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=REbOz8ytgi10EedfoAEMhlYKYROnz5ZfYZphu0d3tBu/RANE6uCV+N2hmhKHuozBRX31lfZ53Ok+qOT8Zd5PujYaAhy4hExCKuGDoRUwRO7lNulZhmktJvWmQ+1bcoKWe4BVQ9/4W99kruxEz76siUs5G+Ht7MfnoOFNQPFA8ZU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UnNTQJto; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UnNTQJto" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E283C19425; Tue, 27 Jan 2026 19:27:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769542071; bh=ytjJ25Q1jmwXE29IQbjqiVL3coToMRadyXhmXWtjND8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=UnNTQJtoSVqy9mLMLJ2g0son1lXJ7iQ8GevQnsC3V6Ny+XKz5OWLiv+ewt8gilpth 13b61T3CgpcvbizoZAQ7OIzB4o2dR/WXGgK5UP6bshYgCyVluTBShM1udB0RIUtZbF /pV2vILb0FgWu4a/QREO7y9D21mgs9tg1hZssRqPM/wvhBnbM1nvj0vg9JQdCHWBM6 lEPOVPPNcyusNnqxU951RnQDcct4tLMpE4sHZWdjIVh3FOYhOTR+8L0I84kcCj3kpL ENQLW7mVAQ0mPaojxEXbpZfzNqNc+JvduiZAhZIN00+gMo0QaRfMTUQehXkycBDTxU IbepUWMs5717g== From: "Matthieu Baerts (NGI0)" Date: Tue, 27 Jan 2026 20:27:27 +0100 Subject: [PATCH net 5/5] selftests: mptcp: join: fix local endp not being tracked Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260127-net-mptcp-dup-nl-events-v1-5-7f71e1bc4feb@kernel.org> References: <20260127-net-mptcp-dup-nl-events-v1-0-7f71e1bc4feb@kernel.org> In-Reply-To: <20260127-net-mptcp-dup-nl-events-v1-0-7f71e1bc4feb@kernel.org> To: Mat Martineau , Geliang Tang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan Cc: netdev@vger.kernel.org, mptcp@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, "Matthieu Baerts (NGI0)" , stable@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2148; i=matttbe@kernel.org; h=from:subject:message-id; bh=ytjJ25Q1jmwXE29IQbjqiVL3coToMRadyXhmXWtjND8=; b=owGbwMvMwCVWo/Th0Gd3rumMp9WSGDIrBZfnbsn02dD+KTqoor5G+3r8av1V/x+o9E2Y47q0t 8W88/nPjlIWBjEuBlkxRRbptsj8mc+reEu8/Cxg5rAygQxh4OIUgImUX2P4w+uzxCLT70JehuLU FD2btzN8167r36puLmi7/ormd4VN5owMewzurdFKddtles1kth8D0+rpP87N5GaXTJHJ3xdkUX6 dBQA= X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 When running this mptcp_join.sh selftest on older kernel versions not supporting local endpoints tracking, this test fails because 3 MP_JOIN ACKs have been received, while only 2 were expected. It is not clear why only 2 MP_JOIN ACKs were expected on old kernel versions, while 3 MP_JOIN SYN and SYN+ACK were expected. When testing on the v5.15.197 kernel, 3 MP_JOIN ACKs are seen, which is also what is expected in the selftests included in this kernel version, see commit f4480eaad489 ("selftests: mptcp: add missing join check"). Switch the expected MP_JOIN ACKs to 3. While at it, move this chk_join_nr helper out of the special condition for older kernel versions as it is now the same as with more recent ones. Also, invert the condition to be more logical: what's expected on newer kernel versions having such helper first. Fixes: d4c81bbb8600 ("selftests: mptcp: join: support local endpoint being = tracked or not") Cc: stable@vger.kernel.org Reviewed-by: Mat Martineau Signed-off-by: Matthieu Baerts (NGI0) --- tools/testing/selftests/net/mptcp/mptcp_join.sh | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testin= g/selftests/net/mptcp/mptcp_join.sh index 3fc29201362a..e70d3420954f 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh @@ -2329,17 +2329,16 @@ signal_address_tests() ip netns exec $ns1 sysctl -q net.mptcp.add_addr_timeout=3D1 speed=3Dslow \ run_tests $ns1 $ns2 10.0.1.1 + chk_join_nr 3 3 3 =20 # It is not directly linked to the commit introducing this # symbol but for the parent one which is linked anyway. - if ! mptcp_lib_kallsyms_has "mptcp_pm_subflow_check_next$"; then - chk_join_nr 3 3 2 - chk_add_nr 4 4 - else - chk_join_nr 3 3 3 + if mptcp_lib_kallsyms_has "mptcp_pm_subflow_check_next$"; then # the server will not signal the address terminating # the MPC subflow chk_add_nr 3 3 + else + chk_add_nr 4 4 fi fi } --=20 2.51.0