From nobody Fri Oct 31 16:39:06 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0924B19F11E; Sun, 21 Sep 2025 17:19:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758475179; cv=none; b=bfClsN2GYM83ATNc4GJbKiTtg5c1HiezGiyyLOdsPpXg2pFckHtUvhshB1rEhZys+PluVw3Ub4AOpSchqIaTFSrUGBnicz55vd/WSMs9ZsnByu+l8bPtnd84Wa/N3qzl1bzJTNv/LuqThaFGViI1XitIQ0mWPUX6zm+g/FqihC8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758475179; c=relaxed/simple; bh=3Q6Oq5TjC9LaBtdS73aYcu0ty45eBPMlOs8OeRYX/LE=; h=Subject:To:Cc:From:Date:In-Reply-To:Message-ID:MIME-Version: Content-Type; b=h49J7Uy3aTqUT4AbcXhk3yAGF0AeKiO0qieELVwAWHUpwrFuEXIH0+CGflL/F8X4T6ijzvRENu7KQ82wUUoK/8goc0ylSwMvvzrEilNf7QkhafxBfrs7swJVBaLLmdtIXeL/MjXOa/FB4irHvGANavfUx6HaAVy2g5fOjll4aB0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=oV84iJMl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="oV84iJMl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42682C4CEE7; Sun, 21 Sep 2025 17:19:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1758475178; bh=3Q6Oq5TjC9LaBtdS73aYcu0ty45eBPMlOs8OeRYX/LE=; h=Subject:To:Cc:From:Date:In-Reply-To:From; b=oV84iJMlhNx4AjwhqS7/rn0cUIf/JGLjxT8Q5oYoewZA3NDVHylUkAhPAXr+SeiLZ xwhTqMFLrw0ri7xptrVfTRrZ6p4Kr3Ve2Jn8wzk0GM283S+TiEhqB7hJjPxaPBOp0W rIHUEMSyIj68aS6s3h0iCwoVrp1E0YnRgrGsI/wc= Subject: Patch "selftests: mptcp: userspace pm: validate deny-join-id0 flag" has been added to the 6.6-stable tree To: gregkh@linuxfoundation.org,kuba@kernel.org,martineau@kernel.org,matttbe@kernel.org,mptcp@lists.linux.dev,sashal@kernel.org Cc: From: Date: Sun, 21 Sep 2025 19:19:21 +0200 In-Reply-To: <20250919223819.3679521-6-matttbe@kernel.org> Message-ID: <2025092121-majestic-moneybags-3d06@gregkh> Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-stable: commit X-Patchwork-Hint: ignore Content-Type: text/plain; charset="utf-8" This is a note to let you know that I've just added the patch titled selftests: mptcp: userspace pm: validate deny-join-id0 flag to the 6.6-stable tree which can be found at: http://www.kernel.org/git/?p=3Dlinux/kernel/git/stable/stable-queue.git= ;a=3Dsummary The filename of the patch is: selftests-mptcp-userspace-pm-validate-deny-join-id0-flag.patch and it can be found in the queue-6.6 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. From matttbe@kernel.org Sat Sep 20 00:38:39 2025 From: "Matthieu Baerts (NGI0)" Date: Sat, 20 Sep 2025 00:38:22 +0200 Subject: selftests: mptcp: userspace pm: validate deny-join-id0 flag To: mptcp@lists.linux.dev, stable@vger.kernel.org, gregkh@linuxfoundation.o= rg Cc: "Matthieu Baerts (NGI0)" , sashal@kernel.org, Mat M= artineau , Jakub Kicinski Message-ID: <20250919223819.3679521-6-matttbe@kernel.org> From: "Matthieu Baerts (NGI0)" commit 24733e193a0d68f20d220e86da0362460c9aa812 upstream. The previous commit adds the MPTCP_PM_EV_FLAG_DENY_JOIN_ID0 flag. Make sure it is correctly announced by the other peer when it has been received. pm_nl_ctl will now display 'deny_join_id0:1' when monitoring the events, and when this flag was set by the other peer. The 'Fixes' tag here below is the same as the one from the previous commit: this patch here is not fixing anything wrong in the selftests, but it validates the previous fix for an issue introduced by this commit ID. Fixes: 702c2f646d42 ("mptcp: netlink: allow userspace-driven subflow establ= ishment") Reviewed-by: Mat Martineau Signed-off-by: Matthieu Baerts (NGI0) Link: https://patch.msgid.link/20250912-net-mptcp-pm-uspace-deny_join_id0-v= 1-3-40171884ade8@kernel.org Signed-off-by: Jakub Kicinski [ Conflict in userspace_pm.sh, because of a difference in the context, introduced by commit c66fb480a330 ("selftests: userspace pm: avoid relaunching pm events"), which is not in this version. The same lines can still be added at the same place. ] Signed-off-by: Matthieu Baerts (NGI0) Signed-off-by: Greg Kroah-Hartman --- tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 7 +++++++ tools/testing/selftests/net/mptcp/userspace_pm.sh | 14 +++++++++++--- 2 files changed, 18 insertions(+), 3 deletions(-) --- a/tools/testing/selftests/net/mptcp/pm_nl_ctl.c +++ b/tools/testing/selftests/net/mptcp/pm_nl_ctl.c @@ -194,6 +194,13 @@ static int capture_events(int fd, int ev fprintf(stderr, ",error:%u", *(__u8 *)RTA_DATA(attrs)); else if (attrs->rta_type =3D=3D MPTCP_ATTR_SERVER_SIDE) fprintf(stderr, ",server_side:%u", *(__u8 *)RTA_DATA(attrs)); + else if (attrs->rta_type =3D=3D MPTCP_ATTR_FLAGS) { + __u16 flags =3D *(__u16 *)RTA_DATA(attrs); + + /* only print when present, easier */ + if (flags & MPTCP_PM_EV_FLAG_DENY_JOIN_ID0) + fprintf(stderr, ",deny_join_id0:1"); + } =20 attrs =3D RTA_NEXT(attrs, msg_len); } --- a/tools/testing/selftests/net/mptcp/userspace_pm.sh +++ b/tools/testing/selftests/net/mptcp/userspace_pm.sh @@ -196,6 +196,9 @@ make_connection() is_v6=3D"v4" fi =20 + # set this on the client side only: will not affect the rest + ip netns exec "$ns2" sysctl -q net.mptcp.allow_join_initial_addr_port=3D0 + # Capture netlink events over the two network namespaces running # the MPTCP client and server if [ -z "$client_evts" ]; then @@ -227,23 +230,28 @@ make_connection() local client_token local client_port local client_serverside + local client_nojoin local server_token local server_serverside + local server_nojoin =20 client_token=3D$(mptcp_lib_evts_get_info token "$client_evts") client_port=3D$(mptcp_lib_evts_get_info sport "$client_evts") client_serverside=3D$(mptcp_lib_evts_get_info server_side "$client_evts") + client_nojoin=3D$(mptcp_lib_evts_get_info deny_join_id0 "$client_evts") server_token=3D$(mptcp_lib_evts_get_info token "$server_evts") server_serverside=3D$(mptcp_lib_evts_get_info server_side "$server_evts") + server_nojoin=3D$(mptcp_lib_evts_get_info deny_join_id0 "$server_evts") =20 print_test "Established IP${is_v6} MPTCP Connection ns2 =3D> ns1" - if [ "$client_token" !=3D "" ] && [ "$server_token" !=3D "" ] && [ "$clie= nt_serverside" =3D 0 ] && - [ "$server_serverside" =3D 1 ] + if [ "${client_token}" !=3D "" ] && [ "${server_token}" !=3D "" ] && + [ "${client_serverside}" =3D 0 ] && [ "${server_serverside}" =3D 1 ] && + [ "${client_nojoin:-0}" =3D 0 ] && [ "${server_nojoin:-0}" =3D 1 ] then test_pass print_title "Connection info: ${client_addr}:${client_port} -> ${connect= _addr}:${app_port}" else - test_fail "Expected tokens (c:${client_token} - s:${server_token}) and s= erver (c:${client_serverside} - s:${server_serverside})" + test_fail "Expected tokens (c:${client_token} - s:${server_token}), serv= er (c:${client_serverside} - s:${server_serverside}), nojoin (c:${client_no= join} - s:${server_nojoin})" mptcp_lib_result_print_all_tap exit 1 fi Patches currently in stable-queue which might be from matttbe@kernel.org are queue-6.6/mptcp-tfo-record-deny-join-id0-info.patch queue-6.6/mptcp-pm-nl-announce-deny-join-id0-flag.patch queue-6.6/selftests-mptcp-connect-catch-io-errors-on-listen-side.patch queue-6.6/selftests-mptcp-avoid-spurious-errors-on-tcp-disconnect.patch queue-6.6/mptcp-set-remote_deny_join_id0-on-syn-recv.patch queue-6.6/selftests-mptcp-sockopt-fix-error-messages.patch queue-6.6/selftests-mptcp-userspace-pm-validate-deny-join-id0-flag.patch