From nobody Wed Sep 17 19:34:29 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E23E25E814; Mon, 14 Jul 2025 15:52:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752508374; cv=none; b=mytnBOjnIibB0JS0Y2Yc2mZPyi1yi0bC7skIrp51qteNuwu4fBB4xrlgV+T9Bky/JNXRjPHbrPpAQbZiipnTIal70hXcF0ss6IKMJrhXqvve+RAtHKr5hHxN4epsTUxkL3+lZTbnHo+B5Y3vB6pjeFfktUH68B8N6aBtNU8Xkjg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752508374; c=relaxed/simple; bh=vRHppQdSz4rg5inxkVZW9mtmlObDuSVHllJt+T5+y00=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=m7srGd0mcJ0Cv07deS7rLbI9T4p38hof7To1C6MVr8h4E7bEjywhSD+ayxoonO17XWLx/NN4/QW2CAvhhh37KF+RE8ah6SwvVYK2PBfKEWaJAG+1xKIL6kkoel+b8ax0WQzZfWA6Jy2ovS2Krx0HwzXAIdLFVsXAPjDpHFjqV7A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gqSC137k; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gqSC137k" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C459BC4CEF5; Mon, 14 Jul 2025 15:52:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752508373; bh=vRHppQdSz4rg5inxkVZW9mtmlObDuSVHllJt+T5+y00=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=gqSC137kDgHeMztqLsQtCCx2hTkK/Fleom2gSSm7XvD2LuYTWIpB/Pk3+jND9gmWY ILPrrUtbDnDem3SlZ4xgBVSV7kGFIdhjfoWs2GbgRZrhuHzXYQ4elQhvCqSygEkSIO MKsc6EzgwG0A7+9g5Wa3Rh7KSKkc5jyX6ZyHrQWoVju7vPnrYZycrj1szmESoZXbmo ucT7ufZH225AB+PRVNaj34XT2oSiaoJgEDsP9oUMujMFKE/wcfmk8wBdeMv8i67kh8 4XA0ixwYtLJC94A+ZHyDrc6y/n3aZ2VCCu8lhKqkhVazRJkwR/+nSinbzofegGPEPG NZ4+A7gVFUP2Q== From: "Matthieu Baerts (NGI0)" Date: Mon, 14 Jul 2025 17:52:32 +0200 Subject: [PATCH net 1/2] selftests: mptcp: connect: also cover alt modes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250714-net-mptcp-sft-connect-alt-v1-1-bf1c5abbe575@kernel.org> References: <20250714-net-mptcp-sft-connect-alt-v1-0-bf1c5abbe575@kernel.org> In-Reply-To: <20250714-net-mptcp-sft-connect-alt-v1-0-bf1c5abbe575@kernel.org> To: mptcp@lists.linux.dev, Mat Martineau , Geliang Tang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , Christoph Paasch , Davide Caratti Cc: Florian Westphal , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, "Matthieu Baerts (NGI0)" , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2731; i=matttbe@kernel.org; h=from:subject:message-id; bh=vRHppQdSz4rg5inxkVZW9mtmlObDuSVHllJt+T5+y00=; b=owGbwMvMwCVWo/Th0Gd3rumMp9WSGDJK1c++PXx0wrNbz799OTwv4PBMo7XODIb3WU6HV0pfT GI7575DqaOUhUGMi0FWTJFFui0yf+bzKt4SLz8LmDmsTCBDGLg4BWAicnUM/4N3PP7DGpZoELrt 9c7DPAe/BmtycnzhXcWYvigk/11YpD7D/8qp1+wiPk7SXjRT8IexQMKyE8s696g2Zbewt1QJL9l Xyg0A X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 The "mmap" and "sendfile" alternate modes for mptcp_connect.sh/.c are available from the beginning, but only tested when mptcp_connect.sh is manually launched with "-m mmap" or "-m sendfile", not via the kselftests helpers. The MPTCP CI was manually running "mptcp_connect.sh -m mmap", but not "-m sendfile". Plus other CIs, especially the ones validating the stable releases, were not validating these alternate modes. To make sure these modes are validated by these CIs, add two new test programs executing mptcp_connect.sh with the alternate modes. Fixes: 048d19d444be ("mptcp: add basic kselftest for mptcp") Cc: stable@vger.kernel.org Reviewed-by: Geliang Tang Signed-off-by: Matthieu Baerts (NGI0) --- tools/testing/selftests/net/mptcp/Makefile | 3 ++- tools/testing/selftests/net/mptcp/mptcp_connect_mmap.sh | 4 ++++ tools/testing/selftests/net/mptcp/mptcp_connect_sendfile.sh | 4 ++++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/mptcp/Makefile b/tools/testing/sel= ftests/net/mptcp/Makefile index e47788bfa671313f21d5ba95821121cdc3e5d2c7..c6b030babba8cf888101d6af44f= 3e56fe5ab831b 100644 --- a/tools/testing/selftests/net/mptcp/Makefile +++ b/tools/testing/selftests/net/mptcp/Makefile @@ -4,7 +4,8 @@ top_srcdir =3D ../../../../.. =20 CFLAGS +=3D -Wall -Wl,--no-as-needed -O2 -g -I$(top_srcdir)/usr/include $(= KHDR_INCLUDES) =20 -TEST_PROGS :=3D mptcp_connect.sh pm_netlink.sh mptcp_join.sh diag.sh \ +TEST_PROGS :=3D mptcp_connect.sh mptcp_connect_mmap.sh mptcp_connect_sendf= ile.sh \ + pm_netlink.sh mptcp_join.sh diag.sh \ simult_flows.sh mptcp_sockopt.sh userspace_pm.sh =20 TEST_GEN_FILES =3D mptcp_connect pm_nl_ctl mptcp_sockopt mptcp_inq mptcp_d= iag diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect_mmap.sh b/tool= s/testing/selftests/net/mptcp/mptcp_connect_mmap.sh new file mode 100755 index 0000000000000000000000000000000000000000..09bde1303bf79198fe9f7890cbe= 89901859d78e8 --- /dev/null +++ b/tools/testing/selftests/net/mptcp/mptcp_connect_mmap.sh @@ -0,0 +1,4 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0 + +"$(dirname "${0}")/mptcp_connect.sh" -m mmap "${@}" diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect_sendfile.sh b/= tools/testing/selftests/net/mptcp/mptcp_connect_sendfile.sh new file mode 100755 index 0000000000000000000000000000000000000000..c50d08481581f0f8997c6f4f217= 4d606150bfa6a --- /dev/null +++ b/tools/testing/selftests/net/mptcp/mptcp_connect_sendfile.sh @@ -0,0 +1,4 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0 + +"$(dirname "${0}")/mptcp_connect.sh" -m sendfile "${@}" --=20 2.48.1 From nobody Wed Sep 17 19:34:29 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90A0C25A655; Mon, 14 Jul 2025 15:52:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752508377; cv=none; b=qqKnjGO9JHH385OTY/8itobVRzdP5wGFSj9oI7EXThj34XfG7cmSySNpfzjVDjdHf0wOAnv86CLUgLR/bqbPdF6B9XEW43ZC0A02t1M1aibQPrGnIaNUuY8ejTqNZwySmLjBR3nQrxyfkucEWWN8Ici2q1Vw4hhfkDPFSpcBLIg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752508377; c=relaxed/simple; bh=aY7+lwqzjxq2+7DTmWOz7PzESoPsMgwuJgkQHk5+Jik=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Jm2URLi4kIe0V7Q22MVRwEfLAaVmgDUdXmn5KC17LDuBymjMQdfQcEiG02TJzLd+wZScOFVVbUEXUxW3wPWns74pvRZy1YkMWkc39FS7I+0reDWr/ftWpnBnINl0+n9PZYTPqNk7jd9AkwLt0NMV43/0TwUZlPl0elUY2QMEl3s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Pq5hB+B3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Pq5hB+B3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 275AAC4CEF0; Mon, 14 Jul 2025 15:52:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752508377; bh=aY7+lwqzjxq2+7DTmWOz7PzESoPsMgwuJgkQHk5+Jik=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Pq5hB+B30PSCHFfDR6z4xbk/uJNmrBJs3/fOCJ2YA7SZwWsy6w+MpN8tXki3WKep5 Yl5o8l+sPsqXK/nAgw9gPKeISUHzfQ2KHlRNGL0SP0Zg53TMvDGTsbC9ahynRaaa0V ecFKdSAfjE3VnQnuqkatlI9FERV11avUs+pq/0blzoKqku+2V7lDy3sWFGhUbi2vn7 Qad1x7WaPp2SbUgHwwqeWQcq4QvGJ22Zoy+7vuU9Xn3z7zMUg7B0de3eKeFSp7OB8V ysmQYSKCB87v7NF7Ms1jaTqA5JdzPviDseq7mfZpmwSI5RNgpz+6OurTXuJ4oSeJ3Z uQVROr6Jk3Meg== From: "Matthieu Baerts (NGI0)" Date: Mon, 14 Jul 2025 17:52:33 +0200 Subject: [PATCH net 2/2] selftests: mptcp: connect: also cover checksum Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250714-net-mptcp-sft-connect-alt-v1-2-bf1c5abbe575@kernel.org> References: <20250714-net-mptcp-sft-connect-alt-v1-0-bf1c5abbe575@kernel.org> In-Reply-To: <20250714-net-mptcp-sft-connect-alt-v1-0-bf1c5abbe575@kernel.org> To: mptcp@lists.linux.dev, Mat Martineau , Geliang Tang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , Christoph Paasch , Davide Caratti Cc: Florian Westphal , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, "Matthieu Baerts (NGI0)" , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1975; i=matttbe@kernel.org; h=from:subject:message-id; bh=aY7+lwqzjxq2+7DTmWOz7PzESoPsMgwuJgkQHk5+Jik=; b=owGbwMvMwCVWo/Th0Gd3rumMp9WSGDJK1c89+nb1W1HlnAdvFTZ+ELooJhsy54n/tAM3Z08Xs Io24OHd11HKwiDGxSArpsgi3RaZP/N5FW+Jl58FzBxWJpAhDFycAjCRtN+MDDtePNK7sLCcz+BA 5xTGL+/2dcZ4zWKv0mT8Gf5sBcdhS3dGhiNezdeMgj/krKp7/qZQfbbg8p++/vveuDVH615UDkh 6wQUA X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 The checksum mode has been added a while ago, but it is only validated when manually launching mptcp_connect.sh with "-C". The different CIs were then not validating these MPTCP Connect tests with checksum enabled. To make sure they do, add a new test program executing mptcp_connect.sh with the checksum mode. Fixes: 94d66ba1d8e4 ("selftests: mptcp: enable checksum in mptcp_connect.sh= ") Cc: stable@vger.kernel.org Reviewed-by: Geliang Tang Signed-off-by: Matthieu Baerts (NGI0) --- tools/testing/selftests/net/mptcp/Makefile | 2 +- tools/testing/selftests/net/mptcp/mptcp_connect_checksum.sh | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/mptcp/Makefile b/tools/testing/sel= ftests/net/mptcp/Makefile index c6b030babba8cf888101d6af44f3e56fe5ab831b..4c7e51336ab25c662f02719f163= 2fa2d27d148f1 100644 --- a/tools/testing/selftests/net/mptcp/Makefile +++ b/tools/testing/selftests/net/mptcp/Makefile @@ -5,7 +5,7 @@ top_srcdir =3D ../../../../.. CFLAGS +=3D -Wall -Wl,--no-as-needed -O2 -g -I$(top_srcdir)/usr/include $(= KHDR_INCLUDES) =20 TEST_PROGS :=3D mptcp_connect.sh mptcp_connect_mmap.sh mptcp_connect_sendf= ile.sh \ - pm_netlink.sh mptcp_join.sh diag.sh \ + mptcp_connect_checksum.sh pm_netlink.sh mptcp_join.sh diag.sh \ simult_flows.sh mptcp_sockopt.sh userspace_pm.sh =20 TEST_GEN_FILES =3D mptcp_connect pm_nl_ctl mptcp_sockopt mptcp_inq mptcp_d= iag diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect_checksum.sh b/= tools/testing/selftests/net/mptcp/mptcp_connect_checksum.sh new file mode 100755 index 0000000000000000000000000000000000000000..569340d4f00ae2e4655b30220bc= fce695549a686 --- /dev/null +++ b/tools/testing/selftests/net/mptcp/mptcp_connect_checksum.sh @@ -0,0 +1,4 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0 + +"$(dirname "${0}")/mptcp_connect.sh" -C "${@}" --=20 2.48.1