From nobody Fri Nov 22 00:44:50 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 026FA1C2330 for ; Tue, 27 Aug 2024 13:35:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724765719; cv=none; b=PgIRlHQaHpeMh6QtbtBV8bsHdYpiqXCoQAgZ79JvCLFnU9cjpq3nr9fok/w5RVjnJGtCOyhuejtJNpQnovBa7iFqXdYGnaVU8jOHHUToH92rXEielbCxpcaz/hXhJM3Qt2O7QjyGDZFk9MyDDr9Z7qm1/A1YYHcG43qnSHQIKhM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724765719; c=relaxed/simple; bh=VVrro10mqUZOcJaiRiC3g0dR3rSnbd42V5/CBv2bHcg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Z+lLv1EY8PZpOlsaB8rTagieRnurBmnDEViUPwqKM3ep01dHz3PZsXvXbw2HvaAgoIB/lU+IUSZVHBu/dOjrHce5CKe8Ogfg3+07WQH1DJpGrVuE2iE4Z1X3KuCxFbfef8X3ZJhYDWU0ty+vYuopAdxsU1D3gara9xvLToAjLKw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=C6dWZLRK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="C6dWZLRK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0E13C6104A; Tue, 27 Aug 2024 13:35:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724765718; bh=VVrro10mqUZOcJaiRiC3g0dR3rSnbd42V5/CBv2bHcg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=C6dWZLRKWk7xrVQ26op+Qd1FaGo38ZskDrPIj9tFe+9Ob9ykUOkSuVevYI9BSVFkg ZWqa5YBPR7mPSJJt8f4qqtiCog8u5Vm+IwG8qbL/qgNRdFGebmxN3YOjSt09lF5dCI 7FCz4gwHuKTNICpND7EBXWWdDFCF0SXg7uO7GzK/ge4tC7H6JxBWg6Y2BmKAaaIOx7 2UBWI2V1QKFz9r6F9tkkaprmE1/RMnQTEQWp6H5xYlq6G2i+9/+kd8MQKp+O1DCsbG 36ME7Juv5kxKDFtL6Ke7fqiClphWuOBL3xUL0I6TtAlUJ/pL4LEmdKqVjRifofk/dV 7oQZdMGD0SZdQ== From: "Matthieu Baerts (NGI0)" Date: Tue, 27 Aug 2024 15:35:10 +0200 Subject: [PATCH mptcp-next 1/2] Squash to "selftests: mptcp: join: check re-re-adding ID 0 endp" Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240827-selftests-mptcp-longer-tests-v1-1-ec11c05fe980@kernel.org> References: <20240827-selftests-mptcp-longer-tests-v1-0-ec11c05fe980@kernel.org> In-Reply-To: <20240827-selftests-mptcp-longer-tests-v1-0-ec11c05fe980@kernel.org> To: mptcp@lists.linux.dev Cc: "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2006; i=matttbe@kernel.org; h=from:subject:message-id; bh=VVrro10mqUZOcJaiRiC3g0dR3rSnbd42V5/CBv2bHcg=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBmzdYUQ8kql0PjuLvedVc91zXZSiOZMEYpQKmqE dKN2VxNb1eJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZs3WFAAKCRD2t4JPQmmg c34KD/9t6aVTBqq5cY86aI9cXiD4w+0uUEtdaN5Tz/uhkD1CxsjTNdHEUfuvaUUn4rTNHwjde++ u/IDuruEwH8dqCsd0Meo0d0d6r3Ax2uSFwbPdnPcLjR2Hd6qC782hV+xZCUDIg/22/CSocOaYQ7 H/pxxk6hqDEqKxjf2qoHYIOq4m6ciFg01uHwoVtPo/B9Y54J7KBuN/3kDmvAW25+2zevQ+RS38H TKommJhoWeSc/eqradq/jvW+D6TlsUWV+QCNSLnauIr4ogJ95z40ET3PY7prR87GqXkgfhuMnmO vOiqe5YnHuteyQvtyUvra31QGTVmf5KhJXgjvx2AFIpraktEw9h5zAhp5Yb4iDe/Ohr7mOaqj0k OQiKQIxxokpgitXVq0pOflehDlO2wIykcEKNvOdpJb4LOQBHHoivy85pdBSd4HJI44KRDTEGaEw 3cMaw8BQ4L6gPYxQqMGoLlgLq47XMXIpBqqvF2mvvS+OFXBZJeolOlHSVb6QvkE4NAU92ceHQhi 8WOC8s6qzxWbugO4heyPSyaP8LsS8xrRQKbXv1b/2iJ2jgNrYjKxfr3xlRK35KB1DAlzqIw11U5 Qk4445qmb4dLKi6O+AUNKexuDz0V0ksUeBture28gcAl0wrby95ucMvBTcLL/WopmmGqH86fg5O twfN8b5d8uw4GjA== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 This will make "delete and re-add" MPTCP Join subtest longer. This test is manipulating the endpoints while the connection runs in the background. When all the manipulations are done, it stops (kills) the connection. It is then fine to make the connection run for a longer time by sending smaller chunks per batch, as it is anyway stopped when the operations are over. This modification is needed, because this test is doing more operations now, and this causes the Netdev CI to fail, as reported by Jakub [1]. In the logs [2], we can see that there is no more subflows for the connections, plus we don't see the "read: Connection reset by peer" message, telling us the connection has been killed. (Note that this message is removed in "selftests: mptcp: join: mute errors when ran in the background" patch, queued for net-next.) We didn't see this error on our side, probably because we disable CONFIG_SLUB_DEBUG_ON when using the debug kernel config, plus the Netdev CI can be quite busy from time to time. Link: https://lore.kernel.org/netdev/20240826192955.3dbb469d@kernel.org/ [1] Link: https://netdev-3.bots.linux.dev/vmksft-mptcp-dbg/results/745102/1-mpt= cp-join-sh/stdout [2] Signed-off-by: Matthieu Baerts (NGI0) --- tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testin= g/selftests/net/mptcp/mptcp_join.sh index 321bc5caf7da..19abc3c1a7ae 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh @@ -3685,7 +3685,7 @@ endpoint_tests() pm_nl_set_limits $ns2 0 3 pm_nl_add_endpoint $ns2 10.0.1.2 id 1 dev ns2eth1 flags subflow pm_nl_add_endpoint $ns2 10.0.2.2 id 2 dev ns2eth2 flags subflow - { test_linkfail=3D4 speed=3D20 \ + { test_linkfail=3D4 speed=3D5 \ run_tests $ns1 $ns2 10.0.1.1 & } 2>/dev/null local tests_pid=3D$! =20 --=20 2.45.2 From nobody Fri Nov 22 00:44:50 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D295F1C4634 for ; Tue, 27 Aug 2024 13:35:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724765719; cv=none; b=gb/RkzfFkOsPuKYtc3Wq9qLO/2eq8LOcSB/kqadS7N7db2gdENu78OeSO0nJsOCrxvQHQ2xTreMzQrTSqmz8NXxc5Q+zG4HembpPYKwhdHXQw+dVsLw3BSd/FQYCAg9iZg5pA4uKPGLKHk6tcugNRUIXRR5Th0uElX0YA83Sx+8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724765719; c=relaxed/simple; bh=WJb/Kgt9lR8/dWqylu2fOxhLzw/aMaNSn5UlKGkvWF8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TYVIbqR3hht6xrHFS8X2nAIJz7olE782rBe8O1bhoRtccjR1vSmK0bLEaT2oscZLFleol/uQwRI07/jkCeQ+U2XhP+8YQ3/tLfuNPM02qXEIczsv+CsazHlEQUxH25kETMwPZ9E8H4DAPL7asnBUqY8UIyVzc77MPhmijqyzxAA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GVu3IE6N; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GVu3IE6N" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF828C61051; Tue, 27 Aug 2024 13:35:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724765719; bh=WJb/Kgt9lR8/dWqylu2fOxhLzw/aMaNSn5UlKGkvWF8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=GVu3IE6N0ESmKMKoNezskf+VMMdMdrF6zHBBruXAJT1mMkz73QNxHnxRvcYr6lOOq szQ5njcC5aAwsPsG/vv1u7vioBPp5SCIdRJGBaWJJdQq79jIGQlDN8HrCBS13im6af My86u/nx9sp4z10sf7tq7i+4gyMSjZQrO3XzuIXr9EpzxNWDmt3fgfDyc5PaPtqkio Z3rxoYvbedl5Yvjg4/eJiGHW5wLW9/cpBnqfgCt8976sApCVrWoIgyETUvmb5ypAqy MnX8jMCy+78rBP+4mjsWcCmFrBB/RmG3elkQTbiVfaZGNZnQ8sRUISJeDSaL99k0D5 QmS86u4OaYRiw== From: "Matthieu Baerts (NGI0)" Date: Tue, 27 Aug 2024 15:35:11 +0200 Subject: [PATCH mptcp-next 2/2] Squash to "selftests: mptcp: join: check re-re-adding ID 0 signal" Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240827-selftests-mptcp-longer-tests-v1-2-ec11c05fe980@kernel.org> References: <20240827-selftests-mptcp-longer-tests-v1-0-ec11c05fe980@kernel.org> In-Reply-To: <20240827-selftests-mptcp-longer-tests-v1-0-ec11c05fe980@kernel.org> To: mptcp@lists.linux.dev Cc: "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1166; i=matttbe@kernel.org; h=from:subject:message-id; bh=WJb/Kgt9lR8/dWqylu2fOxhLzw/aMaNSn5UlKGkvWF8=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBmzdYUBu9g1j7kqwo0mcmhnPIA9M15TFwqu7/xd lk9jOcicsKJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZs3WFAAKCRD2t4JPQmmg c90gD/4+KU1VaFPSUTd1Zr0bdfZSUZnhFd9MDQg7braYmCmx6NijnDjnBGMX1MU6xicccwe8kut 7TBgNtigatIsCN3EIBp/ZA0oexViQNewBgG6HwEo1RhN2JmUeo+kBza/5SEHj4rb0UdqG+lp1TM Rc/DJoJCsE9fKr3mhFLXDdNdolOPjS/VgGQ/YTDLPlSQ5OpNeN6/OeRzmXUAHs/G8NiBv2mw5kv b5YJNi/0rAbgoQRvFts8rDiTy85yAeHYwW4IDfmlOyiJuN317lgT1hMuN1OfJgvj80fV2VaQ6aF 0OnMQwDyr4KDAgus6pOmOYtgnbVgb6UJAkUS/JXmloutbtGW20MaVHeBSctJmegeDp7tfrPg8/s XfAQjVaC5X3Nns/yVRyCzm12/F+mD6w0FDzo7CtuGX2r5rO20W2HSiU1387T/MDilAPdA7a25Oo XEafulTiOzVj/RvK8fKuk40PASmnGgMUGJEt5gmul5bLy2KsnP2rBs07wP69wW7+E4jnYExJJHY ItTzNEPMV4XCVAJ6wZdSScYMqhjW8dS3kDe5okv+j5Zb+ZKaMhD+Dl+eg9fmAZRq0ZD94iVdPVD 5+fJunUTSKO/XLKgdpiWv/VamfSLiVTOJ1eAKMyFMO4soVAYH9NrdrgZK80q8+RItLqy6rzXf7e Q3yYWDmlo2SLd4g== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 Just to align with the previous test (delete and re-add), here we do the same for "delete re-add signal". It doesn't seem to be an issue on the Netdev CI for the moment, but better be safe than sorry. Plus, it doesn't change anything for the test: the connection will run for longer, but it will be killed when all operations have been done. Signed-off-by: Matthieu Baerts (NGI0) --- tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testin= g/selftests/net/mptcp/mptcp_join.sh index 19abc3c1a7ae..3564cd06643c 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh @@ -3762,7 +3762,7 @@ endpoint_tests() # broadcast IP: no packet for this address will be received on ns1 pm_nl_add_endpoint $ns1 224.0.0.1 id 2 flags signal pm_nl_add_endpoint $ns1 10.0.1.1 id 42 flags signal - { test_linkfail=3D4 speed=3D20 \ + { test_linkfail=3D4 speed=3D5 \ run_tests $ns1 $ns2 10.0.1.1 & } 2>/dev/null local tests_pid=3D$! =20 --=20 2.45.2