From nobody Wed Oct 30 22:16:39 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7C5C40849; Sat, 27 Jul 2024 10:12:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722075140; cv=none; b=TlzrmfFFn4A6hpQaSK5F4W8LqMO5aaegrksuhbA8+VkqlQxivBSTV7C8gFKPyuwi2SG08jy7eudz/voC0Ummi0nRpPPSlNPELPB1+ZloZIIXPyRgDit7HIp4G+EM1z8DHG1NbwtpYMwF8s/UoFva23X9PU14V3DrGosBFF6jt7k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722075140; c=relaxed/simple; bh=bCaMgVST+E6nlnwmefePq27Eu3ZiZE5vGpFBfhZlblU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=h3RgiGSHQ4eJRRU4mYCWcxp82Nnbj2rJVIKj1d6/HkiOChEEewWo5PvPb/MzdQudw3Mh4HHoztyB8rDx6NHwmx3r0itpJtOyYdw3g5uebgSxWG5eVnwf0krl0249hiw44RlSIBMllXsHdtcVzSQYxGeaXIsi6l0t3AYnszKUTSE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lesZFCSw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lesZFCSw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D064EC4AF09; Sat, 27 Jul 2024 10:12:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722075140; bh=bCaMgVST+E6nlnwmefePq27Eu3ZiZE5vGpFBfhZlblU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=lesZFCSw82Lvj7lfYviIrG770L5/v/8zxtuAYqnDEKUUXfQZcGToY5Tg/Z6SXrN2+ WlMO9fIj2iXDXH8WoG5dDxtExnlv3AhMPYRsPeZw0yQsT2YPRcxwwNjzCZdNiFxBDL bJ2jREr69uoubznx4kpRK3P3AEuCkBlAtxH6s/lJjevqiKTTHLsrAlueIjXN1OBWMZ vNfuMbcrpRjrlN+RqxTsGmrqCN7xN04tJNxfndH+ihzn17otfOw7xWoTr0CO0VakNW qJukt72nYW1eUisr/ByxfTN9x9SAasGymez/vDCylMGRyC6vdi8UHhkodR92Ac5O/T g/46jxSuvIC5w== From: "Matthieu Baerts (NGI0)" Date: Sat, 27 Jul 2024 12:10:30 +0200 Subject: [PATCH iproute2-net 1/7] man: mptcp: document 'dev IFNAME' Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240727-upstream-iproute2-net-20240726-mptcp-man-user-feedback-v1-1-c6398c2014ea@kernel.org> References: <20240727-upstream-iproute2-net-20240726-mptcp-man-user-feedback-v1-0-c6398c2014ea@kernel.org> In-Reply-To: <20240727-upstream-iproute2-net-20240726-mptcp-man-user-feedback-v1-0-c6398c2014ea@kernel.org> To: Stephen Hemminger Cc: David Ahern , netdev@vger.kernel.org, MPTCP Upstream , Mat Martineau , Geliang Tang , "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1191; i=matttbe@kernel.org; h=from:subject:message-id; bh=bCaMgVST+E6nlnwmefePq27Eu3ZiZE5vGpFBfhZlblU=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBmpMgAstfIOovUd8Yhzbd7mp7xtRP9EMSgj0gch 7EcDktVEPaJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZqTIAAAKCRD2t4JPQmmg c0k8D/9GbxRSkx2obBwjmEF1U3QimDSjJdwzA92kA1IY8mtvJYMqV4o+Wt3xT37RVs3+Fralq43 VNW47rJ1gvqzkCDGc4URCjrqbQ7aaLLN9WlvIqoKDtghXAPjt2jb9MEA4Q5WQtN2z48nwRpCXwE ldre2gwknYzSaxdCJ81Bt/MIyVrK8ofB9JfENqGvhNRriwyArsaS8cFe76ptKclhRY9UBd7a3fQ TUjyrXoc+O8HW1YLvShy7TCB5MkNT9cJzhyTVAJSdBBv/Av582lKaVR0r9QQ32hfnMgkwfFCpos pm/b+RgIE+b3+vXte3k2uHCBwX8vDPO3z//VuHGEeh1QevLXkdvTJWMfze9642kIbTiSYW5JpKU S5sANC7NRz/3ly+SPH6rojxtVw18IjdkZaGHNrI07B2PVBwfD8D9m4zMZQTtZ8duMRBsf0ggrLY 0PcPe9w3KyjndetUMSF07Hah3mpMQ16UnF2nWki6pA/TiHIT5HNs5EtyNMV1dRAx2yYncc4AYtg qNqbMruoV0DS8ZPTV6v07nb2OIqE4L+8D4VTnVdT2eDymUV86u2urYlcrpyrIYxlowBKZ96fmGQ I/pTC+GjSTrH8tYGQmEjUsOJPp4BAFf0QM0IlTmhGmstnUKhsfHi9N7ZpCVoQCHpoUxN5U2oJ+B HBm6Lgn6etT1KxQ== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 It was missing, while it is a very important option. Indeed, without it, the kernel might not pick the right interface to send packets for additional subflows. Mention that in the man page. Acked-by: Mat Martineau Signed-off-by: Matthieu Baerts (NGI0) --- man/man8/ip-mptcp.8 | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/man/man8/ip-mptcp.8 b/man/man8/ip-mptcp.8 index 6c708957..89fcb64f 100644 --- a/man/man8/ip-mptcp.8 +++ b/man/man8/ip-mptcp.8 @@ -135,6 +135,14 @@ established MPTCP sockets will be accepted on the spec= ified port, regardless the original listener port accepting the first MPTCP subflow and/or this peer being actually on the client side. =20 +.TP +.IR IFNAME +is the network interface name attached to the endpoint. It is important to +specify this device name linked to the address to make sure the system kno= ws how +to route packets from the specified IP address to the correct network inte= rface. +Without this, it might be required to add IP rules and routes to have the +expected behavior. + .TP .IR ID is a unique numeric identifier for the given endpoint --=20 2.45.2 From nobody Wed Oct 30 22:16:39 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62EBD55E58; Sat, 27 Jul 2024 10:12:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722075142; cv=none; b=lqLuNI2drOuztF9PxsaiTIQRyhpxXXVZtHF7vK5FAzuojHGHLKS/mpa4tVAeh0SqwCWuLIM/z/w1Se9n9pRMLqQPiO87H+2PFXJUV8zgVbxdN7sxukQPd0yfJeZJmH3xBC0FGJtKUYg0hKbx2RJDdkrcrR6GLEE3H96LjDtliJA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722075142; c=relaxed/simple; bh=c+fr862AGNGG8UQ/xKpCft+CWaGk6C9gagkc+WEPBJc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aEBlKu1b0MQrO5C5Zu+tWVAdXxoy5FtqA0HWOplOt2VJgrX6cnUXzeDXHb/H2dV+t4FHPVS6sLFuJ3tM+v2OW5cSckDSdKf8JPRMF4QgYQMV1dSekyL9UidZnU/BgvHOrD+CITMcrtMVzmZzQ4V8OjPEeY5FR1DFCgEbOFp66Q4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oI6qqdfy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oI6qqdfy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2B7DC4AF0A; Sat, 27 Jul 2024 10:12:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722075142; bh=c+fr862AGNGG8UQ/xKpCft+CWaGk6C9gagkc+WEPBJc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=oI6qqdfyDR54b7/EZ7KCQZcJwzHm299xOi0RlUfuNEWiUN4btEA9wrjDXj4FXroH9 z9XpgAcd0D5DRb9WXMhfC4ZX9cKfv/kiaD1nwmXvZ9Ejz8NBYl3Nh6eJmXrX3uxV5/ CLZn6dbYXbxI1mlusQPxQMUAqFzlfFWcWXoCeW3xapU7QtWLaBdME0raO0YbUh2H4Z IJWHQ1sfPUp7WzIYvKFCVLr9bMZgyrxbBB70yT4CqTnYA/2PzwkzgoAlxA1Eaj011c ln9c4p+C81a98NN/YWXdZRU705O7Xh3KeXClmtI5SRBv8allDwY9SoMKzEIYgppe4m pZLYVeijJLUrg== From: "Matthieu Baerts (NGI0)" Date: Sat, 27 Jul 2024 12:10:31 +0200 Subject: [PATCH iproute2-net 2/7] man: mptcp: clarify 'signal' and 'subflow' flags Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240727-upstream-iproute2-net-20240726-mptcp-man-user-feedback-v1-2-c6398c2014ea@kernel.org> References: <20240727-upstream-iproute2-net-20240726-mptcp-man-user-feedback-v1-0-c6398c2014ea@kernel.org> In-Reply-To: <20240727-upstream-iproute2-net-20240726-mptcp-man-user-feedback-v1-0-c6398c2014ea@kernel.org> To: Stephen Hemminger Cc: David Ahern , netdev@vger.kernel.org, MPTCP Upstream , Mat Martineau , Geliang Tang , "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1535; i=matttbe@kernel.org; h=from:subject:message-id; bh=c+fr862AGNGG8UQ/xKpCft+CWaGk6C9gagkc+WEPBJc=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBmpMgA900tEZBs4VqKQyj2dPfNMRPxRdJalSzp/ aNag84jr5GJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZqTIAAAKCRD2t4JPQmmg c9T7D/kBnmTpe5cBnHSR4wZCzUV90Ky8LF1Mavg3Ri9vRXt0C11GlfEDEwaLJtM5bYYhbLAa6In syEoA1QWt0hw4shDbE/plEiybmWZYa9jgFgWTthAczMuNN5MBYpcba/qDXK3smxcvJq9GGZt1Q3 EB6/BmM6lqPwVlD4ZSLdrU4dnfQHukRC7s6GNVCB4O1pGcz/cgj732rQtjaTUtPDEmnA3kdLdfI ulnTB6vWQw+iYlibz/oQXW418DMoltoWgQBFMsLZokf/g8Z8EWglOjfO5FHRQ/UErh6ltcQmtma Fjvs3rmmfXgqOyATNbq91W1IjyBGRZ+o5lOe1w8zlIWAouc/LjRbn/2fhdPLNU71hcwDIPhkWuO dGVQAWXB104CyBJK02o5jj4yhGzxvdcPpjXe/sweYPlgIpBJhmx2oujm6QtcMd/QRch6D9m6EOZ NEc2Z+aGcMm24URaQKhZaZ+eU3jN0Rhc47cxdChIh8UDgaafRkfSrzJ9JSsJrV+3e4Tt8XyDgFh QY2BYkZByHVg1OEbyUbFlRAgK2SjPJyACTtqDrMG6DZfNf8e10sIOw6Dczn+jz30ODEgC4iidr2 jKZC+DedVTSV8OPB6eEvoZQh8/p525PkNtygTMrva/mRsqW5dHG+9JBQVHVs8otvi7ZRNcPjzU7 mXVXffEnb/+ZldQ== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 According to some bug reports on the MPTCP project, these options might be a bit confusing for some. Mentioning that the 'signal' flag is typically for a server, and the 'subflow' one is typically for a client should help the user knowing in which context which flag should be picked. Acked-by: Mat Martineau Signed-off-by: Matthieu Baerts (NGI0) --- man/man8/ip-mptcp.8 | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/man/man8/ip-mptcp.8 b/man/man8/ip-mptcp.8 index 89fcb64f..2b693564 100644 --- a/man/man8/ip-mptcp.8 +++ b/man/man8/ip-mptcp.8 @@ -150,7 +150,8 @@ is a unique numeric identifier for the given endpoint .TP .BR signal The endpoint will be announced/signaled to each peer via an MPTCP ADD_ADDR -sub-option. Upon reception of an ADD_ADDR sub-option, the peer can try to +sub-option. Typically, a server would be responsible for this. Upon recept= ion of +an ADD_ADDR sub-option, the other peer, typically the client side, can try= to create additional subflows, see .BR ADD_ADDR_ACCEPTED_NR. =20 @@ -158,7 +159,8 @@ create additional subflows, see .BR subflow If additional subflow creation is allowed by the MPTCP limits, the MPTCP path manager will try to create an additional subflow using this endpoint -as the source address after the MPTCP connection is established. +as the source address after the MPTCP connection is established. A client = would +typically do this. =20 .TP .BR backup --=20 2.45.2 From nobody Wed Oct 30 22:16:39 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 554E958203; Sat, 27 Jul 2024 10:12:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722075144; cv=none; b=CucZ9uw1Cvxbd1QUKjK7bSvGiACYf+0G8H0fkSPA6KovcYwO1oitiq45qmRE0XxdCkTErRFLWkoXCnOHbGkJnx/+JpVqwFhOPlXTtKvU/tPWE27IjufDfbdHuRN1dQoGccwaPtVnmsKizfGkX/Air1k0PlIKgcLygNeH7ab7T2I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722075144; c=relaxed/simple; bh=Eg4C6ZPAfMWBhmGpVUvBdOM2+OEckNAuop6FhUHVt60=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AbE7Zo40iqK00zLzregVEK73Z6GFfXi/QjaDSkWHi5M0MNtu0D3O8e8HJB4+BToNLgpW1MTcfsw5WZQk6D4UR4pmh0SEEHolAkmODt054rKeSpRPb/ComMlVZxpy4ONPpzHWK27Nkv/Ljg6avmt08eQOWCmV1Wpk9WIKAlUiO/A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iwu4cLMe; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iwu4cLMe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B61F1C32786; Sat, 27 Jul 2024 10:12:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722075144; bh=Eg4C6ZPAfMWBhmGpVUvBdOM2+OEckNAuop6FhUHVt60=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=iwu4cLMegLousCQrzmVYTo6b7P9hDlSmVBy+0CNxJfxAu/FxOv5aOhZbhQMkqGj4g onPRUA0edxf3YFmcby1R6kvXl5TLAqa/OTdg3fHjceaRn/Lbb1HccfClBAg5/rKzcH Aywz/A50K5YTX1sUzQCBtdL0bjX3HuMWoqg7sd1KxngLApiGNlGX3KQs/dF7/iMRGB QMUqF5W56NDDqla3ftOWpbIT27gKkHx5ziUpHQe7z1B9mCJqKJ7xHxHh0/CMgWN9bY V1hYz6NNlbUnRfZg6rDdYoP+D/AA6uHrrZStPIm1QbGf6KZklCWSkkIPXkihwnjvKB SfVeV6er4Oq7g== From: "Matthieu Baerts (NGI0)" Date: Sat, 27 Jul 2024 12:10:32 +0200 Subject: [PATCH iproute2-net 3/7] man: mptcp: 'port' has to be used with 'signal' Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240727-upstream-iproute2-net-20240726-mptcp-man-user-feedback-v1-3-c6398c2014ea@kernel.org> References: <20240727-upstream-iproute2-net-20240726-mptcp-man-user-feedback-v1-0-c6398c2014ea@kernel.org> In-Reply-To: <20240727-upstream-iproute2-net-20240726-mptcp-man-user-feedback-v1-0-c6398c2014ea@kernel.org> To: Stephen Hemminger Cc: David Ahern , netdev@vger.kernel.org, MPTCP Upstream , Mat Martineau , Geliang Tang , "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=985; i=matttbe@kernel.org; h=from:subject:message-id; bh=Eg4C6ZPAfMWBhmGpVUvBdOM2+OEckNAuop6FhUHVt60=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBmpMgAEkZxKixtdp2t675k2vJgI7nBO1CLg0pun BjlXAeaeBGJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZqTIAAAKCRD2t4JPQmmg cwVgD/9IDhs50LM5foYRFi8M+HJ0TMK9zVqaaj1eFrGogYndUZVJce8bRBlraPSyGehhw11XSlY dXBSgxKNqeFDNbdDzip3y8/5c9KdydtLuDTa1hEeO8daA5cZLKWgcNxkcHu29qnlzyWKVE+Tllx JZX2nASb3EfAGz8nWbd2LtjNPyOfgR507E3KdCZQfzoDFQ8fLCqab3HfbV7LCdf0oWfhc5Erak6 V8/Ct2IbDQn5dlQHVLI+09cY+NQeKE5J7Do50WWFSrEseCx82C+vtiplLJY2D+kn4N30miWX1ua lcZsNlaAuNY4vhiGccxmct891soE+xd8zKX3TPcSM9b+9GP3GK/WRND37YechOqhPdQt8ehsvsu 8gIhzeWSUsBo4H5MFDzZ6a6X02h9N5220/2mTqrUrg7Kl291lu0Lde5yzh9j6a0QkeHNUvLEoeo Eoen06CJa2GWQ8QpRbeZLCk/BvmMT++PPZEthLV+qcKzOMMDzzoD+qooJudJIQ5yeaC1okuIad/ K57Cob8ag+IZHj7sHSLDDMhoyJm3+UPWdcASsKIbHWQGz8L7ybYFu/HyM9+YohjZHTSeEN/IYnx pGvLPXusuk7fxaLHF7Rs7PBc4AjZS7RM1lCEZRoPaEkXrXQCfxi+6dkg/iHIbcx0P8ETl/kRA6/ Xp4ELsC+j7pXT8Q== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 That's what is enforced by the kernel: the 'port' is used to create a new listening socket on that port, not to create a new subflow from/to that port. It then requires the 'signal' flag. Acked-by: Mat Martineau Signed-off-by: Matthieu Baerts (NGI0) --- man/man8/ip-mptcp.8 | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/man/man8/ip-mptcp.8 b/man/man8/ip-mptcp.8 index 2b693564..11df43ce 100644 --- a/man/man8/ip-mptcp.8 +++ b/man/man8/ip-mptcp.8 @@ -133,7 +133,10 @@ is 0. When a port number is specified, incoming MPTCP subflows for already established MPTCP sockets will be accepted on the specified port, regardle= ss the original listener port accepting the first MPTCP subflow and/or -this peer being actually on the client side. +this peer being actually on the client side. This option has to be used in +combination with the +.BR signal +flag. =20 .TP .IR IFNAME --=20 2.45.2 From nobody Wed Oct 30 22:16:39 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52AC51C2D; Sat, 27 Jul 2024 10:12:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722075146; cv=none; b=lwwW/1Fs1j1bj4/cYjynKh31rc/Sd1F+FZvGVUz6OOqONKIYfWfvu6NLy8jcsBipDaoEUYVIofcxoxaYZuZcirb1o6m/iYkKfbRvvPKOQyU2Ka1n4NL+tkSwLhcxm6wB91vjL4a35F3m6dXn1dBq401L46tsevtb3T8/Gn7sVJY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722075146; c=relaxed/simple; bh=m8/YsWwUAxDtOWWk0+Nmfe8UX/0337jnAlbMwnQqOPE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=psx+HJ59k//fKToXyzHiNlm/G6WrwlKiBzRccTSjjj2pxOuhCl8RqC6/HRFUjbvY6FC+umIT6G3Z/h0j7PQe+uf4rnBI1Gsm5CRrfzGKud7pQ2rIyS5Og50PvPhcy8Cn4WaM332T5zttJKGbxh/Twq7Xh/TkbBe1hnNi4oVh+Qs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dOBdDx0Z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dOBdDx0Z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8C69C32781; Sat, 27 Jul 2024 10:12:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722075146; bh=m8/YsWwUAxDtOWWk0+Nmfe8UX/0337jnAlbMwnQqOPE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=dOBdDx0ZmfqLgBtBS8Rr+1HFP+Z8lceqVaEa8VJACt0B9ksDT8KM8mWcvF8bdxSt+ U11iwr4DUyxEWMKCkUM6oeroJMquHY7aA/jvdxbqxVcX9qPnDbAHrVoEpgY7dvSL7j WFozx7RNVwTueLs7C/5fFUZEPK3XyjuNkF+ul9SDVwfNUt+AHmAZ+a1LFItJ1dY2S+ n9G7fWCGWLQZEdWqjJdE69aboewQBoUmEuD4LbJAmGSxn9QoETKKHyDkY/bbfhD9F9 1AlbB6wStNHpjKWxPWbxcfJHjFcduROY48U54ffufGz9zt7BuDtR0QOokawf853/FU ahCvo0CyPn7AQ== From: "Matthieu Baerts (NGI0)" Date: Sat, 27 Jul 2024 12:10:33 +0200 Subject: [PATCH iproute2-net 4/7] man: mptcp: 'backup' flag also affects outgoing data Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240727-upstream-iproute2-net-20240726-mptcp-man-user-feedback-v1-4-c6398c2014ea@kernel.org> References: <20240727-upstream-iproute2-net-20240726-mptcp-man-user-feedback-v1-0-c6398c2014ea@kernel.org> In-Reply-To: <20240727-upstream-iproute2-net-20240726-mptcp-man-user-feedback-v1-0-c6398c2014ea@kernel.org> To: Stephen Hemminger Cc: David Ahern , netdev@vger.kernel.org, MPTCP Upstream , Mat Martineau , Geliang Tang , "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1512; i=matttbe@kernel.org; h=from:subject:message-id; bh=m8/YsWwUAxDtOWWk0+Nmfe8UX/0337jnAlbMwnQqOPE=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBmpMgATtUmo+tqHIdsuGh49PdI9IYuDsIrdsWUy rgWaWPm2wyJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZqTIAAAKCRD2t4JPQmmg cx97D/9gRtNusXHJuU+CXV+zkc/JDsmTp08L5ztt+U6nj3y3Z7zAq11J7WeZ6bkTbqsuD6iV9x7 JWktt5cvsUglQ8QRDrp8EC+zdNUFKQZFqudmJb0pdMVplhU+JTu3A2r4GfPT4Rbu7BGlAw7Xp1X DPLuHmuu6F8Fheop/H5gf2K5Nxn16yVq3j+cOX4QG6ynO5uzTRatXTWO/5bLLyg211JSY3EBPzq axC3haW1FNf8Env9mPJNCmAZH5BUkkWHlZ8nToofZeQZEbhHoPMw1ipmtdadTdvewff0V7bj+GE 1gzfwF35UQ0oOiFa8giRrNvXZWDvMN4fWbCftx/lraPE5AYiS/QPguwxxa5ft/86vhlHItfFi6t t/gAAnqANUtAi/5VihjcPA2CDV/cyQ5R0Jm1O635n28QB6BjpIb7sncb5TRDFff3fqSV///ZXXc 4EK2Qy0uhkG8iujAtzind8iVN3YqjarFDOHSk2tRUojI8J3mmllYVvEaMoezP72Z5eXksXBhgzu BzzH4goVAIpOeTHTpQzxw4uWzZiEkPIsu4CYE5Dr88M0Qmmn/rsYr7W/yPI9iRKNWpvBAV/DgDg IHHDX4PtLdwDM8/MVaxpIk6IYTrAFf0eeairW+5z0QdM/C+zmcPioj49akgISHGzGCPHfr8cMHI n58/N1RiwMWm/UA== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 That's the behaviour with the default packet scheduler. In some early design, the default scheduler was supposed to take into account only the received backup flags, but it ended up not being the case, and setting the flag would also affect outgoing data. Suggested-by: Mat Martineau Acked-by: Mat Martineau Signed-off-by: Matthieu Baerts (NGI0) --- man/man8/ip-mptcp.8 | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/man/man8/ip-mptcp.8 b/man/man8/ip-mptcp.8 index 11df43ce..f3d09bab 100644 --- a/man/man8/ip-mptcp.8 +++ b/man/man8/ip-mptcp.8 @@ -170,10 +170,12 @@ typically do this. If this is a .BR subflow endpoint, the subflows created using this endpoint will have the backup -flag set during the connection process. This flag instructs the peer to -only send data on a given subflow when all non-backup subflows are -unavailable. This does not affect outgoing data, where subflow priority -is determined by the backup/non-backup flag received from the peer +flag set during the connection process. This flag instructs the remote +peer to only send data on a given subflow when all non-backup subflows +are unavailable. When using the default packet scheduler with a 'backup' +endpoint, outgoing data from the local peer is also affected: packets +will only be sent from this endpoint when all non-backup subflows are +unavailable. =20 .TP .BR fullmesh --=20 2.45.2 From nobody Wed Oct 30 22:16:39 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 897721C2D; Sat, 27 Jul 2024 10:12:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722075148; cv=none; b=Lc/YLEq+3tJCI+Hi5VBD8UASEcZQyoFiKRtvdgn49e0PI+2uXRd4JiTTmQdMSz8cyMxc3Nln+empp51dZUmVMk2a7Gf0ILGjSPxNAd/a2c68AbHXWj5rXg3GyM+/g+LGFCsn3mQuEyF4S3JP0Hraxj7qynTrlYfxKKy42geYSeg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722075148; c=relaxed/simple; bh=DzynoOoC7+thgs+TYKlYcgcBgYWHSkzlGjhag0lPEks=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OQ1ZtroSMvwk4yMgIXLvgWbY3OH+CeFuDAs+cwk4oBvKVUjBUFqs3zTIFrVHdhxJwPwZzzDyeMPmx4MFGRA1EL3sYBHduNsrbUugjFJru/Xei28rd1pcKgxGf7+3vkqV4fbxrBMgWIwH+8Tmhwp1GRz6wEw2OTDzkqEsm6ss28g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dGdpCBBY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dGdpCBBY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C532C4AF10; Sat, 27 Jul 2024 10:12:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722075148; bh=DzynoOoC7+thgs+TYKlYcgcBgYWHSkzlGjhag0lPEks=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=dGdpCBBY5dkw7CtZKjNmnZyAt2Hnv2vhFn/Je0Kyr7JimrwFXPYkc5/3AZp0Yfv1T 9YwfbxDhGeBtEnCDdv+reWUwIuffxO4Mh+k7Bgg8OXbIvWMPA2lDS3+U5eGbQJREBL Y0d0Rz1+9Ow/NmrFeYpkmXjUJspIZ2aDWfuY2uqApsNf8eRvlg7G8AIgWA0Nqhwp9S kveS2O3gd9+Ds3bTCJdS7AWHSmM+aQIo4fKW95+GMTA/qCcDBCIZ33wHkVhOkWtqIt dsDqdmgOCjw6oCs5QFWLoQUZXTXtlYgJIUgkZBw3FqzdgcObArM31t0ZsC2nedvanw XvjY2H9BEldCw== From: "Matthieu Baerts (NGI0)" Date: Sat, 27 Jul 2024 12:10:34 +0200 Subject: [PATCH iproute2-net 5/7] man: mptcp: 'fullmesh' has to be used with 'subflow' Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240727-upstream-iproute2-net-20240726-mptcp-man-user-feedback-v1-5-c6398c2014ea@kernel.org> References: <20240727-upstream-iproute2-net-20240726-mptcp-man-user-feedback-v1-0-c6398c2014ea@kernel.org> In-Reply-To: <20240727-upstream-iproute2-net-20240726-mptcp-man-user-feedback-v1-0-c6398c2014ea@kernel.org> To: Stephen Hemminger Cc: David Ahern , netdev@vger.kernel.org, MPTCP Upstream , Mat Martineau , Geliang Tang , "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=980; i=matttbe@kernel.org; h=from:subject:message-id; bh=DzynoOoC7+thgs+TYKlYcgcBgYWHSkzlGjhag0lPEks=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBmpMgA1nOfSI8wBxFpB/DuDl6QbJgrVh1gn3Tj9 9aG4KYledaJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZqTIAAAKCRD2t4JPQmmg c/PAEACjZo0TziZ8rgTRHqgeIf9vm4ITvFfkpylqoXO3jLwc6fuCjNr1jST1C0WCZZu/2WiSvSs KA/oFvqXGEtR5ZHwjTriz4tPJdGALgoovekJB0/+N6tIml5AVILk3TJ6KRuydD/eUpLlRNWJlk3 3IIQ8rkMZH3E38Jib6zNkY+QzQMJztBlvJJP8Ipf46/JuZM/Nq5Qf5IXAM/nBLsDasxBo8/25jW T4ibLYlDPhGtBVGZhQ3tz5MmMZACTqH7835ceFnIyPCMqrkL8cwQUb4ko2ElHzaDo1w0QsA8dm8 GMsHl+Jwl7c05ldy4wLLn4Xsf8TBr9QLC8Tk2ZMMyC3CL5+NGQhjmSk3dK8Q/58kg5q0pU8LSUT jLxnJqYS7Z9VsIzEHGBTcVXkAvMcJWE/Juv/yEcArRL/1no0voV8g9FDwZUEW2ud1DmgCf2ebo7 G3WTtBaQg2aMft0+JknM5TE6kQCXIK07uz8Dv2At3nKTmkFUuRLevKx6q4PUiDgYLE/c3wHE/Bf PflLUoqSXmAoEuMtwtn87VA34BvJ+R0d69P2O/aZoDgIvx7CPOBE6AGgxyyX0V5/L4H8TFLaBFa ktUl6cCI4CVcgWZ7GcJNRVokax/B+BrPrHP7+LgfVXAv95k9KXRZSqhtv5z3M7f7lGlLL+jWiEd CeBa6fwzCnU2YDQ== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 'fullmesh' affects the subflow creation, it has to be used with the 'subflow' flag. That's what is enforced on the kernel side. Acked-by: Mat Martineau Signed-off-by: Matthieu Baerts (NGI0) --- man/man8/ip-mptcp.8 | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/man/man8/ip-mptcp.8 b/man/man8/ip-mptcp.8 index f3d09bab..4c1161fe 100644 --- a/man/man8/ip-mptcp.8 +++ b/man/man8/ip-mptcp.8 @@ -190,7 +190,14 @@ this will behave the same as a plain .BR subflow endpoint. When the peer does announce addresses, each received ADD_ADDR sub-option will trigger creation of an additional subflow to generate a -full mesh topology. +full mesh topology. This +.BR fullmesh +flag should always be used in combination with the +.BR subflow +one to be useful, except for the address used by the initial subflow, +where +.BR subflow +is then optional. =20 .TP .BR implicit --=20 2.45.2 From nobody Wed Oct 30 22:16:39 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8153A537F5; Sat, 27 Jul 2024 10:12:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722075150; cv=none; b=kX58Fym2TSjE+gd9mI9k/4Va4qFc66oOxP0dpGz23scOm81Yc8Yf3HOlYibi6uf0FEwI0fgAsVS3ZmEwcp7R5p5l+zznuGnu9v9hQtjo/pLRH+xYZllVP93dUmldOFzrxQ6dLBP6lg0AaP/iqrnFW8FlzQFYKezLH/EFHbjlRno= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722075150; c=relaxed/simple; bh=cCLFaVdPcQbvfOFyb6WEE2nqQ88R0B1vxmSWl3J/yac=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=r47voU2dqYkobchw8bKeJR0dQWVR56z4zbi5jkncrKhIQGcbBawJsSFP3EAV23m+JZhJCVNsrO7IoUpmxp8G0afU1n1wG8rFGhEJGFmCh9kesCbMcVH1BN1Du/l+5u2gXtreTGh9BjaVN+gP6TVyj4j4IxZuijyuh8ZTk7p7KFE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DwslFaZD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DwslFaZD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8EC48C4AF09; Sat, 27 Jul 2024 10:12:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722075150; bh=cCLFaVdPcQbvfOFyb6WEE2nqQ88R0B1vxmSWl3J/yac=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=DwslFaZD38mcBaSsI2KY8l/52pdMuKd4utfHjTtjgEefdigFwDYjVooFBjI4zHyv3 Do7/dWfRHhwTzX5ntvN17pH3Q0nKg//hXcC0EScu4R7DT5zIzgiYoqRPXB5Jp5nXqf k+pYuGK96KmFAu9YvzD3/eZvvpLPNh+w03SqmddaBvKvU8TQ0BwErQBERJzO2Xxw6i av+ABoXBSEHbyjgbWdqWBjkowLao3n6Ysxvce1gS9fyzP5rCpElC9t1NwwrhSRTScz cT8kUOjMvRXBSHA+c13h6HuZSFWP+Nz9+ivKSS/N45RIJajdgAaLS8K4ko1TgoAYV6 cqSv+2UEVONDw== From: "Matthieu Baerts (NGI0)" Date: Sat, 27 Jul 2024 12:10:35 +0200 Subject: [PATCH iproute2-net 6/7] man: mptcp: clarify the 'ID' parameter Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240727-upstream-iproute2-net-20240726-mptcp-man-user-feedback-v1-6-c6398c2014ea@kernel.org> References: <20240727-upstream-iproute2-net-20240726-mptcp-man-user-feedback-v1-0-c6398c2014ea@kernel.org> In-Reply-To: <20240727-upstream-iproute2-net-20240726-mptcp-man-user-feedback-v1-0-c6398c2014ea@kernel.org> To: Stephen Hemminger Cc: David Ahern , netdev@vger.kernel.org, MPTCP Upstream , Mat Martineau , Geliang Tang , "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1106; i=matttbe@kernel.org; h=from:subject:message-id; bh=cCLFaVdPcQbvfOFyb6WEE2nqQ88R0B1vxmSWl3J/yac=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBmpMgAzKelMinQhdZVzeDELlFRgzoiCxP5QsUdj xF0HcuYU0qJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZqTIAAAKCRD2t4JPQmmg c1qDEADT2096Z1+roQdEKI5MjBCqUMAtbql7EYuQFyWPvmNsTlb4dtKkxQUhUBv6plKx/YSJ3R0 TZJjFgb+0Go9XeoqrW2/m9FwVBN4ocQcPP/zH90ffMAvRSKH3/vcuOGKEpaUeKPVewHNsapphPj yrODnxhj+SaV0TynWgIXwcBCxCpmQAX9ZvV+iPOLzkZvZr2+iZVnCzrCPm3pZ/62Ah+yoDssTdU FcDfeMqLJlenbd8lNRHMScx5sURinNhtDeZ6s2mLIgVUzq5IVSxEMbIWOFa+ieOie6m7mnmpDE3 pRxhptH5N9yyHQ7q/BjwZnRCLUTsZ/KxL8Xipl6mi7X6AFDk1r1XjRsVpnc/NoA0GuQyyXQtDzq tvuRgHAxg4HsM/wLa+ljNeLkd1zFJy2KOJ/gn4rFVExkGUYFQ5giX/3RNszuXtBmL90fiEbCq46 SmyOW/Ws5UlCu53CMQ4u89jhze+jOf7BJ40g9Ep5YC0JjplwwKU+vQ28w42oLG+Y0etbL5z8gqL F9FPCSavj6npAYwEpc4cOffSQg4Qiw1T15xCM2y/nYEWfVIbYE4lEY/4iNxJlg+vy9los+IYBul l0kkOhXCK+AOD+sZDvgVXfwGZd7pFZ/YsXKD7d5Uta8PgVWCM7SQZE8tYnYA0tSxn8lv6UN6NT2 8qebVZxwIvPXPcA== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 Explain the range (u8), and the special case for ID 0. The endpoints here are for all the connections, while the ID 0 is a special case per connection, depending on the source address used by the initial subflow. This ID 0 can then not be used for the global endpoints. Acked-by: Mat Martineau Signed-off-by: Matthieu Baerts (NGI0) --- man/man8/ip-mptcp.8 | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/man/man8/ip-mptcp.8 b/man/man8/ip-mptcp.8 index 4c1161fe..e4a55f6c 100644 --- a/man/man8/ip-mptcp.8 +++ b/man/man8/ip-mptcp.8 @@ -148,7 +148,11 @@ expected behavior. =20 .TP .IR ID -is a unique numeric identifier for the given endpoint +is a unique numeric identifier, between 0 and 255, for the given endpoint.= It is +not possible to add endpoints with ID 0, because this special ID is reserv= ed for +the initial subflow. For rules linked to the initial subflow, the path-man= ager +will look at endpoints matching the same address, and port if set, ignorin= g the +ID. =20 .TP .BR signal --=20 2.45.2 From nobody Wed Oct 30 22:16:39 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21209537F5; Sat, 27 Jul 2024 10:12:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722075152; cv=none; b=iKZmw4SEHtJh5f7X2CyIVm6fKlAzCYEL4wMA7YpyGAE5aWWaQO5OJa3efUYCWrzZ1IO7UyKslfVAGNeUC+3Yg3yzmh9t8S9BdYKtbfBujty3qyWc/1enXVnvtwbDmqz7IO+xWaTIzo4UgYth4fFvqXdmxsQVCjjNA7+k8i3GDQo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722075152; c=relaxed/simple; bh=siha0gETqKkpCOCou11om2FKnFkBx2msg5ODXag2Kms=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZI1QmJuSCo5NuNoUfiefEsuvKspe4j2/By+l+HYADu1rJfkFAsEkrisAxmqKXZR/0Rca3uePJI2rSk9gXrI8rAhv7Z8OYtv46y/bOaaSmbC4nl/u0ptMcNuqxYiAo34363B/j/Gkn9xh6FKbDivXPQsWnpWFxXsULRqsCpL4afo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CuksPL5+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CuksPL5+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81CC0C32781; Sat, 27 Jul 2024 10:12:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722075152; bh=siha0gETqKkpCOCou11om2FKnFkBx2msg5ODXag2Kms=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=CuksPL5+LT138DBvawSof00uLuOmI5g4+FM/OezHw95tgnoACfzQq2H0TWk20fiOP 8X8nvkcSPslaUmyvQGbgjIfmWYO05XucMWP3DZ0CgqpX36762D1NRIduHrnTzpckgp m2fRDaQBEpbl8dXftViFI45k8P8W6LICPmIdurBDJ/1vcLXy8I2CwQlwvY+itHtRj4 HTYxckdCaiC+pEUojgiQvqa0BhzuyTUAA5VcAeSQxac36vLWWMXq8wuYv26mccX0cp ArZmbqKMx0BWA1le742IWsln2tNxlmk6CIEa3gou0l+8dJYJp1hhv9ikPeHwQibJoq aF+aDTRX3RyCw== From: "Matthieu Baerts (NGI0)" Date: Sat, 27 Jul 2024 12:10:36 +0200 Subject: [PATCH iproute2-net 7/7] ip: mptcp: 'id 0' is only for 'del' Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240727-upstream-iproute2-net-20240726-mptcp-man-user-feedback-v1-7-c6398c2014ea@kernel.org> References: <20240727-upstream-iproute2-net-20240726-mptcp-man-user-feedback-v1-0-c6398c2014ea@kernel.org> In-Reply-To: <20240727-upstream-iproute2-net-20240726-mptcp-man-user-feedback-v1-0-c6398c2014ea@kernel.org> To: Stephen Hemminger Cc: David Ahern , netdev@vger.kernel.org, MPTCP Upstream , Mat Martineau , Geliang Tang , "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1070; i=matttbe@kernel.org; h=from:subject:message-id; bh=siha0gETqKkpCOCou11om2FKnFkBx2msg5ODXag2Kms=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBmpMgAAkXNwMnF2/o1lLBKtHNqd7mMVSPykdvM6 17GT5/FGWGJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZqTIAAAKCRD2t4JPQmmg c2GhD/9qhZF5vhSE/4HyTz3W/pxrb2JLC0E5NP8vOvgeGyJpDFOqfHXlKh9OXXFZp8Kqh1vuNwH KIf/BCDYNsnMsnq2P2btv0v91LQUvXttGKARFe/SbwbfbXQOvgTEnNtMcwGEL3Rpo/dpO9t0yt4 /WbpExsdfp2IpK1/31XbvDodXUpdOtZIPCo74zHCbuW0roYJtotk8B9xariuwhYccptkHYYqxAn zu0j9ZH6EG652SzTibdiXcOdTBXmhWbB+fC1W+uNJcwHHAGd0Z1uk+n2Z9wAH0zBpiddLVP8IUa EiPXTCCbIX/c0bk0ZEhyR3rBppoaQGqG1NdHQPKszdplVL/KUV40QJRi51klIeJQATeivfJCnqH lZBZsRHCKTgE2h3f3hctoY3h0A+vYNkHfVDmUh2Sy49JDD4Vjq2O2x1P4zESWE4K8NrLqEYDfXD rb69s8wwQ/vRANDLDYpsL6tJRCMBJY8+ZSUDt1kykopdJxYpt66UMDymQUFpcK8D5fvARXEC5HV GtLvZukjnUJQGildLsbgOaWf/shTqLk/jEU0Q4o7EBsVfTBztL33Rf+gh9ULNGg5l2nTswNF+83 8ylDuWxTtx5UBUUSEysQh+lL1JZkQrYZ8pfSRobJQz/w/XZuyKhKVKOrUIBCPLVBqaLIopy078O vxs/TMDwtpCcIKA== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 Adding an endpoint with 'id 0' is not allowed. In this case, the kernel will ignore this 'id 0' and set another one. Similarly, because there are no endpoints with this 'id 0', changing an attribute for such endpoint will not be possible. To avoid some confusions, it sounds better to clearly report an error that the ID cannot be 0 in these cases. Acked-by: Mat Martineau Signed-off-by: Matthieu Baerts (NGI0) --- ip/ipmptcp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ip/ipmptcp.c b/ip/ipmptcp.c index 9847f95b..118bac4a 100644 --- a/ip/ipmptcp.c +++ b/ip/ipmptcp.c @@ -174,6 +174,8 @@ static int mptcp_parse_opt(int argc, char **argv, struc= t nlmsghdr *n, int cmd) invarg("invalid for non-zero id address\n", "ADDRESS"); else if (!id && !addr_set) invarg("address is needed for deleting id 0 address\n", "ID"); + } else if (id_set && !deling && !id) { + invarg("cannot be 0\n", "ID"); } =20 if (adding && port && !(flags & MPTCP_PM_ADDR_FLAG_SIGNAL)) --=20 2.45.2