From nobody Mon Sep 16 19:16:48 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B5631741C8 for ; Fri, 26 Jul 2024 09:01:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721984509; cv=none; b=cDIRLfhvL/B3e+kKDdVG4L+bgUFJffZ9c2uihK+nV/p3ZtCYqo2KttiWrnTK7v8EAoTaFxMLyVygd3ovWl9PXr1+Vt0qoRsZjMrExDPars47pgLPTrlGWhbLn2aFITqfOshJcHXmG8S9gHvNB3Quev7S6ckEp91L3KPFn01aadE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721984509; c=relaxed/simple; bh=MyS+EwUW0YWnKz/PhHMEA8YFpC8AJpbZ+hVxc3AqPZ0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VhyQQu4ra+eZYVLuQ+/ekjSYQOCb5WRPbDu1LkyZ7e+H2EwEwKRVegqTURQ2XIhr/JmbW4sneF7YeA5kq12VQXQDl2dhPJmIXWZ1eEsoHiw9CO/SA2wJA83I4E7iMjktbmIHg+CmpQV9Nhgjp1CqUpio+4HibJEaqz1Dv6ELfC0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uvGMPIEA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uvGMPIEA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21DCBC4AF0C; Fri, 26 Jul 2024 09:01:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721984508; bh=MyS+EwUW0YWnKz/PhHMEA8YFpC8AJpbZ+hVxc3AqPZ0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=uvGMPIEAbulkBbCk8T2J59951gpghj9Cyb0DUAkzfS2qS+sdFxQukWzg40s6OIreN p549+aOwh2D8o37C172lBaKscu6HaSs9Z7gFYy5Q/z8WfErPc0F35dmwJj3W6/dkXl kFoh1NE5f2qJwuaiyt4syRFrpVwZ1Ahd/H0+YkXk7QJKfw/Mp7LDE5Xy2nyArFMfLu sBNRpFjTY3X4VKiJHwhnSdkNmhEGHjlPVUIJybJHl1+3hnzGbtJ7hc18PHeWC1rdHG 5Z+RxKTaT46KwRzi6uyfjuFiZF9FLj+lG7oicTeoYcLmLaPYwk6mdmEahTwOR1/AI+ NqoZ5WLI0iQfg== From: "Matthieu Baerts (NGI0)" Date: Fri, 26 Jul 2024 11:01:36 +0200 Subject: [PATCH mptcp-iproute v3 1/7] man: mptcp: document 'dev IFNAME' Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240726-mptcp-user-feedback-v3-1-c6ba1f5fa13e@kernel.org> References: <20240726-mptcp-user-feedback-v3-0-c6ba1f5fa13e@kernel.org> In-Reply-To: <20240726-mptcp-user-feedback-v3-0-c6ba1f5fa13e@kernel.org> To: MPTCP Upstream Cc: Mat Martineau , "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1143; i=matttbe@kernel.org; h=from:subject:message-id; bh=MyS+EwUW0YWnKz/PhHMEA8YFpC8AJpbZ+hVxc3AqPZ0=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBmo2X6vQZrC5rDhJER+KGaaJvabvBrk85vVyuDU qp0JYUrpE6JAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZqNl+gAKCRD2t4JPQmmg cxfrEADDIGQXJIDdJgXvwvfETaEArHn/hNR1uusC4y+7CiPLoR0n1xYWZCP9sH2URAQraLqG53z QFovd5s4ahWYQ6498O2b2Sw3uP7KsQg9L6JiNN1Z5FmiVd4Rvj4BFrQUbr09KCUU+0s74chKabk ybwJGU8zovpM8eq4unLUrwCWgpS//tprM3eDh9YXxXKt+6mmQQ63AbHAzz2U2hL6OxZhRMYQ/yW zAhCRTkVTJFMSDq4eSbcgBxZ5LgSiPtykp+0SmJ/RYmMVldlJKzTHu5Dbc3SG/Z8SFNW+Kp3OBB QL2enkEbtaIa9qRZGQcUwygWRF+sNwKY5FbtPYke5BEWI4wPFTFSA1l/XxDpZJZCeOTcXvg4EXz DHbbI1cqn9HKdJLADzwAsOqVe0gRUyy2N1r9zgttao2nzGRAN+FOChdFl+Hg7SWpVxasrmvBB8u 1QsAw0qWB0sjML24Sgdna9ExvFQTHDvvbITZXqR0whxIOA9FAo5UiJwWXe40cvsG8WQzpspy3IE j5sS/GdYnvOywX3CS4tjEueciOy1rdImMFsUruwm8dLVTvzX1Xlr8koyxs6bgp9sKBz5uzkzMbs k1CVjhpiL9BCo3rVYDYAZe1OVYExPtlNzMPZF5omA2QahTz+kxqVAM/Xsz9EWrVANAipYOGvSWW XLsEHtiz8qITh8g== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 It was missing, while it is a very important option. Indeed, without it, the kernel might not pick the right interface to send packets for additional subflows. Mention that in the man page. Signed-off-by: Matthieu Baerts (NGI0) --- man/man8/ip-mptcp.8 | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/man/man8/ip-mptcp.8 b/man/man8/ip-mptcp.8 index 6c708957..89fcb64f 100644 --- a/man/man8/ip-mptcp.8 +++ b/man/man8/ip-mptcp.8 @@ -135,6 +135,14 @@ established MPTCP sockets will be accepted on the spec= ified port, regardless the original listener port accepting the first MPTCP subflow and/or this peer being actually on the client side. =20 +.TP +.IR IFNAME +is the network interface name attached to the endpoint. It is important to +specify this device name linked to the address to make sure the system kno= ws how +to route packets from the specified IP address to the correct network inte= rface. +Without this, it might be required to add IP rules and routes to have the +expected behavior. + .TP .IR ID is a unique numeric identifier for the given endpoint --=20 2.45.2 From nobody Mon Sep 16 19:16:48 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72B3E1F951 for ; Fri, 26 Jul 2024 09:01:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721984510; cv=none; b=iuMuZS+S5/Tvy8cWNTe84DazHsPWQcw135KG2Xox3qvCda1VzZHxsw9wDaCtfmXvvGwEWQFpOGMgszhZR3NSA4GPfPtNZ1zXKGPDpQzvFTbJIXLb4ttu3JeqSYsjzJuaLIiB+dvjkc2XufCGm1pBaZMgtcWBPzbtaxIOnB2eU+I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721984510; c=relaxed/simple; bh=apSMkqX6PlYgHFRluqpDHKw+wbmfYFw9YsE5MBU44Eo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZMHrzzxiZskMV4Onr6FOspDN56fdfeFq9tZkwne9Pvf+Y9PzGnSHoC+52z83NFFLeYSaX138Luams3bTatCR7p/uxBbnzCD7CPREPelLkLYgKM+2CJR6U0nEjCkUdmtLFcb/KA4Az6+f+kLBWbWAadTVXflk7LNAuZ9BZC6Mwg4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NSAdlEzH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NSAdlEzH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5213EC4AF09; Fri, 26 Jul 2024 09:01:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721984510; bh=apSMkqX6PlYgHFRluqpDHKw+wbmfYFw9YsE5MBU44Eo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=NSAdlEzHjjdvDLPGWihE1VVcc0e+kgBwoYGS0FIA9v4WkdjJwG10k05lUzgqOatl0 7VmemXu7LkYYEsuhQMg56zUMypsNGLlefr5KGBqAjH0urbD6MimdFKXVgba/rs2TjL vECwP6j3vAltKOa9X37h9HJorlO9IGf2FohFvoUOyo+RQVIEecpEQf32DnyqUEORq/ LCgzLSuhsOE7SRYU+esENRjRk6XuV9Dji4Bxb84yaxQ0hbfdieDYwTx4hd8sPNueO3 Miu4E2FXP53s/H9R6zMlAE7raglO3Iaov1vaDMHTCmGATVu99qMj5c+iP8OQpqQZeA iITfhmjlzCvRA== From: "Matthieu Baerts (NGI0)" Date: Fri, 26 Jul 2024 11:01:37 +0200 Subject: [PATCH mptcp-iproute v3 2/7] man: mptcp: clarify 'signal' and 'subflow' flags Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240726-mptcp-user-feedback-v3-2-c6ba1f5fa13e@kernel.org> References: <20240726-mptcp-user-feedback-v3-0-c6ba1f5fa13e@kernel.org> In-Reply-To: <20240726-mptcp-user-feedback-v3-0-c6ba1f5fa13e@kernel.org> To: MPTCP Upstream Cc: Mat Martineau , "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1487; i=matttbe@kernel.org; h=from:subject:message-id; bh=apSMkqX6PlYgHFRluqpDHKw+wbmfYFw9YsE5MBU44Eo=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBmo2X6tVIDsMDfkiB1zy5JfigiSsG96Hxd9spyF C9zDA4SoeWJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZqNl+gAKCRD2t4JPQmmg c6HsD/40cUJOvk4dtaflevUzYF4K5GNEer/GjUCMEwYulxck6FPy+K2lHUbGYUao0QA3OL9DRzY 7iPuViNxzCB099yQKbblvp4uBYRhn3qo0UPkOgMMYAt6TcwfxpgC9yjEd4uS8nnb9uTP2Fb8HqR GaY1XWaJogzQxDlIdr6ktyT4LwGU39y4aKD1Iztg8UccyblaL79p0uFaHJmWAHRbMuPY/tJMg/3 z7qy6+SZUz3RSZgpfilJ80wLMuOrAlmXFtvJUEg9IU6zBiEddb6rnQfA0YbN5Zuk/C+kF4jNc0a c0Ayf40WHCfCnvIiNhNpogi/mDh9lazkqLQBi8Zsizre46Y8z4LQgHB7j3W1gLAGMlbgkCFgtVL XTJyy7SFGi0e3fvffbp2aidBWjalIgLtyEaZ5F4NeOT3in9twXGr5d5LjnwEcFg3CAxVZ09zUrG uiBizeNaDdf1UrY/3bnycIShCTzyFINPZhbKip/lMECyuIch+XV+MpYetgND/xJWmKFTZWlq6Rz DjuCB6qFhQaH82TMW1iK5LN16S/l3GDB7NXQmudNw/ZiBIPQn68lzx5RiwrSqCXoDwIeDywTwAS xrOYII/z+WM+2VbTmTTZjrOyv0F41Dcc9e+u8vtKuwB4TyJiMUCCRaesIPgRGyDDwrImbttSaY6 2b3T+Wpd1H5WIeQ== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 According to some bug reports on the MPTCP project, these options might be a bit confusing for some. Mentioning that the 'signal' flag is typically for a server, and the 'subflow' one is typically for a client should help the user knowing in which context which flag should be picked. Signed-off-by: Matthieu Baerts (NGI0) --- man/man8/ip-mptcp.8 | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/man/man8/ip-mptcp.8 b/man/man8/ip-mptcp.8 index 89fcb64f..2b693564 100644 --- a/man/man8/ip-mptcp.8 +++ b/man/man8/ip-mptcp.8 @@ -150,7 +150,8 @@ is a unique numeric identifier for the given endpoint .TP .BR signal The endpoint will be announced/signaled to each peer via an MPTCP ADD_ADDR -sub-option. Upon reception of an ADD_ADDR sub-option, the peer can try to +sub-option. Typically, a server would be responsible for this. Upon recept= ion of +an ADD_ADDR sub-option, the other peer, typically the client side, can try= to create additional subflows, see .BR ADD_ADDR_ACCEPTED_NR. =20 @@ -158,7 +159,8 @@ create additional subflows, see .BR subflow If additional subflow creation is allowed by the MPTCP limits, the MPTCP path manager will try to create an additional subflow using this endpoint -as the source address after the MPTCP connection is established. +as the source address after the MPTCP connection is established. A client = would +typically do this. =20 .TP .BR backup --=20 2.45.2 From nobody Mon Sep 16 19:16:48 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E91C1F951 for ; Fri, 26 Jul 2024 09:01:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721984511; cv=none; b=IrFFLtyG9boTWYqqOa1O+d/jbac8c/D/WQ3Xp0/w2BugERLucj0Xa81d7L7UBryb80n2MA5r4d3cU0+hi/5zVMgf6VZubt3r0WDhGUAYJXijzl8mNWnWX0yJn2vOeXrTbzcyZu4JwMwq8F9prldOx7/iTc1fPpHHzv15msJBNJ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721984511; c=relaxed/simple; bh=6LK+vWpXvXMPJCfqIGEmLGG1ZGT7sOEi4Qt/ngfpWWo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Yay3zMH1X5nE+m1x8pZXhP6tMcOdEVBzV0fr+SD/FQCXTJGNT0AjCVo+lBG/o0Iiy03j4PW5YN1iB2oZIRqIgevNmgPjoLjf4nV/GHjJNoT6dZ7jSRwW2mPrtHPxkx+XiA8v2c28UjuDELY4gIDbsCNWf0W+7CHIkopGOEJWA/w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iZ6hMPOi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iZ6hMPOi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83C83C4AF0A; Fri, 26 Jul 2024 09:01:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721984511; bh=6LK+vWpXvXMPJCfqIGEmLGG1ZGT7sOEi4Qt/ngfpWWo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=iZ6hMPOig2uaRdcJ9E+UIL4VuKzCpUXXbd6L3XocHTqJMxUBUNBzrhC5f4aa0Stqf rf0ImqueVzkoXmNX8+Pz5qy/QdQ9f/jP0AMWLCx384gYKIj0VYTAnV7imPJ5v4Wnf+ AcqEklgwV2Qkr/Mb8NEIjGhWRUnG1b8Ufy/xgHk3hHD7hzCoBzn05ZQmkGZ3+NcVvz uOzw0jgaPrsokoI162aaTaWlZLFf8yRBuexQWjosCvMfTndArIuYanq1rxZJ9VYR/S dDW+MnZ9WeyzQFzHNgCRwldhj+2hSDSF5TuhMxDuZVbJCvYdoErv9jynXglJqOfIHC yTIbhnBdM9CnQ== From: "Matthieu Baerts (NGI0)" Date: Fri, 26 Jul 2024 11:01:38 +0200 Subject: [PATCH mptcp-iproute v3 3/7] man: mptcp: 'port' has to be used with 'signal' Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240726-mptcp-user-feedback-v3-3-c6ba1f5fa13e@kernel.org> References: <20240726-mptcp-user-feedback-v3-0-c6ba1f5fa13e@kernel.org> In-Reply-To: <20240726-mptcp-user-feedback-v3-0-c6ba1f5fa13e@kernel.org> To: MPTCP Upstream Cc: Mat Martineau , "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=937; i=matttbe@kernel.org; h=from:subject:message-id; bh=6LK+vWpXvXMPJCfqIGEmLGG1ZGT7sOEi4Qt/ngfpWWo=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBmo2X6hb7hBf5BqDFgUROYi1IL6cGU5DGXYdia/ 9qUn4gHxnWJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZqNl+gAKCRD2t4JPQmmg cxS7D/41E8wKKmWb7zXxwri3Z1+UK73kNLt1wSimDCBHJagw23RKMZcjvL4ZJ45dBWj8p7GuVt3 V7OkMY1vSb3He4bCv5hbH+AelbbaYPXJ8RhWd/QvC+zfqys/E3pybarrBkc8TxxfluDpz/2+olg sixHAOgVP4dsQLnWfomjyzBXJb8+rilOfOrYa6/cQukmEGRORXFkHv5sTtI/WkxQrUk3BJQrXT+ nz6yriUmABnJVMXgRD/oKVbw7oQiSQGaRkamBAsXZVP26zTBCMg3/Ra/sHwO21sIPV/T3htksCD 4Ysc/bkTkHDuxxGFN1sKJ6h8twSgOV8o79XVvNQYM68WCpZYVVl1P7P9fVOYubvGxpMPmlyDQsh YjN1bdevqfoPPlj9lKvvfwajIpDHNW/7SG9xSaBsDH5PxupFMifZa7VJne3qY3ErSov4JYkwvrm m4dyDxvxgr51oJguEgkIbcB4pCD6QZUVEjjZqzaMtEkI5K9fU771SFdmTlKoGSDAEehrgRAUpHn 0Prt+o3LIW90CgkQ6ApETvCjHwUWKdOt9ZMIbt5RN14kjQL5xB1Is7VH7l9YJUBtNWTEEJcpgHA vYPNkZQVrwEqnX95vvL/GYe4DqD1BboK5dVnafc8A1XN2Qzusmg1KqfnLBCPkgtQAZOyM1uEdDp 3TDeJqWgow3XZ7g== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 That's what is enforced by the kernel: the 'port' is used to create a new listening socket on that port, not to create a new subflow from/to that port. It then requires the 'signal' flag. Signed-off-by: Matthieu Baerts (NGI0) --- man/man8/ip-mptcp.8 | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/man/man8/ip-mptcp.8 b/man/man8/ip-mptcp.8 index 2b693564..11df43ce 100644 --- a/man/man8/ip-mptcp.8 +++ b/man/man8/ip-mptcp.8 @@ -133,7 +133,10 @@ is 0. When a port number is specified, incoming MPTCP subflows for already established MPTCP sockets will be accepted on the specified port, regardle= ss the original listener port accepting the first MPTCP subflow and/or -this peer being actually on the client side. +this peer being actually on the client side. This option has to be used in +combination with the +.BR signal +flag. =20 .TP .IR IFNAME --=20 2.45.2 From nobody Mon Sep 16 19:16:48 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A9F61F951 for ; Fri, 26 Jul 2024 09:01:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721984513; cv=none; b=CC9F50ajh+fikSHPZKblOchdA0Jq4XyI2D9UU0KIeFBpJTKqsz9ja8khcKo4lbWGHvw2ynXSjqGGQf1xxtQVd4eH32mQ0hJPF+LSoZTAJqh1LEycoKg013cX5xfCPq0vC2/ZGmndbDCpLnjXfX7IM0aNKhXZ1X2Td1E14uAP0E8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721984513; c=relaxed/simple; bh=g+6jj3ecIUY7f4kZO95pei5W83/MT0hJxTpUSoOGufI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qO2k3UnWrMti1T5OgPltTcJASghxDOkt2vevVTAv8t1FBhnXmc+GbWJE4ZMYrvcRpu2b2Mi/1fD8I0yg3Bsd+bRXnJ7FCYdJ8+hrX8yxqlMUKYBALAcVAAjcXyzyrcJ+/Etu8i1GoxWKEoPSUeH3M+hz76DVUN2O4y/QhaJtZQ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kw6vZYwl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kw6vZYwl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C08B2C4AF0B; Fri, 26 Jul 2024 09:01:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721984512; bh=g+6jj3ecIUY7f4kZO95pei5W83/MT0hJxTpUSoOGufI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=kw6vZYwl6UiKyfz6RwNNN3tlyKQMz0DUoho5GU8i1xpffLm3tnjEtDVXNJAjToAVo Q+yOcTBZ/1OO3ZMSg2+g6FGnUs9aqvTeOdB2w212Cs+BlzHsykNTSmNEUcNW/QNtXL txnN62Y0axIeXEX2B2HfROMYkdsmYal6ygEK34tlGY1REn48kofnp+tVy745mC8R3B xtdoaOjBGTYm58lQKZJkmpNJMdzGrQxU3+hKN3LHpyn8/VjblAG3PX3Dgd588MNUzg ZhWo78Q605ZcRgx4oj/7MSpTlpgcciyYGeTn3AnRHUqeNIPdWkfnPUupyRJJhlC09f 50DX2dvx1vuWg== From: "Matthieu Baerts (NGI0)" Date: Fri, 26 Jul 2024 11:01:39 +0200 Subject: [PATCH mptcp-iproute v3 4/7] man: mptcp: 'backup' flag also affects outgoing data Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240726-mptcp-user-feedback-v3-4-c6ba1f5fa13e@kernel.org> References: <20240726-mptcp-user-feedback-v3-0-c6ba1f5fa13e@kernel.org> In-Reply-To: <20240726-mptcp-user-feedback-v3-0-c6ba1f5fa13e@kernel.org> To: MPTCP Upstream Cc: Mat Martineau , "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1498; i=matttbe@kernel.org; h=from:subject:message-id; bh=g+6jj3ecIUY7f4kZO95pei5W83/MT0hJxTpUSoOGufI=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBmo2X6qPy08wALt4tb5el07tjAQyAedAAQy5yC/ 1KMv6srxZSJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZqNl+gAKCRD2t4JPQmmg c2qPEADqVNJMvGbtvKSblRiR9qat1IS8Ng3agCfRiecB/CxzZ6NwY8k5dP7iYL6w/LDWf2Q77cb 0k0CSBDQRchavvUtdWEeOl5QUkWAyaEs2e0HMrQDPzLrsrX8fpHcciueBrB4ZfWXhAi5Q0l+30t ueTx8KnZ/vlbZ7pgU/tmmHJDwOzIjcvmlBoiWVQT3DgBbW2Sow3JIKE6pIpLCK34XaQ0cF0Q1Fp ikw4211W03dI9YoGis2ia5eRJ47nqFkkMdpoAhC2d4I2WmvSNJVQeNO+docFyG88X/i7YZJ8aDk 7pihsPGTko/L/LCKpBUsMd9tsE2TjU6LEbylDteKKG1Effl6wYb4Nn/dGZfmeLNQHNZ4McYiE4w kBy7aM3j27X02vFZyE/MFm9/6G25BsGZQpNAseTV5TzG5nA+If59M6XuUZ9d7uugJrY3Ur2OsdS d3Z+7G2XZuAtxQ3n6eySTNnHHGuX80rsp5f/F0SUH6eOdaF8y8dUURNOi3Hi5QrD8J7GQ5K8Thq KSSdNf0Bjyq5Z443aRl8cj4htHhRA0NfzC7uSMOr9zho3qjA02LGL4RKWKGJwKJQm8lCNVzE2M1 pY8E4E/Ziw9E+29FA4eqR9Cg349w6D+/9+x2rr2F9cY+wTqFB3tDKY0X/IpoqYCpXY4+HjsQPOH +nHxo5350GXQsFA== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 That's the behaviour with the default packet scheduler. In some early design, the default scheduler was supposed to take into account only the received backup flags, but it ended up not being the case, and setting the flag would also affect outgoing data. Suggested-by: Mat Martineau Signed-off-by: Matthieu Baerts (NGI0) --- Notes: - v2: Reword (Mat) --- man/man8/ip-mptcp.8 | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/man/man8/ip-mptcp.8 b/man/man8/ip-mptcp.8 index 11df43ce..f3d09bab 100644 --- a/man/man8/ip-mptcp.8 +++ b/man/man8/ip-mptcp.8 @@ -170,10 +170,12 @@ typically do this. If this is a .BR subflow endpoint, the subflows created using this endpoint will have the backup -flag set during the connection process. This flag instructs the peer to -only send data on a given subflow when all non-backup subflows are -unavailable. This does not affect outgoing data, where subflow priority -is determined by the backup/non-backup flag received from the peer +flag set during the connection process. This flag instructs the remote +peer to only send data on a given subflow when all non-backup subflows +are unavailable. When using the default packet scheduler with a 'backup' +endpoint, outgoing data from the local peer is also affected: packets +will only be sent from this endpoint when all non-backup subflows are +unavailable. =20 .TP .BR fullmesh --=20 2.45.2 From nobody Mon Sep 16 19:16:48 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47EEE1F951 for ; Fri, 26 Jul 2024 09:01:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721984514; cv=none; b=gNhJaO0QbMNut/qk0T0vTF3vwMYeGC3TAM3h+w46ldRohuLvm9PYMqQyyw7ROfvJNjTlGaumJtTef4KwgSHLZXd2HooFg3ltb0VPRXqjKogcTBxNpMaDvFmYSHvnZiHvp3Y4EatK5dBIExH6BL0GQ7Y4ofp1jIKxikVsFDATlLc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721984514; c=relaxed/simple; bh=LjtnQPANnSg5t2n6XNeq9rMALo2ilBott2YSuABt+Oo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QUddz7TEq3J9IrrH6+lxKOcN4xZamq8Z1dM5khaOIPO24tCh4mjX6Kq9KL71rzU2sTkvVo4dF+5b/iYXOqaWNOzSJ4XTKatbjQPyToOueT3CGXuZKtltAlGcEabCIDE8tv3MIE3yr5I2+jxiP6qSMHRckUiC2xcF2GyaVSrM1PI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LaIjKCJJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LaIjKCJJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1FC07C4AF09; Fri, 26 Jul 2024 09:01:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721984513; bh=LjtnQPANnSg5t2n6XNeq9rMALo2ilBott2YSuABt+Oo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=LaIjKCJJW40UYAi7BoLUU9pRk2wcLdzCFwscnEYd2GVEn7ht4RTN6oeSDWc0Bfrbd sMUXtr0Qw/0h4UnSg5tCP2rwTB4WB5bsGNCu/h8weLUmhj14SIkS49hXbZxOlOD3tT 1CL/z4JzMYrB7aj1VeW43llusrRwVm0mJbVbs8pO/4zb+2WjsAc4TWDLfPR0pr6IxP Tq+MeDCkTdSvIBrL77M/tYhiDHta9cyPfMSDUhNDF1HvYJWZe9p4SF+l9NT0R6EQKr GYTaDNQMxpoRt4II2r3vqwRTP1aXGm5Af/dK1UXXoNrMa1Ld1HjjvkFGoNJ9F8hAn4 N1ZJI32nLA5zA== From: "Matthieu Baerts (NGI0)" Date: Fri, 26 Jul 2024 11:01:40 +0200 Subject: [PATCH mptcp-iproute v3 5/7] man: mptcp: 'fullmesh' has to be used with 'subflow' Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240726-mptcp-user-feedback-v3-5-c6ba1f5fa13e@kernel.org> References: <20240726-mptcp-user-feedback-v3-0-c6ba1f5fa13e@kernel.org> In-Reply-To: <20240726-mptcp-user-feedback-v3-0-c6ba1f5fa13e@kernel.org> To: MPTCP Upstream Cc: Mat Martineau , "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=932; i=matttbe@kernel.org; h=from:subject:message-id; bh=LjtnQPANnSg5t2n6XNeq9rMALo2ilBott2YSuABt+Oo=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBmo2X6X7MHo46kcjM7K0bbrGrZsVP11QsPd5Lir qaIBlX4F1eJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZqNl+gAKCRD2t4JPQmmg c/t6D/9dA7B/HObygMZaaYqr3Z0YFdxO207ojrNcMCijerRFo0Eglus59j3PkX4TpZAaLKvYsWf tsXz7MCVQpikSrH+n98HcTzQc9XuKE5FkLWsJ1Y+FI2yo0QVJt2b3ayEFefz1JBgYHI8Ra7gQXi IH5z6g0dS7ijt6Y7grcCXu02H1TnCxKe+sRyfGdpfJmtNL212OxTzphIY5hpYNWycKsaAmEgAjj Mi5ZZ+NEDYTmiC6iZz+bWVUPTg5gks9Kc17Jmm3mrK4zp61KX7fHkBAF8XbqT2CDeL2f/Sd0egu aX0GRoyakX2jmlTvoA+Ww8rS5ND9g9FQc3dIyv1/MuvD8qLgDhkTDDf6hlogo+EmDsl+vft9Hcg rlwyrJ3BWCw6jmAIvDT3bNzRgiXKbShX05SZbGaspo85A5tomw5naiote9+gXUB8zrSfq8hEJ2j pnSLO41E0v5zwIlYZHkmpB4Y9gaOLpXIws1NO9yD0ShGIkSrbc8bF+oVS/qq+LJwRlUkfbK9JAQ Dc0UFBgM2WcXDq3sxILixbhLQtC9NOGy6ReROjdWmTRA7xlYmVlQUwTcSRvckNM7RvzP8/bqXYt 1V9uNi65N3hMlXhAMu5ILzu5WNcq+lne7fA4BxO4wLIzIxt61sSKtXIaqV4thqOlLFESho7YITB 762NKhTPbyImoFA== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 'fullmesh' affects the subflow creation, it has to be used with the 'subflow' flag. That's what is enforced on the kernel side. Signed-off-by: Matthieu Baerts (NGI0) --- man/man8/ip-mptcp.8 | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/man/man8/ip-mptcp.8 b/man/man8/ip-mptcp.8 index f3d09bab..4c1161fe 100644 --- a/man/man8/ip-mptcp.8 +++ b/man/man8/ip-mptcp.8 @@ -190,7 +190,14 @@ this will behave the same as a plain .BR subflow endpoint. When the peer does announce addresses, each received ADD_ADDR sub-option will trigger creation of an additional subflow to generate a -full mesh topology. +full mesh topology. This +.BR fullmesh +flag should always be used in combination with the +.BR subflow +one to be useful, except for the address used by the initial subflow, +where +.BR subflow +is then optional. =20 .TP .BR implicit --=20 2.45.2 From nobody Mon Sep 16 19:16:48 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CFD91F951 for ; Fri, 26 Jul 2024 09:01:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721984515; cv=none; b=gojriJJDFuQi4/C5F02QOe4/O863CN2YkVrnBXoPOR/hDSmt3Cv0KyCwAttz6z60dk1Lku4ChSIPB5BsZESYWAEWA+GRSiDPqllnMDMGQMgVPR2J9T27IRHTZ7IR/nboIYI0UrRl7XDuQ9LRX0Hfzcb0i97rK2dqF9Z8xlMQ3Yo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721984515; c=relaxed/simple; bh=yEPcMmCeaqg3o1UyMTKaVpLPYrPv+RpiuhU93uIWic0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ovxxxoLTwlDzSbgF9O8GSAIc9xpxxfs+yDeZp6vnSM/mvwz5US2Zz3xqRe8GQjWa+CP864XU1BDIaS2xHCH+CIjVAjQppQTowd/PGeqFf42panJu7/ZhDLnFT16QU35YuxkwpO4p9JBc5Y9kaDmBzWBBgbi5nuH9Lx+IB1OyrT4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CqOqjDIi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CqOqjDIi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 657B9C4AF0A; Fri, 26 Jul 2024 09:01:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721984515; bh=yEPcMmCeaqg3o1UyMTKaVpLPYrPv+RpiuhU93uIWic0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=CqOqjDIi1vPEW5ojN/+2Um12O1J9ckicE9j2rwHYEmjBFMK6qv2Ehw+bhdAP9sv8U 7VvPYTzsM8kaUgrHnzVGlbUZH+UsUPUjpeJQ24g2/Omxc6hSug8NtzijUpqWmpFgDg IaWReMg8BSjmLqMZBEKPmfLVEDe13vi2OiXWD2OUzQ5oYTri1S0vQ4yMcP9Pm10fqN rhcIZjRKOx7EHRq7oFGsnIy7fQCHfNGJaol20foMQ3Fr85J2pyZOhWVZLTp43FJnlg auqP/lFXTTLPhWqwrzfWlUnkR8MCaz2aROV5B2YVixoUfF5Y0zGQfHOWx5TJ9YGwXg /D843t8TOD3qw== From: "Matthieu Baerts (NGI0)" Date: Fri, 26 Jul 2024 11:01:41 +0200 Subject: [PATCH mptcp-iproute v3 6/7] man: mptcp: clarify the 'ID' parameter Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240726-mptcp-user-feedback-v3-6-c6ba1f5fa13e@kernel.org> References: <20240726-mptcp-user-feedback-v3-0-c6ba1f5fa13e@kernel.org> In-Reply-To: <20240726-mptcp-user-feedback-v3-0-c6ba1f5fa13e@kernel.org> To: MPTCP Upstream Cc: Mat Martineau , "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1058; i=matttbe@kernel.org; h=from:subject:message-id; bh=yEPcMmCeaqg3o1UyMTKaVpLPYrPv+RpiuhU93uIWic0=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBmo2X6nd+JDpzqmyWDJT2DioxQP2ObidjZ/KK2g 7f2v9ikpJuJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZqNl+gAKCRD2t4JPQmmg cx5bD/0aL669xJCiVKj9VjZiQesWA1/UZCwjMBuSUpVG6CmTP7Dzv5jPAE2Qrle2nV/K6j6Ajll +1zEPeotTIafoEs1kruIEhC0q7FYYl3LNggx5wXQrEMdk0Z5XyYXkQiL4jvYxORP1OPplWdSQ3o QHFF4R1wi1FWUclBNWK6QThDtu4rjpPFCoXKLPYJcczk2DJWrcfPQFmYAxSXItkc3wS2GvGxa5u 8FoSFTxrqf7ejrq8XYBKMk0QZfElo8lonbo561T8H9z2ocB6bdnBZwMr7AQPLGaiYvrLrbAgfMW jPPeH77VyootlZgh1gHsIJNSmdRf8crZ8fMAFtoPJMz/oHXyqrg84tZ33ZcfUOa7Y8UJaedHV68 Clgsz03xhLH8NVUQcaeQsC/t9WFhJ3/XYGFwsW+9S64igNr7moC3K3HEI7syadJ4hPi5mjwvXM4 Z+YouyDvCvS0II1DEpio5KYWtEAaFy993wdtpSSMnYRW5bW+D/6ygb12rfSSQMOXAsgKG/xHY3p RxpPZDnMZwrJjeuj2HpI757gZIXn+mQklIeLw5pdCCD89eLCpxIWWjAUPfDvGH6ku7jC+6TCc4e wUlcaGDzZUXi5hP0X0zjWCQtVBA1ioHUUCvUnr2KZi89u7pOfIEVueg/xQvcI6n9BSK1+NUMGFI DTw5tmwe41Zm6Nw== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 Explain the range (u8), and the special case for ID 0. The endpoints here are for all the connections, while the ID 0 is a special case per connection, depending on the source address used by the initial subflow. This ID 0 can then not be used for the global endpoints. Signed-off-by: Matthieu Baerts (NGI0) --- man/man8/ip-mptcp.8 | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/man/man8/ip-mptcp.8 b/man/man8/ip-mptcp.8 index 4c1161fe..e4a55f6c 100644 --- a/man/man8/ip-mptcp.8 +++ b/man/man8/ip-mptcp.8 @@ -148,7 +148,11 @@ expected behavior. =20 .TP .IR ID -is a unique numeric identifier for the given endpoint +is a unique numeric identifier, between 0 and 255, for the given endpoint.= It is +not possible to add endpoints with ID 0, because this special ID is reserv= ed for +the initial subflow. For rules linked to the initial subflow, the path-man= ager +will look at endpoints matching the same address, and port if set, ignorin= g the +ID. =20 .TP .BR signal --=20 2.45.2 From nobody Mon Sep 16 19:16:48 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 789EA1F951 for ; Fri, 26 Jul 2024 09:01:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721984516; cv=none; b=J/Tzv2uQu6FrTF4MqYK97KMvQpSB1VOpcT3WRB5y1N9aeCCEdhiYQuA736njFGke0lPsHhU3GHq9vk47M6RiihP5Rw6rdJLg78Y/iSFkXIKiJcrtts9ExNaqn9MwfT6SfIWJVhoH+xO97kxB/CsCEkdvGIA2a/rgiVCL7pyAy6I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721984516; c=relaxed/simple; bh=F4MAuB6QFQmzQhtbpngs/2R1rQblHEYfrO/wmuPILXg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EbSe4EkhfJE20b8Z5XP7zzOZi8GvYK9SJusfo9eqXonIfdJDJUADH3H5clnXs/kQRizQxL8a6dTxL4Lv+gQS3siuzVGEaWOTRe2u0RQVeBayPRa3lr408LJ6OrkOOGVAGUy3Ln5NJVq0gKoctGYzcHbFBIBgiXZCVxY0CnvlBsQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=e9mYEtYL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="e9mYEtYL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99D42C4AF09; Fri, 26 Jul 2024 09:01:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721984516; bh=F4MAuB6QFQmzQhtbpngs/2R1rQblHEYfrO/wmuPILXg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=e9mYEtYLl0VXURKtKLfsxoSOyRKPNkxlXeL2fo0TGOXNR8mpUGM9Gsbvt8mmKDM+g R3rD+ro/qvd29JIxQZK30aERkRYDqqHTKq81UGlTpnHW06JxKYJXm8bLIg6EAJorfp 2SWjkyf7sYVbcqGqeGpwdmOXD2WL6sVVwU4Ym56X6seR83K+AlA81dB1P0INfhkchU +206V7NBjI0GiUhE8ORQWQKtV9d6vw6SjQGZEuAiDB2nyQiHGfQ5jO9KG889z985E6 chEdi7XTquzd5rdmv3aiPjpjPUv5DMF5rGnWhAx/OdRLffRJ9W6i6rv6MH756/l+da kl951NsFRbuiA== From: "Matthieu Baerts (NGI0)" Date: Fri, 26 Jul 2024 11:01:42 +0200 Subject: [PATCH mptcp-iproute v3 7/7] ip: mptcp: 'id 0' is only for 'del' Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240726-mptcp-user-feedback-v3-7-c6ba1f5fa13e@kernel.org> References: <20240726-mptcp-user-feedback-v3-0-c6ba1f5fa13e@kernel.org> In-Reply-To: <20240726-mptcp-user-feedback-v3-0-c6ba1f5fa13e@kernel.org> To: MPTCP Upstream Cc: Mat Martineau , "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1022; i=matttbe@kernel.org; h=from:subject:message-id; bh=F4MAuB6QFQmzQhtbpngs/2R1rQblHEYfrO/wmuPILXg=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBmo2X6MqNgrGsLYQZq+Pmi9eCTj/prLNK8uT4QP S3NvdfMqHGJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZqNl+gAKCRD2t4JPQmmg cxVlEADlxEIlVGyO6r9tC7r+etJ3RYDhZddfnthpLC8HOT02Tym+qbNVSHIDwSziBt+DCA5JM63 8iEa9eizV5V6Z2PSUgiNnvpD/xtcdJcgrVpG1pPlJ3JnDPWE1EXBzzUW+WtduI4Xaj75TLxtolD zcR42vt4E+43gYAHRmlArHsnairnIVxF+z+kD68eJY9i5mLZAO0zCh0jolGqWzSRzwnYVGgO6uf FlxCmSZI6CWhAMksgf57U9PTcp9KTF+ApmN7BpG9qTqtKh7RHor/95861iAiCbb/gdRfRob/+fN j8ed2Y3w9CIBM+F0aPkAVJyjLib0OwrgEwPZrPhzqvAGfOjHJ/ACVtm6djkVOZFacZ2oACDSyFs phV8JO0rxlASXsE6Z6aliYmt/cGHg46jtMASz+vLohVKb+lbV+ucjbwCprtiRMqS34Z8oNT4OJu Lqt5vuZ0i02hoaET3pbUnXSVB9DOp9YlqcVggxlSHpsC/ICKJtiKYNKe2kye+2dKe3C3zbq/Zou 4POhxJJD4XSSebPSpulwNMRKC0HXycyISOwQ4blz4D3rF/e4q1rNEBTHS0UZJBDUkjOuuPqND40 PCjeQ9fw6CZd7pxFPH5lGQqRAmHho1rXliPYK7E+9vsOZ2q+jOUXOW4fdI14MBqYs4Bj005s9Jo cgBnvADraW8P8lw== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 Adding an endpoint with 'id 0' is not allowed. In this case, the kernel will ignore this 'id 0' and set another one. Similarly, because there are no endpoints with this 'id 0', changing an attribute for such endpoint will not be possible. To avoid some confusions, it sounds better to clearly report an error that the ID cannot be 0 in these cases. Signed-off-by: Matthieu Baerts (NGI0) --- ip/ipmptcp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ip/ipmptcp.c b/ip/ipmptcp.c index 9847f95b..118bac4a 100644 --- a/ip/ipmptcp.c +++ b/ip/ipmptcp.c @@ -174,6 +174,8 @@ static int mptcp_parse_opt(int argc, char **argv, struc= t nlmsghdr *n, int cmd) invarg("invalid for non-zero id address\n", "ADDRESS"); else if (!id && !addr_set) invarg("address is needed for deleting id 0 address\n", "ID"); + } else if (id_set && !deling && !id) { + invarg("cannot be 0\n", "ID"); } =20 if (adding && port && !(flags & MPTCP_PM_ADDR_FLAG_SIGNAL)) --=20 2.45.2