From nobody Mon Sep 16 19:14:30 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDBD113C3EE for ; Tue, 23 Jul 2024 16:31:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721752291; cv=none; b=H8k44qZn2eQmY8ZekqNDfAoCf/94SPvwjmJVzohmUJ0xWkWusI6+q7EnWMXaJEHn36K3A0kakcXxuspjs6WuGBFA1OsvQ0SjB7WWlj6tVdw4PWTovrxC59RjWQz68eRmOAfMftm9CNi4Ml2V6ygThZeuCybgoFxkSXxUZOBrtf8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721752291; c=relaxed/simple; bh=MyS+EwUW0YWnKz/PhHMEA8YFpC8AJpbZ+hVxc3AqPZ0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sG1d2FeYvXQkJ8w8x0iXuoUlHh/1/fpGx4zeDGWKtscZLGDU7BNE9c2h3WkBKwDWhgiUOH2sFimIS3aXiGSIaXOogGGfrfDk63MonO/5DNrF0ySyJE0cpDRB+V9NszSOirRKo0V2cBA8LpT4rvTeitjGtHytk2cq5UEeaPY8sMk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=e9aSqqFU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="e9aSqqFU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FB58C4AF0A; Tue, 23 Jul 2024 16:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721752291; bh=MyS+EwUW0YWnKz/PhHMEA8YFpC8AJpbZ+hVxc3AqPZ0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=e9aSqqFUHI17Y7YaKINDhpYkAofcO9aLS+Dedf/YqqSCDJZ3TKxYVisuY73SLpa7G aEzSdzRt0SAk1k5yGikU0iZ2Yhon0neCF8X0375RysQ48lUU7r4vb+k+DWZkLXQWmD nShTaQtvDYsnVSCB5w3lcHdnMymV7QBzWwX33D37q3BrH++I+sJ8t1Zj/IHdUbTA9h bJoP7xbkAvPlTv1koToVKCrM+Vnyz6t0Bate3Mtuf61NU86/7xJOIODnMYzSAXkqyN CKg8JSo1nc/kVZ+7OJNDTeHsm6e01nCLwSBslrRD4JBiSDh+Phst0KqGijYhj2B4fi 6+as/G7WwrodQ== From: "Matthieu Baerts (NGI0)" Date: Tue, 23 Jul 2024 18:31:04 +0200 Subject: [PATCH mptcp-iproute v2 1/7] man: mptcp: document 'dev IFNAME' Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240723-mptcp-user-feedback-v2-1-59f18975401c@kernel.org> References: <20240723-mptcp-user-feedback-v2-0-59f18975401c@kernel.org> In-Reply-To: <20240723-mptcp-user-feedback-v2-0-59f18975401c@kernel.org> To: MPTCP Upstream Cc: Mat Martineau , "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1143; i=matttbe@kernel.org; h=from:subject:message-id; bh=MyS+EwUW0YWnKz/PhHMEA8YFpC8AJpbZ+hVxc3AqPZ0=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBmn9rgAxKRbpRXotYAaZU0s+NBPm7GZvCk4UP5h zFb9teYI3eJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZp/a4AAKCRD2t4JPQmmg c85EEAC5E6YJMQwu6tDN5kmtRxZW9CFWdWi+t19JaQfW6xl95YR1aJe4PKy6XRr06styc388CLs YUrmw6zUdZhY0X6YEPoJjXbJmYyVN590fiEtOloAi70XNklhnFhBgjWUN3UygN69QmnJSoXBr1+ itXTwi+u+OGcS3No9b9XDcoAngrDUoJRrgj7QfsudwERqlUz75wENqbemmpED3jcBNG1acYfi1M hywDh8zEafuQ3uNWnnRjSKoC4RKY435Xt9IiyeGiTsM6pLueepzusM2HqAiFJsk42dU7lsgzuAi zXxeoGl4lSSeZokPNhnHBrMNlozB2dkWlsLby7jdafih7p75wgLzpaA1voY1Ml55rl4G3dyX9QN zd2Qw/WSUYyvmiAlV/aWpBg0V09b3+5VbdsoyZdrwARRBBilFOH9Ga8Njywd3gTnwgoZapIED4+ Vdu9NqqHJxSOtz8UKMCydSJZzSz0rOe2RfLbeQD9KFxWM6Kq9heh6pY01N1rugPgwC6NuKnDbLq jfO6iiJ+LA7CPU/ZA9P872amyuUwzTmIPgBPwIPuUtydEw4DszPFyZqsDduZvIvZIBDwMrmhLdH eQHkfLomy24JJEchwFNnGKm5cnGr6dMSUbLnTJ1yqGSqaDMA+GccpAXGG9ZtFRU+G2ClJpFGjxR lnwX+WPHtht+ytw== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 It was missing, while it is a very important option. Indeed, without it, the kernel might not pick the right interface to send packets for additional subflows. Mention that in the man page. Signed-off-by: Matthieu Baerts (NGI0) --- man/man8/ip-mptcp.8 | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/man/man8/ip-mptcp.8 b/man/man8/ip-mptcp.8 index 6c708957..89fcb64f 100644 --- a/man/man8/ip-mptcp.8 +++ b/man/man8/ip-mptcp.8 @@ -135,6 +135,14 @@ established MPTCP sockets will be accepted on the spec= ified port, regardless the original listener port accepting the first MPTCP subflow and/or this peer being actually on the client side. =20 +.TP +.IR IFNAME +is the network interface name attached to the endpoint. It is important to +specify this device name linked to the address to make sure the system kno= ws how +to route packets from the specified IP address to the correct network inte= rface. +Without this, it might be required to add IP rules and routes to have the +expected behavior. + .TP .IR ID is a unique numeric identifier for the given endpoint --=20 2.45.2 From nobody Mon Sep 16 19:14:30 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2BF213C3EE for ; Tue, 23 Jul 2024 16:31:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721752293; cv=none; b=ppB/lcmdjkCcc4G8AMIM3B//UF7xokMYt8o6wGaRGXfJDszpG0cxYQ0SDO3YGGOXZ/d9SE/xK+niNK6HMNQP1nzOgT8kj9VtPz1eyQy7H8UwIsEPiRuMfsiNHbmIyA1Qq1B2LBvq/jqwu9s3knN8ECFMovxmEAruvMbvRNo1FEs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721752293; c=relaxed/simple; bh=apSMkqX6PlYgHFRluqpDHKw+wbmfYFw9YsE5MBU44Eo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TbQNlxfTUrhk/ArnVTrcTpdveNK/YaYYQUuoNF4hr+JtDIffIxEFF7WTqR6ea1e6I8C7HfMrIuM3WDIlfzkt3Qak+tGnMO7Yrt5MfRQFf7vVUnV/bpCejlH5ZAXLCS74PhDCifx7LxCoJfiw14iP20mLC4yZWoKzjWx3TQpM7Yc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NoQEIaxM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NoQEIaxM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC24CC4AF0C; Tue, 23 Jul 2024 16:31:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721752292; bh=apSMkqX6PlYgHFRluqpDHKw+wbmfYFw9YsE5MBU44Eo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=NoQEIaxMFp+yGimkoVAUrsrkJTNRGz7X0K09wsE1JMilqvM1Y2hRXarSorCfQYw2n 1OzPjXPrWZknVYKbEaWa10HFw1qfR4yZlKjlDjRT9Xz8y4/UJYdSP+QLK7yQMsG2ic EXktzxjCKGRQrpIXPmIZsg2MZNuYHNjOgib3hTtcqPFTUchkJEApVPFM1ajWScLtxE jjNaJLlAHCH3Q/jF3b8tCaLLessN21rOmACOSfIrj9kSxa+NMf/FhkYMbFEhx02Rej F0hf2pLcw5JTZ5o4YMtzZCq6QQd7Fkc1P0NftB1FJEPNJdzdnKitAeVDpV9hcO8V75 IyqkNjvYs6eBw== From: "Matthieu Baerts (NGI0)" Date: Tue, 23 Jul 2024 18:31:05 +0200 Subject: [PATCH mptcp-iproute v2 2/7] man: mptcp: clarify 'signal' and 'subflow' flags Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240723-mptcp-user-feedback-v2-2-59f18975401c@kernel.org> References: <20240723-mptcp-user-feedback-v2-0-59f18975401c@kernel.org> In-Reply-To: <20240723-mptcp-user-feedback-v2-0-59f18975401c@kernel.org> To: MPTCP Upstream Cc: Mat Martineau , "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1487; i=matttbe@kernel.org; h=from:subject:message-id; bh=apSMkqX6PlYgHFRluqpDHKw+wbmfYFw9YsE5MBU44Eo=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBmn9rgPSmd58lubH2NJlC/RoJk5x3Ct660v7/GB yqAFpH/CkqJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZp/a4AAKCRD2t4JPQmmg c0XfD/9vW4yPAMkYxNCs6dH4FOcPjavXVXdNyFW8EddKi8NkOxU++bCYP7JPNbqXcJ1N5SjBGep wzMuN2We60R+dNEjmDS9N7e3qen70MSa8dAu87UJmmPsnDW/NiEOdIUcZg0qxDT4gC+cl8o63kj IyUDq/lSPDcKd7ytAfM10AMsM5hdkVzLzmsUiAxhUXEGHQTeeeHkP62zlUHy02Wev/AodCKz0hj lAtvdY0oGjVA7H5VTFabBbCt/qJYDcuYFakKmtRJ738OWXEd6AU8VXyExd/D4j/xG8RwOwvVBx8 TRNMBDBoQoXep7Fo6IRsF9HvUgNVt4FG7UWxAI/sDp3HuyqdzuSSRLJoZgK06XSnOT7Bi41V4GJ U/V+V1javGJECLLcS87owPGP9frw1jex1AZch7E7W3XzPXR3n7o9faDXQB4hEx9JykeR1r/bRzJ Pa0jWZxz2BKaXtajsjjcgJwfKdTn2o92VbQsK1XXMWOy0ggBgTgFcDrE5V+fVfPRODZRqOs6j3R XZFBWSj69VHcPOTADVsqM7mLRHO0fLVacLpaDIu9IgDktWPKjn1ZTSZsq9Xx2vDWxD/5eSNKMVm O5wul/uzSmekJWJy4UoTQ8TaxP8tdK+PS2F0K7J0blCr0UPG21r1Wfom+bWR6H22VozfJTHmjxk pr4e9nLf0Q2T1Cg== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 According to some bug reports on the MPTCP project, these options might be a bit confusing for some. Mentioning that the 'signal' flag is typically for a server, and the 'subflow' one is typically for a client should help the user knowing in which context which flag should be picked. Signed-off-by: Matthieu Baerts (NGI0) --- man/man8/ip-mptcp.8 | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/man/man8/ip-mptcp.8 b/man/man8/ip-mptcp.8 index 89fcb64f..2b693564 100644 --- a/man/man8/ip-mptcp.8 +++ b/man/man8/ip-mptcp.8 @@ -150,7 +150,8 @@ is a unique numeric identifier for the given endpoint .TP .BR signal The endpoint will be announced/signaled to each peer via an MPTCP ADD_ADDR -sub-option. Upon reception of an ADD_ADDR sub-option, the peer can try to +sub-option. Typically, a server would be responsible for this. Upon recept= ion of +an ADD_ADDR sub-option, the other peer, typically the client side, can try= to create additional subflows, see .BR ADD_ADDR_ACCEPTED_NR. =20 @@ -158,7 +159,8 @@ create additional subflows, see .BR subflow If additional subflow creation is allowed by the MPTCP limits, the MPTCP path manager will try to create an additional subflow using this endpoint -as the source address after the MPTCP connection is established. +as the source address after the MPTCP connection is established. A client = would +typically do this. =20 .TP .BR backup --=20 2.45.2 From nobody Mon Sep 16 19:14:30 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3399113C3EE for ; Tue, 23 Jul 2024 16:31:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721752294; cv=none; b=OeHVS2EQj+5BV/4qDkxAS0VJFlXcljWIG4dBlnZ9HGtA/TZZi46rAyug0A7hcea4MUlJdQmbMkx5uKj+tCbnMq1gE/Ia7rkUdA/dEZGMDIXqCxMqq1vGsM/EVhg9/wUKqMvH3bVd/yuNlyBeFihCbymnCOPkfImP1I+4TgJeAig= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721752294; c=relaxed/simple; bh=6LK+vWpXvXMPJCfqIGEmLGG1ZGT7sOEi4Qt/ngfpWWo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=d+Xtbz/W2Id59TIDXB9EOJgB5nG3piGtz2rGv0+ZM+L+w9IKH0dsLEwHepGNlLumwAtHx8JBXvbvrbG67D3IXzH1LgRI1veAPTO/C1Yu9YSGtnUCBO5o2r9ZQrQS1rQkRRP1RXnMx1OEbd8tt6UUZ/+s8kPVDKP+XkrZq26b/4Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fju//gBd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fju//gBd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8541C4AF09; Tue, 23 Jul 2024 16:31:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721752293; bh=6LK+vWpXvXMPJCfqIGEmLGG1ZGT7sOEi4Qt/ngfpWWo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=fju//gBdNcQ4CS85yKUQrjA6TXSQpWsthPWIUDy0K25fZ12yNz+OtLD8oQZXwZbmw TE/3YZU1ZhrphdC+1piIyjQb8rRspvauscPQLfI/1UTv6FCT6v8V2OUBx4wH1aJhBD xQZCZDpUU3820HVxlo4NedJPWGlhsRPiCZmtBETkHtFkpVAAkQNDJLCVRVZGldNUxF GYZTRavL0ra6rO7tXxlkNU6HzI+4fc95bXUeRN/oWGQ9ZgoUAEn3M066sQjy4Tg928 5iLirt8H+NAojE6iZwvc4zNCyXhSgz7ED6s1cTIF1mTR86FOfhKQJiMaDadO9EEFQx mQuVHXAs1i38g== From: "Matthieu Baerts (NGI0)" Date: Tue, 23 Jul 2024 18:31:06 +0200 Subject: [PATCH mptcp-iproute v2 3/7] man: mptcp: 'port' has to be used with 'signal' Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240723-mptcp-user-feedback-v2-3-59f18975401c@kernel.org> References: <20240723-mptcp-user-feedback-v2-0-59f18975401c@kernel.org> In-Reply-To: <20240723-mptcp-user-feedback-v2-0-59f18975401c@kernel.org> To: MPTCP Upstream Cc: Mat Martineau , "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=937; i=matttbe@kernel.org; h=from:subject:message-id; bh=6LK+vWpXvXMPJCfqIGEmLGG1ZGT7sOEi4Qt/ngfpWWo=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBmn9rgWRpyy6J1akJmPU71gohplzbp/CGcQ8FcW gBnjpqIWK6JAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZp/a4AAKCRD2t4JPQmmg c+QrEACnTfJMv3vXCY1B0vrVY3P2fBpXPsFHoTEQNXDqA7GK6C5ArZy4IrtzRqWPwKadqyCTWXl KJEWCQwR+8e6fA9sfq9ULIjWJTbxL3X71sgbim9fkWOhtR6ABYC3Bfwhc9NeMreFkyWmRs1HbNN OnrPrGsS2QHWrcHC/5HjHfTBJdYVtDtB+hvqYNBlS7cq9b4YIYqtxmW8572M7K7tuIyt6cPIm6m 7O25zG5DLluea166DcBH/YovenfpHNXJJSpLW8fWEyrK4X7eDD6zWR5lsG83iQgsO4k44tmGLcq QZ0fqrMCgm0zs4Ab0xYn+XpAu+IcCD2G334TfBs1+fY6dS6GL1RmdFCSAnmd8qnfmpLhvzG3GyT R0yHOmJlAylmsrrZn87GUZU2XaIQW1CcWa6YOHuOC05GwV0qp9ZzGu+mKRxq+U44vqx+sNmbKKs 2mSP4VaMPQYFi2CRQIS2xv6A5v6dNRQQquIR2KIIawxRF+a2IheRmCTPaeaEpYeanM5dN/4NoP6 HzFAU51X9u11/A5iE7UF1vAsDSEbi0VFyrMFnMGQyblewf7w+6OT2T5qzQFhqPC7CHDxlP67cLu f0VGa2OZeJptThf0Z96RJuT3GRBvzIUJULHY5HfoFbjiQ7zuHuKtvlhO7PyMxNXkj3PjbhiAydk IVVX9yNvsKwsM1Q== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 That's what is enforced by the kernel: the 'port' is used to create a new listening socket on that port, not to create a new subflow from/to that port. It then requires the 'signal' flag. Signed-off-by: Matthieu Baerts (NGI0) --- man/man8/ip-mptcp.8 | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/man/man8/ip-mptcp.8 b/man/man8/ip-mptcp.8 index 2b693564..11df43ce 100644 --- a/man/man8/ip-mptcp.8 +++ b/man/man8/ip-mptcp.8 @@ -133,7 +133,10 @@ is 0. When a port number is specified, incoming MPTCP subflows for already established MPTCP sockets will be accepted on the specified port, regardle= ss the original listener port accepting the first MPTCP subflow and/or -this peer being actually on the client side. +this peer being actually on the client side. This option has to be used in +combination with the +.BR signal +flag. =20 .TP .IR IFNAME --=20 2.45.2 From nobody Mon Sep 16 19:14:30 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 583AC13C3EE for ; Tue, 23 Jul 2024 16:31:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721752295; cv=none; b=ddN+JdpRFbuvGpt4mHzGvdRbGQyMBPCD6f3Q/MHdC9UXrYtaCY/p0k1vZnUw7g5ZSIh4txIx1/d6A0+mPA5tcfOTmXO+Lci8gHGgw/jGxARiWBwiyUic2W0eHIB501XxghjsGYL8NNTlMQJOqpR+lifYqYJS6jks4InElr0DKJY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721752295; c=relaxed/simple; bh=FCNZhogJAqUc+dw4wheAd0YWaIlnlTPCs4r+lUGfi20=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=euT+ZL6cGvIAbd3RUsRrUnFGXQiyY54hav5acBd7oXY/gbDyn5MsD8BWT6orlnSjbm+Ca7LWqzQv2If8qdO0OZYAmR9TtMnqHxdS6WVkLa6EJ3xpghzgfXa0ZUPVqfun3X9vaIP7ZwxkRZRWpd1GcOL8NBYCCfG3G4jUiZ34Czs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KYdAlxvE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KYdAlxvE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20428C4AF0A; Tue, 23 Jul 2024 16:31:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721752294; bh=FCNZhogJAqUc+dw4wheAd0YWaIlnlTPCs4r+lUGfi20=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=KYdAlxvEx/ZgfQT+TdWd+cd21Uus+fR4UMqc1HhvLszbS22tYNH7AbGz6U8ujkXyx 8We/IbOWIiI8VIkctpvIcblQALHXI3Dx/9rIhLHRNeEGjPgJuehxxOLSh4CsjnHvkH 4kZA1q7BZYUhSBfNueaJHbyo9IEdWh6CaD+yGji/7+ctAgYTEjjR2mbzfnuLRHdnqv N2cLby6qVT4f/eugr3edn1wowgq5CR27JFcjxtYWENYI+FG5SpaC+nObrPOIYg64XS NdKqGbLeIYniZ1x/LnqfOTmos9zBHpWUq64XUjqfPo0+t03+o1GuZ2jUtEoL92fO5w hxLXHXDvImupQ== From: "Matthieu Baerts (NGI0)" Date: Tue, 23 Jul 2024 18:31:07 +0200 Subject: [PATCH mptcp-iproute v2 4/7] man: mptcp: 'backup' flag also affects outgoing data Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240723-mptcp-user-feedback-v2-4-59f18975401c@kernel.org> References: <20240723-mptcp-user-feedback-v2-0-59f18975401c@kernel.org> In-Reply-To: <20240723-mptcp-user-feedback-v2-0-59f18975401c@kernel.org> To: MPTCP Upstream Cc: Mat Martineau , "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1197; i=matttbe@kernel.org; h=from:subject:message-id; bh=FCNZhogJAqUc+dw4wheAd0YWaIlnlTPCs4r+lUGfi20=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBmn9rgOElzZrmLEgD3HNEsNUYUHcZR6m4c7lDI7 JRO3vq8wrmJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZp/a4AAKCRD2t4JPQmmg c3jIEADeKAdAn3jmgwDjjtuVhICEQMQvsN0xrBNrCKO1m3yqbhe98orlsxPpPw28zib033XJ/4J ywnFH4SDzVY0upMp8hpRSeJpujVuRRx505at0cBCGVG7QIljXrqas6EdLyWEPFvonjbOJARzfjZ q1w5Jlv8HRqWZTENfuWybENesSPMw/5GPlwOofQANYlNA+VjwL45fXYfXeyAmzaet1g49CMQrv8 YNWIf4sQxbVZk9YDxgWZlfbpXwxbuLtkpeD94JDckovzEvyHdfBv4KjQKOr/uPdxjqJGUYnc0El ao/OSFI8vgf/24qbQKsMcjODcUIXNGGkd7AM4HOUVgKwlU7Az1KkCmmkrTnzzZLjBIsEyPY1ksG mgYDpRc3BIiiYqvkY55XoXaDV/arNhpZtghxI9qwZNWamm3NM//loeABGvA9pHKVHAOZMjypqCx ho/0I2iiPOSH1zgiXXObm3yneW7TL79NHb+Gk5DZHKG3KsIWy9tOkG1u333wKVwabFonPCACjIa X0EpXSG+TpiEMPXZGilm90thYX/vRP81OMQGSWM2eplglt03hm9NoASbt/nxfQAKe7esbQSOQ48 KdgnzU2HoCulO4ijJsoQOR3b61JG7DnlHp7s1ED3vu0kx9uWKyjlqXpnTuWd4rqrmlh/lzhyQDe Iu9q1ujWzgq033w== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 That's the behaviour with the default packet scheduler. In some early design, the default scheduler was supposed to take into account only the received backup flags, but it ended up not being the case, and setting the flag would also affect outgoing data. Signed-off-by: Matthieu Baerts (NGI0) --- man/man8/ip-mptcp.8 | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/man/man8/ip-mptcp.8 b/man/man8/ip-mptcp.8 index 11df43ce..4d4c879b 100644 --- a/man/man8/ip-mptcp.8 +++ b/man/man8/ip-mptcp.8 @@ -172,8 +172,9 @@ If this is a endpoint, the subflows created using this endpoint will have the backup flag set during the connection process. This flag instructs the peer to only send data on a given subflow when all non-backup subflows are -unavailable. This does not affect outgoing data, where subflow priority -is determined by the backup/non-backup flag received from the peer +unavailable. This does also affect outgoing data when the default packets +scheduler is used. With it, the subflow priority is determined by the +backup/non-backup flag sent to or received from the peer. =20 .TP .BR fullmesh --=20 2.45.2 From nobody Mon Sep 16 19:14:30 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 278AD13C3EE for ; Tue, 23 Jul 2024 16:31:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721752296; cv=none; b=N/YOOduoELKs7C1S9KW2wae+dm+A8dObnokOOVpPYnD4rFm8oeDZvdF/ZZqOuIJmsTK5LueSqqKRYHT3tncclMDv1pTHJZpdDQp2fVikTeRuY8Y+UPhvXJAf8fVWYM4snE2BeeeLszxC07DLBE7CLZ5By8AnN07aasamWzA3RhM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721752296; c=relaxed/simple; bh=yShgghvWN+d0JwzuFGKRLCbjmKgCyWHurnO2662vpjY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PP3iObr1Y/yWqE96yZAyBVE/gnH8gcB2m7s98eTpbI0MxhashW3t8DEfQpapooC2D+RM8V3vHyeSQYabM8zWf1ai3SSxatUH9j2ollrrcpXfScN3RGCUBeLnNCXuXncputbeO9u3RaH7ZXoIs0qP24AthR3u5cSAz55gLg9kBcs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cjP39Pr0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cjP39Pr0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B9BAC4AF0E; Tue, 23 Jul 2024 16:31:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721752296; bh=yShgghvWN+d0JwzuFGKRLCbjmKgCyWHurnO2662vpjY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=cjP39Pr0xl8FME4ggV213hA8wWgMRTMz4WCrNpjxz97b/17FbC5p6RZDDdDz5kB6+ fiZbRk19DmraRqToEHeQaum7Rd4E0/cUi6U8I0UzhBQrXZvvpWq9rrZagmLc9cEyHk 7M+bbrf43iouuCW0hdHjKC6qYTH/S8duhw+m09ABlm+CUGgjVLrf61xPQBsks1AcIp gx2xDS9aaxk1c6qChX6tl6df/G8fMIQyNydYvpmA9F4KTXa0Y4SmQDmIzYmB7HH4RO hCPFieYDH592FayNhUGPGLksL9+OpuTtP7HB/uQV6+mpx+X1+9S7ti8TWEjL5rUBRa kxRBf1qTlq2bw== From: "Matthieu Baerts (NGI0)" Date: Tue, 23 Jul 2024 18:31:08 +0200 Subject: [PATCH mptcp-iproute v2 5/7] man: mptcp: 'fullmesh' has to be used with 'subflow' Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240723-mptcp-user-feedback-v2-5-59f18975401c@kernel.org> References: <20240723-mptcp-user-feedback-v2-0-59f18975401c@kernel.org> In-Reply-To: <20240723-mptcp-user-feedback-v2-0-59f18975401c@kernel.org> To: MPTCP Upstream Cc: Mat Martineau , "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=932; i=matttbe@kernel.org; h=from:subject:message-id; bh=yShgghvWN+d0JwzuFGKRLCbjmKgCyWHurnO2662vpjY=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBmn9rgNk3lXxHqYzvtUm/UvPSpmXd8BY7QUUrVq sy5F0bmwjiJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZp/a4AAKCRD2t4JPQmmg cxXcD/0RKNs3oN6PpNQL1IhbjimeTrUiYgrnzC6h9+hZn1URPF27vzd2hc/SaKEGlSDwpbGoUGH CsJx13ArBOluvOGVxATIfoJRNHqUqYCozB1Mdi833xP8PRlKKoF4FZ5OLeQv6H8kmgc3Qmy5god lINArq/4tLijxSaHUwM1akvIO3Tm5FoRs385+1OeDl7OvNvvYjnNxqpDwgfQIzqur9I9aBO9vKV UprJHRyH7h0PYczBrDd7VfZBsFUpCC49KJQLo+b1JOYQhMPMJG1C7xw2m5z2OlZ8wDd+UBNofI7 iE2lGqK9Sk7wvz04eDos00FghH5XEk2sGlbqds6oscBUmfngxyTK/YtLJj2LbvoQm42M1bUNIWt KA54R8HVo56mT4aQPM60n/OsA9Ya0OyXhWqscOtSyrqzvfy3Wt8QXfpOZrn79kMggo6rCIxDqPu X+WWc+CgbCe1g5lo62jmzIZUgXmZ4JYWTWZcYDQxSFzckqNiuatACurFA85VigwKNef0SEvqBdR VtyG2vg4nWIULJc5UpbZdV/eJvTNDZrcb2jVisbDoB3JWjTQG4K/E58lMkgDsL7kx63/Hl5TQmy nBASpFeCTmDDsIzDj4ilPIgUN+P81N8adt7n3FjT74d1FJzvAjVei65sKVT85TlTNOIVYhN+kCv QCAsoXUqpYp7R1w== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 'fullmesh' affects the subflow creation, it has to be used with the 'subflow' flag. That's what is enforced on the kernel side. Signed-off-by: Matthieu Baerts (NGI0) --- man/man8/ip-mptcp.8 | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/man/man8/ip-mptcp.8 b/man/man8/ip-mptcp.8 index 4d4c879b..7eeeeef2 100644 --- a/man/man8/ip-mptcp.8 +++ b/man/man8/ip-mptcp.8 @@ -189,7 +189,14 @@ this will behave the same as a plain .BR subflow endpoint. When the peer does announce addresses, each received ADD_ADDR sub-option will trigger creation of an additional subflow to generate a -full mesh topology. +full mesh topology. This +.BR fullmesh +flag should always be used in combination with the +.BR subflow +one to be useful, except for the address used by the initial subflow, +where +.BR subflow +is then optional. =20 .TP .BR implicit --=20 2.45.2 From nobody Mon Sep 16 19:14:30 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E49913C3EE for ; Tue, 23 Jul 2024 16:31:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721752297; cv=none; b=dzeExzkOqXDZepKsRLBnj4r/X9hL/JEObScozwrBYylL6gbBMTfScnM4nNIjrUCG/xNnGEGCJyUb5eHV77zBi57IV5FpHnnYpRcacBFppLPPz+J/YFFhXDwypxdRpV9yDIxY/TY/GFq/tUVoFahaqjHsGz9gIOW/qtZ1s8IcojE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721752297; c=relaxed/simple; bh=PplTJohmT5S2cPHnQWFnjnzrj4AGTAH5tTm9GIwqejA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GFPi7N3FdMMkLXN6bA/OetLXp10FnVxdmi9MgD0AxmJ9CIWyBaTwvqSy3L0q6PNXqk40qf7Xqa6QdKGzNpJeeYmN2JHiIRbRlGUAaJ5Usa3HOL4M2vLmnbLAdYZb9sGObaQCMC6x6w0vZmug1JM6bdH3BtTbJ7yokWgb+AIKNnc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hrNcJadc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hrNcJadc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77E3EC4AF09; Tue, 23 Jul 2024 16:31:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721752297; bh=PplTJohmT5S2cPHnQWFnjnzrj4AGTAH5tTm9GIwqejA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=hrNcJadcmAmRpO0eWTBZjOrOsUnayRY1Po/gtNKxTagfwM1le1xwQFViFcXU6ZZPl 7lnS5VCQRORbd+X/3ToVfthJzPTZpZSMPayzv9UoLjP/5L8PBoGu1/z2c3jZliNYwx y4Cn8OU3qEZ3W+C4wmtqK39isYPfChaZ0KsnTP6NwTDJ2+At2asM5glGdmcvVpGsXz PRRzPw2KLWU8kHvckWhdwFZRL+BASoR1TvYY1Rd4c3lTmRdnv1ZhkiWlaHfOqoUuBx GoCgOQ4k9t7FZ5UgF88sIC2nzqcsYd81dwnYNABP+0aSm2qWlvEcXnax/bPs3JcTzd dsemRjWTr/5YA== From: "Matthieu Baerts (NGI0)" Date: Tue, 23 Jul 2024 18:31:09 +0200 Subject: [PATCH mptcp-iproute v2 6/7] man: mptcp: clarify the 'ID' parameter Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240723-mptcp-user-feedback-v2-6-59f18975401c@kernel.org> References: <20240723-mptcp-user-feedback-v2-0-59f18975401c@kernel.org> In-Reply-To: <20240723-mptcp-user-feedback-v2-0-59f18975401c@kernel.org> To: MPTCP Upstream Cc: Mat Martineau , "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1058; i=matttbe@kernel.org; h=from:subject:message-id; bh=PplTJohmT5S2cPHnQWFnjnzrj4AGTAH5tTm9GIwqejA=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBmn9rg+mb1EHXAkeQlL3ckSF+TFWDxQJR2HpJ9D QPCQcgYebOJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZp/a4AAKCRD2t4JPQmmg c/TVD/44RmK8qgbOMcCiAgNbo/Hq4HqvlmFSjpBLHbqi0KI6SrJd/WCSpvdBmX519dRBpzsV6u5 wayLGssNT7hMJ5+xJm8SIsKDLirWPhfMnBHnh5+LvCnwsksrpaYZet4aZ/5tod2NeTHTMjxyiMC Gn87W3/ZmQlkG94YNvMlFxfoUhV19C06DlU9mDVx0UbgvRPsV5m2kFegK+twLV1ok/Fg0zgjBwW 4PghRJklPZw5DeCtACvYXEjt5Ixvjx6hkJxPop4D7CCb06ueSC5K7iPKv/0sw7hI43Dz80+uEvg nJoOOwUJ9AxObhIBl2ymQXDMvhgUcS7gyzkt9kZQmb9hzIvFZQ0fONHfl6c3YW2WJ88U8cWNg4q oJDMK5IttXvGizA3lVMstWCMjmAggbsVvW5TW+lpZWqX1OHpP7JeHX9x9D1fdMdAyFOoT+faSXo vAwclWawcYJBdtMfPMGSpVPW6ouOkGtzU+2GAGTb9Ir6+R9VttFbL8YPjQh1s7NzIPouKcUBiGt 1lcN9pZ0W0QIT2c0aDP8tSaP5Q+TqYIJ4ii/m5Bh2+07G5gnixHcIcG2hO3CEA8OenFxFTD+Xbq H2F/0COGCnd5JmPTwI0hObJbsaqaRtQqGjFnkBcZZyEnf31GB2aZ6Uoj4dts2xF4GyHLLRcnELy DdPdhh5q3GzbuJg== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 Explain the range (u8), and the special case for ID 0. The endpoints here are for all the connections, while the ID 0 is a special case per connection, depending on the source address used by the initial subflow. This ID 0 can then not be used for the global endpoints. Signed-off-by: Matthieu Baerts (NGI0) --- man/man8/ip-mptcp.8 | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/man/man8/ip-mptcp.8 b/man/man8/ip-mptcp.8 index 7eeeeef2..9c2e4ea6 100644 --- a/man/man8/ip-mptcp.8 +++ b/man/man8/ip-mptcp.8 @@ -148,7 +148,11 @@ expected behavior. =20 .TP .IR ID -is a unique numeric identifier for the given endpoint +is a unique numeric identifier, between 0 and 255, for the given endpoint.= It is +not possible to add endpoints with ID 0, because this special ID is reserv= ed for +the initial subflow. For rules linked to the initial subflow, the path-man= ager +will look at endpoints matching the same address, and port if set, ignorin= g the +ID. =20 .TP .BR signal --=20 2.45.2 From nobody Mon Sep 16 19:14:30 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3B2F13C3EE for ; Tue, 23 Jul 2024 16:31:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721752298; cv=none; b=qq8tlrF1IFcwKdnA2BL7x7GHRR9jCgmYXaT4GKdv1mcjLQ9ZWqBPLoD+1oQ3srR9fHHZm6akf/Gy8Z58JENicKuVRyfnAtTSOfIfKwEYhUM96IKI8JcigUmil/EBwO0iLrF08IesF0wRPRHok8tehIdy3Y9+kRlohH7PTJ+8VPU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721752298; c=relaxed/simple; bh=F4MAuB6QFQmzQhtbpngs/2R1rQblHEYfrO/wmuPILXg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SkfodW2wwhBz4m+1GBgX+wHlVCaz9d6wOIF/9Y9O9seFtVlsx51r35fNeZcgUD/K2fGVZpR7wlPzpD0uPPx7F0o7hpETZ5RGldDWGTMfVDjUfcZXGXIKI7OBNVGshcG6rbh1U9ZbhfpHzHKMvfHZO7UqBrudoUdAxRZ7Pp685uU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bf6trVTU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bf6trVTU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A32E4C4AF0E; Tue, 23 Jul 2024 16:31:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721752298; bh=F4MAuB6QFQmzQhtbpngs/2R1rQblHEYfrO/wmuPILXg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=bf6trVTUSex5BVXGjM6n365o+OQkEQOude1z6//EWHXPhciSa9ZBCHpuy/9+oMf3C eHhCjG68QZvoTevg9wu+IAFJBXS5c6CgP1x4SKieKej/UoyvN+JczOEcdGKiFWffIO ZwLUg2o3YO3GpoiYnT5jsFWark8HyB46/hFEi3FMF5fb3MTju0RramR9U09xuNw8RQ X0ujQpyss9f1VSjUFVE7Ic8R6zV27PcFfO7Fz/RHViuE3uv4Up1IsQt64ve5fpa6EO UBq87zN6qtI5Ff4GJey3rodJ6iHZjHrZQ7eNHSXxb/o/243zaTd+a6V5wU7cDCcKIf lbIZOSeQuLdqw== From: "Matthieu Baerts (NGI0)" Date: Tue, 23 Jul 2024 18:31:10 +0200 Subject: [PATCH mptcp-iproute v2 7/7] ip: mptcp: 'id 0' is only for 'del' Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240723-mptcp-user-feedback-v2-7-59f18975401c@kernel.org> References: <20240723-mptcp-user-feedback-v2-0-59f18975401c@kernel.org> In-Reply-To: <20240723-mptcp-user-feedback-v2-0-59f18975401c@kernel.org> To: MPTCP Upstream Cc: Mat Martineau , "Matthieu Baerts (NGI0)" X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1022; i=matttbe@kernel.org; h=from:subject:message-id; bh=F4MAuB6QFQmzQhtbpngs/2R1rQblHEYfrO/wmuPILXg=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBmn9rhh/uqAM9UJGkfrXejSHfVvJ1eZ6r/Uoyg9 k8nGuY/1i6JAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZp/a4QAKCRD2t4JPQmmg c53QEACu5/xrueytf+nHW/cVnoTcULbnOw5716bplBHi+UovNKPGRpzTC86KcGMvd3B3wb43/tG Lcs7SVE/BefHclaWeybcQ5jHBCBxcjfUhRoVqbsfSboLipMDRu4qIn6W3pMujefUZihE0/EvB3v zs0R0tT9u6Abc8EB4iolCeK/V1AFDfvs5epIRX1asM/4vpU9Kk4FubRvySy/v7ankKo+m1RcD27 WP0IlRYO513Jvq2Fke2pe8jBqGT1Qt1t3iqs3Tw1ju76k/bodXah6dKYGHux5esZxvUeLGt2stK hJI+LsHH8M7UMHIAaGHuHM6/fRrj3Ohy0BOLZ6+nNmf/r4J4Ht3KE+1+OlU7ZAOMbUEBTjuIIfz 4P6FLlgPFXGR0GQ1PcmKf5EFV2e6n8unvjja6Uw7lTLvSmhcSq7JfrcLYESF/JY/dYsL2VYKtoC 21cEeMI4InWDOEtgg9oE6tx0IMpQvp5J1ooqhj9QItAAbQFRSQFtLSkfNBBwsRM3dmt6lquRcri Ex1ZxkCHWUp563dnOFMKsy36bjuE64QfrhcENQbDB/APVPsHcrhwA2+54ekl6HAIl4xGhoLJ3LN JLlnXMpxdxGIBm4aIJsL4+pNoPFYjybyqdkGSCgA0F3TILKWo3QjpwILVkrKPV6ufGka1t4MfcU nlT8jvBsBcWh19A== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 Adding an endpoint with 'id 0' is not allowed. In this case, the kernel will ignore this 'id 0' and set another one. Similarly, because there are no endpoints with this 'id 0', changing an attribute for such endpoint will not be possible. To avoid some confusions, it sounds better to clearly report an error that the ID cannot be 0 in these cases. Signed-off-by: Matthieu Baerts (NGI0) --- ip/ipmptcp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ip/ipmptcp.c b/ip/ipmptcp.c index 9847f95b..118bac4a 100644 --- a/ip/ipmptcp.c +++ b/ip/ipmptcp.c @@ -174,6 +174,8 @@ static int mptcp_parse_opt(int argc, char **argv, struc= t nlmsghdr *n, int cmd) invarg("invalid for non-zero id address\n", "ADDRESS"); else if (!id && !addr_set) invarg("address is needed for deleting id 0 address\n", "ID"); + } else if (id_set && !deling && !id) { + invarg("cannot be 0\n", "ID"); } =20 if (adding && port && !(flags & MPTCP_PM_ADDR_FLAG_SIGNAL)) --=20 2.45.2