[PATCH mptcp-next v2 0/3] doc: introduce MPTCP global doc

Matthieu Baerts (NGI0) posted 3 patches 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/20240518-mptcp-doc-v2-0-68304a17cd7d@kernel.org
Documentation/networking/index.rst        |   1 +
Documentation/networking/mptcp-sysctl.rst |  74 +++++++-------
Documentation/networking/mptcp.rst        | 156 ++++++++++++++++++++++++++++++
MAINTAINERS                               |   2 +-
4 files changed, 197 insertions(+), 36 deletions(-)
[PATCH mptcp-next v2 0/3] doc: introduce MPTCP global doc
Posted by Matthieu Baerts (NGI0) 8 months ago
The most interesting bit is in the last patch: a new 'mptcp' page in
'networking' documentation.

The first patch is a fix (missing sysctl entry), and the second one
reorder the sysctl entries.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Changes in v2:
- patch 2/3: make it clearer it is OK to do such modifications for the
  backports by adding a note about that in the commit message (Mat).
- patch 3/3: applied Mat's comments.
- Link to v1: https://lore.kernel.org/r/20240517-mptcp-doc-v1-0-fc1ef063584e@kernel.org

---
Matthieu Baerts (NGI0) (3):
      doc: mptcp: add missing 'available_schedulers' entry
      doc: mptcp: alphabetical order
      doc: new 'mptcp' page in 'networking'

 Documentation/networking/index.rst        |   1 +
 Documentation/networking/mptcp-sysctl.rst |  74 +++++++-------
 Documentation/networking/mptcp.rst        | 156 ++++++++++++++++++++++++++++++
 MAINTAINERS                               |   2 +-
 4 files changed, 197 insertions(+), 36 deletions(-)
---
base-commit: 2ccd59d4df6aef3f553caf11e00af66300448e63
change-id: 20240517-mptcp-doc-315f909a12c4

Best regards,
-- 
Matthieu Baerts (NGI0) <matttbe@kernel.org>
Re: [PATCH mptcp-next v2 0/3] doc: introduce MPTCP global doc
Posted by Matthieu Baerts 8 months ago
Hello,

On 18/05/2024 17:52, Matthieu Baerts (NGI0) wrote:
> The most interesting bit is in the last patch: a new 'mptcp' page in
> 'networking' documentation.
> 
> The first patch is a fix (missing sysctl entry), and the second one
> reorder the sysctl entries.

I just applied this v2 in our tree.

I guess there is no need to wait before sending them upstream, so we can
have some reviews from the Doc team.

New patches for t/upstream-net and t/upstream:
- a2f67e9be84c: doc: mptcp: add missing 'available_schedulers' entry
- b720ebf6d555: doc: mptcp: alphabetical order
- 01721919a84a: doc: new 'mptcp' page in 'networking'
- Results: 7ff2cd284fdf..ef872e5e6e1a (export-net)
- Results: 2ccd59d4df6a..e7a4c0868f83 (export)

Tests are now in progress:

- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/7f7f9dac2795d5224e357b5646c83c63cd9add2c/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/61b1ea718087c5d099db254c2da376e3a566a93a/checks

Cheers,
Matt

-- 
Sponsored by the NGI0 Core fund.
Re: [PATCH mptcp-next v2 0/3] doc: introduce MPTCP global doc
Posted by MPTCP CI 8 months ago
Hi Matthieu,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Unstable: 1 failed test(s): selftest_mptcp_join 🔴
- KVM Validation: debug: Success! ✅
- KVM Validation: btf (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/9141046566

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/65924c221c10
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=854193


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)