From nobody Tue May 14 23:13:34 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D710446C8 for ; Wed, 7 Feb 2024 18:17:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707329878; cv=none; b=YqxmLe83kZNSfgczOHXadCcO/TiCytpRBgMhPutEH6JpyOARYK5IfB/h11Yql6g+9dG8LAxOj0i3g5KvxoaJJzH31xZxiOIKjRetM+S97yOVoVtELO8AvMtRoz8AcE28HTPVtVyEJnVJYY+sPOeg1p8MLW/quOkXDzZCKAPjkuc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707329878; c=relaxed/simple; bh=2Vc3niTSsHEKY0zHjJKb4Kr+o+DXlwDcYE1IFy0IfQI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rwpbT/DTyCVqKu0aDF58hN7cFMJTppRSkWhCImkrBUhZRP4hLcybnWI5R3WJenvaKrRTUfKuaGjRVGiWmlW4WRyNer1XBaenngIGZGlXVJv2/GE/cFMtS3OL4zdyms6WpZkQyC3FJ0S25oKGAY29ixPKstabWzqKDD5BQrYS4OA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=A5fe5FgQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="A5fe5FgQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E772C43394; Wed, 7 Feb 2024 18:17:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707329878; bh=2Vc3niTSsHEKY0zHjJKb4Kr+o+DXlwDcYE1IFy0IfQI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=A5fe5FgQKh5cW4UM7I0pbeHgvEn33uHzzArEJGQ+f1psbxGrr1KFwzlJnik2ZrJrF x5gcoAsmoXvwbek8IEloyv3C7GsLMekuNrsuAUkggTk+92uyevgCo/EBKIr+Z5jZoc Kqjt9JJAqKoaWlv1rTP7ATV9H3p5ZNCW4AlcNJPXe6r3IzTHvcmO59f2Xqtc0EqYuJ seqlaq03lmGauPIVomp9eGc/YfUQgsPZg51QM+ZdSH7kpDfSlxO+Gkuhwfa1EFWdru 59r+aE2YGCRkZC9k/+Q8ygmLRsv619HZf1aI2t49CWh7GDMAz9VTCIfbk3Ej7SJBNv O78TFXERSQ5CQ== From: "Matthieu Baerts (NGI0)" Date: Wed, 07 Feb 2024 19:17:49 +0100 Subject: [PATCH mptcp-next 1/3] selftests: mptcp: pm nl: also list skipped tests Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240207-selftests-mptcp-fix-5-15-v1-1-005b0cdb135a@kernel.org> References: <20240207-selftests-mptcp-fix-5-15-v1-0-005b0cdb135a@kernel.org> In-Reply-To: <20240207-selftests-mptcp-fix-5-15-v1-0-005b0cdb135a@kernel.org> To: mptcp@lists.linux.dev Cc: "Matthieu Baerts (NGI0)" X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1149; i=matttbe@kernel.org; h=from:subject:message-id; bh=2Vc3niTSsHEKY0zHjJKb4Kr+o+DXlwDcYE1IFy0IfQI=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBlw8lTpU2D19+r2gWZ/Eb07nFp9PBtvagksfFsG vZX4xG1x+2JAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZcPJUwAKCRD2t4JPQmmg c6d2EADbWkY4yMYsqZ1Clb92NWJvdGgAA4PnlaQF/WEtUwKifbvcwta06qCP8ALDSzJ4EsYaPQd bwHKcgYYMji61B4uHiqyYlEndtPrJTYixUux/7DyY0k+vhgbhrOYyWxbKXmmiP+a/WmTyZDxR9d c6NaB+tg3/2B7ZIHmv4RM4BNfyc6ACHgG12tMJoGdLWOLvdX8hGNkI/43MsCATlCCRLrWWsSMjJ AgdGPk9Ge4vLO/eG01T+0Ip6Ht0tLUSQIWInMHuW/zRXQmeXJpzkOwEaIcuO+ZeI2dzQZR+OBFW n2tcFfhvOL3jK4qDYu/4ciLiH3gGjI29M3xUw8NTCWCe9zzjz0Tbp0z4UxlucGnakNVxvFSkZ0K eEhmr6zxJYcZgRYvT4tKcmthY17IO6AlPD1FiiDw7wWiPb4diFQMOLrsmGUKpWEIOYhcREOBuc+ PplazoLidfq3WJtP+sRw7d7q1FK7yYpM1IJS3CUxeaLZgVPy5A7s7Zo69Wo8nPpwgbWkC4Ki1zH J9iugBBJ6vX7YyFXZ3Dpq1uATxp0467E0g4uRE9abGtwfmn2fqbFdfzPyHHvnn350JFAdweqvT0 v6HD8WvmFEhj9R7GUb9bMQuBDzfHfojgx/v9Z/aezr4pnwxgEeY2dZKxj5+SwpojZfyLABI/Cl+ KJ6EtLTReHXHV6Q== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 If the feature is not supported by older kernels, and instead of just ignoring some tests, we should mark them as skipped, so we can still track them. Fixes: d85555ac11f9 ("selftests: mptcp: pm_netlink: format subtests results= in TAP") Signed-off-by: Matthieu Baerts (NGI0) Reviewed-by: Geliang Tang --- tools/testing/selftests/net/mptcp/pm_netlink.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/testing/selftests/net/mptcp/pm_netlink.sh b/tools/testin= g/selftests/net/mptcp/pm_netlink.sh index 8f4ff123a7eb..79e83a2c95de 100755 --- a/tools/testing/selftests/net/mptcp/pm_netlink.sh +++ b/tools/testing/selftests/net/mptcp/pm_netlink.sh @@ -194,6 +194,12 @@ subflow 10.0.1.1" " (nofullmesh)" ip netns exec $ns1 ./pm_nl_ctl set id 1 flags backup,fullmesh check "ip netns exec $ns1 ./pm_nl_ctl dump" "id 1 flags \ subflow,backup,fullmesh 10.0.1.1" " (backup,fullmesh)" +else + for st in fullmesh nofullmesh backup,fullmesh; do + st=3D" (${st})" + printf "%-50s%s\n" "${st}" "[SKIP]" + mptcp_lib_result_skip "${st}" + done fi =20 mptcp_lib_result_print_all_tap --=20 2.43.0 From nobody Tue May 14 23:13:34 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FE5D823DA for ; Wed, 7 Feb 2024 18:17:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707329879; cv=none; b=PjYfSYd7tluo/udZFoQ3kpwtgTij705S1D6gEqtu30uFxanbMU1N6xN7BQEH1HI3rpm5uV3mU7JhSO50YyX1b2QYlaDH69cnhtgZCk2Z3ilHWaaRTfPjM7JhGJtbyxnBBXx1YRJMwsI9KCUrfQI0FCCuoMo2SChC7lb8wXKl8/8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707329879; c=relaxed/simple; bh=SgZOTWzuw1wrJ5HpXCZkxUS0s5IbIT6m9evcld+aQXQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cyrAbdLY4juQGR3P5pLpqvYywWEkpuXxhTGvHBlyUJrUUzS02DmRmmMCxqN/EXDJ6LrQOnZ6tp0pbcCegVqTztJMLsc1Ie3WObCZ/NmW9y0QuTvodBG3u/NNXK5c/7SYKBJGMd9M0OSDo7mU2kAoyyIJ21mM5JG+pJEW/V7eIns= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=njdR3401; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="njdR3401" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71842C433C7; Wed, 7 Feb 2024 18:17:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707329879; bh=SgZOTWzuw1wrJ5HpXCZkxUS0s5IbIT6m9evcld+aQXQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=njdR34012C18Y5DdcSGQfG/B79or++LdZRos3rFKJz/3PX5jBiKW+YXpDOEIOItd7 c6m5h5HON7NG9mlbnbalPlNThbUdk/IWwEEim8Jyfz63BfObPihvyo8k1kXVMbtaVp TEgSZPZcSR/mZGbLRNI14wxtpo1c5zCXLJeEpOaWw5C4M1D+kY8+6Wo2JRNNwMkSRB Yvbndmv5yHeK8xoHbl3YcbeC49wpT+0zen/4MUvi825t4/6PqgMd67hsWOLdwWOksh xEe5QqIyC26Ab+A3eDDZHi4pQDg/jeuEl93n/JN/EDqFPRyZ/qndyoaIdOYKWcHOHi DsReptVTEDm2g== From: "Matthieu Baerts (NGI0)" Date: Wed, 07 Feb 2024 19:17:50 +0100 Subject: [PATCH mptcp-next 2/3] selftests: mptcp: pm nl: avoid error msg on older kernels Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240207-selftests-mptcp-fix-5-15-v1-2-005b0cdb135a@kernel.org> References: <20240207-selftests-mptcp-fix-5-15-v1-0-005b0cdb135a@kernel.org> In-Reply-To: <20240207-selftests-mptcp-fix-5-15-v1-0-005b0cdb135a@kernel.org> To: mptcp@lists.linux.dev Cc: "Matthieu Baerts (NGI0)" X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1434; i=matttbe@kernel.org; h=from:subject:message-id; bh=SgZOTWzuw1wrJ5HpXCZkxUS0s5IbIT6m9evcld+aQXQ=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBlw8lUkHWt3nYhlFwJqdkFICjV5aB1k3vkknsCN fl9pf41VpCJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZcPJVAAKCRD2t4JPQmmg c9YGEADJgLCkNwIfSn+xGE/5Hyr+WgWe44u6rEv6N3nJLMM98EIgHDC989j/csHuVmqzyWH0V3m tKM+N0oG3b7nwlb1f4aKgsqO1ZYnBIFdxprgiilPyteCQP+DaYsmA/DqV0svWqpN6TRywCUDE8P cR4zoEksAmz5kUTFBMSJocuA4Coho6FKDiuv5333bdNGr3y8cgOzw7jjSZ8Bl5kISf9wNyuW7ts JobNhNMSvD8oCqNOQoEEOMPVhRvmEgagUjKB2uSIMIQXe1pLp9X8EVGUgq7ZRR66eoJCXzzNwUB 9aObeZRnvK1XGh6r7dNijIH9i3PuA0NPz9pIUzIeBgHIzcJ8E+Uxu/iFGXWOOXLO3woaN2yD+Ha rcb029CeNlsr+j71sJWWMDdo6aa4Le5XG/eGPCpUKf5oZZNUxu6F703a+ev55S0JByii5Ft8bNO Q1FdDhVP0M5OJSVGYJJA07n/6O1ubPpmwKiaz27qb69JmN6cfXgsn23zoLYpXNidhamYsz2pXPq Xwm239pCX2jYmmWu1eKBnT7i0H+wCeQP0WpLkzOV/wV7ARB+SKcTul0Tfm3Qad2dSd/GPXwzOzE c9JcQHXHF0q9yntoRsz02YkqbwHmctj71fK/pu57/LoqQX7B/DbkiWNr6e05Js5RlxM9qcQYU2y +u2g3f5LYi8Bf6g== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 Since the 'Fixes' commit mentioned below, and if the kernel being tested doesn't support the 'fullmesh' flag, this error will be printed: netlink error -22 (Invalid argument) ./pm_nl_ctl: bailing out due to netlink error[s] But that can be normal if the kernel doesn't support the feature, no need to print this worrying error message while everything else looks OK. So we can mute stderr. Failures will still be detected if any. Fixes: 1dc88d241f92 ("selftests: mptcp: pm_nl_ctl: always look for errors") Signed-off-by: Matthieu Baerts (NGI0) --- tools/testing/selftests/net/mptcp/pm_netlink.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/mptcp/pm_netlink.sh b/tools/testin= g/selftests/net/mptcp/pm_netlink.sh index 79e83a2c95de..71899a3ffa7a 100755 --- a/tools/testing/selftests/net/mptcp/pm_netlink.sh +++ b/tools/testing/selftests/net/mptcp/pm_netlink.sh @@ -183,7 +183,7 @@ check "ip netns exec $ns1 ./pm_nl_ctl dump" "id 1 flags= \ subflow 10.0.1.1" " (nobackup)" =20 # fullmesh support has been added later -ip netns exec $ns1 ./pm_nl_ctl set id 1 flags fullmesh +ip netns exec $ns1 ./pm_nl_ctl set id 1 flags fullmesh 2>/dev/null if ip netns exec $ns1 ./pm_nl_ctl dump | grep -q "fullmesh" || mptcp_lib_expect_all_features; then check "ip netns exec $ns1 ./pm_nl_ctl dump" "id 1 flags \ --=20 2.43.0 From nobody Tue May 14 23:13:34 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D4B08288A for ; Wed, 7 Feb 2024 18:18:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707329880; cv=none; b=PzwElNbvywVYfBIFJ0cqZHe5yMfjfyLILsdut5DRvXt0j1XOksWTinEe8xDCQslhYCO/qF8Z+5f1gma5eQ3Ycd2tlhmwO8hX/0M1VmTKkoIUp299n3MILi0NpfJnbmUNdjigo0w5Zg7l6m++f4JN+1j7Ezc76m/TyUxFYQCzoMk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707329880; c=relaxed/simple; bh=i1KNSzbovpyLjoHTdjxW2Iw+Uu0Ys1SpFF3/L0Chsio=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bY5ZycsYfTtFYMSoSyOIlFaYDXtPt5zgBos7R71gzLGwF1EaS6enCj4qtHYbNyslITqj2nX9a2BiJExHnbCH4TL1ZHiiwCO8wC3/FpQ+1G6gkfbD5KkvA1vum06/5V0Bk2tZv5U4P3DLBv1v11wGf8BSwsXP6VKit5O3WJ1yzxc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RmxCHtxR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RmxCHtxR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 740D8C433F1; Wed, 7 Feb 2024 18:17:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707329880; bh=i1KNSzbovpyLjoHTdjxW2Iw+Uu0Ys1SpFF3/L0Chsio=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=RmxCHtxRZbNPuPFCSvpfersTPjHG67zxONHtaEQcLIQAGUGZm/DAibSNzLT4ic6hd ZaVXoTERm7vZSxMnXjL0x2HBt1Ec6h3l2SQJ0enCVV/y4ayb3uNGW7KcrDwWdvCag3 AAWljYky7u5Jo3vMw7aFe4P5Ad5XP7qCPoiR6oXD656K5rLHAuFT8B0GZaFJ5vwh/B eXwSooov6kdiK0TCkL2YofH7RIihhvnS2fMnJVPt5KOQE04y74bOgnozCd4ROV7xdX azD8iQ5iSK1pZ5NLhWl7wbMLfZzYHekV4V3Uox6/jcZN3LdpnKy0iVnSu3lbS09G8F Lj4IzU7yBQrgw== From: "Matthieu Baerts (NGI0)" Date: Wed, 07 Feb 2024 19:17:51 +0100 Subject: [PATCH mptcp-next 3/3] selftests: mptcp: diag: fix bash warnings on older kernels Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240207-selftests-mptcp-fix-5-15-v1-3-005b0cdb135a@kernel.org> References: <20240207-selftests-mptcp-fix-5-15-v1-0-005b0cdb135a@kernel.org> In-Reply-To: <20240207-selftests-mptcp-fix-5-15-v1-0-005b0cdb135a@kernel.org> To: mptcp@lists.linux.dev Cc: "Matthieu Baerts (NGI0)" X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1303; i=matttbe@kernel.org; h=from:subject:message-id; bh=i1KNSzbovpyLjoHTdjxW2Iw+Uu0Ys1SpFF3/L0Chsio=; b=owEBbQKS/ZANAwAIAfa3gk9CaaBzAcsmYgBlw8lURfZ/PjrL6mHJz7N1X4lMG9V8rWOkPQF7M VmKgJ8FShWJAjMEAAEIAB0WIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZcPJVAAKCRD2t4JPQmmg c9gWEAC+OmRB4MHzCX6tzQdT9FUlMXq93R2xq2l/sZMz8w33FR9gGjdwS22GAsdE/zU2XOy/XwB ZUbT68NqYgqk1qg4bKW93S0IBQeoRETHDr2EFHzfRnzfGVhIGG4atv43ncswdJH3UVxdiorF0Rf sktSJsbF28/njpLGOPHxxSD3knR7H4Bl2NWTLR+8uabPpgJ+lqCzJDNyNp07y8oMUJo/bgNiOnL nr46ifxqPfxKkHNN0Zg/mVtd6PbNNwzbKU2Lqiy7FNds4XrYrJZ81SOt/+a09rzMfkxqAB4Js4X t4B4HbvDiqvat+pXIU78MZ8srEakyScqNFzZaPBpUcce3MXIN2biepqrU1lKRsa7XqoTrf4xBV4 RPUyGrVA9u+GLzQKSxLqDPLGeJGbWfmEaj18P7CDtUXaDvVkNFYBni+CEZJrWZCk6k1/1y/oWJH lM2e92tCP26LH4pV2m5F3rhMmeXRXFjR/w4Qhtqi6D+sW6X9DRKqqiNU62C+wCqM6+pzTHb5p/l t2bLMx/g6enJmp9eugmRZYib6yJxDzPkb7W8iGtpWCWBPQv300inVv/x3xuMyEPzVUTi3ZzQ6at l55PwjYtYRfoh9fGxELCkuBplTXCC6lwrvJ6h327LgjxoAurbQDNTBLRv9M/I1DLc9ShHX8sNNX iyhYzbtso1lZSPg== X-Developer-Key: i=matttbe@kernel.org; a=openpgp; fpr=E8CB85F76877057A6E27F77AF6B7824F4269A073 Since the 'Fixes' commit mentioned below, the command that is executed in __chk_nr() helper can return nothing if the feature is not supported. This is the case when the MPTCP CURRESTAB counter is not supported. To avoid this warning ... ./diag.sh: line 65: [: !=3D: unary operator expected ... we just need to surround '$nr' with double quotes, to support an empty string when the feature is not supported. Fixes: 81ab772819da ("selftests: mptcp: diag: check CURRESTAB counters") Signed-off-by: Matthieu Baerts (NGI0) --- tools/testing/selftests/net/mptcp/diag.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/diag.sh b/tools/testing/self= tests/net/mptcp/diag.sh index 04fcb8a077c9..e0615c6ffb8d 100755 --- a/tools/testing/selftests/net/mptcp/diag.sh +++ b/tools/testing/selftests/net/mptcp/diag.sh @@ -62,8 +62,8 @@ __chk_nr() nr=3D$(eval $command) =20 printf "%-50s" "$msg" - if [ $nr !=3D $expected ]; then - if [ $nr =3D "$skip" ] && ! mptcp_lib_expect_all_features; then + if [ "$nr" !=3D "$expected" ]; then + if [ "$nr" =3D "$skip" ] && ! mptcp_lib_expect_all_features; then echo "[ skip ] Feature probably not supported" mptcp_lib_result_skip "${msg}" else --=20 2.43.0