From nobody Thu Apr 25 14:34:01 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2580EC61DA4 for ; Tue, 14 Feb 2023 04:15:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231587AbjBNEPZ (ORCPT ); Mon, 13 Feb 2023 23:15:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229627AbjBNEPV (ORCPT ); Mon, 13 Feb 2023 23:15:21 -0500 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E6B010F9; Mon, 13 Feb 2023 20:15:19 -0800 (PST) Received: by mail-pl1-x62b.google.com with SMTP id be8so15779702plb.7; Mon, 13 Feb 2023 20:15:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=aYoGiVnitKVsiwNVJDrEKDE+kZ8NsbSA29728NlslYo=; b=L3svDzg8AWJe2cYOCVf8R3Kyd9+pqdQrJEvcPYliRXKdirjtAs0hHLgKY4IhCwcUc6 YsV81el0iCr+i91i+byhN5ZYPdLvkwWJOcSjsV3dzTCzni5Vl5hkMuZGfh4bTsH5T98t L6DbhzajIXfLqOm4UYJ6g7KQykx5OUuLidBvvOM8uBTmcJBBb0MMSC0nKtZyADzm72u4 6wbywC9gE8oi2rlwEqKygDAiOuNy7xk/QKE6sO8usd+96aoTB/NWzj8h1/hOvsGsfqI0 VG3XkcPRorB/tO1ezDw/cAJvCdH5r0s9Mom7hOR/unSibg4JRgsI+cT8840+Iz75p3m8 fzqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aYoGiVnitKVsiwNVJDrEKDE+kZ8NsbSA29728NlslYo=; b=bwe/buxghvYgYW+pL4inMhqV76Z957vUrCd8czpWR3UkHD/tM0x7vsRtH5OPtnqrEH OLiXK03Q4m55M5uLk2gk4NAOsB2Xg20ZLih7AbOcFVjgAqsKQjlRLTfzjWif5AP4QGmS OiKOxQg7mgRvrIuZ61J2R9VXFIN6cdEl5y+uHNDzoxXFDr6s6nD1L593JTo9B2HiDFxA LK4Pwuxk12qaa/tP+8yGeJvyQKxS+FMGhl4KZwZiCPvPXj531fyR115ylKjNnXtZv4th o9/GPzJhGLvR6Fp9LI6l1zSVoT3hjtDLyFb0x6VBSFoS8r6LDlufaD96J88OqBniJv7y cojA== X-Gm-Message-State: AO0yUKW8PPuSJ22kvpAzvPa1dV/K2iRUYBhTx7ebM7d+HQF2sRklC6Cg G6uj6eRTNifrx790kK2cQ5Y= X-Google-Smtp-Source: AK7set/olXPDRSQzuo4Wwxxbe1sWjQiXnjrAFsiPwcOGM2AriEpild14YdA2O572A2LuCJhCsIOmYA== X-Received: by 2002:a05:6a21:980d:b0:bd:93a:4c8f with SMTP id ue13-20020a056a21980d00b000bd093a4c8fmr680154pzb.23.1676348118709; Mon, 13 Feb 2023 20:15:18 -0800 (PST) Received: from KERNELXING-MB0.tencent.com ([103.7.29.31]) by smtp.gmail.com with ESMTPSA id iw3-20020a170903044300b0019ab3308554sm740154plb.85.2023.02.13.20.15.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 20:15:18 -0800 (PST) From: Jason Xing To: kuniyu@amazon.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, dsahern@kernel.org, matthieu.baerts@tessares.net, willemdebruijn.kernel@gmail.com, nhorman@tuxdriver.com, marcelo.leitner@gmail.com, lucien.xin@gmail.com, kgraul@linux.ibm.com, wenjia@linux.ibm.com, jaka@linux.ibm.com, bjorn@kernel.org, magnus.karlsson@intel.com, maciej.fijalkowski@intel.com, jonathan.lemon@gmail.com Cc: bpf@vger.kernel.org, linux-s390@vger.kernel.org, linux-sctp@vger.kernel.org, mptcp@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kerneljasonxing@gmail.com, Jason Xing Subject: [PATCH v2 net-next] net: no longer support SOCK_REFCNT_DEBUG feature Date: Tue, 14 Feb 2023 12:14:10 +0800 Message-Id: <20230214041410.6295-1-kerneljasonxing@gmail.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Jason Xing Commit e48c414ee61f ("[INET]: Generalise the TCP sock ID lookup routines") commented out the definition of SOCK_REFCNT_DEBUG in 2005 and later another commit 463c84b97f24 ("[NET]: Introduce inet_connection_sock") removed it. Since we could track all of them through bpf and kprobe related tools and the feature could print loads of information which might not be that helpful even under a little bit pressure, the whole feature which has been inactive for many years is no longer supported. Link: https://lore.kernel.org/lkml/20230211065153.54116-1-kerneljasonxing@g= mail.com/ Suggested-by: Kuniyuki Iwashima Signed-off-by: Jason Xing Acked-by: Matthieu Baerts Acked-by: Wenjia Zhang Reviewed-by: Eric Dumazet Reviewed-by: Kuniyuki Iwashima --- v2: 1) change the title and body message. 2) remove the whole feature instead suggested by Kuniyuki Iwashima. --- include/net/sock.h | 28 ---------------------------- net/core/sock.c | 13 ------------- net/ipv4/af_inet.c | 3 --- net/ipv4/inet_connection_sock.c | 2 -- net/ipv4/inet_timewait_sock.c | 3 --- net/ipv6/af_inet6.c | 10 ---------- net/ipv6/ipv6_sockglue.c | 12 ------------ net/mptcp/protocol.c | 1 - net/packet/af_packet.c | 4 ---- net/sctp/ipv6.c | 2 -- net/sctp/protocol.c | 2 -- net/smc/af_smc.c | 3 --- net/xdp/xsk.c | 4 ---- 13 files changed, 87 deletions(-) diff --git a/include/net/sock.h b/include/net/sock.h index dcd72e6285b2..e6369068a7bb 100644 --- a/include/net/sock.h +++ b/include/net/sock.h @@ -1349,9 +1349,6 @@ struct proto { char name[32]; =20 struct list_head node; -#ifdef SOCK_REFCNT_DEBUG - atomic_t socks; -#endif int (*diag_destroy)(struct sock *sk, int err); } __randomize_layout; =20 @@ -1359,31 +1356,6 @@ int proto_register(struct proto *prot, int alloc_sla= b); void proto_unregister(struct proto *prot); int sock_load_diag_module(int family, int protocol); =20 -#ifdef SOCK_REFCNT_DEBUG -static inline void sk_refcnt_debug_inc(struct sock *sk) -{ - atomic_inc(&sk->sk_prot->socks); -} - -static inline void sk_refcnt_debug_dec(struct sock *sk) -{ - atomic_dec(&sk->sk_prot->socks); - printk(KERN_DEBUG "%s socket %p released, %d are still alive\n", - sk->sk_prot->name, sk, atomic_read(&sk->sk_prot->socks)); -} - -static inline void sk_refcnt_debug_release(const struct sock *sk) -{ - if (refcount_read(&sk->sk_refcnt) !=3D 1) - printk(KERN_DEBUG "Destruction of the %s socket %p delayed, refcnt=3D%d\= n", - sk->sk_prot->name, sk, refcount_read(&sk->sk_refcnt)); -} -#else /* SOCK_REFCNT_DEBUG */ -#define sk_refcnt_debug_inc(sk) do { } while (0) -#define sk_refcnt_debug_dec(sk) do { } while (0) -#define sk_refcnt_debug_release(sk) do { } while (0) -#endif /* SOCK_REFCNT_DEBUG */ - INDIRECT_CALLABLE_DECLARE(bool tcp_stream_memory_free(const struct sock *s= k, int wake)); =20 static inline int sk_forward_alloc_get(const struct sock *sk) diff --git a/net/core/sock.c b/net/core/sock.c index f954d5893e79..be7b29d97637 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -2338,17 +2338,6 @@ struct sock *sk_clone_lock(const struct sock *sk, co= nst gfp_t priority) smp_wmb(); refcount_set(&newsk->sk_refcnt, 2); =20 - /* Increment the counter in the same struct proto as the master - * sock (sk_refcnt_debug_inc uses newsk->sk_prot->socks, that - * is the same as sk->sk_prot->socks, as this field was copied - * with memcpy). - * - * This _changes_ the previous behaviour, where - * tcp_create_openreq_child always was incrementing the - * equivalent to tcp_prot->socks (inet_sock_nr), so this have - * to be taken into account in all callers. -acme - */ - sk_refcnt_debug_inc(newsk); sk_set_socket(newsk, NULL); sk_tx_queue_clear(newsk); RCU_INIT_POINTER(newsk->sk_wq, NULL); @@ -3696,8 +3685,6 @@ void sk_common_release(struct sock *sk) =20 xfrm_sk_free_policy(sk); =20 - sk_refcnt_debug_release(sk); - sock_put(sk); } EXPORT_SYMBOL(sk_common_release); diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index 6c0ec2789943..f46a3924c440 100644 --- a/net/ipv4/af_inet.c +++ b/net/ipv4/af_inet.c @@ -156,7 +156,6 @@ void inet_sock_destruct(struct sock *sk) kfree(rcu_dereference_protected(inet->inet_opt, 1)); dst_release(rcu_dereference_protected(sk->sk_dst_cache, 1)); dst_release(rcu_dereference_protected(sk->sk_rx_dst, 1)); - sk_refcnt_debug_dec(sk); } EXPORT_SYMBOL(inet_sock_destruct); =20 @@ -356,8 +355,6 @@ static int inet_create(struct net *net, struct socket *= sock, int protocol, inet->mc_list =3D NULL; inet->rcv_tos =3D 0; =20 - sk_refcnt_debug_inc(sk); - if (inet->inet_num) { /* It assumes that any protocol which allows * the user to assign a number at socket diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_soc= k.c index d1f837579398..64be59d93b04 100644 --- a/net/ipv4/inet_connection_sock.c +++ b/net/ipv4/inet_connection_sock.c @@ -1178,8 +1178,6 @@ void inet_csk_destroy_sock(struct sock *sk) =20 xfrm_sk_free_policy(sk); =20 - sk_refcnt_debug_release(sk); - this_cpu_dec(*sk->sk_prot->orphan_count); =20 sock_put(sk); diff --git a/net/ipv4/inet_timewait_sock.c b/net/ipv4/inet_timewait_sock.c index beed32fff484..40052414c7c7 100644 --- a/net/ipv4/inet_timewait_sock.c +++ b/net/ipv4/inet_timewait_sock.c @@ -77,9 +77,6 @@ void inet_twsk_free(struct inet_timewait_sock *tw) { struct module *owner =3D tw->tw_prot->owner; twsk_destructor((struct sock *)tw); -#ifdef SOCK_REFCNT_DEBUG - pr_debug("%s timewait_sock %p released\n", tw->tw_prot->name, tw); -#endif kmem_cache_free(tw->tw_prot->twsk_prot->twsk_slab, tw); module_put(owner); } diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c index fee9163382c2..c93f2e865fea 100644 --- a/net/ipv6/af_inet6.c +++ b/net/ipv6/af_inet6.c @@ -238,16 +238,6 @@ static int inet6_create(struct net *net, struct socket= *sock, int protocol, inet->pmtudisc =3D IP_PMTUDISC_DONT; else inet->pmtudisc =3D IP_PMTUDISC_WANT; - /* - * Increment only the relevant sk_prot->socks debug field, this changes - * the previous behaviour of incrementing both the equivalent to - * answer->prot->socks (inet6_sock_nr) and inet_sock_nr. - * - * This allows better debug granularity as we'll know exactly how many - * UDPv6, TCPv6, etc socks were allocated, not the sum of all IPv6 - * transport protocol socks. -acme - */ - sk_refcnt_debug_inc(sk); =20 if (inet->inet_num) { /* It assumes that any protocol which allows diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c index 9ce51680290b..2917dd8d198c 100644 --- a/net/ipv6/ipv6_sockglue.c +++ b/net/ipv6/ipv6_sockglue.c @@ -464,13 +464,6 @@ int do_ipv6_setsockopt(struct sock *sk, int level, int= optname, __ipv6_sock_mc_close(sk); __ipv6_sock_ac_close(sk); =20 - /* - * Sock is moving from IPv6 to IPv4 (sk_prot), so - * remove it from the refcnt debug socks count in the - * original family... - */ - sk_refcnt_debug_dec(sk); - if (sk->sk_protocol =3D=3D IPPROTO_TCP) { struct inet_connection_sock *icsk =3D inet_csk(sk); =20 @@ -507,11 +500,6 @@ int do_ipv6_setsockopt(struct sock *sk, int level, int= optname, =20 inet6_cleanup_sock(sk); =20 - /* - * ... and add it to the refcnt debug socks count - * in the new family. -acme - */ - sk_refcnt_debug_inc(sk); module_put(THIS_MODULE); retv =3D 0; break; diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index 8cd6cc67c2c5..e913752df112 100644 --- a/net/mptcp/protocol.c +++ b/net/mptcp/protocol.c @@ -2876,7 +2876,6 @@ static void __mptcp_destroy_sock(struct sock *sk) sk_stream_kill_queues(sk); xfrm_sk_free_policy(sk); =20 - sk_refcnt_debug_release(sk); sock_put(sk); } =20 diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index b5ab98ca2511..a4c8f86ac12a 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -1335,8 +1335,6 @@ static void packet_sock_destruct(struct sock *sk) pr_err("Attempt to release alive packet socket: %p\n", sk); return; } - - sk_refcnt_debug_dec(sk); } =20 static bool fanout_flow_is_huge(struct packet_sock *po, struct sk_buff *sk= b) @@ -3172,7 +3170,6 @@ static int packet_release(struct socket *sock) =20 skb_queue_purge(&sk->sk_receive_queue); packet_free_pending(po); - sk_refcnt_debug_release(sk); =20 sock_put(sk); return 0; @@ -3362,7 +3359,6 @@ static int packet_create(struct net *net, struct sock= et *sock, int protocol, packet_cached_dev_reset(po); =20 sk->sk_destruct =3D packet_sock_destruct; - sk_refcnt_debug_inc(sk); =20 /* * Attach a protocol block diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c index 097bd60ce964..62b436a2c8fe 100644 --- a/net/sctp/ipv6.c +++ b/net/sctp/ipv6.c @@ -807,8 +807,6 @@ static struct sock *sctp_v6_create_accept_sk(struct soc= k *sk, =20 newsk->sk_v6_rcv_saddr =3D sk->sk_v6_rcv_saddr; =20 - sk_refcnt_debug_inc(newsk); - if (newsk->sk_prot->init(newsk)) { sk_common_release(newsk); newsk =3D NULL; diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c index 909a89a1cff4..c365df24ad33 100644 --- a/net/sctp/protocol.c +++ b/net/sctp/protocol.c @@ -601,8 +601,6 @@ static struct sock *sctp_v4_create_accept_sk(struct soc= k *sk, =20 newinet->inet_daddr =3D asoc->peer.primary_addr.v4.sin_addr.s_addr; =20 - sk_refcnt_debug_inc(newsk); - if (newsk->sk_prot->init(newsk)) { sk_common_release(newsk); newsk =3D NULL; diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c index e12d4fa5aece..c594312e22cd 100644 --- a/net/smc/af_smc.c +++ b/net/smc/af_smc.c @@ -359,8 +359,6 @@ static void smc_destruct(struct sock *sk) return; if (!sock_flag(sk, SOCK_DEAD)) return; - - sk_refcnt_debug_dec(sk); } =20 static struct sock *smc_sock_alloc(struct net *net, struct socket *sock, @@ -389,7 +387,6 @@ static struct sock *smc_sock_alloc(struct net *net, str= uct socket *sock, spin_lock_init(&smc->accept_q_lock); spin_lock_init(&smc->conn.send_lock); sk->sk_prot->hash(sk); - sk_refcnt_debug_inc(sk); mutex_init(&smc->clcsock_release_lock); smc_init_saved_callbacks(smc); =20 diff --git a/net/xdp/xsk.c b/net/xdp/xsk.c index 9f0561b67c12..a245c1b4a21b 100644 --- a/net/xdp/xsk.c +++ b/net/xdp/xsk.c @@ -845,7 +845,6 @@ static int xsk_release(struct socket *sock) sock_orphan(sk); sock->sk =3D NULL; =20 - sk_refcnt_debug_release(sk); sock_put(sk); =20 return 0; @@ -1396,8 +1395,6 @@ static void xsk_destruct(struct sock *sk) =20 if (!xp_put_pool(xs->pool)) xdp_put_umem(xs->umem, !xs->pool); - - sk_refcnt_debug_dec(sk); } =20 static int xsk_create(struct net *net, struct socket *sock, int protocol, @@ -1427,7 +1424,6 @@ static int xsk_create(struct net *net, struct socket = *sock, int protocol, sk->sk_family =3D PF_XDP; =20 sk->sk_destruct =3D xsk_destruct; - sk_refcnt_debug_inc(sk); =20 sock_set_flag(sk, SOCK_RCU_FREE); =20 --=20 2.37.3