From nobody Thu Apr 25 05:59:10 2024 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6F9017C3 for ; Sat, 22 Oct 2022 00:45:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666399552; x=1697935552; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=kz8r5YH7Q2QfoWM5VaAHKc6rmHLjowK138ZlxWCEK0I=; b=RJr878CSPFkR1icCoT8TtBh5vkty6tmOF0NaVmIfAA/KEZlrY3HXadBX V1gMEM4ggYn4TYd7H/X98MzcvBObZcUoVIK7VFlOeTSsmi2RA2nDqG8aL WS/Cmn0al3Uv158rkDBesJF71j/usFUE2E/sU5M74SWSrauq1bNttb9/z wW23+noxopMGPtTr3XX311bbi6dTKFU1goAYc4ONaGW0yOLkhyBPSky9J M1VVBpl394bXuun9TR60o8x3j9lhEIY6NwRLd8bqRII1ymRsmUHB1vV3Y aZENOU/RkXlIv3Ds1h/1Vm3vLitO5MhB7Do3bIQOFjI+b7ioQptyUTY+5 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10507"; a="308822189" X-IronPort-AV: E=Sophos;i="5.95,203,1661842800"; d="scan'208";a="308822189" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2022 17:45:50 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10507"; a="581795619" X-IronPort-AV: E=Sophos;i="5.95,203,1661842800"; d="scan'208";a="581795619" Received: from tremple-mobl1.amr.corp.intel.com (HELO mjmartin-desk2.intel.com) ([10.209.66.81]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2022 17:45:50 -0700 From: Mat Martineau To: netdev@vger.kernel.org Cc: Matthieu Baerts , davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, mptcp@lists.linux.dev, Mat Martineau Subject: [PATCH net-next 1/3] mptcp: sockopt: make 'tcp_fastopen_connect' generic Date: Fri, 21 Oct 2022 17:45:03 -0700 Message-Id: <20221022004505.160988-2-mathew.j.martineau@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221022004505.160988-1-mathew.j.martineau@linux.intel.com> References: <20221022004505.160988-1-mathew.j.martineau@linux.intel.com> Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Matthieu Baerts There are other socket options that need to act only on the first subflow, e.g. all TCP_FASTOPEN* socket options. This is similar to the getsockopt version. In the next commit, this new mptcp_setsockopt_first_sf_only() helper is used by other another option. Reviewed-by: Mat Martineau Signed-off-by: Matthieu Baerts Signed-off-by: Mat Martineau --- net/mptcp/sockopt.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/net/mptcp/sockopt.c b/net/mptcp/sockopt.c index c7cb68c725b2..8d3b09d75c3a 100644 --- a/net/mptcp/sockopt.c +++ b/net/mptcp/sockopt.c @@ -769,17 +769,17 @@ static int mptcp_setsockopt_sol_tcp_defer(struct mptc= p_sock *msk, sockptr_t optv return tcp_setsockopt(listener->sk, SOL_TCP, TCP_DEFER_ACCEPT, optval, op= tlen); } =20 -static int mptcp_setsockopt_sol_tcp_fastopen_connect(struct mptcp_sock *ms= k, sockptr_t optval, - unsigned int optlen) +static int mptcp_setsockopt_first_sf_only(struct mptcp_sock *msk, int leve= l, int optname, + sockptr_t optval, unsigned int optlen) { struct socket *sock; =20 - /* Limit to first subflow */ + /* Limit to first subflow, before the connection establishment */ sock =3D __mptcp_nmpc_socket(msk); if (!sock) return -EINVAL; =20 - return tcp_setsockopt(sock->sk, SOL_TCP, TCP_FASTOPEN_CONNECT, optval, op= tlen); + return tcp_setsockopt(sock->sk, level, optname, optval, optlen); } =20 static int mptcp_setsockopt_sol_tcp(struct mptcp_sock *msk, int optname, @@ -811,7 +811,8 @@ static int mptcp_setsockopt_sol_tcp(struct mptcp_sock *= msk, int optname, case TCP_DEFER_ACCEPT: return mptcp_setsockopt_sol_tcp_defer(msk, optval, optlen); case TCP_FASTOPEN_CONNECT: - return mptcp_setsockopt_sol_tcp_fastopen_connect(msk, optval, optlen); + return mptcp_setsockopt_first_sf_only(msk, SOL_TCP, optname, + optval, optlen); } =20 return -EOPNOTSUPP; --=20 2.38.1 From nobody Thu Apr 25 05:59:10 2024 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0A3317CF for ; Sat, 22 Oct 2022 00:45:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666399552; x=1697935552; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bts6J7VmVqhJslBL4eKvBMqv2XznmmoBLJcdMMDN+8A=; b=TlVNLXPWRDb8ykMdbbsMyU/yNeRg5wG9WhbYigrT6m56MZ0x/4mlJtr+ oOCvQalNyPj6aqvmYMiB6zB3D+IedV289qcHI0QH34qm6HrC9nIW17V/6 /jH5fAATygDDkMYy0lkrv/Jq5igCFEvpVp5DZaa8QG002IEwlMN+8SvuN 3vZrXUy6MQ7bP1UYj4uLUkKClgFSbFWu2qm9iJ8GR7C1FOFIbikVrJ5D0 o+oC30t3MG45L9CkTCMojSamoNMKPejb3/alRVeuTQdsHCOaqJQKvd7g2 siAp8aIOzBJVp8Za/7wQ4tVYQI2sipQ6OHvap7JaaqIytzlq6PD9gjVSY A==; X-IronPort-AV: E=McAfee;i="6500,9779,10507"; a="308822190" X-IronPort-AV: E=Sophos;i="5.95,203,1661842800"; d="scan'208";a="308822190" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2022 17:45:50 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10507"; a="581795620" X-IronPort-AV: E=Sophos;i="5.95,203,1661842800"; d="scan'208";a="581795620" Received: from tremple-mobl1.amr.corp.intel.com (HELO mjmartin-desk2.intel.com) ([10.209.66.81]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2022 17:45:50 -0700 From: Mat Martineau To: netdev@vger.kernel.org Cc: Matthieu Baerts , davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, mptcp@lists.linux.dev, Mat Martineau Subject: [PATCH net-next 2/3] mptcp: add TCP_FASTOPEN_NO_COOKIE support Date: Fri, 21 Oct 2022 17:45:04 -0700 Message-Id: <20221022004505.160988-3-mathew.j.martineau@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221022004505.160988-1-mathew.j.martineau@linux.intel.com> References: <20221022004505.160988-1-mathew.j.martineau@linux.intel.com> Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Matthieu Baerts The goal of this socket option is to configure MPTCP + TFO without cookie per socket. It was already possible to enable TFO without a cookie per netns by setting net.ipv4.tcp_fastopen sysctl knob to the right value. Per route was also supported by setting 'fastopen_no_cookie' option. This patch adds a per socket support like it is possible to do with TCP thanks to TCP_FASTOPEN_NO_COOKIE socket option. The only thing to do here is to relay the request to the first subflow like it is already done for TCP_FASTOPEN_CONNECT. Reviewed-by: Mat Martineau Signed-off-by: Matthieu Baerts Signed-off-by: Mat Martineau --- net/mptcp/sockopt.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/net/mptcp/sockopt.c b/net/mptcp/sockopt.c index 8d3b09d75c3a..1857281a0dd5 100644 --- a/net/mptcp/sockopt.c +++ b/net/mptcp/sockopt.c @@ -560,6 +560,7 @@ static bool mptcp_supported_sockopt(int level, int optn= ame) case TCP_TX_DELAY: case TCP_INQ: case TCP_FASTOPEN_CONNECT: + case TCP_FASTOPEN_NO_COOKIE: return true; } =20 @@ -568,8 +569,8 @@ static bool mptcp_supported_sockopt(int level, int optn= ame) /* TCP_REPAIR, TCP_REPAIR_QUEUE, TCP_QUEUE_SEQ, TCP_REPAIR_OPTIONS, * TCP_REPAIR_WINDOW are not supported, better avoid this mess */ - /* TCP_FASTOPEN_KEY, TCP_FASTOPEN, TCP_FASTOPEN_NO_COOKIE, - * are not supported fastopen is currently unsupported + /* TCP_FASTOPEN_KEY, TCP_FASTOPEN are not supported because + * fastopen for the listener side is currently unsupported */ } return false; @@ -811,6 +812,7 @@ static int mptcp_setsockopt_sol_tcp(struct mptcp_sock *= msk, int optname, case TCP_DEFER_ACCEPT: return mptcp_setsockopt_sol_tcp_defer(msk, optval, optlen); case TCP_FASTOPEN_CONNECT: + case TCP_FASTOPEN_NO_COOKIE: return mptcp_setsockopt_first_sf_only(msk, SOL_TCP, optname, optval, optlen); } @@ -1175,6 +1177,7 @@ static int mptcp_getsockopt_sol_tcp(struct mptcp_sock= *msk, int optname, case TCP_CC_INFO: case TCP_DEFER_ACCEPT: case TCP_FASTOPEN_CONNECT: + case TCP_FASTOPEN_NO_COOKIE: return mptcp_getsockopt_first_sf_only(msk, SOL_TCP, optname, optval, optlen); case TCP_INQ: --=20 2.38.1 From nobody Thu Apr 25 05:59:10 2024 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7596117C3 for ; Sat, 22 Oct 2022 00:45:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666399554; x=1697935554; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=zhcIsV30RmXvtXV2KMqAcqNirSX2pOhDxfaozeXt4Dw=; b=YhMmiZxVYLySudXQIowkkDdrDA2p0fdfgyBPe6ndOMJSlucgIHV4Vf7I 8NnG+gK58DBFf2pZO0VOil2W0dHIeSXg0HXou+yBYAGbj/D3o4S0jxnMY +oWz1vQ3VTUV/9tou5mPIXZ3RQ3X2esQH6kFuYjrseDOuBpw8DP0sR8VF GFz2siNcKi9NV7xFTswBnjTJXm6U1FSQOpCAh2pB2+P2t9j3nsCyqrIVQ VLR29D7vt/QT9H85Qyu3nUHmHOWWY8UDQnrqzoviBbBhMi5z2DL1NjPI4 rLzSL2QWdrW3rwcs1t19OsfyqPNYHFegNNA/XrPk8eUDSy/tsox0uoU51 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10507"; a="308822191" X-IronPort-AV: E=Sophos;i="5.95,203,1661842800"; d="scan'208";a="308822191" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2022 17:45:50 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10507"; a="581795621" X-IronPort-AV: E=Sophos;i="5.95,203,1661842800"; d="scan'208";a="581795621" Received: from tremple-mobl1.amr.corp.intel.com (HELO mjmartin-desk2.intel.com) ([10.209.66.81]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2022 17:45:50 -0700 From: Mat Martineau To: netdev@vger.kernel.org Cc: Matthieu Baerts , davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, mptcp@lists.linux.dev, Mat Martineau Subject: [PATCH net-next 3/3] mptcp: sockopt: use new helper for TCP_DEFER_ACCEPT Date: Fri, 21 Oct 2022 17:45:05 -0700 Message-Id: <20221022004505.160988-4-mathew.j.martineau@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221022004505.160988-1-mathew.j.martineau@linux.intel.com> References: <20221022004505.160988-1-mathew.j.martineau@linux.intel.com> Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Matthieu Baerts mptcp_setsockopt_sol_tcp_defer() was doing the same thing as mptcp_setsockopt_first_sf_only() except for the returned code in case of error. Ignoring the error is needed to mimic how TCP_DEFER_ACCEPT is handled when used with "plain" TCP sockets. The specific function for TCP_DEFER_ACCEPT can be replaced by the new mptcp_setsockopt_first_sf_only() helper and errors can be ignored to stay compatible with TCP. A bit of cleanup. Suggested-by: Mat Martineau Reviewed-by: Mat Martineau Acked-by: Paolo Abeni Signed-off-by: Matthieu Baerts Signed-off-by: Mat Martineau --- net/mptcp/sockopt.c | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/net/mptcp/sockopt.c b/net/mptcp/sockopt.c index 1857281a0dd5..f85e9bbfe86f 100644 --- a/net/mptcp/sockopt.c +++ b/net/mptcp/sockopt.c @@ -758,18 +758,6 @@ static int mptcp_setsockopt_v4(struct mptcp_sock *msk,= int optname, return -EOPNOTSUPP; } =20 -static int mptcp_setsockopt_sol_tcp_defer(struct mptcp_sock *msk, sockptr_= t optval, - unsigned int optlen) -{ - struct socket *listener; - - listener =3D __mptcp_nmpc_socket(msk); - if (!listener) - return 0; /* TCP_DEFER_ACCEPT does not fail */ - - return tcp_setsockopt(listener->sk, SOL_TCP, TCP_DEFER_ACCEPT, optval, op= tlen); -} - static int mptcp_setsockopt_first_sf_only(struct mptcp_sock *msk, int leve= l, int optname, sockptr_t optval, unsigned int optlen) { @@ -810,7 +798,9 @@ static int mptcp_setsockopt_sol_tcp(struct mptcp_sock *= msk, int optname, case TCP_NODELAY: return mptcp_setsockopt_sol_tcp_nodelay(msk, optval, optlen); case TCP_DEFER_ACCEPT: - return mptcp_setsockopt_sol_tcp_defer(msk, optval, optlen); + /* See tcp.c: TCP_DEFER_ACCEPT does not fail */ + mptcp_setsockopt_first_sf_only(msk, SOL_TCP, optname, optval, optlen); + return 0; case TCP_FASTOPEN_CONNECT: case TCP_FASTOPEN_NO_COOKIE: return mptcp_setsockopt_first_sf_only(msk, SOL_TCP, optname, --=20 2.38.1