[PATCH mptcp-next 0/4] mptcp: run mptcp_sockopt from a new netns + cleanup

Matthieu Baerts posted 4 patches 1 year, 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/20221019161940.3178393-1-matthieu.baerts@tessares.net
Maintainers: Mat Martineau <mathew.j.martineau@linux.intel.com>, Matthieu Baerts <matthieu.baerts@tessares.net>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>, Florian Westphal <fw@strlen.de>
tools/testing/selftests/net/mptcp/diag.sh       |  1 +
.../selftests/net/mptcp/mptcp_connect.sh        |  6 +-----
tools/testing/selftests/net/mptcp/mptcp_join.sh |  5 +++--
.../selftests/net/mptcp/mptcp_sockopt.sh        | 17 ++++++++---------
.../testing/selftests/net/mptcp/simult_flows.sh |  4 +---
.../testing/selftests/net/mptcp/userspace_pm.sh |  2 +-
6 files changed, 15 insertions(+), 20 deletions(-)
[PATCH mptcp-next 0/4] mptcp: run mptcp_sockopt from a new netns + cleanup
Posted by Matthieu Baerts 1 year, 5 months ago
Here are some small fixes for the MPTCP selftests, no big changes.

The first patch is a fix and for -net: if we run mptcp_sockopt.sh after having
modified some settings related to MPTCP on the host, we can run into issues
without this patch.

The second patch uses the new netns for mptcp_inq, cleaner.

The third one remove some defined but unused vars.

The last one uniform 'rndh' variable because it was declared with undefined
variables in a few places.

Matthieu Baerts (4):
  selftests: mptcp: run mptcp_sockopt from a new netns
  selftests: mptcp: run mptcp_inq from a clean netns
  selftests: mptcp: removed defined but unused vars
  selftests: mptcp: uniform 'rndh' variable

 tools/testing/selftests/net/mptcp/diag.sh       |  1 +
 .../selftests/net/mptcp/mptcp_connect.sh        |  6 +-----
 tools/testing/selftests/net/mptcp/mptcp_join.sh |  5 +++--
 .../selftests/net/mptcp/mptcp_sockopt.sh        | 17 ++++++++---------
 .../testing/selftests/net/mptcp/simult_flows.sh |  4 +---
 .../testing/selftests/net/mptcp/userspace_pm.sh |  2 +-
 6 files changed, 15 insertions(+), 20 deletions(-)


base-commit: 1907372cfe4315a0491ae262ac23b1b4cd9cdf94
-- 
2.37.2
Re: [PATCH mptcp-next 0/4] mptcp: run mptcp_sockopt from a new netns + cleanup
Posted by Mat Martineau 1 year, 4 months ago
On Wed, 19 Oct 2022, Matthieu Baerts wrote:

> Here are some small fixes for the MPTCP selftests, no big changes.
>
> The first patch is a fix and for -net: if we run mptcp_sockopt.sh after having
> modified some settings related to MPTCP on the host, we can run into issues
> without this patch.
>
> The second patch uses the new netns for mptcp_inq, cleaner.
>
> The third one remove some defined but unused vars.
>
> The last one uniform 'rndh' variable because it was declared with undefined
> variables in a few places.
>
> Matthieu Baerts (4):
>  selftests: mptcp: run mptcp_sockopt from a new netns
>  selftests: mptcp: run mptcp_inq from a clean netns
>  selftests: mptcp: removed defined but unused vars
>  selftests: mptcp: uniform 'rndh' variable
>
> tools/testing/selftests/net/mptcp/diag.sh       |  1 +
> .../selftests/net/mptcp/mptcp_connect.sh        |  6 +-----
> tools/testing/selftests/net/mptcp/mptcp_join.sh |  5 +++--
> .../selftests/net/mptcp/mptcp_sockopt.sh        | 17 ++++++++---------
> .../testing/selftests/net/mptcp/simult_flows.sh |  4 +---
> .../testing/selftests/net/mptcp/userspace_pm.sh |  2 +-
> 6 files changed, 15 insertions(+), 20 deletions(-)
>
>
> base-commit: 1907372cfe4315a0491ae262ac23b1b4cd9cdf94
> -- 
> 2.37.2

Ok, with the follow-up discussion and handling Geliang's suggested fix for 
mptcp-next as an additional patch, this series looks good to me:

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

--
Mat Martineau
Intel
Re: [PATCH mptcp-next 0/4] mptcp: run mptcp_sockopt from a new netns + cleanup
Posted by Matthieu Baerts 1 year, 4 months ago
Hi Mat,

On 31/10/2022 23:04, Mat Martineau wrote:
> On Wed, 19 Oct 2022, Matthieu Baerts wrote:
> 
>> Here are some small fixes for the MPTCP selftests, no big changes.
>>
>> The first patch is a fix and for -net: if we run mptcp_sockopt.sh
>> after having
>> modified some settings related to MPTCP on the host, we can run into
>> issues
>> without this patch.
>>
>> The second patch uses the new netns for mptcp_inq, cleaner.
>>
>> The third one remove some defined but unused vars.
>>
>> The last one uniform 'rndh' variable because it was declared with
>> undefined
>> variables in a few places.
>>
>> Matthieu Baerts (4):
>>  selftests: mptcp: run mptcp_sockopt from a new netns
>>  selftests: mptcp: run mptcp_inq from a clean netns
>>  selftests: mptcp: removed defined but unused vars
>>  selftests: mptcp: uniform 'rndh' variable
> 
> Ok, with the follow-up discussion and handling Geliang's suggested fix
> for mptcp-next as an additional patch, this series looks good to me:
> 
> Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

Thank you for the review!

Now in our tree (fix for net for patch 1/4, feat. for net-next with the
others):

New patches for t/upstream-net:
- c0dbc5e74ae0: selftests: mptcp: run mptcp_sockopt from a new netns
- Results: 21b3ec76c898..5a5c32fdb403 (export-net)

New patches for t/upstream:
- c0dbc5e74ae0: selftests: mptcp: run mptcp_sockopt from a new netns
- 972ae67540f4: selftests: mptcp: run mptcp_inq from a clean netns
- 6af6a13a0afc: selftests: mptcp: removed defined but unused vars
- ca4c25547d92: selftests: mptcp: uniform 'rndh' variable
- Results: d33b3e9215cd..5f9e0bf4aacf (export)


Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export-net/20221110T171431
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20221110T171431


Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
Re: [PATCH mptcp-next 0/4] mptcp: run mptcp_sockopt from a new netns + cleanup
Posted by Mat Martineau 1 year, 5 months ago
On Wed, 19 Oct 2022, Matthieu Baerts wrote:

> Here are some small fixes for the MPTCP selftests, no big changes.
>
> The first patch is a fix and for -net: if we run mptcp_sockopt.sh after having
> modified some settings related to MPTCP on the host, we can run into issues
> without this patch.
>

Hi Matthieu -

The changes are looking good to me, and Geliang's suggestion on patch 1 
seems worthwhile for consistency. Can you post a v2 with the suggested 
global ns variables?


Thanks,

Mat


> The second patch uses the new netns for mptcp_inq, cleaner.
>
> The third one remove some defined but unused vars.
>
> The last one uniform 'rndh' variable because it was declared with undefined
> variables in a few places.
>
> Matthieu Baerts (4):
>  selftests: mptcp: run mptcp_sockopt from a new netns
>  selftests: mptcp: run mptcp_inq from a clean netns
>  selftests: mptcp: removed defined but unused vars
>  selftests: mptcp: uniform 'rndh' variable
>
> tools/testing/selftests/net/mptcp/diag.sh       |  1 +
> .../selftests/net/mptcp/mptcp_connect.sh        |  6 +-----
> tools/testing/selftests/net/mptcp/mptcp_join.sh |  5 +++--
> .../selftests/net/mptcp/mptcp_sockopt.sh        | 17 ++++++++---------
> .../testing/selftests/net/mptcp/simult_flows.sh |  4 +---
> .../testing/selftests/net/mptcp/userspace_pm.sh |  2 +-
> 6 files changed, 15 insertions(+), 20 deletions(-)
>
>
> base-commit: 1907372cfe4315a0491ae262ac23b1b4cd9cdf94
> -- 
> 2.37.2
>
>
>

--
Mat Martineau
Intel