From nobody Mon Apr 29 20:36:37 2024 Delivered-To: wpasupplicant.patchew@gmail.com Received: by 2002:ab0:590e:0:0:0:0:0 with SMTP id n14csp1805025uad; Mon, 25 Jul 2022 13:52:43 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sAK1ICKGQhlqq+by/7xeMbRmBSdHgaIS5DutQ84BRXTVmrLnetX24c3ijrcviC4avQWQ+o X-Received: by 2002:a05:620a:400b:b0:6b6:2010:3015 with SMTP id h11-20020a05620a400b00b006b620103015mr10616591qko.491.1658782362981; Mon, 25 Jul 2022 13:52:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658782362; cv=none; d=google.com; s=arc-20160816; b=pxvrJeeByRE8/57s/lq74g5xMv+jFCsZP1gTL4GdhnSBN6ruv28XFlMHcyeVG9+FiV aeOpIeYTBWRwHU2lDo7+FQQWdovWPFTXuJCwdFXi3P0ofb3npMhgePSR1FtZVpkeJHaG rzPL9gEzgvnI+8M/Cc9GOTDwjNfN/F49DTXTFUNz/zqPDEG+dhMCBlJm0vmaexcjK22T bjt2Mf4tJ9MijapMTV0MWpJB2XUzU4RiVai+DclAccXlJSW/d4wD00RpcAoxvkvmpuDh hAKU1sf4+GeQgUXeSrBQJ9nV8fT2zo9NROmB21UVHwY3zXCd4/sZT9kLKgKl0fE6SzYZ 2V6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=QZc6R+tBelQ2acmQKFjl9XO719XFRZg3iWqDuawfQM4=; b=QnSpYt0v+Iq4MgstKWmPsEMdxtH0CWT2G17j3xRCpElRSlaTNHlri89ViXO323GrNc t4GwmCFrmd0XkJfXX7q6wd/njUr57vYhBGRlINrWrKO0XNXOCmF9jc+jdTSNvaMuBpkj yHnqfsqXEJs/bvAcbYtob7i9eCyc5hliLKLXUF8KNvsAX5tzpomMdctECygdHRKmWml4 7XbJaoniVKFsfI/0mHX5LxpKPSPvkj4mtkLVcfqSCJKPixJohmPk/APzUdce0o8rYTQs aIlFn3KHRtELb68qlRQA8FHMKN81hmxpe/MnLR/Jm/PkkLP2XyhZhMYd9Q5u/XLJdYEo kq+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=c7Y7uJm5; spf=pass (google.com: domain of mptcp+bounces-6048-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="mptcp+bounces-6048-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id kl11-20020a056214518b00b00474283f335dsi4561328qvb.134.2022.07.25.13.52.42 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Jul 2022 13:52:42 -0700 (PDT) Received-SPF: pass (google.com: domain of mptcp+bounces-6048-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=c7Y7uJm5; spf=pass (google.com: domain of mptcp+bounces-6048-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="mptcp+bounces-6048-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9527E1C208EF for ; Mon, 25 Jul 2022 20:52:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 212474A3E; Mon, 25 Jul 2022 20:52:41 +0000 (UTC) X-Original-To: mptcp@lists.linux.dev Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEC5E4A38 for ; Mon, 25 Jul 2022 20:52:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658782359; x=1690318359; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=tx6gJ865FBlGF8GXhCZ8lBxX17nODAgYp59Qf1QLR34=; b=c7Y7uJm5AWvuM2pbaO1rXUBvvGlu597gw/9tYypzn6lKRQftjiY1X/zo rd2ogkASFKB1W/6msab7A6WkGO446sbZkIOCLBdhpzycwf3YDXaRJ3UEM pXjnXSxanP31TYga41JnSodOWUw52UmWeJ0HRPVa3XcXp3qW+yYOgTaea pUmVYRF5woQnwjXt5Vf+uJlcqN97XSDuiVhvO1FpSf5WMniciCuttcceV wIX8dDJD420qraGYEgU0pjeoB8bp6l0C8BeXbtbfgdkh6oGNQu47nqShA nG8+wwto2TCE7fCNWjE0patb0/mVPQ4RsCDRpKU7IwhCAZreLAzOOhh5I Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10419"; a="274659143" X-IronPort-AV: E=Sophos;i="5.93,193,1654585200"; d="scan'208";a="274659143" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2022 13:52:39 -0700 X-IronPort-AV: E=Sophos;i="5.93,193,1654585200"; d="scan'208";a="599741712" Received: from dbpatel1-mobl.amr.corp.intel.com (HELO mjmartin-desk2.intel.com) ([10.209.117.180]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2022 13:52:38 -0700 From: Mat Martineau To: netdev@vger.kernel.org Cc: Mat Martineau , davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, matthieu.baerts@tessares.net, fw@strlen.de, mptcp@lists.linux.dev Subject: [PATCH net] mptcp: Do not return EINPROGRESS when subflow creation succeeds Date: Mon, 25 Jul 2022 13:52:31 -0700 Message-Id: <20220725205231.87529-1-mathew.j.martineau@linux.intel.com> X-Mailer: git-send-email 2.37.1 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" New subflows are created within the kernel using O_NONBLOCK, so EINPROGRESS is the expected return value from kernel_connect(). __mptcp_subflow_connect() has the correct logic to consider EINPROGRESS to be a successful case, but it has also used that error code as its return value. Before v5.19 this was benign: all the callers ignored the return value. Starting in v5.19 there is a MPTCP_PM_CMD_SUBFLOW_CREATE generic netlink command that does use the return value, so the EINPROGRESS gets propagated to userspace. Make __mptcp_subflow_connect() always return 0 on success instead. Fixes: ec3edaa7ca6c ("mptcp: Add handling of outgoing MP_JOIN requests") Fixes: 702c2f646d42 ("mptcp: netlink: allow userspace-driven subflow establ= ishment") Acked-by: Paolo Abeni Signed-off-by: Mat Martineau --- Note: The original author of ec3edaa7ca6c is no longer reachable at that email address. --- net/mptcp/subflow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c index 63e8892ec807..af28f3b60389 100644 --- a/net/mptcp/subflow.c +++ b/net/mptcp/subflow.c @@ -1533,7 +1533,7 @@ int __mptcp_subflow_connect(struct sock *sk, const st= ruct mptcp_addr_info *loc, mptcp_sock_graft(ssk, sk->sk_socket); iput(SOCK_INODE(sf)); WRITE_ONCE(msk->allow_infinite_fallback, false); - return err; + return 0; =20 failed_unlink: list_del(&subflow->node); base-commit: 9af0620de1e118666881376f6497d1785758b04c --=20 2.37.1