[PATCH net-next] net: mptcp: fix some spelling mistake in mptcp

menglong8.dong@gmail.com posted 1 patch 1 year, 9 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/20220627121626.1595732-1-imagedong@tencent.com
Maintainers: Matthieu Baerts <matthieu.baerts@tessares.net>, Eric Dumazet <edumazet@google.com>, "David S. Miller" <davem@davemloft.net>, Mat Martineau <mathew.j.martineau@linux.intel.com>, Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>
net/mptcp/pm_netlink.c | 2 +-
net/mptcp/subflow.c    | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
[PATCH net-next] net: mptcp: fix some spelling mistake in mptcp
Posted by menglong8.dong@gmail.com 1 year, 9 months ago
From: Menglong Dong <imagedong@tencent.com>

codespell finds some spelling mistake in mptcp:

net/mptcp/subflow.c:1624: interaces ==> interfaces
net/mptcp/pm_netlink.c:1130: regarless ==> regardless

Just fix them.

Signed-off-by: Menglong Dong <imagedong@tencent.com>
---
 net/mptcp/pm_netlink.c | 2 +-
 net/mptcp/subflow.c    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index e099f2a12504..3de83e2a2611 100644
--- a/net/mptcp/pm_netlink.c
+++ b/net/mptcp/pm_netlink.c
@@ -1127,7 +1127,7 @@ void mptcp_pm_nl_subflow_chk_stale(const struct mptcp_sock *msk, struct sock *ss
 			}
 			unlock_sock_fast(ssk, slow);
 
-			/* always try to push the pending data regarless of re-injections:
+			/* always try to push the pending data regardless of re-injections:
 			 * we can possibly use backup subflows now, and subflow selection
 			 * is cheap under the msk socket lock
 			 */
diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
index 654cc602ff2c..8c3e699d3387 100644
--- a/net/mptcp/subflow.c
+++ b/net/mptcp/subflow.c
@@ -1621,7 +1621,7 @@ int mptcp_subflow_create_socket(struct sock *sk, struct socket **new_sock)
 	/* the newly created socket really belongs to the owning MPTCP master
 	 * socket, even if for additional subflows the allocation is performed
 	 * by a kernel workqueue. Adjust inode references, so that the
-	 * procfs/diag interaces really show this one belonging to the correct
+	 * procfs/diag interfaces really show this one belonging to the correct
 	 * user.
 	 */
 	SOCK_INODE(sf)->i_ino = SOCK_INODE(sk->sk_socket)->i_ino;
-- 
2.36.1
Re: [PATCH net-next] net: mptcp: fix some spelling mistake in mptcp
Posted by patchwork-bot+netdevbpf@kernel.org 1 year, 9 months ago
Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 27 Jun 2022 20:16:25 +0800 you wrote:
> From: Menglong Dong <imagedong@tencent.com>
> 
> codespell finds some spelling mistake in mptcp:
> 
> net/mptcp/subflow.c:1624: interaces ==> interfaces
> net/mptcp/pm_netlink.c:1130: regarless ==> regardless
> 
> [...]

Here is the summary with links:
  - [net-next] net: mptcp: fix some spelling mistake in mptcp
    https://git.kernel.org/netdev/net-next/c/d640516a65d8

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Re: net: mptcp: fix some spelling mistake in mptcp: Tests Results
Posted by MPTCP CI 1 year, 9 months ago
Hi Menglong,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal:
  - Unstable: 1 failed test(s): selftest_simult_flows 🔴:
  - Task: https://cirrus-ci.com/task/4864806451675136
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/4864806451675136/summary/summary.txt

- KVM Validation: debug:
  - Unstable: 1 failed test(s): selftest_mptcp_join 🔴:
  - Task: https://cirrus-ci.com/task/5990706358517760
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5990706358517760/summary/summary.txt

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/b8c9415261d9


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-debug

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (Tessares)
Re: [PATCH net-next] net: mptcp: fix some spelling mistake in mptcp
Posted by Matthieu Baerts 1 year, 9 months ago
Hi Menglong Dong,

On 27/06/2022 14:16, menglong8.dong@gmail.com wrote:
> From: Menglong Dong <imagedong@tencent.com>
> 
> codespell finds some spelling mistake in mptcp:
> 
> net/mptcp/subflow.c:1624: interaces ==> interfaces
> net/mptcp/pm_netlink.c:1130: regarless ==> regardless
> 
> Just fix them.

Thank you for this fix.

Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net