From nobody Mon May 6 20:20:09 2024 Delivered-To: wpasupplicant.patchew@gmail.com Received: by 2002:ab0:35eb:0:0:0:0:0 with SMTP id w11csp2208572uau; Tue, 21 Jun 2022 17:18:55 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u73MlsW4WX7OjlQsu+MqVQSyL1w6f7TE8S8TJpYpD0jTtEAnSJm4P7pBN9iXlV/ImqZltT X-Received: by 2002:a63:1209:0:b0:3fc:818e:861d with SMTP id h9-20020a631209000000b003fc818e861dmr553482pgl.62.1655857135059; Tue, 21 Jun 2022 17:18:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655857135; cv=none; d=google.com; s=arc-20160816; b=c53+U/qufGYYoqgMy9jOK4vQN4m+InHMw7ye9UnHtjajzPH9jfGkzYBhIu7doeSBDt ZRXQ2uJzKzEuFiugK+tvbSKzxyQmwumHQjI2h7qIZL+Ib5ZroxDp7kRt7PXUBsHyPZ8r JywpUdFB19rnSSagWY41NX/apBV7p+fnraQv3zhcz4sq4Whd/r3GzCcS0ibF7zSCDXTh YL/smePRoZDuVt2z1cB22uKSJ1q0fnd0pDw+c0R/O7Xb4cLAi9VirJLxZVcQnVx3gEJR NxjIWrxmHUOjHx9Wb65rax7tq0diwc4/8AgabSD7q0sQIw9lWF9Py1p3QrH/HEkqNsZJ WxTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=kCB8g5xU6xtaL/YRYcsR4+qXVN8p7gUWsNwKX+oXcQM=; b=Qx5qo8epm8b0QqaOWljhonZBWbQsZFy0ohBlECAxEBfMxiYdFr9JvpUVapj9VTradn VgmmjOJVEnJNd8pIrvWS3D6KI5sMva1AJeenr5d7l87fFklpS1O/DwijLWhEFB7bRL3z pDRoKHPqXJhmjYMIHvgiykf26nTVCudM8sRKGrZkHa87ZJQXzxJoUY0hS3YPLMdxQo3N c+5slQnBqn4StaqP/A8G0nqvO9h+lNEJR2KL2fhgIZVdd2mzZS+WOr/cxyTnhfibMJsh IQ8oDzSpxjf2Z+G9ePh3FhF2LcgzeVr1sg77AAz+gAyqk3EawYgl9QPW1NuuFxFlyb4E Y2PQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=SbAVgRmJ; spf=pass (google.com: domain of mptcp+bounces-5753-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 139.178.88.99 as permitted sender) smtp.mailfrom="mptcp+bounces-5753-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id z19-20020a17090ab11300b001ec9c2aad09si9930717pjq.13.2022.06.21.17.18.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Jun 2022 17:18:55 -0700 (PDT) Received-SPF: pass (google.com: domain of mptcp+bounces-5753-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=SbAVgRmJ; spf=pass (google.com: domain of mptcp+bounces-5753-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 139.178.88.99 as permitted sender) smtp.mailfrom="mptcp+bounces-5753-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 31749280A89 for ; Wed, 22 Jun 2022 00:18:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2A2F0EA1; Wed, 22 Jun 2022 00:18:53 +0000 (UTC) X-Original-To: mptcp@lists.linux.dev Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8DADA52 for ; Wed, 22 Jun 2022 00:18:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655857131; x=1687393131; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=mLHOTebsTSrgxUmTOUjrMKtwnFO40+Lg320nyhPkMcs=; b=SbAVgRmJpyOR1vEzCq3Gyes+YbgcasAfRBxTQLKwaIQwWxHC2StcaefR J4HftYeVQ+vHz+uvG7TMlj1GqhWQz5j57FMLIIJAW5mNfgtvyFFFrLMdG 4MwKoQX/wq8fqO/pNRJN8F7IcvGz2qax158cjOwU/PwEsK23h4K5oWudO nCQ1cXv865+dfRuui/gcIu+Pr4sxOGDeQ3YnCGrpsfBlB1CsYQlOgpr9U RCNm8caeYq/voWutOvwIEm9anp+Nu4FiMNka2AyHFQVwwrhb9SJVqinND XUWjVLfAGemm1/+sWj0jIzYqhLJs/QdXFfPae9EWAyopTkRO72OkkmsXa A==; X-IronPort-AV: E=McAfee;i="6400,9594,10385"; a="305721448" X-IronPort-AV: E=Sophos;i="5.92,210,1650956400"; d="scan'208";a="305721448" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2022 17:18:51 -0700 X-IronPort-AV: E=Sophos;i="5.92,210,1650956400"; d="scan'208";a="833825995" Received: from kingsum-mobl.amr.corp.intel.com (HELO mjmartin-desk2.intel.com) ([10.212.204.100]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2022 17:18:50 -0700 From: Mat Martineau To: mptcp@lists.linux.dev Cc: Mat Martineau Subject: [PATCH mptcp-next] selftests: mptcp: Initialize variables to quiet gcc 12 warnings Date: Tue, 21 Jun 2022 17:18:46 -0700 Message-Id: <20220622001846.172735-1-mathew.j.martineau@linux.intel.com> X-Mailer: git-send-email 2.36.1 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In a few MPTCP selftest tools, gcc 12 complains that the 'sock' variable might be used uninitialized. This is a false positive because the only code path that could lead to uninitialized access is where getaddrinfo() fails, but the local xgetaddrinfo() wrapper exits if such a failure occurs. Initialize the 'sock' variable anyway to allow the tools to build with gcc 12. Signed-off-by: Mat Martineau Acked-by: Paolo Abeni --- tools/testing/selftests/net/mptcp/mptcp_connect.c | 2 +- tools/testing/selftests/net/mptcp/mptcp_inq.c | 2 +- tools/testing/selftests/net/mptcp/mptcp_sockopt.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.c b/tools/test= ing/selftests/net/mptcp/mptcp_connect.c index 8628aa61b763..e2ea6c126c99 100644 --- a/tools/testing/selftests/net/mptcp/mptcp_connect.c +++ b/tools/testing/selftests/net/mptcp/mptcp_connect.c @@ -265,7 +265,7 @@ static void sock_test_tcpulp(int sock, int proto, unsig= ned int line) static int sock_listen_mptcp(const char * const listenaddr, const char * const port) { - int sock; + int sock =3D -1; struct addrinfo hints =3D { .ai_protocol =3D IPPROTO_TCP, .ai_socktype =3D SOCK_STREAM, diff --git a/tools/testing/selftests/net/mptcp/mptcp_inq.c b/tools/testing/= selftests/net/mptcp/mptcp_inq.c index 29f75e2a1116..8672d898f8cd 100644 --- a/tools/testing/selftests/net/mptcp/mptcp_inq.c +++ b/tools/testing/selftests/net/mptcp/mptcp_inq.c @@ -88,7 +88,7 @@ static void xgetaddrinfo(const char *node, const char *se= rvice, static int sock_listen_mptcp(const char * const listenaddr, const char * const port) { - int sock; + int sock =3D -1; struct addrinfo hints =3D { .ai_protocol =3D IPPROTO_TCP, .ai_socktype =3D SOCK_STREAM, diff --git a/tools/testing/selftests/net/mptcp/mptcp_sockopt.c b/tools/test= ing/selftests/net/mptcp/mptcp_sockopt.c index ac9a4d9c1764..ae61f39556ca 100644 --- a/tools/testing/selftests/net/mptcp/mptcp_sockopt.c +++ b/tools/testing/selftests/net/mptcp/mptcp_sockopt.c @@ -136,7 +136,7 @@ static void xgetaddrinfo(const char *node, const char *= service, static int sock_listen_mptcp(const char * const listenaddr, const char * const port) { - int sock; + int sock =3D -1; struct addrinfo hints =3D { .ai_protocol =3D IPPROTO_TCP, .ai_socktype =3D SOCK_STREAM, --=20 2.36.1