From nobody Thu Sep 18 08:15:36 2025 Delivered-To: wpasupplicant.patchew@gmail.com Received: by 2002:a05:6a06:869:b0:4b8:7781:bd2f with SMTP id d41csp696977pis; Tue, 26 Apr 2022 14:57:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz2+AzOs9lNhZOFaBk1BF/qqTO0/njQ4PkiLSS0LK+3OYH+eT3P+LwrWwTR0RQUvzZE4/LB X-Received: by 2002:a05:6512:1308:b0:450:ad32:2b30 with SMTP id x8-20020a056512130800b00450ad322b30mr17706573lfu.470.1651010256047; Tue, 26 Apr 2022 14:57:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651010256; cv=none; d=google.com; s=arc-20160816; b=q6J9K5GYGn5x6eZ0UpWB6u74DX68L6VHsRzooAll9Cypa4QsbIFS+XTuN92cfa4guH qJRh0xR80/aMRoDWX1QxbQZqJTB3sazqPoFFONf3pJG4Lc+Wz1OoP9+Tc/9KIk3W587X WFur26CFBErRLRImBNalTuSpCOSlhq4oCDm3MDN5CfdrpkP5Ja5VmezNKmN0mvNrBV0y VrDohP1vpbcwKykbaiqg8gM7cxfCn8RnkeGZDbaCemhOcEMhNhTaj0wpz5NZjqlJZqE9 EBbcBeUJLjdF9cP18vlfxFVyNcASBZ/4NE04bGg1X9poCzVlIACI23aYq7/d/kauo1mQ aNzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=EVt5bOtX8UX7U5Fs8g432cYgOKfA0KmjL7pI6GlKzeQ=; b=cQljBJRXYJTeVIIDhx8F3XgajvJu4w9LlAwI3BOjTx87UVHv6x+NF8C3C4ia3GASQY 92lIkeiB7Q4PIytAGwjCUO+yW604hRJrwAoO2h+rbPjOuq0MoegRVtvosP71hkUH915P tbeAgj+lxCTQUlwt0z37a2OCIuy1qGkVIwxqX6LJqzcycK9L+W61tSAktSl93eyjHaaX ZDxEmPHPLS15O7TEHfiv3DRME9WLfprmEzoH4MsTfBLavpVqlYpWoSRY8WE9uiR0fPp6 0MaftdiMjpH3KvhfEiU7cxJLDnBKGsW4nMscBWlOMTOw2mp7fSXZUnwUaZtnlIt1BGfG QhuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=YpHffhdf; spf=pass (google.com: domain of mptcp+bounces-4906-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 139.178.84.19 as permitted sender) smtp.mailfrom="mptcp+bounces-4906-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from da.mirrors.kernel.org (da.mirrors.kernel.org. [139.178.84.19]) by mx.google.com with ESMTPS id y7-20020a0565123f0700b0045dd8d9db7esi19154219lfa.595.2022.04.26.14.57.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Apr 2022 14:57:36 -0700 (PDT) Received-SPF: pass (google.com: domain of mptcp+bounces-4906-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 139.178.84.19 as permitted sender) client-ip=139.178.84.19; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=YpHffhdf; spf=pass (google.com: domain of mptcp+bounces-4906-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 139.178.84.19 as permitted sender) smtp.mailfrom="mptcp+bounces-4906-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by da.mirrors.kernel.org (Postfix) with ESMTPS id 9346E2E09F1 for ; Tue, 26 Apr 2022 21:57:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1459E33C3; Tue, 26 Apr 2022 21:57:33 +0000 (UTC) X-Original-To: mptcp@lists.linux.dev Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B157533E7 for ; Tue, 26 Apr 2022 21:57:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651010248; x=1682546248; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=uQR/9rFY6hY2tSmUCN0th77tAuxipN7j03E1ZDb6EZY=; b=YpHffhdf1a+Z4rwN/Vb/g1VhEJiIt6IgwA0vNrgencTyaPeQhNJHP+t1 7bIuSM5w/9b/aWwChZ7unCkHtdL7Hy7PFivOqhauENlaChS85qeAKlAPy xzN3eIvODTQpg1jHA78DaDjkn4dsQ8dJADVQKu7njCyQLqbCDuChMhKeS n7AHshEg9Uzoe/wOTxf+fx4G6zv5Nz2PDXvxib2EeTXAyqSvmIZHIuXeM TTEtlMcODQw8kMEj3GgDETCzFYb3edReJ/82o+NX00aiiWzkMha7fojta s7sPPYxAC+hXUo3Rkr6WlOH7AuQLQb5wHStXYyOTaaRaLSSRAiTAkRCJG Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10329"; a="326222723" X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; d="scan'208";a="326222723" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2022 14:57:24 -0700 X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; d="scan'208";a="532878102" Received: from mjmartin-desk2.amr.corp.intel.com (HELO mjmartin-desk2.intel.com) ([10.209.10.176]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2022 14:57:23 -0700 From: Mat Martineau To: netdev@vger.kernel.org Cc: Geliang Tang , davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, matthieu.baerts@tessares.net, mptcp@lists.linux.dev, Mat Martineau Subject: [PATCH net-next 7/7] selftests: mptcp: print extra msg in chk_csum_nr Date: Tue, 26 Apr 2022 14:57:17 -0700 Message-Id: <20220426215717.129506-8-mathew.j.martineau@linux.intel.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220426215717.129506-1-mathew.j.martineau@linux.intel.com> References: <20220426215717.129506-1-mathew.j.martineau@linux.intel.com> Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Geliang Tang When the multiple checksum errors occur in chk_csum_nr(), print the numbers of the errors as an extra message. Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- tools/testing/selftests/net/mptcp/mptcp_join.sh | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testin= g/selftests/net/mptcp/mptcp_join.sh index 8023c0773d95..e5c8fc2816fb 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh @@ -1013,6 +1013,7 @@ chk_csum_nr() local csum_ns2=3D${2:-0} local count local dump_stats + local extra_msg=3D"" local allow_multi_errors_ns1=3D0 local allow_multi_errors_ns2=3D0 =20 @@ -1028,6 +1029,9 @@ chk_csum_nr() printf "%-${nr_blank}s %s" " " "sum" count=3D$(ip netns exec $ns1 nstat -as | grep MPTcpExtDataCsumErr | awk '= {print $2}') [ -z "$count" ] && count=3D0 + if [ "$count" !=3D "$csum_ns1" ]; then + extra_msg=3D"$extra_msg ns1=3D$count" + fi if { [ "$count" !=3D $csum_ns1 ] && [ $allow_multi_errors_ns1 -eq 0 ]; } = || { [ "$count" -lt $csum_ns1 ] && [ $allow_multi_errors_ns1 -eq 1 ]; }; = then echo "[fail] got $count data checksum error[s] expected $csum_ns1" @@ -1039,15 +1043,20 @@ chk_csum_nr() echo -n " - csum " count=3D$(ip netns exec $ns2 nstat -as | grep MPTcpExtDataCsumErr | awk '= {print $2}') [ -z "$count" ] && count=3D0 + if [ "$count" !=3D "$csum_ns2" ]; then + extra_msg=3D"$extra_msg ns2=3D$count" + fi if { [ "$count" !=3D $csum_ns2 ] && [ $allow_multi_errors_ns2 -eq 0 ]; } = || { [ "$count" -lt $csum_ns2 ] && [ $allow_multi_errors_ns2 -eq 1 ]; }; = then echo "[fail] got $count data checksum error[s] expected $csum_ns2" fail_test dump_stats=3D1 else - echo "[ ok ]" + echo -n "[ ok ]" fi [ "${dump_stats}" =3D 1 ] && dump_stats + + echo "$extra_msg" } =20 chk_fail_nr() --=20 2.36.0