From nobody Sun May 5 09:20:04 2024 Delivered-To: wpasupplicant.patchew@gmail.com Received: by 2002:aa7:c50d:0:0:0:0:0 with SMTP id o13csp28389edq; Thu, 17 Mar 2022 15:10:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx26EpG05kI5MZn+KdqZuJ9kwWANzFozRSv3sRyxk8Yh8mdHJR+Jpx1G5R1iy5uC7fUCGn8 X-Received: by 2002:ac2:410b:0:b0:448:58a8:3e8a with SMTP id b11-20020ac2410b000000b0044858a83e8amr4178725lfi.258.1647555016890; Thu, 17 Mar 2022 15:10:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647555016; cv=none; d=google.com; s=arc-20160816; b=yZTcQRFkDZTFMoQM8Z6je+qybXhsYz8oz56FWRwRJpvjj/vzU+5eanfokWCCJ+a4dt 98FJkYn77XV0KTxCT5AAmISGl+ZG+/FEYGoC+a/zAd0ljmzsAzviHD2JVUAWeH+e5pUg 1uGjYFuJcn0i6Lbwmds7ubQ+Y1qM2oSHNi1A42sYDPCnL+XJRDX1zwTAYQgZAeVEb+hh 9HPXcEJzZk88IkI631B3g2VGVpahy2d6lYRxbPTP2HF5OJSvqyT0ThGJvAssfM4w/84A bx2txTi65/KogUtf62/Tw2RGJw5dN0HlT1kVTzlloor44sCBwYS+ebIk6VdFkNv9/Tyx Nnpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=Z8+nxBvZxx1uaZkkSmH6pkri/g/oRmF4yN78ceO8J1o=; b=s3EiZXuWzcZf9Lv1wIUlMuY/qYoF7qA3L0HqdF9stRhbbs9YIQiIXZAOGr+pQOWBvH /k4GLHA8KOX1nQWLnjZWzYs7tad2ZQef6lgZyZ5tRuk9nuNsVJfQ84iCp6h0u9VK6XKx w4VIrxueGymnfslF9qgQ/jhpkbKevnhUX0ORps+jEyzncFyySdr4dwBwmjuB+7Bg3IKX CLeJErjUVn6epEXImN0BnLzki10hsf9TZP87RgHJtMMNVw1W5vDmIY5as9KjyG0GCPpY 43mHNG49tsIq1Hojth5D3oUz3hsBlppx/MMi8xhYZMuhDKFbmnWc1XpHnA9Xz4fmpHiT kWXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=S5Wju0Gf; spf=pass (google.com: domain of mptcp+bounces-4292-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 2604:1380:1:3600::1 as permitted sender) smtp.mailfrom="mptcp+bounces-4292-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ewr.edge.kernel.org (ewr.edge.kernel.org. [2604:1380:1:3600::1]) by mx.google.com with ESMTPS id i22-20020a056512319600b00447861fe33asi5799803lfe.316.2022.03.17.15.10.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Mar 2022 15:10:16 -0700 (PDT) Received-SPF: pass (google.com: domain of mptcp+bounces-4292-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 2604:1380:1:3600::1 as permitted sender) client-ip=2604:1380:1:3600::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=S5Wju0Gf; spf=pass (google.com: domain of mptcp+bounces-4292-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 2604:1380:1:3600::1 as permitted sender) smtp.mailfrom="mptcp+bounces-4292-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ewr.edge.kernel.org (Postfix) with ESMTPS id 4D8CE1C0D4F for ; Thu, 17 Mar 2022 22:10:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B158F4AB3; Thu, 17 Mar 2022 22:10:12 +0000 (UTC) X-Original-To: mptcp@lists.linux.dev Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 488F94A9F for ; Thu, 17 Mar 2022 22:10:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647555011; x=1679091011; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=QpWbczOzLS4au3qRyyNQY/DJiO8OZbjCj8/kWLrheTM=; b=S5Wju0Gfln2zWw43LDG2Odo5NKpk1BVqi2VgxXDI8lmIEHSSAeyVlRpw Q47UM0i7xjUCzTposY92IydIaDRLVJ3LwG2FFbZDijRhdhwYGWVoRzcEp /iDFTCdALRCsUL27Yon9Kx23NlzTU7J0s2iELBez3bBH5dyUFPSYhTumn ejy5EXxKCjiGoNjvXexSWcARqaeI+EufyrZMUSljRxms9tTUB77hr6wr7 8goPWIs5IdsXNwO3N3Fe22AxzVlRJINzhrO9bnxnPfa1b7iK5dKqPSo6o g4AGXytDw8i5EX9G7F4XozceHjsGnLIDjyfJiiItbWUTh+nZVzIki9RUy g==; X-IronPort-AV: E=McAfee;i="6200,9189,10289"; a="320207519" X-IronPort-AV: E=Sophos;i="5.90,190,1643702400"; d="scan'208";a="320207519" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2022 15:10:10 -0700 X-IronPort-AV: E=Sophos;i="5.90,190,1643702400"; d="scan'208";a="599259580" Received: from mjmartin-desk2.amr.corp.intel.com (HELO mjmartin-desk2.intel.com) ([10.251.9.212]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2022 15:10:09 -0700 From: Mat Martineau To: netdev@vger.kernel.org Cc: Yonglong Li , davem@davemloft.net, kuba@kernel.org, matthieu.baerts@tessares.net, mptcp@lists.linux.dev, stable@vger.kernel.org, Paolo Abeni , Mat Martineau Subject: [PATCH net] mptcp: Fix crash due to tcp_tsorted_anchor was initialized before release skb Date: Thu, 17 Mar 2022 15:09:53 -0700 Message-Id: <20220317220953.426024-1-mathew.j.martineau@linux.intel.com> X-Mailer: git-send-email 2.35.1 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Yonglong Li Got crash when doing pressure test of mptcp: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D dst_release: dst:ffffa06ce6e5c058 refcnt:-1 kernel tried to execute NX-protected page - exploit attempt? (uid: 0) BUG: unable to handle kernel paging request at ffffa06ce6e5c058 PGD 190a01067 P4D 190a01067 PUD 43fffb067 PMD 22e403063 PTE 8000000226e5c063 Oops: 0011 [#1] SMP PTI CPU: 7 PID: 7823 Comm: kworker/7:0 Kdump: loaded Tainted: G E Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.2.1 04/01/2014 Call Trace: ? skb_release_head_state+0x68/0x100 ? skb_release_all+0xe/0x30 ? kfree_skb+0x32/0xa0 ? mptcp_sendmsg_frag+0x57e/0x750 ? __mptcp_retrans+0x21b/0x3c0 ? __switch_to_asm+0x35/0x70 ? mptcp_worker+0x25e/0x320 ? process_one_work+0x1a7/0x360 ? worker_thread+0x30/0x390 ? create_worker+0x1a0/0x1a0 ? kthread+0x112/0x130 ? kthread_flush_work_fn+0x10/0x10 ? ret_from_fork+0x35/0x40 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D In __mptcp_alloc_tx_skb skb was allocated and skb->tcp_tsorted_anchor will be initialized, in under memory pressure situation sk_wmem_schedule will return false and then kfree_skb. In this case skb->_skb_refdst is not null because_skb_refdst and tcp_tsorted_anchor are stored in the same mem, and kfree_skb will try to release dst and cause crash. Fixes: f70cad1085d1 ("mptcp: stop relying on tcp_tx_skb_cache") Cc: stable@vger.kernel.org Reviewed-by: Paolo Abeni Signed-off-by: Yonglong Li Signed-off-by: Mat Martineau --- net/mptcp/protocol.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index 1c72f25f083e..014c9d88f947 100644 --- a/net/mptcp/protocol.c +++ b/net/mptcp/protocol.c @@ -1196,6 +1196,7 @@ static struct sk_buff *__mptcp_alloc_tx_skb(struct so= ck *sk, struct sock *ssk, g tcp_skb_entail(ssk, skb); return skb; } + tcp_skb_tsorted_anchor_cleanup(skb); kfree_skb(skb); return NULL; } base-commit: 551acdc3c3d2b6bc97f11e31dcf960bc36343bfc --=20 2.35.1