From nobody Sun Feb 8 21:49:07 2026 Delivered-To: wpasupplicant.patchew@gmail.com Received: by 2002:a05:6402:358d:0:0:0:0 with SMTP id y13csp814130edc; Mon, 7 Mar 2022 12:44:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJx63bvr1udPAOE+38EqV2IwwpQMpqkOoC8oyiK932/BQo/SE9ZItjjIDaItnXDRnOa1Iv1Q X-Received: by 2002:a81:a4d:0:b0:2db:efff:b9df with SMTP id 74-20020a810a4d000000b002dbefffb9dfmr9985202ywk.174.1646685899224; Mon, 07 Mar 2022 12:44:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646685899; cv=none; d=google.com; s=arc-20160816; b=kAHYJd0RFRXN+N9EfqgAETZkTY1NyP0luEEbT8xEFU2VvPMKekJvbM5u6+6YgY3yEN eaiguuuiH9nroTHvKSxm/bNbmmv5j1XvxQ7z6UYRVmLP0dKtHubAVHVWjLt6s6FQSjIX 0bUnjf9S20Pi3eaT4sG44n1DFUyGTr9bnShBQ9PwBWcDYqB5efuZ98w6gevgMXY/ShG4 AQaQByvfMDoOLJZuIhAJyhj69DWdty1YIHGed2oM2iqfGWe+fwFxdVlJW4QRnRJrk09V GUIShmrLptXjBg2MUB9rd9evDUX00i197J2CFlBbX1IRWSgaVYfhzNeVZVk2mkZmRsc9 9t8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=SljWsmg6Ip+uRNNav/RYcW0zzuPdsiXsQ8E8iifN31k=; b=XOrCCEcT9dttMq59HiVsZnyvRheXuUxOhNnN9APDz+6cxhCaUXAWt6NnwLsA4Ji1SA gNZKQu74Zyi9y07sEh6k8uvJekCcCOvvn6mTbWRx9/Ku8NiMjmkW4Lc5T2bBAyFJ8NFe eZSi84d78BFk5wpldOigcOOwD+JNfUHYlN5Ny1bThALhZR4PENRfaa18axZywm/Hr+le tWgsJUotS2We0fKSB//4b9dxqlyJKAspmJ7LphgDsKDtC5DakuW/m7DBMEcIQQchJhYR TGW71yIywL7tNXNg0h8vVu67G6gA0BY6A5kBlQkhdSLLfxzGYkBZPOdb7Wz+PuTMfHyr g4Rg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Nc3SKl4q; spf=pass (google.com: domain of mptcp+bounces-4140-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 2604:1380:1:3600::1 as permitted sender) smtp.mailfrom="mptcp+bounces-4140-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ewr.edge.kernel.org (ewr.edge.kernel.org. [2604:1380:1:3600::1]) by mx.google.com with ESMTPS id n3-20020a252703000000b0061d87a9dc5bsi9164672ybn.270.2022.03.07.12.44.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Mar 2022 12:44:59 -0800 (PST) Received-SPF: pass (google.com: domain of mptcp+bounces-4140-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 2604:1380:1:3600::1 as permitted sender) client-ip=2604:1380:1:3600::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Nc3SKl4q; spf=pass (google.com: domain of mptcp+bounces-4140-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 2604:1380:1:3600::1 as permitted sender) smtp.mailfrom="mptcp+bounces-4140-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ewr.edge.kernel.org (Postfix) with ESMTPS id C46EC1C0B5C for ; Mon, 7 Mar 2022 20:44:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0A576434D; Mon, 7 Mar 2022 20:44:52 +0000 (UTC) X-Original-To: mptcp@lists.linux.dev Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 046884356 for ; Mon, 7 Mar 2022 20:44:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646685890; x=1678221890; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=/eP9FA3TlK1JhqXDW8j+WHnR3670oSgdS19K3yRsgGA=; b=Nc3SKl4qPl2uyX4+VocbLD43/cXKURaaHiiOoUmU5T0zpbU79Jlyjzmd qnZF8+0Z/PAlqtctnA59OfkGwg1CynXRau5joa3BjzVMAo41JI5m1+5qP BCobAEAB3huJoaG8iN9nVJgR8rIyx/Q3iHipO17Blsnoibmf8mXTSH24H G6Ex2rZZRsCM8stobUOoAf/fzVu3i/1pPa1K3MX+AXsJsxcPiBVaKRAlE 7g3YMiFq0BRWT6DaYirpM+g+HWy0WJ9kRdbvqUFkV3Vc2LYo6Q3CqqaHx fV7Hr4PAPi9Uw1pAMbyo46bk16EpDtV5YkNrYvNhOdw8BNDb1SFUuY3n4 Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10279"; a="317731795" X-IronPort-AV: E=Sophos;i="5.90,163,1643702400"; d="scan'208";a="317731795" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2022 12:44:45 -0800 X-IronPort-AV: E=Sophos;i="5.90,163,1643702400"; d="scan'208";a="553320496" Received: from mjmartin-desk2.amr.corp.intel.com (HELO mjmartin-desk2.intel.com) ([10.212.192.43]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2022 12:44:45 -0800 From: Mat Martineau To: netdev@vger.kernel.org Cc: Geliang Tang , davem@davemloft.net, kuba@kernel.org, matthieu.baerts@tessares.net, mptcp@lists.linux.dev, Mat Martineau Subject: [PATCH net-next 9/9] mptcp: add fullmesh flag check for adding address Date: Mon, 7 Mar 2022 12:44:39 -0800 Message-Id: <20220307204439.65164-10-mathew.j.martineau@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220307204439.65164-1-mathew.j.martineau@linux.intel.com> References: <20220307204439.65164-1-mathew.j.martineau@linux.intel.com> Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Geliang Tang The fullmesh flag mustn't be used with the signal flag when adding an address. This patch added the necessary flags check for this case. Fixes: 73c762c1f07d ("mptcp: set fullmesh flag in pm_netlink") Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- net/mptcp/pm_netlink.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c index e090810bb35d..800515fe5e1d 100644 --- a/net/mptcp/pm_netlink.c +++ b/net/mptcp/pm_netlink.c @@ -1264,6 +1264,12 @@ static int mptcp_nl_cmd_add_addr(struct sk_buff *skb= , struct genl_info *info) return -EINVAL; } =20 + if (addr.flags & MPTCP_PM_ADDR_FLAG_SIGNAL && + addr.flags & MPTCP_PM_ADDR_FLAG_FULLMESH) { + GENL_SET_ERR_MSG(info, "flags mustn't have both signal and fullmesh"); + return -EINVAL; + } + if (addr.flags & MPTCP_PM_ADDR_FLAG_IMPLICIT) { GENL_SET_ERR_MSG(info, "can't create IMPLICIT endpoint"); return -EINVAL; --=20 2.35.1