From nobody Fri May 3 14:03:50 2024 Delivered-To: wpasupplicant.patchew@gmail.com Received: by 2002:a02:9f92:0:0:0:0:0 with SMTP id a18csp902135jam; Tue, 8 Feb 2022 01:10:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJxVVgzet5VHDDhN49rabThyyZfvfDebpvpsz2IICtYmK1GlDXCxAWifD0QhH2GR9gb8fSJB X-Received: by 2002:a05:622a:95:: with SMTP id o21mr2280132qtw.684.1644311440805; Tue, 08 Feb 2022 01:10:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644311440; cv=none; d=google.com; s=arc-20160816; b=lkazxcFWVaX9pMKlV+kicUI+k6A8M+LJTGZLpCibAdBLZnDx0rqDztkDQd/3XsckNc 0xeYCMBQ+O7ZcO+/zwf5z9WxBPu78pGI9O/b5/QV8IzPzIGugjXhdrQOC5SuKLiwTrEF kO/8kziHQJqHN12q99U+yJ6Qv5OkgOH2yJzdvDymdA99+hWLituaI8kUVEshSFyQeHTm EhVQm/afFBhMSfLVwbMp6oPa22aW8FAgLjC9SGXhiE5Cu9bIlp+eaMeZu7pevt47VMwV CeCYylYhRciVHOeI9ie9AFvh5/IYvtv8E9UTfqPsFsGnZajMv7IIsAwY7dgkBgCJDItS cNSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=VJY/s0Ymy2GvPYWmhVYqLgy8IdGkR/Hi9JaHk7vDvZw=; b=pHBa82qc7SQSKTp7SmpjXO3p422Z+02DPPtTr7XjRroicW20+6JoEy23auGFafA6ks /GWvfqOaUSWgpkHE5RocZSV55I1xNrrT7sZCUygRsuPAzzDL0U+PnFntVtaZqjFC/gYG 5qf0ZjaZIzmC5e4I2zhp582bTw8sBA4mbQwMSs7R1+ZPq0G+OafPL91E56ctrdayjDU8 GsoubrU6T3oXxUS5MgG+iQAbsFUziMdER/7Wb5yEr6A/7Z4W3XxXw2NrYMF9EzAG+zUS KiuEQNhG29HoPEuMdUK+WME7TlEWblku/TybYvifx4uegovziJhF1wBL+lIsKcgoDPfg jWQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tessares-net.20210112.gappssmtp.com header.s=20210112 header.b="Zm/WdaoV"; spf=pass (google.com: domain of mptcp+bounces-3510-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 2604:1380:1:3600::1 as permitted sender) smtp.mailfrom="mptcp+bounces-3510-wpasupplicant.patchew=gmail.com@lists.linux.dev" Return-Path: Received: from ewr.edge.kernel.org (ewr.edge.kernel.org. [2604:1380:1:3600::1]) by mx.google.com with ESMTPS id u2si3033173qta.57.2022.02.08.01.10.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Feb 2022 01:10:40 -0800 (PST) Received-SPF: pass (google.com: domain of mptcp+bounces-3510-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 2604:1380:1:3600::1 as permitted sender) client-ip=2604:1380:1:3600::1; Authentication-Results: mx.google.com; dkim=pass header.i=@tessares-net.20210112.gappssmtp.com header.s=20210112 header.b="Zm/WdaoV"; spf=pass (google.com: domain of mptcp+bounces-3510-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 2604:1380:1:3600::1 as permitted sender) smtp.mailfrom="mptcp+bounces-3510-wpasupplicant.patchew=gmail.com@lists.linux.dev" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ewr.edge.kernel.org (Postfix) with ESMTPS id 295061C0375 for ; Tue, 8 Feb 2022 09:10:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C271529CA; Tue, 8 Feb 2022 09:10:38 +0000 (UTC) X-Original-To: mptcp@lists.linux.dev Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B45702F26 for ; Tue, 8 Feb 2022 09:10:36 +0000 (UTC) Received: by mail-wm1-f48.google.com with SMTP id k3-20020a1ca103000000b0037bdea84f9cso1113784wme.1 for ; Tue, 08 Feb 2022 01:10:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tessares-net.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=VJY/s0Ymy2GvPYWmhVYqLgy8IdGkR/Hi9JaHk7vDvZw=; b=Zm/WdaoVimz/0PmQrjVI5RlXTYXTICxDNFur+4gkc03/OjjCzERbyefZocDoGMxnbF YqCRY0MM950SHUlcmShs2lujDR7jWbdN3Uea1F+9F4+9qFMSzncHh5gkrpBL/V8Tfmvz femkkCpZqwtxOLGUteOL+xEi179k3xshe5DyZrb1ELLWI56vUG0CMsEoJ8KNNhMfom3Y 4JGbKrK9FsUGpcMoDLTwnf+v+cznRlflglkCNrNXAO2CGOkM8WDrBL/na3edxIg/IwvH xKTJdF8a2VfklbE6plLpv8yewTYjI0/CIaDvPLk9DS8t36o6aKCHOtx1BsSKKGLkeARP HOLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=VJY/s0Ymy2GvPYWmhVYqLgy8IdGkR/Hi9JaHk7vDvZw=; b=onqud1hKgXlVRmujVgM7yyqm2U2JCiSwILyA9fegwdMMiiklc6Knn15qboeqfazCCh 0vzgIrg8cm8WtliwbF8XvJWHnUowuRF+SomEco69Ngao1hCH0m5eLd+BLNMpWIWl9Nik C7XVoNFx6xw+sbOF6IF1ErmuemhO6hBZzJ0Vw4Fkysi/4qAtvEppITY1oeyKvkAAItuW QtSXQQTMhpTYLCXQXunouTfssM28INQUpQ9JTQdmD3486R+GfFE7fSyWfUHh4l54bOX7 emJrB9Zs59cu0+f0iLKyGBbVlAIZdRiWjUpfHtcschkZ4RxjbJacXGJeetXVsRetoovp t8XA== X-Gm-Message-State: AOAM53158SEpxtmYmyonDW/KkWWVK1ljN231EqupnJ063hCNqbkPbq8b 0o306W5YJDSCYsZcIENbpt6KYmjVu0Ztn9XrbGE= X-Received: by 2002:a05:600c:4e16:: with SMTP id b22mr235178wmq.31.1644311434520; Tue, 08 Feb 2022 01:10:34 -0800 (PST) Received: from tsr-vdi-mbaerts.nix.tessares.net (static.23.216.130.94.clients.your-server.de. [94.130.216.23]) by smtp.gmail.com with ESMTPSA id a15sm1100237wri.22.2022.02.08.01.10.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Feb 2022 01:10:34 -0800 (PST) From: Matthieu Baerts To: mptcp@lists.linux.dev Cc: Matthieu Baerts Subject: [PATCH mptcp-next v2] selftests: mptcp: increase timeout to 20 minutes Date: Tue, 8 Feb 2022 10:10:13 +0100 Message-Id: <20220208091013.749627-1-matthieu.baerts@tessares.net> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" With the increase number of tests, one CI instance, using a debug kernel config and not recent hardware, takes around 10 minutes to execute the slowest MPTCP test: mptcp_join.sh. Even if most CIs don't take that long to execute these tests -- typically max 10 minutes to run all selftests -- it will helpi some of them if the timeout is increased. The timeout could be disabled but it is always good to have an extra safeguard, just in case. Please note that on slow public CIs with kernel debug settings, it has been observed it can easily take up to 45 minutes to execute all tests in this very slow environment with other jobs running in parallel. The slowest test, mptcp_join.sh takes ~30 minutes in this case. In such environments, the selftests timeout set in the 'settings' file is disabled because this environment is known as being exceptionnaly slow. It has been decided not to take such exceptional environments into account and set the timeout to 20min. Signed-off-by: Matthieu Baerts --- Notes: On my CI at Tessares, another machine is now used with a different host kernel. mptcp_join.sh selftest is now regularly taking more than 10 minutes when testing with a debug kernel. v2: - from 1h to 20 min (Mat) and adapt the commit message to explain why this don't cover all cases that have been observed. tools/testing/selftests/net/mptcp/settings | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/mptcp/settings b/tools/testing/sel= ftests/net/mptcp/settings index a62d2fa1275c..79b65bdf05db 100644 --- a/tools/testing/selftests/net/mptcp/settings +++ b/tools/testing/selftests/net/mptcp/settings @@ -1 +1 @@ -timeout=3D600 +timeout=3D1200 --=20 2.34.1