From nobody Mon Feb 9 12:42:32 2026 Delivered-To: wpasupplicant.patchew@gmail.com Received: by 2002:a02:b119:0:0:0:0:0 with SMTP id r25csp4642475jah; Wed, 19 Jan 2022 02:16:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJzZB+Qx9lBJBIDCfSsjANprJ+K9u79UP4QK6exLpvRzhJlwOuAPr+wVGbqXOc0Q2nZHSGlQ X-Received: by 2002:a25:4406:: with SMTP id r6mr38449377yba.180.1642587361417; Wed, 19 Jan 2022 02:16:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642587361; cv=none; d=google.com; s=arc-20160816; b=le6IoYuSSdysXQ2H0IVIadeQQqKWbivd7ShWBf+6cwc8T3nGms8Ks6ks+syUXYnQRz mxdZAIQTV8aWeBSyQC5ykGvbR1pFPcOrbtK1PWzWRuPp535tczMr6WNrSg4utLm2XaKc G0qeTfcOlVaw/LBJdfTHx1LEs8UEZGGA2QJxxC+8olUMw45QPvPfdQTaIJWZBdmahalE yJ9rJnFCivRUxSEWd5EVK+QmYGA49qMuy/wRm/ugmY6klsh4WsaMnKbspZOXdqv5tn4E CMlRWo1UyxNNXL5sJ/vPYPbWruoXykHMETcf2kBysHoKAZd7vylkysbLuNJu/32qD+q9 Kisg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=BaHsoZFWiX9mv47s4BV0uxhL1kBfcottdTr5yzS2FcM=; b=yyXihUKIQsyRp9mfTs4CVd07e4W4XsbuQKTK0eT8LNg8+YEd4mGHTdoEZ6vwJCU9A4 cp9Pm6udqG60QERVnO5Tc4EJZiGK1og0wcy7mFyC52Qyt50Rpt6lRcMy3n/0twBqKVCq GS0iuSypTTlYZyxGIJmnEQwnwNYM0fERjNwVrdC9dXdVYq9uaeCNz+o8fejkqIrARvxh 0OoHp7bX7AJBmUtGEB1q6QzT6EqZ9U6aF8JWJgSkzu0fjHSiksdchUV6thIjRafxzyaB cIX5e0xGCaQMCHQCPtRDtuaiq1wGzj6pv7yKPV8JOscOpckbU/wgZF9NYV6gKEMww6wm z52g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=WmPQKScN; spf=pass (google.com: domain of mptcp+bounces-3228-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 2604:1380:1:3600::1 as permitted sender) smtp.mailfrom="mptcp+bounces-3228-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from ewr.edge.kernel.org (ewr.edge.kernel.org. [2604:1380:1:3600::1]) by mx.google.com with ESMTPS id o131si4208282ybg.581.2022.01.19.02.16.01 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Jan 2022 02:16:01 -0800 (PST) Received-SPF: pass (google.com: domain of mptcp+bounces-3228-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 2604:1380:1:3600::1 as permitted sender) client-ip=2604:1380:1:3600::1; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=WmPQKScN; spf=pass (google.com: domain of mptcp+bounces-3228-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 2604:1380:1:3600::1 as permitted sender) smtp.mailfrom="mptcp+bounces-3228-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ewr.edge.kernel.org (Postfix) with ESMTPS id CAE801C09BD for ; Wed, 19 Jan 2022 10:16:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 652AF2CA5; Wed, 19 Jan 2022 10:15:59 +0000 (UTC) X-Original-To: mptcp@lists.linux.dev Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0ABC429CA for ; Wed, 19 Jan 2022 10:15:58 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: usama.anjum) with ESMTPSA id 4AD4A1F4442B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1642587356; bh=gjVHu+jWyShCzwYH7u0I9MtX/la4ZTeWCA5VgFyOCk0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WmPQKScNKXIubsHhUPQ0UWTMbZea42T4UR9/BPGN2ahBB8XcJiVrhQIYF6BZ5hlX0 q8gp7LUxCSQFElIffyo0lDWVGD/zC2KBugbqEh1TcLrlatMGeZfU8rimVe4dL/fbcX 6s9z2ZfRvciZcnZtAIaztjLlNW7+HElw+ZF++XYNpZYCnprNkUvvOJXvFUMri1oVTL c60tiiXFIJwZbREPLPZA6Wqzrnm+ezgrofEvBRqJOEVHxoMBzoDDzHdIvnljxq7UW1 YscwBUloUa1M8a5eTGAa8VhR0L/h5p9Vazp/3TXlZknKFvePVk6yZDZl7g0bc1CdND Xb+nwl8+gV8YA== From: Muhammad Usama Anjum To: Shuah Khan , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?UTF-8?q?Andr=C3=A9=20Almeida?= , Paolo Bonzini , =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= , "David S. Miller" , Jakub Kicinski , Mat Martineau , Matthieu Baerts , Andrew Morton , chiminghao , linux-kselftest@vger.kernel.org (open list:KERNEL SELFTEST FRAMEWORK), linux-kernel@vger.kernel.org (open list), kvm@vger.kernel.org (open list:KERNEL VIRTUAL MACHINE (KVM)), linux-security-module@vger.kernel.org (open list:LANDLOCK SECURITY MODULE), netdev@vger.kernel.org (open list:NETWORKING [GENERAL]), mptcp@lists.linux.dev (open list:NETWORKING [MPTCP]), linux-mm@kvack.org (open list:MEMORY MANAGEMENT) Cc: Muhammad Usama Anjum , kernel@collabora.com Subject: [PATCH V2 01/10] selftests: set the BUILD variable to absolute path Date: Wed, 19 Jan 2022 15:15:22 +0500 Message-Id: <20220119101531.2850400-2-usama.anjum@collabora.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220119101531.2850400-1-usama.anjum@collabora.com> References: <20220119101531.2850400-1-usama.anjum@collabora.com> Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The build of kselftests fails if relative path is specified through KBUILD_OUTPUT or O=3D method. BUILD variable is used to determine the path of the output objects. When make is run from other directories with relative paths, the exact path of the build objects is ambiguous and build fails. make[1]: Entering directory '/home/usama/repos/kernel/linux_mainline2/tool= s/testing/selftests/alsa' gcc mixer-test.c -L/usr/lib/x86_64-linux-gnu -lasound -o build/kselft= est/alsa/mixer-test /usr/bin/ld: cannot open output file build/kselftest/alsa/mixer-test Set the BUILD variable to the absolute path of the output directory. Make the logic readable and easy to follow. Use spaces instead of tabs for indentation as if with tab indentation is considered recipe in make. Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/Makefile | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Mak= efile index d08fe4cfe811..a7b63860b7bc 100644 --- a/tools/testing/selftests/Makefile +++ b/tools/testing/selftests/Makefile @@ -114,19 +114,27 @@ ifdef building_out_of_srctree override LDFLAGS =3D endif =20 -ifneq ($(O),) - BUILD :=3D $(O)/kselftest +top_srcdir ?=3D ../../.. + +ifeq ("$(origin O)", "command line") + KBUILD_OUTPUT :=3D $(O) +endif + +ifneq ($(KBUILD_OUTPUT),) + # Make's built-in functions such as $(abspath ...), $(realpath ...) cann= ot + # expand a shell special character '~'. We use a somewhat tedious way he= re. + abs_objtree :=3D $(shell cd $(top_srcdir) && mkdir -p $(KBUILD_OUTPUT) &= & cd $(KBUILD_OUTPUT) && pwd) + $(if $(abs_objtree),, \ + $(error failed to create output directory "$(KBUILD_OUTPUT)")) + # $(realpath ...) resolves symlinks + abs_objtree :=3D $(realpath $(abs_objtree)) + BUILD :=3D $(abs_objtree)/kselftest else - ifneq ($(KBUILD_OUTPUT),) - BUILD :=3D $(KBUILD_OUTPUT)/kselftest - else - BUILD :=3D $(shell pwd) - DEFAULT_INSTALL_HDR_PATH :=3D 1 - endif + BUILD :=3D $(CURDIR) + DEFAULT_INSTALL_HDR_PATH :=3D 1 endif =20 # Prepare for headers install -top_srcdir ?=3D ../../.. include $(top_srcdir)/scripts/subarch.include ARCH ?=3D $(SUBARCH) export KSFT_KHDR_INSTALL_DONE :=3D 1 --=20 2.30.2