From nobody Sun Feb 8 18:30:30 2026 Delivered-To: wpasupplicant.patchew@gmail.com Received: by 2002:a05:6638:38c:0:0:0:0 with SMTP id y12csp1899537jap; Thu, 6 Jan 2022 16:20:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJy2FPCYHF3Aa3klNjafdXams1AFlxVHVoja9S9jJHrAfgvHIUb97q5naxe2eKCN9SKR8gmg X-Received: by 2002:a25:d913:: with SMTP id q19mr308580ybg.244.1641514851992; Thu, 06 Jan 2022 16:20:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1641514851; cv=none; d=google.com; s=arc-20160816; b=zs8X+saTfIVRghe2ODgWMVvBhc612hp5rkpnV/HSkbC6VeFcyvtskOyFYEidNEUdY1 bqQ01tByIfNn5Lweu7SdCD4C0kYQCq7vrm5jildwTW2N4dKB9QuSB0OJ3TG/OIeJiKNU TEtwaXmC/1nxuEgBLej44wrQ3J7vKOktUiof5/xFysPT0Zh4WvMcSwrQhO5GN/SykTrg l1mM0mK1J1OsOu3xObSFl/W9OZXW7GE8bKkaKf2nO9uoDu5VPJABCc1F0oUPVtAdw9fD Ky559UcNw0708lqCxvtGeurOf5Limpzals6YV5D0AjwS1/2IENjbdEaEnRc9EOFWNgC2 Nz0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=1+XKtsIwhTZwoyobUIdRYulUx1q0DvRR9CTz1AKWkBo=; b=jCnph4x+ph6xP9+ggXokcntRhmfSPVWYKAh5bxtM6ja54EZwQN+V610DlmrtATaBTP go12UwcM0hwlEFXfmsOTxU3jLRqpX5TaaXEXHOTwVTv6DMorlSxGSK6oT8BTIs9VaA5a kYvEPe7LT4KR2c0PiQoR57g0yC07tzwGoxSQrf6MTY9BuXg7u1KxoJ5J9UVjws/Q22Ea HyFNC/Pyl9guwtT0rkdrRIdN/IUpAN36aFXRPPMFgAz7Q5cbNmkLrbK9JpYWOwuDZd0j jmKhjWaWU2AZIE/b/VJRpefQ63XAqOZgRHJx0/L/bmzNEFNX1WLYOTmsPOEdSV7OY2hJ FGsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=WsMIzPyz; spf=pass (google.com: domain of mptcp+bounces-2945-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 2604:1380:1:3600::1 as permitted sender) smtp.mailfrom="mptcp+bounces-2945-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ewr.edge.kernel.org (ewr.edge.kernel.org. [2604:1380:1:3600::1]) by mx.google.com with ESMTPS id r13si126595ybb.454.2022.01.06.16.20.51 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Jan 2022 16:20:51 -0800 (PST) Received-SPF: pass (google.com: domain of mptcp+bounces-2945-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 2604:1380:1:3600::1 as permitted sender) client-ip=2604:1380:1:3600::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=WsMIzPyz; spf=pass (google.com: domain of mptcp+bounces-2945-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 2604:1380:1:3600::1 as permitted sender) smtp.mailfrom="mptcp+bounces-2945-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ewr.edge.kernel.org (Postfix) with ESMTPS id 38CA71C0C58 for ; Fri, 7 Jan 2022 00:20:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B0A7F2CA8; Fri, 7 Jan 2022 00:20:49 +0000 (UTC) X-Original-To: mptcp@lists.linux.dev Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27752168 for ; Fri, 7 Jan 2022 00:20:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641514848; x=1673050848; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Wc56x3z89MoqMhqYjlsOIeQJY/RWfoCH4DjPm2rYDaM=; b=WsMIzPyzxgfZ9Jkzm2RqCwsnZmpXfl1YDdcV+/7qRNukq6nGiJgRxMDP ao+Ku1AqlPyXISd4vvHZ0ItqxrBEUUkzVDapU2yStK5LA5j9ey7gLb+YU mcGWQ92jqV9ALUqnQy/7P2aI8+zGX5wb/ic54KkSFlnWIdtwXmrL9g+Me jQa5sWg8JM81DyaiLqNEtawktt9CdbOpFwBlJRYo0aKv8lYxS31Vla+L0 1PU1dO/Qokhq3QEVMGMQooEtMORDk4RB1n/OT01U7cmKMuqFvsqXwzGf6 1FZVDN2CVs+nrsetSwK8NiNJ521O88hhOFkqGe68/j3EBBguSNVlCWoox w==; X-IronPort-AV: E=McAfee;i="6200,9189,10217"; a="329111019" X-IronPort-AV: E=Sophos;i="5.88,268,1635231600"; d="scan'208";a="329111019" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2022 16:20:34 -0800 X-IronPort-AV: E=Sophos;i="5.88,268,1635231600"; d="scan'208";a="618508492" Received: from mjmartin-desk2.amr.corp.intel.com (HELO mjmartin-desk2.intel.com) ([10.209.94.200]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2022 16:20:33 -0800 From: Mat Martineau To: netdev@vger.kernel.org Cc: Paolo Abeni , davem@davemloft.net, kuba@kernel.org, matthieu.baerts@tessares.net, mptcp@lists.linux.dev, Mat Martineau Subject: [PATCH net-next 01/13] mptcp: keep snd_una updated for fallback socket Date: Thu, 6 Jan 2022 16:20:14 -0800 Message-Id: <20220107002026.375427-2-mathew.j.martineau@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220107002026.375427-1-mathew.j.martineau@linux.intel.com> References: <20220107002026.375427-1-mathew.j.martineau@linux.intel.com> Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Paolo Abeni After shutdown, for fallback MPTCP sockets, we always have write_seq =3D=3D snd_una+1 The above will foul OUTQ ioctl(). Keep snd_una in sync with write_seq even after shutdown. Signed-off-by: Paolo Abeni Signed-off-by: Mat Martineau --- net/mptcp/protocol.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index df5a0cf431c1..f6fc0f0f66f0 100644 --- a/net/mptcp/protocol.c +++ b/net/mptcp/protocol.c @@ -2666,6 +2666,7 @@ static void __mptcp_check_send_data_fin(struct sock *= sk) * state now */ if (__mptcp_check_fallback(msk)) { + WRITE_ONCE(msk->snd_una, msk->write_seq); if ((1 << sk->sk_state) & (TCPF_CLOSING | TCPF_LAST_ACK)) { inet_sk_state_store(sk, TCP_CLOSE); mptcp_close_wake_up(sk); --=20 2.34.1