[PATCH] selftests: mptcp: Remove the deprecated config NFT_COUNTER

Ma Xinjian posted 1 patch 2 years, 3 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/20211224095928.60584-1-xinjianx.ma@intel.com
Maintainers: Jakub Kicinski <kuba@kernel.org>, Matthieu Baerts <matthieu.baerts@tessares.net>, "David S. Miller" <davem@davemloft.net>, Mat Martineau <mathew.j.martineau@linux.intel.com>, Shuah Khan <shuah@kernel.org>
tools/testing/selftests/net/mptcp/config | 1 -
1 file changed, 1 deletion(-)
[PATCH] selftests: mptcp: Remove the deprecated config NFT_COUNTER
Posted by Ma Xinjian 2 years, 3 months ago
NFT_COUNTER was removed since
390ad4295aa ("netfilter: nf_tables: make counter support built-in")
LKP/0Day will check if all configs listing under selftests are able to
be enabled properly.

For the missing configs, it will report something like:
LKP WARN miss config CONFIG_NFT_COUNTER= of net/mptcp/config

- it's not reasonable to keep the deprecated configs.
- configs under kselftests are recommended by corresponding tests.
So if some configs are missing, it will impact the testing results

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Ma Xinjian <xinjianx.ma@intel.com>
---
 tools/testing/selftests/net/mptcp/config | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/testing/selftests/net/mptcp/config b/tools/testing/selftests/net/mptcp/config
index 0faaccd21447..2b82628decb1 100644
--- a/tools/testing/selftests/net/mptcp/config
+++ b/tools/testing/selftests/net/mptcp/config
@@ -9,7 +9,6 @@ CONFIG_NETFILTER=y
 CONFIG_NETFILTER_ADVANCED=y
 CONFIG_NETFILTER_NETLINK=m
 CONFIG_NF_TABLES=m
-CONFIG_NFT_COUNTER=m
 CONFIG_NFT_COMPAT=m
 CONFIG_NETFILTER_XTABLES=m
 CONFIG_NETFILTER_XT_MATCH_BPF=m
-- 
2.20.1


Re: [PATCH] selftests: mptcp: Remove the deprecated config NFT_COUNTER
Posted by patchwork-bot+netdevbpf@kernel.org 2 years, 3 months ago
Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Fri, 24 Dec 2021 17:59:28 +0800 you wrote:
> NFT_COUNTER was removed since
> 390ad4295aa ("netfilter: nf_tables: make counter support built-in")
> LKP/0Day will check if all configs listing under selftests are able to
> be enabled properly.
> 
> For the missing configs, it will report something like:
> LKP WARN miss config CONFIG_NFT_COUNTER= of net/mptcp/config
> 
> [...]

Here is the summary with links:
  - selftests: mptcp: Remove the deprecated config NFT_COUNTER
    https://git.kernel.org/netdev/net/c/e6007b85dfa2

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html