From nobody Mon Feb 9 19:05:15 2026 Delivered-To: wpasupplicant.patchew@gmail.com Received: by 2002:a05:6638:27c:0:0:0:0 with SMTP id x28csp1072684jaq; Wed, 6 Oct 2021 21:37:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxGI2hlqJoGH4s1M/mkClOzK6Ceh4iYUk4y7O3a5vXWqaBCUaZaF0ZDIMd/+/RQOkziCu4e X-Received: by 2002:a05:622a:199c:: with SMTP id u28mr2531432qtc.342.1633581446356; Wed, 06 Oct 2021 21:37:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633581446; cv=none; d=google.com; s=arc-20160816; b=pjjoLZT7WG1gp0+wuIb76q0Do+9Vx7hqNW/YCFuVE4RkQGcFcb48RSWfTU4GWcIWt8 t3UeX4Woj9sndttuy/XMf4JP89sOUsi/Vr5LN2uiKRji0ZNoy4M1cTBiY7Paglyt8SXK OK0jd/n1xs9y+ZX30eoLNzILVbMqWTe7YTND0nnCox3wNoy1DkhoKT+YAVSxXgkOLgH8 J0rRuBOOStuvozM2UOI1eUB/vINEoCkMVA2gWF4D0YoVZpNke5uAjP6J0ibrCiT1Hkvp VwlKoLsVOCtsik1J0W1hSyDYXcCo98apkdQM3ss8EAG50knIK9ucWZ6QoNCnzA+W4dLK xjQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:to:from; bh=JHjLPVHj+VLzqB2TKlQHdVn24BLNYdkMLnWRNN9zt9c=; b=GiCH+KlGL7BKGDnNbq4lqoc/DWWhzadYOiruGojCYE2N19cXuD8xl1FoiSAywNdtwC EBfhsGjDHCaMSq0BV85QVnbhUm8oU+eHBSotvhSw47pKTAqbSt9kE+4tzIk1TpEycKex 55hbJp5Rr4xeUkIi1E5azUhRM7hFUfLojbrWpM/slJYKdUciY6XkbIY0BzQbi3rcUe66 Z69AQ6VpGbqhYVvucg8gF5CbVcYIEHtp4lltVRnUMg+1g7ldhkXvRH9YBOaiATKOtmvM iODMvcYsgb53E3d4F3N6SNFF7sYc8vRnCyBa/lKF0ikLhwn5y0aq9Y6NWG69ecgvYxuM VQmw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of mptcp+bounces-2125-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 2604:1380:1:3600::1 as permitted sender) smtp.mailfrom="mptcp+bounces-2125-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ewr.edge.kernel.org (ewr.edge.kernel.org. [2604:1380:1:3600::1]) by mx.google.com with ESMTPS id jv9si6537904qvb.35.2021.10.06.21.37.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Oct 2021 21:37:26 -0700 (PDT) Received-SPF: pass (google.com: domain of mptcp+bounces-2125-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 2604:1380:1:3600::1 as permitted sender) client-ip=2604:1380:1:3600::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of mptcp+bounces-2125-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 2604:1380:1:3600::1 as permitted sender) smtp.mailfrom="mptcp+bounces-2125-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ewr.edge.kernel.org (Postfix) with ESMTPS id 01BC21C0A97 for ; Thu, 7 Oct 2021 04:37:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BFD912C8E; Thu, 7 Oct 2021 04:37:23 +0000 (UTC) X-Original-To: mptcp@lists.linux.dev Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFAA92C88 for ; Thu, 7 Oct 2021 04:37:22 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10129"; a="249476780" X-IronPort-AV: E=Sophos;i="5.85,352,1624345200"; d="scan'208";a="249476780" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 21:37:22 -0700 X-IronPort-AV: E=Sophos;i="5.85,352,1624345200"; d="scan'208";a="568443847" Received: from otc-tsn-4.jf.intel.com ([10.23.153.135]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 21:37:22 -0700 From: Kishen Maloor To: mptcp@lists.linux.dev, mathew.j.martineau@linux.intel.com, kishen.maloor@intel.com Subject: [RFC PATCH 4/4] mptcp: selftests: MPTCP_PM_CMD_REMOVE Date: Thu, 7 Oct 2021 00:36:56 -0400 Message-Id: <20211007043656.261552-5-kishen.maloor@intel.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211007043656.261552-1-kishen.maloor@intel.com> References: <20211007043656.261552-1-kishen.maloor@intel.com> Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This change updates the "pm_nl_ctl" testing sample with a "rem" (remove) option to support the newly added netlink interface command MPTCP_PM_CMD_REMOVE to issue REMOVE_ADDR signals over the chosen MPTCP connection. E.g. ./pm_nl_ctl rem token 823274047 id 2345 Signed-off-by: Kishen Maloor --- tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+) diff --git a/tools/testing/selftests/net/mptcp/pm_nl_ctl.c b/tools/testing/= selftests/net/mptcp/pm_nl_ctl.c index 47c2667ad676..8adc370060d6 100644 --- a/tools/testing/selftests/net/mptcp/pm_nl_ctl.c +++ b/tools/testing/selftests/net/mptcp/pm_nl_ctl.c @@ -27,6 +27,7 @@ static void syntax(char *argv[]) fprintf(stderr, "%s add|get|set|del|flush|dump|accept []\n", argv[0= ]); fprintf(stderr, "\tadd [flags signal|subflow|backup|fullmesh] [id ] [= dev ] \n"); fprintf(stderr, "\tann token [port ] [id ] [dev ]\n"); + fprintf(stderr, "\trem id token "); fprintf(stderr, "\tdel []\n"); fprintf(stderr, "\tget \n"); fprintf(stderr, "\tset [flags backup|nobackup]\n"); @@ -171,6 +172,54 @@ static int resolve_mptcp_pm_netlink(int fd) return genl_parse_getfamily((void *)data); } =20 +int remove_addr(int fd, int pm_family, int argc, char *argv[]) +{ + char data[NLMSG_ALIGN(sizeof(struct nlmsghdr)) + + NLMSG_ALIGN(sizeof(struct genlmsghdr)) + + 1024]; + struct rtattr *rta; + struct nlmsghdr *nh; + u_int8_t id; + u_int32_t token; + int off =3D 0, arg; + + memset(data, 0, sizeof(data)); + nh =3D (void *)data; + off =3D init_genl_req(data, pm_family, MPTCP_PM_CMD_REMOVE, + MPTCP_PM_VER); + + if (argc < 6) + syntax(argv); + + for (arg =3D 2; arg < argc; arg++) { + if (!strcmp(argv[arg], "id")) { + if (++arg >=3D argc) + error(1, 0, " missing id value"); + + id =3D atoi(argv[arg]); + rta =3D (void *)(data + off); + rta->rta_type =3D MPTCP_PM_ATTR_LOC_ID; + rta->rta_len =3D RTA_LENGTH(1); + memcpy(RTA_DATA(rta), &id, 1); + off +=3D NLMSG_ALIGN(rta->rta_len); + } else if (!strcmp(argv[arg], "token")) { + if (++arg >=3D argc) + error(1, 0, " missing token value"); + + token =3D atoi(argv[arg]); + rta =3D (void *)(data + off); + rta->rta_type =3D MPTCP_PM_ATTR_TOKEN; + rta->rta_len =3D RTA_LENGTH(4); + memcpy(RTA_DATA(rta), &token, 4); + off +=3D NLMSG_ALIGN(rta->rta_len); + } else + error(1, 0, "unknown keyword %s", argv[arg]); + } + + do_nl_req(fd, nh, off, 0); + return 0; +} + int announce_addr(int fd, int pm_family, int argc, char *argv[]) { char data[NLMSG_ALIGN(sizeof(struct nlmsghdr)) + @@ -865,6 +914,8 @@ int main(int argc, char *argv[]) return add_addr(fd, pm_family, argc, argv); else if (!strcmp(argv[1], "ann")) return announce_addr(fd, pm_family, argc, argv); + else if (!strcmp(argv[1], "rem")) + return remove_addr(fd, pm_family, argc, argv); else if (!strcmp(argv[1], "del")) return del_addr(fd, pm_family, argc, argv); else if (!strcmp(argv[1], "flush")) --=20 2.31.1