From nobody Mon Feb 9 09:09:12 2026 Delivered-To: wpasupplicant.patchew@gmail.com Received: by 2002:a05:6638:27c:0:0:0:0 with SMTP id x28csp886079jaq; Wed, 6 Oct 2021 17:00:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZQuN6Z9YwDKZCiskMKVeteY8IOSrE74m0BJCDvSt/aeGrTOYKbORcTjfVskZEtBHK1MkH X-Received: by 2002:a05:6808:10b:: with SMTP id b11mr820735oie.162.1633564812338; Wed, 06 Oct 2021 17:00:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633564812; cv=none; d=google.com; s=arc-20160816; b=QqP5NNxSjjWxtLk5dhIFJppfJCcGUKOfowW4CTfyBkjouLSwNNI8qXSBufx4w43/Lh uookARtKLW+HohQjprh6B5Nk2Jfu0Tg+V1U7BzR6sGNyaXify27fOH52xpKWoN3iNLk9 W/cvEDdkJzKs/TGY2M/xpZlTWmuSGsB7A0qAARRZH6d285OZyBfUtDOXZD7FaFuHW4Ct 5ZV3ISO3hIc8LJke+uQQA01wc+9Ar9Yu0FdibvyDWThI/7Dqav8ts5HkoSYizm/qvBzn aTb3WX1lv6etdQIQ+qoPTAPi9qVSRKCc1A/BL2/Ty88vwpPdEb31+jCOwJ7gyfrxxFpy 3vaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=8fSQzzOVe8d2HqiFtvB9QUfGb2/QANKYhyEXU/bVYrw=; b=wcajH5uBqUL56ZZGtcTARPO8hVXFqWVBpiD1idFz0xkxRTCgYoWZdRsYkm0Npby95V yPJkLYlt1hEL0Cyzh97OSqa/W6aJE1EsZv8chch/PkjKtOcFEEgXgFfCjN7zNVpSBRLx XiNx1GkYXstQOpW5TyqP9i7wxII3350+dJZSWNldGcD/eBkipQIP9xhtNqqnDH3Cw4LS 4WEe8zHPPW/dA6CwCnRDV8RP7Lmafl1PtHf0mH4Npd+GhPXHjiRTfPtUw9/3wPjLBbQ9 BRWOy+2XzYuNEL2hzVselmT2tFnWCBqZ2++Nu06eaH04DuQuiNy4UV3ZtaN6BUGRX4yB Kvmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of mptcp+bounces-2117-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 147.75.69.165 as permitted sender) smtp.mailfrom="mptcp+bounces-2117-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sjc.edge.kernel.org (sjc.edge.kernel.org. [147.75.69.165]) by mx.google.com with ESMTPS id 2si4141814otx.78.2021.10.06.17.00.11 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Oct 2021 17:00:11 -0700 (PDT) Received-SPF: pass (google.com: domain of mptcp+bounces-2117-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 147.75.69.165 as permitted sender) client-ip=147.75.69.165; Authentication-Results: mx.google.com; spf=pass (google.com: domain of mptcp+bounces-2117-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 147.75.69.165 as permitted sender) smtp.mailfrom="mptcp+bounces-2117-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sjc.edge.kernel.org (Postfix) with ESMTPS id E512B3E0EDA for ; Thu, 7 Oct 2021 00:00:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5E01F2C96; Thu, 7 Oct 2021 00:00:09 +0000 (UTC) X-Original-To: mptcp@lists.linux.dev Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5259A2C93 for ; Thu, 7 Oct 2021 00:00:08 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10129"; a="226439239" X-IronPort-AV: E=Sophos;i="5.85,352,1624345200"; d="scan'208";a="226439239" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 16:59:59 -0700 X-IronPort-AV: E=Sophos;i="5.85,352,1624345200"; d="scan'208";a="560351289" Received: from mjmartin-desk2.amr.corp.intel.com (HELO mjmartin-desk2.intel.com) ([10.209.0.106]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 16:59:59 -0700 From: Mat Martineau To: mptcp@lists.linux.dev Cc: Mat Martineau , kishen.maloor@intel.com Subject: [RFC PATCH 5/6] DO-NOT-MERGE: debug: mptcp: Warn on use of in-kernel PM functions Date: Wed, 6 Oct 2021 16:59:52 -0700 Message-Id: <20211006235953.212243-6-mathew.j.martineau@linux.intel.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211006235953.212243-1-mathew.j.martineau@linux.intel.com> References: <20211006235953.212243-1-mathew.j.martineau@linux.intel.com> Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Double-check that all relevant call sites are filtered when sockets are managed by userspace. Signed-off-by: Mat Martineau --- net/mptcp/pm_netlink.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c index 434049836707..affa84099bdd 100644 --- a/net/mptcp/pm_netlink.c +++ b/net/mptcp/pm_netlink.c @@ -468,6 +468,8 @@ static void mptcp_pm_create_subflow_or_signal_addr(stru= ct mptcp_sock *msk) struct pm_nl_pernet *pernet; unsigned int subflows_max; =20 + WARN_ON_ONCE(READ_ONCE(msk->pm.userspace)); + pernet =3D net_generic(sock_net(sk), pm_nl_pernet_id); =20 add_addr_signal_max =3D mptcp_pm_get_add_addr_signal_max(msk); @@ -700,6 +702,8 @@ static void mptcp_pm_nl_rm_addr_or_subflow(struct mptcp= _sock *msk, =20 msk_owned_by_me(msk); =20 + WARN_ON_ONCE(READ_ONCE(msk->pm.userspace)); + if (!rm_list->nr) return; =20 @@ -1244,6 +1248,8 @@ static bool mptcp_pm_remove_anno_addr(struct mptcp_so= ck *msk, struct mptcp_rm_list list =3D { .nr =3D 0 }; bool ret; =20 + WARN_ON_ONCE(READ_ONCE(msk->pm.userspace)); + list.ids[list.nr++] =3D addr->id; =20 ret =3D remove_anno_list_by_saddr(msk, addr); --=20 2.33.0