From nobody Thu Mar 28 18:22:27 2024 Delivered-To: wpasupplicant.patchew@gmail.com Received: by 2002:a02:b119:0:0:0:0:0 with SMTP id r25csp524425jah; Thu, 13 Jan 2022 10:35:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJxqjKRnnF5jCmw7L9e0FGf79VvVZK3Cr1PJoUg5z3BwHKcK4Soi8fVdIpGfdC0pHrhu0JsU X-Received: by 2002:a05:622a:28b:: with SMTP id z11mr4750627qtw.165.1642098903904; Thu, 13 Jan 2022 10:35:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642098903; cv=none; d=google.com; s=arc-20160816; b=ga1W/Q+b/srANhxjLV6jc+7Cqpgz8S1tGReQlU7cii1mJfgU1zqijU4ZMBY/UR88U8 QN2deu6s7N1zSRQVbViDYFKcfPHBPPdJDLYTMJhuxO0BhEiN4Cv3WjObEjavDh5ZNMmV lMM4yRppXHBKsdSZD/qYLd7v84Au58hevozk8Llgk3KurvWmXJBY5d7XY0IFgW3ztP3h K9frLLa7HPYphbhEhAquarCTO1imczBwwqjpMbCAKFBqwNGLRYkSBIaGVuGreLS851pI euuL4y5k8bllC1TSsgwg+L8CMBOTCKfuYY46UbIBt1NnQRDy6eX/nIHyCbty7pCe4XRT 3fiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:to:from :dkim-signature; bh=FLMN7lrMADjOTKt9ZU4MyMsE4HFLUoxf6OrIDRNHpcA=; b=FMLTIMahAZNFwQtgnj0H1C0NRy+Z4sJvCHhwi0bbYWdUH9Dy5CNYQGDbqPm8REqZSV UleuYGOuDK6o+WmBSPZqJijnbyeBWvS+SsHv5CKn5ICaQJgKzMVMdukku64jB7xZixH7 zdG9cq1qPecDhVeqLmBCL98XwyNyOruJvB5KQk5aqj/GHGJjcj3oW2s4V6HH7kHVNbLG UyKPBS3sOIZnI5TXCSeEXUftRnPgUHNal1EPIlt8Y1k8fY1XZjgOUgE57B8hXpDpAmeF btWu9a4nNaFR2ebMqR7PzvaPj1BiMPBA0Gons2lK4ZnQiIwGLMkwsVJ8gmmJsXSnyFYp nI4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Xhqlt1rZ; spf=pass (google.com: domain of mptcp+bounces-3128-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 2604:1380:1:3600::1 as permitted sender) smtp.mailfrom="mptcp+bounces-3128-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from ewr.edge.kernel.org (ewr.edge.kernel.org. [2604:1380:1:3600::1]) by mx.google.com with ESMTPS id t16si1361991qvp.147.2022.01.13.10.35.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jan 2022 10:35:03 -0800 (PST) Received-SPF: pass (google.com: domain of mptcp+bounces-3128-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 2604:1380:1:3600::1 as permitted sender) client-ip=2604:1380:1:3600::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Xhqlt1rZ; spf=pass (google.com: domain of mptcp+bounces-3128-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 2604:1380:1:3600::1 as permitted sender) smtp.mailfrom="mptcp+bounces-3128-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ewr.edge.kernel.org (Postfix) with ESMTPS id 415481C0AB4 for ; Thu, 13 Jan 2022 18:35:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DBB3C2CA1; Thu, 13 Jan 2022 18:35:01 +0000 (UTC) X-Original-To: mptcp@lists.linux.dev Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EF452C9C for ; Thu, 13 Jan 2022 18:35:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642098899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FLMN7lrMADjOTKt9ZU4MyMsE4HFLUoxf6OrIDRNHpcA=; b=Xhqlt1rZ8SCJXutri8Imy8uH8h111sWRalDV6X9no4I5D6hoRK7Io1AAKa4iBrKNzs1O9O xJl1poQgDdrtsgKxstJDsiw87L/0Ksky14G97+g2JQtOyxb9SxRfzGTDxT2QroEY9Hslby yKKTbzNNkD90AsIAX9IMZRpyfd9qDFM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-487-je-ztOa3PwO-ZswscL5DDg-1; Thu, 13 Jan 2022 13:34:58 -0500 X-MC-Unique: je-ztOa3PwO-ZswscL5DDg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 839931966340 for ; Thu, 13 Jan 2022 18:34:57 +0000 (UTC) Received: from gerbillo.redhat.com (unknown [10.39.193.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id E72553491F for ; Thu, 13 Jan 2022 18:34:56 +0000 (UTC) From: Paolo Abeni To: mptcp@lists.linux.dev Subject: [PATCH mptcp-net] selftests: mptcp: fix ipv6 routing setup Date: Thu, 13 Jan 2022 19:34:50 +0100 Message-Id: <059912660c7f5973da40413a9384bad542047013.1642098123.git.pabeni@redhat.com> Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pabeni@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" MPJ ipv6 selftests currently lack per link route to the server net. Additionally, ipv6 subflows endpoints are created without any interface specified. The end-result is that in ipv6 self-tests subflows are created all on the same link, leading to expected delays and sporadic self-tests failures. Fix the issue by adding the missing setup bits. Fixes: 523514ed0a99 ("selftests: mptcp: add ADD_ADDR IPv6 test cases") Signed-off-by: Paolo Abeni Reviewed-by: Mat Martineau --- tools/testing/selftests/net/mptcp/mptcp_join.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testin= g/selftests/net/mptcp/mptcp_join.sh index e48ce23d2386..2be3cad4b52b 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh @@ -76,6 +76,7 @@ init() =20 # let $ns2 reach any $ns1 address from any interface ip -net "$ns2" route add default via 10.0.$i.1 dev ns2eth$i metric 10$i + ip -net "$ns2" route add default via dead:beef:$i::1 dev ns2eth$i metric= 10$i done } =20 @@ -1510,7 +1511,7 @@ ipv6_tests() reset ip netns exec $ns1 ./pm_nl_ctl limits 0 1 ip netns exec $ns2 ./pm_nl_ctl limits 0 1 - ip netns exec $ns2 ./pm_nl_ctl add dead:beef:3::2 flags subflow + ip netns exec $ns2 ./pm_nl_ctl add dead:beef:3::2 dev ns2eth3 flags subfl= ow run_tests $ns1 $ns2 dead:beef:1::1 0 0 0 slow chk_join_nr "single subflow IPv6" 1 1 1 =20 @@ -1545,7 +1546,7 @@ ipv6_tests() ip netns exec $ns1 ./pm_nl_ctl limits 0 2 ip netns exec $ns1 ./pm_nl_ctl add dead:beef:2::1 flags signal ip netns exec $ns2 ./pm_nl_ctl limits 1 2 - ip netns exec $ns2 ./pm_nl_ctl add dead:beef:3::2 flags subflow + ip netns exec $ns2 ./pm_nl_ctl add dead:beef:3::2 dev ns2eth3 flags subfl= ow run_tests $ns1 $ns2 dead:beef:1::1 0 -1 -1 slow chk_join_nr "remove subflow and signal IPv6" 2 2 2 chk_add_nr 1 1 --=20 2.33.1