From nobody Sun Feb 8 22:57:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1677853804; cv=none; d=zohomail.com; s=zohoarc; b=kCittS8sXR25AwINyG7/osKd1P1MdyT+u4RWVzvSR1qS3+NoYE1Jw7m43VLyh2+ROhHDF6PWmpKODcsT1zz8D3cUOonNXg4F+ABpcSNk0xXKNnGYCbnhdZ8BMq8Rgw29w0xMZC0BkBOg6CFd7Wg5ndATqSDXvTn7SQsVYXHVocY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1677853804; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0P3xCx8LhBW+LiUvjr2O59k7vU6+bhWu1zQjOEEj7GE=; b=IRMkou3BkGkqbRKSI+wLAkl3M3LnjTp3ex1Wl2ksu6Q8pm2XTtP+3JSSAW/Cg6f9H/zQFMM2wJIOQJ/FrOSjB7QPiJDqrhBIZhDinKgzusDSidRlgOXEjq9s5eVt0e4JAQHGM3BqYHdVygPMwGdIU3cuGP++MsQZcOQs1ZREkxw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1677853804889890.1453862942161; Fri, 3 Mar 2023 06:30:04 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-314-6ww7nU4-PE-8khL0nDuK1A-1; Fri, 03 Mar 2023 09:29:07 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EFB3C100F913; Fri, 3 Mar 2023 14:29:02 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9FB72440DD; Fri, 3 Mar 2023 14:29:02 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9060E194A7CE; Fri, 3 Mar 2023 14:28:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 5D53419465A0 for ; Fri, 3 Mar 2023 14:28:24 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 3EF7D404BEC8; Fri, 3 Mar 2023 14:28:24 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id BB478404BEC6 for ; Fri, 3 Mar 2023 14:28:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677853803; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=0P3xCx8LhBW+LiUvjr2O59k7vU6+bhWu1zQjOEEj7GE=; b=ciwDB6aGnUcAyY5G1goaKiGunX6HtqYiZ+7JiuA02kTODO4aMgtVw2jjwJ+YTkxJfSsWcU X2sN77eEy6PEEcDpyX3X2XLGnKVBdrYelzUHB7DsTlrsRvDgKIZwRVcxrR8tKFy+ojQWY7 3caw4HlctGECC84zLtd0i0yMjEH44dw= X-MC-Unique: 6ww7nU4-PE-8khL0nDuK1A-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 18/31] qemu: capabilities: Remove return value from virQEMUCapsAccelCopy Date: Fri, 3 Mar 2023 15:27:52 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1677853805197100001 Content-Type: text/plain; charset="utf-8" The function now always returns 0. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 5341f5c1da..aba52cc10d 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -1959,7 +1959,7 @@ virQEMUCapsAccelCopyMachineTypes(virQEMUCapsAccel *ds= t, } -static int +static void virQEMUCapsAccelCopy(virQEMUCapsAccel *dst, virQEMUCapsAccel *src) { @@ -1968,8 +1968,6 @@ virQEMUCapsAccelCopy(virQEMUCapsAccel *dst, virQEMUCapsHostCPUDataCopy(&dst->hostCPU, &src->hostCPU); dst->cpuModels =3D qemuMonitorCPUDefsCopy(src->cpuModels); - - return 0; } @@ -1998,10 +1996,9 @@ virQEMUCaps *virQEMUCapsNewCopy(virQEMUCaps *qemuCap= s) ret->arch =3D qemuCaps->arch; ret->cpuData =3D virCPUDataNewCopy(qemuCaps->cpuData); - if (virQEMUCapsAccelCopy(&ret->kvm, &qemuCaps->kvm) < 0 || - virQEMUCapsAccelCopy(&ret->hvf, &qemuCaps->hvf) < 0 || - virQEMUCapsAccelCopy(&ret->tcg, &qemuCaps->tcg) < 0) - return NULL; + virQEMUCapsAccelCopy(&ret->kvm, &qemuCaps->kvm); + virQEMUCapsAccelCopy(&ret->hvf, &qemuCaps->hvf); + virQEMUCapsAccelCopy(&ret->tcg, &qemuCaps->tcg); ret->gicCapabilities =3D g_new0(virGICCapability, qemuCaps->ngicCapabi= lities); ret->ngicCapabilities =3D qemuCaps->ngicCapabilities; --=20 2.39.2