From nobody Mon Feb 2 07:30:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1769611785; cv=none; d=zohomail.com; s=zohoarc; b=awFOL86V+i6AZsjneMn6bVLcINnbDdhoSTKKu60Us24l2HyKhRKAPB0zDMcfRTOLX0VSdtrMjF79JxXnPy6GxAj0YpRcvP32LRiYe6Xe0OcIk8a8n1OBfPcXr3FC4bSEJoHAASXZz7NAXKnYgnxI/bfGTfrhhmE4xhLHXbKa1yo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769611785; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=iksSlpLfge8Q2js8310W6/rPGaF4rWFENHguOpKWJ+4=; b=dYO5Y64/OjLM2SRFQDbCkjAZycFKdMilS6VUAiFymsJto8ICh5sS/cztzmll6NU+7OvtOrTIGihF7oVWme7oYpaF3fjusg1Emo5IKU/a81L1ZFJf695XoyRYrjLti2MI34N4WlO6ELbYkh3yQxAHMtwqAUX6KArzl0De43TydJg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1769611785614158.23079171125448; Wed, 28 Jan 2026 06:49:45 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 1017D3F83A; Wed, 28 Jan 2026 09:49:45 -0500 (EST) Received: from [172.19.199.3] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 9454943E01; Wed, 28 Jan 2026 09:35:24 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 6FE6343DBB; Wed, 28 Jan 2026 09:35:21 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id B4DDE43E6D for ; Wed, 28 Jan 2026 09:31:05 -0500 (EST) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-437-FlFkLpH-OdW-iGWeBjQdYA-1; Wed, 28 Jan 2026 09:31:03 -0500 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DEB8D1955DA7 for ; Wed, 28 Jan 2026 14:31:02 +0000 (UTC) Received: from moe (unknown [10.43.3.236]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4756819541AA for ; Wed, 28 Jan 2026 14:31:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769610665; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iksSlpLfge8Q2js8310W6/rPGaF4rWFENHguOpKWJ+4=; b=UBDajWWIu0ImOrxSUmg8hBerYJn1+q/8JfO7edDat9ElGILbtCnTMYI9Wmf/C0N7WsWpJl IKw1t5TQ/meTXGp3dRpv0A69+ORzEVw+PsDEfvg9Cy6xZftfkgVtPoYLePwezIToMpHBxT Bpb4phxX68Ty7ZO4qIe7iJ0hs0ixKHw= X-MC-Unique: FlFkLpH-OdW-iGWeBjQdYA-1 X-Mimecast-MFC-AGG-ID: FlFkLpH-OdW-iGWeBjQdYA_1769610663 To: devel@lists.libvirt.org Subject: [PATCH 16/20] networkxml2xmltest: Store parsed def for future tests Date: Wed, 28 Jan 2026 15:30:37 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: oNZ8omRixL7MYRuLuN77VJn7FmEIoiNdF5Iv8Ap1Yuo_1769610663 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: QJ62IQ2WNKKKDILERJKLD7QDZAD5U6BJ X-Message-ID-Hash: QJ62IQ2WNKKKDILERJKLD7QDZAD5U6BJ X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1769611788818154100 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik Soon, the testRun() will run more than one test case. The input network XML, however, stays the same. Instead of parsing it and throwing away immediately, store it temporarily. Signed-off-by: Michal Privoznik --- tests/networkxml2xmltest.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tests/networkxml2xmltest.c b/tests/networkxml2xmltest.c index e90b38088a..4a4cf329e4 100644 --- a/tests/networkxml2xmltest.c +++ b/tests/networkxml2xmltest.c @@ -27,6 +27,7 @@ struct _testInfo { unsigned int flags; testCompareNetXML2XMLResult expectResult; virNetworkXMLOption *xmlopt; /* borrowed, immutable */ + virNetworkDef *def; char *inxml; char *outxml; }; @@ -40,6 +41,7 @@ void testInfoFree(testInfo *info) if (!info) return; =20 + virNetworkDefFree(info->def); VIR_FREE(info->inxml); VIR_FREE(info->outxml); VIR_FREE(info); @@ -52,23 +54,23 @@ testCompareXMLToXMLFiles(const void *data) g_autofree char *actual =3D NULL; int ret; testCompareNetXML2XMLResult result =3D TEST_COMPARE_NET_XML2XML_RESULT= _SUCCESS; - g_autoptr(virNetworkDef) dev =3D NULL; + g_autoptr(virNetworkDef) def =3D NULL; =20 - if (!(dev =3D virNetworkDefParse(NULL, info->inxml, info->xmlopt, fals= e))) { + if (!(def =3D virNetworkDefParse(NULL, info->inxml, info->xmlopt, fals= e))) { result =3D TEST_COMPARE_NET_XML2XML_RESULT_FAIL_PARSE; goto cleanup; } if (info->expectResult =3D=3D TEST_COMPARE_NET_XML2XML_RESULT_FAIL_PAR= SE) goto cleanup; =20 - if (networkValidateTests(dev) < 0) { + if (networkValidateTests(def) < 0) { result =3D TEST_COMPARE_NET_XML2XML_RESULT_FAIL_VALIDATE; goto cleanup; } if (info->expectResult =3D=3D TEST_COMPARE_NET_XML2XML_RESULT_FAIL_VAL= IDATE) goto cleanup; =20 - if (!(actual =3D virNetworkDefFormat(dev, info->xmlopt, info->flags)))= { + if (!(actual =3D virNetworkDefFormat(def, info->xmlopt, info->flags)))= { result =3D TEST_COMPARE_NET_XML2XML_RESULT_FAIL_FORMAT; goto cleanup; } @@ -88,6 +90,8 @@ testCompareXMLToXMLFiles(const void *data) if (info->expectResult !=3D TEST_COMPARE_NET_XML2XML_RESULT_SUCCES= S) { VIR_TEST_DEBUG("Got expected failure code=3D%d msg=3D%s", result, virGetLastErrorMessage()); + } else { + info->def =3D g_steal_pointer(&def); } } else { ret =3D -1; --=20 2.52.0