From nobody Sun Feb 8 05:47:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1635867006; cv=none; d=zohomail.com; s=zohoarc; b=O0v+egt57Lll5ScwB51vbzz5J9M28gY5MlBMBmTdsgp6DQgPDijXUfWQiwtOGKIHX+xPgWEPrxH6Kw8UnNCm0xIXqBlJqmNd/pqUCifa+/dDrJJ9mM0mscu+kQKh/PceGBcsEzekMjRuSZpdK6/Ujklry1ww6WXCBIB0n7sJL0k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635867006; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ayov1WGctmXksa/z/k5vCvqiNsA0K6U1izVRn16V6Ik=; b=UT9Qj9k8YStCxX1aU7Xm72vLcqJUx2sr+pzMMxFGaYtviKX3Cwz4Ax4y9cZTeH7Fhk/YFkjBkF3abokg+3l3+zvSyPVrgDuxRJeDLoREdCzLP4izQZjMb3PKRMwNZgWxxLIXSXt1gaZXKi7rpldFxiAeVNaVnbYUxB+g6jsTwq0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 163586700618197.1043672046377; Tue, 2 Nov 2021 08:30:06 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-98-RjFXo7sVMy69lTeudt-IoA-1; Tue, 02 Nov 2021 11:30:02 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 79BC357232; Tue, 2 Nov 2021 15:29:54 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4F31E9D2C0; Tue, 2 Nov 2021 15:29:54 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1C4D9181A1D0; Tue, 2 Nov 2021 15:29:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1A2FSMnT030337 for ; Tue, 2 Nov 2021 11:28:22 -0400 Received: by smtp.corp.redhat.com (Postfix) id E775419811; Tue, 2 Nov 2021 15:28:21 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTP id 71ED41346F for ; Tue, 2 Nov 2021 15:28:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635867005; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ayov1WGctmXksa/z/k5vCvqiNsA0K6U1izVRn16V6Ik=; b=fIPQEHwoWR3e8ZwNl3DxqFAOOsE6XgCZLwvnFu+KinWe1/Sibc8fAwRwkOm5mdxyQM9lt0 +OyFCHjpYzilC+yvoF5noD/fn3ytlVYChPcG+aG/nfCV+uCOoY9ssRuFyPfWSyyUp1XHpJ E+T4UtHcjje2gJ1Rj/2N2jsfJmN5Q60= X-MC-Unique: RjFXo7sVMy69lTeudt-IoA-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 6/7] qemu: always assume QEMU_CAPS_SPICE_UNIX Date: Tue, 2 Nov 2021 16:27:57 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1635867008286100001 The presence of this capability depends on QEMU being compiled with spice that has the SPICE_ADDR_FLAG_UNIX_ONLY constant. It was added by spice commit 5365caeaae released in spice v0.12.6, which is older than the spice version on our supported architectures. Signed-off-by: J=C3=A1n Tomko --- src/qemu/qemu_validate.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index c4384dbe8b..397eea5ede 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -4037,15 +4037,6 @@ qemuValidateDomainDeviceDefSPICEGraphics(const virDo= mainGraphicsDef *graphics, } =20 switch (glisten->type) { - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET: - if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_SPICE_UNIX)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("unix socket for spice graphics are not suppo= rted " - "with this QEMU")); - return -1; - } - break; - case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS: case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK: if (tlsPort > 0 && !cfg->spiceTLS) { @@ -4056,6 +4047,7 @@ qemuValidateDomainDeviceDefSPICEGraphics(const virDom= ainGraphicsDef *graphics, } break; =20 + case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET: case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NONE: break; case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_LAST: --=20 2.31.1