From nobody Sun Feb 8 21:11:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1625148264; cv=none; d=zohomail.com; s=zohoarc; b=XxTopb8jimAbVNhQ4KYmTXJNLBRmDc/yt9ZfblIFTefk0EFs6OYa/FXqNAvC5MQb6mOSbAVNcF083YUh84u8bGQ1y5VIrJ80HmvD5Bl367Iafr5twSylw50R4jNtCyu0C6GR9WCw0b4NcVJvoNLzFfE/eQwtgswKWrXuSqZY/rY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625148264; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=A6shp9sDh1s4FqiNC+NuT/dwXMWT6MQeMgehUTGTebg=; b=EI4K9ZduzyMIPiVUCczlGn71lNHNC5XknRVqZF64HqZOEJGAeMGvKuTHUx/ehkkSW3BlCaIFBh+SJkeNA6yA3z5R2dIaNwEoH3l2KZ+0hCGPcRwq3+sAXzS8ACiui+FPlOYgo5EUqc5/lpl1WuJObr5MRRQRodP8BUIve+jcORw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1625148264388457.32631880419353; Thu, 1 Jul 2021 07:04:24 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-132-L97tfKTpOIyJqS9Z50pi0A-1; Thu, 01 Jul 2021 10:04:20 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C75E6101999D; Thu, 1 Jul 2021 14:04:14 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9F4B85DF36; Thu, 1 Jul 2021 14:04:14 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A8E214EA2A; Thu, 1 Jul 2021 14:04:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 161E4BIH032465 for ; Thu, 1 Jul 2021 10:04:11 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8165F2C6EE; Thu, 1 Jul 2021 14:04:11 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id D73E05F9B7 for ; Thu, 1 Jul 2021 14:04:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625148263; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=A6shp9sDh1s4FqiNC+NuT/dwXMWT6MQeMgehUTGTebg=; b=EV0Vr2haKPqotOAveo5xEcbICBhdmZEaKsAir/hH/aIvGPvI2J2WfY3qrzgPuPltHvH0TK F3vm21L/ObX4+iXxMGbtfkeTstnERa9bF2cLu6Zq3tRHfTBeL6uizn5PwAmp/+CwzptEU6 7GAwoUhjX3JQL+4g7wnGFjZzamf6aVs= X-MC-Unique: L97tfKTpOIyJqS9Z50pi0A-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 3/3] virDomainSetBlockThreshold: Document that two events are fired when index isn't used Date: Thu, 1 Jul 2021 16:03:58 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Libvirt started emitting two threshold events, once with index and once withouth when the index isn't registered. Document this caveat. Signed-off-by: Peter Krempa --- src/libvirt-domain.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 750e32f0ca..0a7d2dd234 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -12637,6 +12637,10 @@ int virDomainGetGuestInfo(virDomainPtr domain, * live VM XML for 'backingStore' or 'source' elements of a disk. If index= is * given the threshold is set for the corresponding image. * + * In case when @dev does not contain index the + * VIR_DOMAIN_EVENT_ID_BLOCK_THRESHOLD event may be emitted twice, once fo= r the + * disk device target without index and once containing the index. + * * Note that the threshold event can be registered also for destinations o= f a * 'virDomainBlockCopy' destination by using the 'index' of the 'mirror' s= ource. * --=20 2.31.1