From nobody Mon Feb 9 01:20:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1639421040; cv=none; d=zohomail.com; s=zohoarc; b=lIkXCC9OClInV3Ox7ARgtb7XRcgqwSFSGjmssNr/1zRsSTlrAD8LtXNsiIMVubVE+SH+bqa8sh6fOxCa9j8wvxg0zt+dQ1GmD0z1Qx9r/DuacNXSOT9xbduxpCcMjSl1Un2a9uwE+GI0TE7jTEoptLY6ypQLk75B4jFmdyVVMJk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1639421040; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=KPwmiadrLF8AS7DloUp93BN6Goe/QA/QciDk2sJGiNE=; b=DSYksT5el1WUqlYTWxV6v9S0nwD/errUCE7x2JXdvPlkCsuoipmqoob3fWntm2R7LziUTWkNSVKbJHl58wtuLzZ3yFBXBMLD5EzFzR9J92X8/ILXA6S7jC8LOtGEpjbkEv5tnONoB1PT5an+LGYKyHVsRMWR/dGB8yK0ShYYae0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1639421040092874.5918862144586; Mon, 13 Dec 2021 10:44:00 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-226-n7dXcU3WPXaXOIV9mE_3AA-1; Mon, 13 Dec 2021 13:43:55 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DEF21185303C; Mon, 13 Dec 2021 18:43:44 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C361B45D8F; Mon, 13 Dec 2021 18:43:44 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5D0DD1809CBA; Mon, 13 Dec 2021 18:43:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1BDIhKBb003835 for ; Mon, 13 Dec 2021 13:43:20 -0500 Received: by smtp.corp.redhat.com (Postfix) id 1290E60C17; Mon, 13 Dec 2021 18:43:20 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8E3C560C04 for ; Mon, 13 Dec 2021 18:43:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639421039; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=KPwmiadrLF8AS7DloUp93BN6Goe/QA/QciDk2sJGiNE=; b=i3gAho1X3RO0NAhqQ1nCDT8MWaCTTI8HOlxbmqJgNNxro+0XNmrwIKp2jskDDc9odpEclc 8fuajesB4TPmAkU7pfimEnabe8DjNGljhBLND9PBNRii74iDV06l5ffkExLA1FLRFWJF2c seRHeV9Yc0qvjFWCSDYFyZf4hHlsxhg= X-MC-Unique: n7dXcU3WPXaXOIV9mE_3AA-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 06/20] openvz: refactor openvzSetDiskQuota Date: Mon, 13 Dec 2021 19:42:58 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1639421041290100008 Signed-off-by: J=C3=A1n Tomko --- src/openvz/openvz_driver.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index c4fa83f4c6..073de66611 100644 --- a/src/openvz/openvz_driver.c +++ b/src/openvz/openvz_driver.c @@ -196,13 +196,12 @@ openvzSetDiskQuota(virDomainDef *vmdef, virDomainFSDef *fss, bool persist) { - int ret =3D -1; unsigned long long sl, hl; - virCommand *cmd =3D virCommandNewArgList(VZCTL, - "--quiet", - "set", - vmdef->name, - NULL); + g_autoptr(virCommand) cmd =3D virCommandNewArgList(VZCTL, + "--quiet", + "set", + vmdef->name, + NULL); if (persist) virCommandAddArg(cmd, "--save"); =20 @@ -220,18 +219,14 @@ openvzSetDiskQuota(virDomainDef *vmdef, } else if (fss->space_soft_limit) { virReportError(VIR_ERR_INVALID_ARG, "%s", _("Can't set soft limit without hard limit")); - goto cleanup; + return -1; } =20 if (virCommandRun(cmd, NULL) < 0) - goto cleanup; + return -1; } =20 - ret =3D 0; - cleanup: - virCommandFree(cmd); - - return ret; + return 0; } =20 =20 --=20 2.31.1