From nobody Tue Feb 10 07:21:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1632719288; cv=none; d=zohomail.com; s=zohoarc; b=CUwcZZs1wLdB32MhtKqD1K0Oq8OTJ3PibfolBJQRRhaS3hacqxBrPmPXaCfQ1zBRmxE52nkx8tEOGJRKDxGaM0BrTRzGL4YOJo/rU3MTtc7fRlnSWQVogEAd4nSBup1Cc3ZTHGcBrkcdn0ze/9NMXUCkuRxgU6OQNsNa97qpZ8U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1632719288; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=YgrTFd6/fXfU+L+EDc8N4vqLJh07qFDZPkrsYUVLNIE=; b=jhxftGWe0Go/sAVQbGqv6qbQzv/Pj44t664pLT2i4l+VcvwaLeCH+Gox0uM2oAC3XFGvqsU6cL9hCdM7CqVVMo40rkht9xPtBTnf+Pf3Bkr04nz5TDO/zPJj/QDxED7LPkKVbsK0Hy8MT6r/i9TBRX+NCPxstZpqP6MxYyN0yk8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1632719288114663.0072613693129; Sun, 26 Sep 2021 22:08:08 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-100-f8Flp4CUNyutDiNzi4JIKA-1; Mon, 27 Sep 2021 01:08:05 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DEFF7101F003; Mon, 27 Sep 2021 05:08:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9677E60C7F; Mon, 27 Sep 2021 05:08:00 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0042F4EA2F; Mon, 27 Sep 2021 05:07:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 18R57x2i004184 for ; Mon, 27 Sep 2021 01:07:59 -0400 Received: by smtp.corp.redhat.com (Postfix) id 66A0B189C4; Mon, 27 Sep 2021 05:07:59 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.192.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id CDC29179B3 for ; Mon, 27 Sep 2021 05:07:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632719287; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=YgrTFd6/fXfU+L+EDc8N4vqLJh07qFDZPkrsYUVLNIE=; b=EejBZ2VJ8oweiYP4eCjPKDVmQPeTsNAB5qloH0hK+azUE4qdHg7Q9CSI4GxFV8zM9+kL0o 5xL34D/Gq0dLWnO8btwRBSD3QP/zBuY2UK/miFemiUoNxtEBPr0Fnh+Vb1ZRcGBOQiTcCY G8LP/iPzKIrCX7c0OX7LCcDl2bLgi2I= X-MC-Unique: f8Flp4CUNyutDiNzi4JIKA-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 1/8] virsh-util.h: Fix ordering of virshXXXFree functions Date: Mon, 27 Sep 2021 07:07:43 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1632719289944100002 Content-Type: text/plain; charset="utf-8" Currently the order of virshXXXFree functions in the header file does not correspond to the order in the corresponding .c file. Signed-off-by: Michal Privoznik --- tools/virsh-util.h | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/tools/virsh-util.h b/tools/virsh-util.h index 6115b05d4d..f7e8116de3 100644 --- a/tools/virsh-util.h +++ b/tools/virsh-util.h @@ -40,16 +40,10 @@ virshCommandOptDomain(vshControl *ctl, const char **name); =20 typedef virDomain virshDomain; - void virshDomainFree(virDomainPtr dom); G_DEFINE_AUTOPTR_CLEANUP_FUNC(virshDomain, virshDomainFree); =20 -typedef virSecret virshSecret; -void -virshSecretFree(virSecretPtr secret); -G_DEFINE_AUTOPTR_CLEANUP_FUNC(virshSecret, virshSecretFree); - typedef virDomainCheckpoint virshDomainCheckpoint; void virshDomainCheckpointFree(virDomainCheckpointPtr chk); @@ -60,6 +54,11 @@ void virshDomainSnapshotFree(virDomainSnapshotPtr snap); G_DEFINE_AUTOPTR_CLEANUP_FUNC(virshDomainSnapshot, virshDomainSnapshotFree= ); =20 +typedef virSecret virshSecret; +void +virshSecretFree(virSecretPtr secret); +G_DEFINE_AUTOPTR_CLEANUP_FUNC(virshSecret, virshSecretFree); + int virshDomainState(vshControl *ctl, virDomainPtr dom, --=20 2.32.0