From nobody Sun Feb 8 21:37:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626864246; cv=none; d=zohomail.com; s=zohoarc; b=KSE5Lu60+obJyjJp+GJbZzoyfE+1X4AQR8ZGDk5szcVHUzW/jTG0rQ7jUbYOtKxwexd/U6x8Fpe58njflzoNkvP8hRGXfEYH0IfF9HnpAwDCOhdL1LbGwvmcIm6mpBH3+QbSDcOOwv1yr+PBVJFHhwzBoQFVkrKljE4nYZZUu2w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626864246; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=StSJTpgJznKfLpNX1GOo/E8B42C58eKae+u60sZ5Muc=; b=AIVSnNEYg3jC7z/cSoqGCgPpmlveAH5JEOqsiZYP9FO6zmu5AZNhx2knzlzUPr4sw0bVL7acQIS5NkBMXhmN/tiJ/yWGJFoZp26bgqquvhdkRh2TcP92aPsf6JMD3EOo8xkMc5zYrLopsG57CUf9qg8uuRBM65aD/bjgRaGIiZc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1626864246223322.4806688306945; Wed, 21 Jul 2021 03:44:06 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-3-sfQHMqRuOPSxfA-6dqHc9Q-1; Wed, 21 Jul 2021 06:43:51 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0218E1005D54; Wed, 21 Jul 2021 10:43:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D3D175D9FC; Wed, 21 Jul 2021 10:43:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A132D4A706; Wed, 21 Jul 2021 10:43:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16LAhUDd001161 for ; Wed, 21 Jul 2021 06:43:30 -0400 Received: by smtp.corp.redhat.com (Postfix) id BEFAE19D9D; Wed, 21 Jul 2021 10:43:30 +0000 (UTC) Received: from andariel.local (unknown [10.40.193.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2C90F19D9B for ; Wed, 21 Jul 2021 10:43:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626864245; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=StSJTpgJznKfLpNX1GOo/E8B42C58eKae+u60sZ5Muc=; b=PRPrrW+iiv8bQuWjfJOgRSk40hQ9PV8/AtWLUJdrqN7/T7bT3BpP9kPXcLRO9IsAbg9pdq BFbe7qys+vBxniQm4p9ve83Hvf/iNH/yDOvInPcKNcm8HUeDMcO+u/wtQtGLuqUN15DKgH pickQLtxwch6RomfE/Ul4LoGQLzwgDk= X-MC-Unique: sfQHMqRuOPSxfA-6dqHc9Q-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 28/33] qemu: Remove return value from qemuMonitorDomainDumpCompletedCallback Date: Wed, 21 Jul 2021 12:42:40 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626864247758100001 Content-Type: text/plain; charset="utf-8" Change the callback prototype and fix the callback registered in the process code. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor.h | 12 ++++++------ src/qemu/qemu_process.c | 3 +-- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h index 22a07d7054..4ad14adb8b 100644 --- a/src/qemu/qemu_monitor.h +++ b/src/qemu/qemu_monitor.h @@ -303,12 +303,12 @@ struct _qemuMonitorDumpStats { unsigned long long total; /* total bytes to be written */ }; -typedef int (*qemuMonitorDomainDumpCompletedCallback)(qemuMonitor *mon, - virDomainObj *vm, - int status, - qemuMonitorDumpStats= *stats, - const char *error, - void *opaque); +typedef void (*qemuMonitorDomainDumpCompletedCallback)(qemuMonitor *mon, + virDomainObj *vm, + int status, + qemuMonitorDumpStat= s *stats, + const char *error, + void *opaque); typedef int (*qemuMonitorDomainPRManagerStatusChangedCallback)(qemuMonitor= *mon, virDomainOb= j *vm, diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index c6ab36d005..d7935fc03e 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -1663,7 +1663,7 @@ qemuProcessHandleMigrationPass(qemuMonitor *mon G_GNU= C_UNUSED, } -static int +static void qemuProcessHandleDumpCompleted(qemuMonitor *mon G_GNUC_UNUSED, virDomainObj *vm, int status, @@ -1700,7 +1700,6 @@ qemuProcessHandleDumpCompleted(qemuMonitor *mon G_GNU= C_UNUSED, cleanup: virResetLastError(); virObjectUnlock(vm); - return 0; } --=20 2.31.1