From nobody Sun Feb 8 07:48:13 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652196492; cv=none; d=zohomail.com; s=zohoarc; b=kstCTX0FmGMBiRivnFzwrzvT03EfKxPHIvs25kAC36G7JAwqgMBg5RHRj8Qub2spdpXPRoiKsFg70i+Qo90emjwurdoLWVFb4pjVLqbWmL6gihqPJx//ldooFjhhRV90DtcDpbXFFQwDn+UwErOq2V1HhCdySFI9B1stUbrGYk8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652196492; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+na1Q0tlq+2rP0/GKxxUMdyWEuLYYgsI8sMErer5bvY=; b=jwEjjA75qOzhquqVeX0m8DuqrAn7JABINQue5Q3hKk+iuP48RauPQxitINBgWf9VsTMqlwMDnb7YtNiq9GI8XS8YrtXf3LDhJYIAW0kggRRlzWaQnm5SzpeiKkWxS1wZEWghZIMVYxbo19gyV/GH74VaOFffCiItdu+cz9G2LYc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1652196492688393.644045213642; Tue, 10 May 2022 08:28:12 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-205-3MTj-1GZNTaF3r_mBaq8zQ-1; Tue, 10 May 2022 11:28:06 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 32CF22949BDA; Tue, 10 May 2022 15:28:03 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id C882240D2822; Tue, 10 May 2022 15:28:02 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9F0641947059; Tue, 10 May 2022 15:28:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 4C5A8194704D for ; Tue, 10 May 2022 15:28:01 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 315DEC27E94; Tue, 10 May 2022 15:28:01 +0000 (UTC) Received: from virval.usersys.redhat.com (unknown [10.43.2.187]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 124E1C27E80 for ; Tue, 10 May 2022 15:28:01 +0000 (UTC) Received: by virval.usersys.redhat.com (Postfix, from userid 500) id CE27D244637; Tue, 10 May 2022 17:21:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652196491; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=+na1Q0tlq+2rP0/GKxxUMdyWEuLYYgsI8sMErer5bvY=; b=b74Im/mHZVXTIT7bHtAaBwR0cWH/vFMbr0WXF6mktA5DhtJIzKzPQXi+JvAgRb/E1dsG0c 2tIkcE4jV+clWOVvMoiB5Fi0ErzLnwfjIx8BnpZZts8efeIYsumpCA0y0pbBreaoffDt4S HFC1r+c8V5VHjQ4BowWou6RKBIAut6w= X-MC-Unique: 3MTj-1GZNTaF3r_mBaq8zQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Jiri Denemark To: libvir-list@redhat.com Subject: [libvirt PATCH 71/80] qemu: Register qemuProcessCleanupMigrationJob after Begin phase Date: Tue, 10 May 2022 17:21:32 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652196494345100001 Content-Type: text/plain; charset="utf-8" The callback will properly cleanup non-p2p migration job in case the migrating domain dies between Begin and Perform while the client which controls the migration is not cooperating (normally the API for the next migration phase would handle this). The same situation can happen even after Prepare and Perform phases, but they both already register a suitable callback, so no fix is needed there. Signed-off-by: Jiri Denemark Reviewed-by: Peter Krempa --- src/qemu/qemu_migration.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 1fc978bad5..38a67f7e20 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2939,6 +2939,7 @@ qemuMigrationSrcBegin(virConnectPtr conn, VIR_FREE(xml); goto endjob; } + qemuDomainCleanupAdd(vm, qemuProcessCleanupMigrationJob); qemuMigrationJobContinue(vm); } else { goto endjob; --=20 2.35.1