From nobody Tue Sep 9 03:19:53 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1737736436605850.9837576607753; Fri, 24 Jan 2025 08:33:56 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 98ADE1627; Fri, 24 Jan 2025 11:33:55 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 55E8B158D; Fri, 24 Jan 2025 11:33:25 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id B8DEF1598; Fri, 24 Jan 2025 11:33:21 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 3BF2A12B0 for ; Fri, 24 Jan 2025 11:33:21 -0500 (EST) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-117-R2QMqDq8MeeusyU9K_0hDA-1; Fri, 24 Jan 2025 11:33:17 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 387AE1B9BF3F for ; Fri, 24 Jan 2025 16:33:16 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.2]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5C4301800344 for ; Fri, 24 Jan 2025 16:33:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737736400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E7dtyHux1lvL2LaDcAI2uZmR9+HcQ3/TvCzqLGRtqtQ=; b=eG2wrXEQ6PSTAkQwiDio7yasFTGgpuvzDvrLdM3MAXqo/v0HAnbie7oiyX2jV5EkdRqOKT VVY0Q9T8Mt7Kbuu0M6m7tkK9nBR20abd1+F2X24aRauPwP+TQsz5GDkI7wtDbFi5Ft3Of8 0uarAbUODEfglHlPcQlk1J3zW5KeZWs= X-MC-Unique: R2QMqDq8MeeusyU9K_0hDA-1 X-Mimecast-MFC-AGG-ID: R2QMqDq8MeeusyU9K_0hDA From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 4/5] qemu: monitor: Plumb in disk IO error message passthrough to VIR_DOMAIN_EVENT_ID_IO_ERROR_REASON Date: Fri, 24 Jan 2025 17:33:05 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1DvOzRlPG_6tMNb_DSAhMn-qpaMKxtFp28FX-nOGe4I_1737736396 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: W6YXHFLQBOL565THD45TM3CXSQU7PLOV X-Message-ID-Hash: W6YXHFLQBOL565THD45TM3CXSQU7PLOV X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1737736437893019100 Content-Type: text/plain; charset="utf-8" Pass the generic error message from qemu to the event so that users can possibly use the information. As documented the error is prefixed with "other: " to prevent collisions with already documented values in our API. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor_json.c | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 9f417d27c6..6de34b03bb 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -695,7 +695,7 @@ qemuMonitorJSONHandleIOError(qemuMonitor *mon, virJSONV= alue *data) const char *device; const char *nodename; const char *action; - const char *reason =3D ""; + g_autofree char *reason =3D NULL; bool nospc =3D false; int actionID; @@ -713,14 +713,27 @@ qemuMonitorJSONHandleIOError(qemuMonitor *mon, virJSO= NValue *data) nodename =3D virJSONValueObjectGetString(data, "node-name"); - if (virJSONValueObjectGetBoolean(data, "nospace", &nospc) =3D=3D 0 && = nospc) - reason =3D "enospc"; + if (virJSONValueObjectGetBoolean(data, "nospace", &nospc) =3D=3D 0 && = nospc) { + reason =3D g_strdup("enospc"); + } else { + /* For any unknown error we prefix the qemu-originating error with= 'other: ' + * so that applications can use that to filter them from errors we + * define in our API */ + const char *qemureason; + + if ((qemureason =3D virJSONValueObjectGetString(data, "reason"))) { + reason =3D g_strdup_printf("other: %s", qemureason); + } + } if ((actionID =3D qemuMonitorIOErrorActionTypeFromString(action)) < 0)= { VIR_WARN("unknown disk io error action '%s'", action); actionID =3D VIR_DOMAIN_EVENT_IO_ERROR_NONE; } + if (!reason) + reason =3D g_strdup(""); + qemuMonitorEmitIOError(mon, device, nodename, actionID, reason); } --=20 2.48.1