From nobody Sat Feb 7 05:01:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1629382569; cv=none; d=zohomail.com; s=zohoarc; b=Y5HF9FSd3teEaLJs7C5Dj9dWtr6qoY9oa7/T2nPG4f4vDyT6T0xjbV8Gp+2+VDfHWzWbDlSkFJUz3LyEOCAznOo3vPEK3FL7MKA2/PJF7/8ZqA/ncyg1U5tue+yjS1tjYRa8xAo8dGgmwR6SO60YZ9aWYMMnXnuW5KKNOnluLDA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629382569; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=FUekkF2xLqjlp/b9vqIUQOBYcq672EgD1YS9RfyKqQ0=; b=cwyN37K66MaQpWOFRKjrTZ/oChuFrg6JDVZMTjuJSKdhzSzhPa/KPWFGuPs0uq8wklXGsLjnkHJPJWqWuOKla/hHiAsw6RNV1VMKu1BUZe94jdpXlhHxYAmLRS7EW80Kl2ESp21S3cW2Lm9jR8jiCkR+AG4jJaW6u6pKWZbmI4o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1629382569287426.5710545205053; Thu, 19 Aug 2021 07:16:09 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-233-RPuLyVLMOlqYXtyuqXvxhQ-1; Thu, 19 Aug 2021 10:16:06 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E2DD7801B3C; Thu, 19 Aug 2021 14:16:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C78D160657; Thu, 19 Aug 2021 14:16:00 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8F7744A7CA; Thu, 19 Aug 2021 14:16:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 17JECgxQ015701 for ; Thu, 19 Aug 2021 10:12:42 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8A98F38E59; Thu, 19 Aug 2021 14:12:42 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1398C2ED6C for ; Thu, 19 Aug 2021 14:12:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629382568; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=FUekkF2xLqjlp/b9vqIUQOBYcq672EgD1YS9RfyKqQ0=; b=HXXVenE8UFwXYQjc0zE+GrFVh9bmQ5PiWTlRf3ieO45juZpdSVVxGiMeec38uw5bmU88rt nx+ZuUezdFlkGSG8gpWLBTZe/VhgGq8tOVF25eTih2FULXYdgeSKLYaRMGgRHjlKz1vbR7 RC2XaooBVqntwV8hza0Uvqvm516B+lg= X-MC-Unique: RPuLyVLMOlqYXtyuqXvxhQ-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 5/5] syntax-check: remove _test_script_regex Date: Thu, 19 Aug 2021 16:12:32 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1629383473145100001 Commit abab5c47f8060eddf0212084a1d70c4b1e3d92dd incorrectly assumed we do not have any files that could be affected by sc_prohibit_reversed_compare_failure due to the conditional assignment: _test_script_regex ?=3D \ so it removed the check. Also remove the leftover assignment of test-lib.sh, since any new code attemptint to use the compare function with reversed arguments should be rejected by review for using shell instead of C or Python. Signed-off-by: J=C3=A1n Tomko --- build-aux/syntax-check.mk | 2 -- 1 file changed, 2 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index b72a5b93d8..cf7a1fa4c6 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -108,8 +108,6 @@ local-check :=3D \ =20 syntax-check: $(local-check) =20 -_test_script_regex =3D \ - # Files that should never cause syntax check failures. VC_LIST_ALWAYS_EXCLUDE_REGEX =3D \ (^(docs/(news(-[0-9]*)?\.html\.in|.*\.patch))|\.(po|fig|gif|ico|png))$$ --=20 2.31.1