From nobody Sun Nov 10 21:37:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1653663959; cv=none; d=zohomail.com; s=zohoarc; b=da7VP8kBIlFWMOU/yTwKeXXFosQeRYebZghfCK7Ijrtn4FgMprRGT+juIDcpdP/M5ujdUIJMc5D/hN1yGVqGCbItKz99TslK5dU+lN9UeybZihqzDZdrr0+ZwpBn5IkJ9Ex18LH3EmJXvYtan8bpEUK8+u9hlAuB9xp7L9qGZ3A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653663959; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=i5H2OSgCAW5rqZ89S9PCbeeDwwzxWDjVzL06b0Yr3gI=; b=dOdHW/oyZIUjRCCVlUzC7jgkxix/1HdDFMNOUJeUKG5fuseX/QWK7PUl7kSId3zxcQ5cT3s+JMPgQIG0P78wUXJq4lGk4YIxmslWpxcYrVK3a2Yz1pfZNunpVUfpObq3EtcxuXXT2LFJqXoFCslmDCPq1foVokdQysR6ansWpYk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1653663959317675.2046943416041; Fri, 27 May 2022 08:05:59 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-581-c8_wmN4sMo6H78Ug7s3IbQ-1; Fri, 27 May 2022 11:05:56 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 47EE2803FF2; Fri, 27 May 2022 15:05:54 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6A3A2401E23; Fri, 27 May 2022 15:05:53 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 013C11947040; Fri, 27 May 2022 15:05:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 715C419466DF for ; Fri, 27 May 2022 15:05:51 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 439572166B29; Fri, 27 May 2022 15:05:51 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.180]) by smtp.corp.redhat.com (Postfix) with ESMTP id DE83A2166B26 for ; Fri, 27 May 2022 15:05:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653663958; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=i5H2OSgCAW5rqZ89S9PCbeeDwwzxWDjVzL06b0Yr3gI=; b=MiqmeYGvWWkKZ2YvU+7v7GBahThAxYQjeUCT5Dws96LQJzEUMgf7cJFaLF10vZsGoyUoBf hsPyggZUhe+ebn9iZDkVXfbFdvLRmZc0IRj10Ss+nGWUlQMBweawNZt5/c2s2v+5krywG7 pvz+wbXNbRkFn6loyPyLQ05YoMSVp9I= X-MC-Unique: c8_wmN4sMo6H78Ug7s3IbQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] qemuProcessStop: Don't try to remove QoS on already removed TAP Date: Fri, 27 May 2022 17:05:49 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1653663961368100001 Content-Type: text/plain; charset="utf-8"; x-default="true" When cleaning up after stopped domain, one of the things we do is attempt to clear QoS settings on OVS type interfaces. Well, this is needless because they were removed just a couple of lines above. As a result, the attempt fails and a warning is printed into logs, polluting them needlessly. Closes: https://gitlab.com/libvirt/libvirt/-/issues/313 Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_process.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 07acb1c427..c6d965d720 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -8166,12 +8166,6 @@ void qemuProcessStop(virQEMUDriver *driver, else VIR_WARN("Unable to release network device '%s'", NULLSTR(= net->ifname)); } - - if (virDomainNetDefIsOvsport(net) && - virNetDevOpenvswitchInterfaceClearQos(net->ifname, vm->def->uu= id) < 0) { - VIR_WARN("cannot clear bandwidth setting for ovs device : %s", - net->ifname); - } } =20 retry: --=20 2.35.1