From nobody Sun Feb 8 20:53:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1632315778; cv=none; d=zohomail.com; s=zohoarc; b=O37hOyUI0000Qe+aCnWvR1m+fTukooDpGNsXPP1ZKJabQG4tM4O7l2uUzrLrsOXneko0xM29F+gQfjZJkC2bCLCcrNtb8IwOZs96lO+lkRfbY9doqoc9Y+ZhVGfnSOz8zX7E5g+M9DO6EOaEw+PmEojb5fWwDlgxZ41VOowBUMA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1632315778; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=w4rjsibvZH51+KWwH2xXD2jpdzM/eJbMPwbsYY/seHI=; b=lMreafMjHnN9leOmXli2u/JUSF1eFa1H22KqZcvPkU2n8DItLBrx1405ZAZTMlRClI6N2LoYU0U1xxMK5E0ox0jmrVnofDphNC25lerQZ0VM0TZrEf9QZNrAyEU4GewN0eHm2UeJwC7f9etH5UKCt/tuDYm4ZoULBGrBJWxJCAA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 163231577803161.801786196332955; Wed, 22 Sep 2021 06:02:58 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-150-HXetcjk-NDiqNzfEKYvf1A-1; Wed, 22 Sep 2021 09:02:55 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 521A91084686; Wed, 22 Sep 2021 13:02:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 35E675BAEE; Wed, 22 Sep 2021 13:02:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id F2AA54EA39; Wed, 22 Sep 2021 13:02:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 18MD2ggm020355 for ; Wed, 22 Sep 2021 09:02:42 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7FBAB5D9F4; Wed, 22 Sep 2021 13:02:42 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id DA0475D9CA for ; Wed, 22 Sep 2021 13:02:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632315776; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=w4rjsibvZH51+KWwH2xXD2jpdzM/eJbMPwbsYY/seHI=; b=X3/+/1/3SUOPp3KU/3q5qO2UC9EAot4aC7s73QmYS6cOlziL0h0+T4WQE/AUeI3YL67ZIq /S54tpNrTDzCwhDEfZ5CAIxFJl9w1bw9L4Z0AGoDQ0jeukIhNmzSZJpiKUhkglCKBm2aq4 2UyIJ6EVwyA0TLCuKsPzD8ISXdcddcs= X-MC-Unique: HXetcjk-NDiqNzfEKYvf1A-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 07/20] qemuxml2argvtest: Remove 'disk-usb-nosupport' case Date: Wed, 22 Sep 2021 15:02:16 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1632315792047100001 Content-Type: text/plain; charset="utf-8" In effor to convert all test cases to real capability testing, this test doesn't make sense any more as even the oldest QEMU supported supports USB storage. Signed-off-by: Peter Krempa --- tests/qemuxml2argvdata/disk-usb-nosupport.err | 1 - tests/qemuxml2argvdata/disk-usb-nosupport.xml | 35 ------------------- tests/qemuxml2argvtest.c | 1 - 3 files changed, 37 deletions(-) delete mode 100644 tests/qemuxml2argvdata/disk-usb-nosupport.err delete mode 100644 tests/qemuxml2argvdata/disk-usb-nosupport.xml diff --git a/tests/qemuxml2argvdata/disk-usb-nosupport.err b/tests/qemuxml2= argvdata/disk-usb-nosupport.err deleted file mode 100644 index 87e8a9dec3..0000000000 --- a/tests/qemuxml2argvdata/disk-usb-nosupport.err +++ /dev/null @@ -1 +0,0 @@ -unsupported configuration: This QEMU doesn't support '-device usb-storage' diff --git a/tests/qemuxml2argvdata/disk-usb-nosupport.xml b/tests/qemuxml2= argvdata/disk-usb-nosupport.xml deleted file mode 100644 index b88ecf1935..0000000000 --- a/tests/qemuxml2argvdata/disk-usb-nosupport.xml +++ /dev/null @@ -1,35 +0,0 @@ - - QEMUGuest1 - c7a5fdbd-edaf-9455-926a-d65c16db1809 - 219136 - 219136 - 1 - - hvm - - - - destroy - restart - destroy - - /usr/bin/qemu-system-i386 - - - - -
- - - - - - - - - - - - - - diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 6ec486bdfc..fa58c7d0ef 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1376,7 +1376,6 @@ mymain(void) DO_TEST_PARSE_ERROR("disk-device-lun-type-invalid", QEMU_CAPS_VIRTIO_SCSI); DO_TEST_CAPS_LATEST_PARSE_ERROR("disk-attaching-partition-nosupport"); - DO_TEST_PARSE_ERROR_NOCAPS("disk-usb-nosupport"); DO_TEST("disk-usb-device", QEMU_CAPS_DEVICE_USB_STORAGE); DO_TEST("disk-usb-device-removable", --=20 2.31.1