From nobody Fri Dec 19 00:06:19 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1742348698; cv=none; d=zohomail.com; s=zohoarc; b=YR9qw9wxz9TLSgGjnJiEGvWcD0Q3vpPMBzNTJNl4/3ECHasgHFVjYrzrU9vbofUurb0Q3qcN+UDPL0Ks+rBljFn3DbObI0d7VvE0cpxWgYVZOm65M6jDTlnIBsKGuukJwcSPYbselx9T0uaNJ/wUVf7UqIRndU/6/Y4HbONeJCQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742348698; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=1meGRW36QyMgXDGd2GRN1SVFJ4sCMgRBxHnlAbvSk44=; b=j7R7n4xC47xsL0cC8ZAxDwy0nULrJXbeUimvt3ornMqhVSE8/34FLRRzlNlZ5vKSMYX/LP00hCYx6IJVRSmig4i6/hq/9IkDP4Bxj/mtIN6CHUK5nWd0dBrgS81+C6TineiEirrzFyR9JzzgGdfUbaHV1+IjePlm4YUz2U0IZtI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1742348698979907.9446117445526; Tue, 18 Mar 2025 18:44:58 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 619841373; Tue, 18 Mar 2025 21:44:58 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 9CCD1185B; Tue, 18 Mar 2025 21:40:44 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 6580C1717; Tue, 18 Mar 2025 21:40:40 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 06C9B17FE for ; Tue, 18 Mar 2025 21:40:20 -0400 (EDT) Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-gWXU0_gtPpWBD2CjCEL4TA-1; Tue, 18 Mar 2025 21:40:16 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 65020195609E; Wed, 19 Mar 2025 01:40:15 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.44.32.4]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CEA711800268; Wed, 19 Mar 2025 01:40:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742348419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/yv0BU9W8fJAB01VIZCfg1BLatDWa04QB4fq0F6t5sE=; b=SmQiEwIXoarmRrsl7evkbC+QPbVjQNyE/JTE3oi4nD3Jt/AIwh5aTHyBCfiR67oMP8t4cc Fo9aUjZdgzfU4AuEQcwkGhcSFEjZpinDv73wWqUPIf7SrCRHnBeXSM1BvTvzzcye+3H5ws +U1xbxIHYDKrVk039vKUpuYWy5T91ec= X-MC-Unique: gWXU0_gtPpWBD2CjCEL4TA-1 X-Mimecast-MFC-AGG-ID: gWXU0_gtPpWBD2CjCEL4TA_1742348415 To: devel@lists.libvirt.org Subject: [libvirt PATCH 5/7] conf: add passthrough and xtsup attributes for IOMMU Date: Wed, 19 Mar 2025 02:38:29 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: cNojtABKNIYO6Vx0ANhlIquz9kUzjNB6LPYbr9Qh-VA_1742348415 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: EZZ7UXJ6RU7JF2LXGLKN3CZ3ZDTSTB2N X-Message-ID-Hash: EZZ7UXJ6RU7JF2LXGLKN3CZ3ZDTSTB2N X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: suravee.suthikulpanit@amd.com, bsd@redhat.com X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?J=C3=A1n_Tomko_via_Devel?= Reply-To: =?UTF-8?q?J=C3=A1n=20Tomko?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1742348700127019000 Content-Type: text/plain; charset="utf-8" For the newly supported AMD device. Signed-off-by: J=C3=A1n Tomko --- docs/formatdomain.rst | 8 ++++++++ src/conf/domain_conf.c | 30 +++++++++++++++++++++++++++++ src/conf/domain_conf.h | 2 ++ src/conf/schemas/domaincommon.rng | 10 ++++++++++ tests/qemuxmlconfdata/amd-iommu.xml | 2 +- 5 files changed, 51 insertions(+), 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 8c122f5dae..690da6d43e 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -8948,6 +8948,14 @@ Example: example to efficiently enable more than 255 vCPUs. :since:`Since 10.7.0` (QEMU/KVM and ``intel`` model only) =20 + ``passthrough`` + Enable passthrough. TODO: Explain what this is + :since:`Since 11.2.0` (QEMU/KVM and ``amd`` model only) + + ``xtsup`` + Enable x2APIC mode. + :since:`Since 11.2.0` (QEMU/KVM and ``amd`` model only) + The ``virtio`` IOMMU devices can further have ``address`` element as descr= ibed in `Device addresses`_ (address has to by type of ``pci``). =20 diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 961ef08ba1..ef31da9d3f 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -14091,6 +14091,14 @@ virDomainIOMMUDefParseXML(virDomainXMLOption *xmlo= pt, if (virXMLPropTristateSwitch(driver, "dma_translation", VIR_XML_PR= OP_NONE, &iommu->dma_translation) < 0) return NULL; + + if (virXMLPropTristateSwitch(driver, "xtsup", VIR_XML_PROP_NONE, + &iommu->xtsup) < 0) + return NULL; + + if (virXMLPropTristateSwitch(driver, "passthrough", VIR_XML_PROP_N= ONE, + &iommu->pt) < 0) + return NULL; } =20 if (virDomainDeviceInfoParseXML(xmlopt, node, ctxt, @@ -21707,6 +21715,20 @@ virDomainIOMMUDefCheckABIStability(virDomainIOMMUD= ef *src, virTristateSwitchTypeToString(src->dma_translation)= ); return false; } + if (src->pt !=3D dst->pt) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Target domain IOMMU device dma translation '%1$s= ' does not match source '%2$s'"), + virTristateSwitchTypeToString(dst->pt), + virTristateSwitchTypeToString(src->pt)); + return false; + } + if (src->xtsup !=3D dst->xtsup) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Target domain IOMMU device dma translation '%1$s= ' does not match source '%2$s'"), + virTristateSwitchTypeToString(dst->xtsup), + virTristateSwitchTypeToString(src->xtsup)); + return false; + } =20 return virDomainDeviceInfoCheckABIStability(&src->info, &dst->info); } @@ -27734,6 +27756,14 @@ virDomainIOMMUDefFormat(virBuffer *buf, virBufferAsprintf(&driverAttrBuf, " dma_translation=3D'%s'", virTristateSwitchTypeToString(iommu->dma_transla= tion)); } + if (iommu->pt !=3D VIR_TRISTATE_SWITCH_ABSENT) { + virBufferAsprintf(&driverAttrBuf, " passthrough=3D'%s'", + virTristateSwitchTypeToString(iommu->pt)); + } + if (iommu->xtsup !=3D VIR_TRISTATE_SWITCH_ABSENT) { + virBufferAsprintf(&driverAttrBuf, " xtsup=3D'%s'", + virTristateSwitchTypeToString(iommu->xtsup)); + } =20 virXMLFormatElement(&childBuf, "driver", &driverAttrBuf, NULL); =20 diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 1ec16d3824..9b00212fb9 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -3003,6 +3003,8 @@ struct _virDomainIOMMUDef { unsigned int aw_bits; virDomainDeviceInfo info; virTristateSwitch dma_translation; + virTristateSwitch xtsup; + virTristateSwitch pt; }; =20 typedef enum { diff --git a/src/conf/schemas/domaincommon.rng b/src/conf/schemas/domaincom= mon.rng index 71b68d6687..7183b4090c 100644 --- a/src/conf/schemas/domaincommon.rng +++ b/src/conf/schemas/domaincommon.rng @@ -6214,6 +6214,16 @@ + + + + + + + + + + diff --git a/tests/qemuxmlconfdata/amd-iommu.xml b/tests/qemuxmlconfdata/am= d-iommu.xml index 0668ed4237..4ad79ce4ae 100644 --- a/tests/qemuxmlconfdata/amd-iommu.xml +++ b/tests/qemuxmlconfdata/amd-iommu.xml @@ -32,7 +32,7 @@ - +
--=20 2.48.1